[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13823732#comment-13823732 ] Raul Gutierrez Segales commented on ZOOKEEPER-1808: --- (Meant FLETestUtils.createMsg() is called again and again with the same params). Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822269#comment-13822269 ] Flavio Junqueira commented on ZOOKEEPER-1808: - [~rgs], can I get another +1 here, please? Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821131#comment-13821131 ] Flavio Junqueira commented on ZOOKEEPER-1808: - Hey guys, I'm happy about the discussion on the 3.5.0 changes, but I have created a task specifically for 3.5.0 (ZOOKEEPER-1810). It would be great if we could get this discussion there and perhaps even start making progress because we will need this is in for 3.5.0. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821160#comment-13821160 ] Germán Blanco commented on ZOOKEEPER-1808: -- Is it ok if I take 1810 and port these changes to trunk? Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821172#comment-13821172 ] Flavio Junqueira commented on ZOOKEEPER-1808: - [~abranzyck], sure, please feel free to start porting it. I'm still mostly focused on getting 3.4.6 out the door, but it is great that we can make progress in parallel. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821221#comment-13821221 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613570/ZOOKEEPER-1808.patch against trunk revision 1540961. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1764//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820599#comment-13820599
]
Raul Gutierrez Segales commented on ZOOKEEPER-1808:
---
Some stylistic nits:
{noformat}
+requestBuffer.putLong(epoch);
+requestBuffer.putInt( Notification.CURRENTVERSION );
{noformat}
no spaces between parenthesis and parameters.
{noformat}
+if(response.buffer.remaining() = 4) {
+n.version = response.buffer.getInt();
+} else {
+n.version = 0x0;
+}
{noformat}
More succinct:
{noformat}
+ n.version ? response.buffer.remaining() = 4 :
0x0;
{noformat}
Nit:
{noformat}
private void printNotification(Notification n){
-LOG.info(Notification: + n.leader + (n.leader), 0x
+LOG.info(Notification: + Long.toHexString(n.version) + (message
format version),
...
{noformat}
Maybe that belongs as toString inside Notification?
Super nit: there's two extra newlines in
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java.
Add version to FLE notifications for 3.4 branch
---
Key: ZOOKEEPER-1808
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Fix For: 3.4.6
Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
Add version to notification messages so that we can differentiate messages
during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820600#comment-13820600
]
Raul Gutierrez Segales commented on ZOOKEEPER-1808:
---
Sorry meant:
{noformat}
n.version = response.buffer.remaining() = 4 ? response.buffer.getInt() : 0x0;
{noformat}
Add version to FLE notifications for 3.4 branch
---
Key: ZOOKEEPER-1808
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Fix For: 3.4.6
Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
Add version to notification messages so that we can differentiate messages
during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820780#comment-13820780 ] Alexander Shraer commented on ZOOKEEPER-1808: - In this case, I'd rather simply check the number of remaining bytes like in the attached patch. This will need to change for the 3.5.0 patch since there I'm setting the buffer length so that it exactly fits the message (the configuration has variable length). Anyway, I think its fine that the patches for 3.5.0 and 3.4.6 do different things. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818825#comment-13818825 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613122/ZOOKEEPER-1808.patch against trunk revision 1539529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1759//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818886#comment-13818886 ] Germán Blanco commented on ZOOKEEPER-1808: -- Impressive! The tests really cover almost everything. Not that I think that it is required, but looking at this, maybe it would also be possible to add a forward compatibility check. Perhaps modifying the current createMsg method, adding some dummy information after the version, and see that it just gets ignored and it doesn't break anything. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818897#comment-13818897 ] Flavio Junqueira commented on ZOOKEEPER-1808: - bq. The tests really cover almost everything. The goal was to cover everything. :-) bq. maybe it would also be possible to add a forward compatibility check Good idea, let me add it. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818989#comment-13818989 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613157/ZOOKEEPER-1808.patch against trunk revision 1539529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1760//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819861#comment-13819861 ] Germán Blanco commented on ZOOKEEPER-1808: -- +1 again. this looks perfect. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818397#comment-13818397
]
Germán Blanco commented on ZOOKEEPER-1808:
--
Unless you change this if(response.buffer.capacity() == 40) { to
if(response.buffer.capacity() = 40) {, it will not be easy to increase the
size of the message in the future. That means that the version field will have
very limited (if any) use, since changing the first 36 bytes of the message
breaks backwards compatibility with 3.4.5.
Add version to FLE notifications for 3.4 branch
---
Key: ZOOKEEPER-1808
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Fix For: 3.4.6
Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
Add version to notification messages so that we can differentiate messages
during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818398#comment-13818398
]
Germán Blanco commented on ZOOKEEPER-1808:
--
Or making it a constructive comment ... if we change this
if(response.buffer.capacity() == 40) { to if(response.buffer.capacity() =
40) {, it will allow us to add more elements to the message without breaking
backwards compatibility.
Add version to FLE notifications for 3.4 branch
---
Key: ZOOKEEPER-1808
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Fix For: 3.4.6
Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch,
ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
Add version to notification messages so that we can differentiate messages
during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818425#comment-13818425 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613046/ZOOKEEPER-1808.patch against trunk revision 1539529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1757//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818487#comment-13818487 ] Germán Blanco commented on ZOOKEEPER-1808: -- +1 This one looks good. I have made a quick test of rolling restart from 3.4.6 and from 3.3.6 and it seems to work (with 3 servers). I noticed during the tests that if you mix the three versions (3.3.6, 3.4.5 and 3.4.6), then there are problems, but hopefully nobody will expect that to work. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818493#comment-13818493 ] Germán Blanco commented on ZOOKEEPER-1808: -- after some more tests, I think I have run into the issue that was reported a few times. I forgot that still needs to be fixed. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818116#comment-13818116 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612986/ZOOKEEPER-1808.patch against trunk revision 1539529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1755//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817159#comment-13817159
]
Germán Blanco commented on ZOOKEEPER-1808:
--
This looks quite good, but I think that there is a problem with backwards
compatibility.
Looking at the previous code (without this patch applied), the Notification
will only be processed correctly if the length is either 28 or less than 28.
But we will be sending one of length 32 when adding the version.
Still, it seems that the message from an updated server will be processed by a
server that is not updated if we place the version in the last position of the
message (it is now the first thing that gets sent). Messages will be processed
as backCompatibility=true (epoch will be extracted from the zxid), but there
will be no log of Got a short response (since it is actually longer, that is
ok).
This comparison if(response.buffer.capacity() == 40) { would be better as
if(response.buffer.capacity() = 40) {. We want the servers to be able to
process notifications with more information (from future updates), even if they
just use the information that they know about and ignore the rest.
Add version to FLE notifications for 3.4 branch
---
Key: ZOOKEEPER-1808
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
Project: ZooKeeper
Issue Type: Sub-task
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Fix For: 3.4.6
Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch
Add version to notification messages so that we can differentiate messages
during rolling upgrades. This task is for the 3.4 branch only.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817534#comment-13817534 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612859/ZOOKEEPER-1808.patch against trunk revision 1539529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1754//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13818034#comment-13818034 ] Germán Blanco commented on ZOOKEEPER-1808: -- If I am not wrong, not-updated servers will interpret the new length as a very large number, try to read all those bytes and wait for a very long time. I don't see any way to encode the version in the existing fields of the message, it will always confuse not-updated servers. One backwards compatible option that I see at the moment is adding version at the end and using a correct greater length so that non-updated servers handle updated servers using the current backwards compatibility code (ignoring peerEpoch and extracting it from zxid). Another might be encoding the version in the sid that gets send in the connection establishment. Maybe updated servers could start using the higher bits of the long in the same way that you have done for the length of the message. They will be seen as very high sids by not-updated servers, but maybe that is not a problem. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815750#comment-13815750 ] Flavio Junqueira commented on ZOOKEEPER-1808: - Ok, thanks for the feedback. Could you review it, please? Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815858#comment-13815858 ] Germán Blanco commented on ZOOKEEPER-1808: -- The patch doesn't seem to work for me. It seems to be based on directory src, it complains about three files not being there, and then it seems to have failed to create those files. Could you please upload a new one? Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815963#comment-13815963 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612600/ZOOKEEPER-1808.patch against trunk revision 1539529. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1748//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814941#comment-13814941 ] Germán Blanco commented on ZOOKEEPER-1808: -- Why is this change only for branch 3.4? Will the version be removed in 3.5.0? Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814994#comment-13814994 ] Flavio Junqueira commented on ZOOKEEPER-1808: - I'm interested in solving the blockers for 3.4.6 and the solution for 3.5.0 might be slightly different because of the changes due to ZOOKEEPER-107, so I was thinking of doing it separately and possibly after releasing 3.4.6. Does it make sense? Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815628#comment-13815628 ] Germán Blanco commented on ZOOKEEPER-1808: -- I can't say much, since I don't know the impacts of ZOOKEEPER-107 well, but if you prefer to do it this way I don't see any problem with it. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814080#comment-13814080 ] Flavio Junqueira commented on ZOOKEEPER-1808: - In this patch, I have added a version field to notifications and propagate it to votes. I have also shuffled things around in the FLE tests so that we use the same method for generating notification messages. Moving tests around made the patch slightly longer, but the overall changes are fairly simple. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814086#comment-13814086 ] Hadoop QA commented on ZOOKEEPER-1808: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612210/ZOOKEEPER-1808.patch against trunk revision 1538853. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1744//console This message is automatically generated. Add version to FLE notifications for 3.4 branch --- Key: ZOOKEEPER-1808 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 Project: ZooKeeper Issue Type: Sub-task Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.4.6 Attachments: ZOOKEEPER-1808.patch Add version to notification messages so that we can differentiate messages during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
