[
https://issues.apache.org/jira/browse/ZOOKEEPER-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646422#comment-15646422
]
Hadoop QA commented on ZOOKEEPER-1816:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12837908/ZOOKEEPER-1816.patch
against trunk revision 440e0923dd9e3be533a196fdd6ada960860ca7f6.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 19 new Findbugs (version
3.0.1) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3529//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3529//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3529//console
This message is automatically generated.
> ClientCnxn.close() should block until threads have died
> -------------------------------------------------------
>
> Key: ZOOKEEPER-1816
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1816
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.3.6, 3.4.5
> Reporter: Jared Winick
> Priority: Minor
> Fix For: 3.4.10
>
> Attachments: ZOOKEEPER-1816.patch
>
>
> In the testing of ACCUMULO-1379 and ACCUMULO-1858 it was seen that the
> non-blocking behavior of ClientCnxn.close(), and therefore ZooKeeper.close(),
> can cause a race condition when undeploying an application running in a Java
> container such as JBoss or Tomcat. As the close() method returns without
> joining on the sendThread and eventThread, those threads continue to
> execute/cleanup while the container is cleaning up the application's
> resources. If the container has unloaded classes by the time this code runs
> {code}
> ZooTrace.logTraceMessage(LOG, ZooTrace.getTextTraceLevel(), "SendThread
> exitedloop.");
> {code}
> A "java.lang.NoClassDefFoundError: org/apache/zookeeper/server/ZooTrace" can
> be seen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
