[jira] [Commented] (ZOOKEEPER-1874) Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898676#comment-13898676 ] Hudson commented on ZOOKEEPER-1874: --- SUCCESS: Integrated in ZooKeeper-trunk #2213 (See [https://builds.apache.org/job/ZooKeeper-trunk/2213/]) ZOOKEEPER-1874 Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer (Rakesh R and Germán Blanco via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1567488) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java > Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer > --- > > Key: ZOOKEEPER-1874 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1874 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Rakesh R > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1874.patch, ZOOKEEPER-1874.patch > > > This jira to provide proper cleanups in ReconfigTest test cases. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1874) Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13898625#comment-13898625 ] Michi Mutsuzaki commented on ZOOKEEPER-1874: +1 Thank you Rakesh and Germán. > Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer > --- > > Key: ZOOKEEPER-1874 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1874 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Rakesh R > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1874.patch, ZOOKEEPER-1874.patch > > > This jira to provide proper cleanups in ReconfigTest test cases. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1874) Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891904#comment-13891904 ] Rakesh R commented on ZOOKEEPER-1874: - Thanks German for the patch. +1 lgtm > Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer > --- > > Key: ZOOKEEPER-1874 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1874 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Rakesh R > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1874.patch, ZOOKEEPER-1874.patch > > > This jira to provide proper cleanups in ReconfigTest test cases. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1874) Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889328#comment-13889328 ] Germán Blanco commented on ZOOKEEPER-1874: -- The changes look good to me. > Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer > --- > > Key: ZOOKEEPER-1874 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1874 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Rakesh R > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1874.patch, ZOOKEEPER-1874.patch > > > This jira to provide proper cleanups in ReconfigTest test cases. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1874) Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889046#comment-13889046 ] Hadoop QA commented on ZOOKEEPER-1874: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12626552/ZOOKEEPER-1874.patch against trunk revision 1561672. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1914//console This message is automatically generated. > Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer > --- > > Key: ZOOKEEPER-1874 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1874 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Rakesh R > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1874.patch, ZOOKEEPER-1874.patch > > > This jira to provide proper cleanups in ReconfigTest test cases. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ZOOKEEPER-1874) Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1332#comment-1332 ] Rakesh R commented on ZOOKEEPER-1874: - Hi German/Flavio, I've attached patch, but again it requires proper eol:style also. Will you please have a look at it when you get sometime. Thanks > Add proper teardown/cleanups in ReconfigTest to shutdown quorumpeer > --- > > Key: ZOOKEEPER-1874 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1874 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Reporter: Rakesh R > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1874.patch > > > This jira to provide proper cleanups in ReconfigTest test cases. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
