[jira] [Commented] (ZOOKEEPER-2173) ZK startup failure should be handled with proper error message
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516327#comment-14516327 ] J.Andreina commented on ZOOKEEPER-2173: --- Thanks [~fournc] for committing the patch. > ZK startup failure should be handled with proper error message > -- > > Key: ZOOKEEPER-2173 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2173 > Project: ZooKeeper > Issue Type: Bug >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2173.1.patch > > > If any failure during zk Startup (myid file does not exist), then still zk > startup returns as successful (STARTED). > ZK startup failure should be handled with proper error message -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2173) ZK startup failure should be handled with proper error message
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516042#comment-14516042 ] Hudson commented on ZOOKEEPER-2173: --- SUCCESS: Integrated in ZooKeeper-trunk #2674 (See [https://builds.apache.org/job/ZooKeeper-trunk/2674/]) ZOOKEEPER-2173. ZK startup failure should be handled with proper error message (J.Andreina via camille) (camille: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1676359) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/bin/zkServer.sh > ZK startup failure should be handled with proper error message > -- > > Key: ZOOKEEPER-2173 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2173 > Project: ZooKeeper > Issue Type: Bug >Reporter: J.Andreina >Assignee: J.Andreina > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2173.1.patch > > > If any failure during zk Startup (myid file does not exist), then still zk > startup returns as successful (STARTED). > ZK startup failure should be handled with proper error message -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2173) ZK startup failure should be handled with proper error message
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514648#comment-14514648 ] Camille Fournier commented on ZOOKEEPER-2173: - This is great, +1. I will check it in. > ZK startup failure should be handled with proper error message > -- > > Key: ZOOKEEPER-2173 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2173 > Project: ZooKeeper > Issue Type: Bug >Reporter: J.Andreina >Assignee: J.Andreina > Attachments: ZOOKEEPER-2173.1.patch > > > If any failure during zk Startup (myid file does not exist), then still zk > startup returns as successful (STARTED). > ZK startup failure should be handled with proper error message -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2173) ZK startup failure should be handled with proper error message
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513942#comment-14513942 ] J.Andreina commented on ZOOKEEPER-2173: --- As this is addition of proper error message if any failure in startup , no need of testcase. > ZK startup failure should be handled with proper error message > -- > > Key: ZOOKEEPER-2173 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2173 > Project: ZooKeeper > Issue Type: Bug >Reporter: J.Andreina >Assignee: J.Andreina > Attachments: ZOOKEEPER-2173.1.patch > > > If any failure during zk Startup (myid file does not exist), then still zk > startup returns as successful (STARTED). > ZK startup failure should be handled with proper error message -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2173) ZK startup failure should be handled with proper error message
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513009#comment-14513009 ] Hadoop QA commented on ZOOKEEPER-2173: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12728231/ZOOKEEPER-2173.1.patch against trunk revision 1672934. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2649//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2649//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2649//console This message is automatically generated. > ZK startup failure should be handled with proper error message > -- > > Key: ZOOKEEPER-2173 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2173 > Project: ZooKeeper > Issue Type: Bug >Reporter: J.Andreina >Assignee: J.Andreina > Attachments: ZOOKEEPER-2173.1.patch > > > If any failure during zk Startup (myid file does not exist), then still zk > startup returns as successful (STARTED). > ZK startup failure should be handled with proper error message -- This message was sent by Atlassian JIRA (v6.3.4#6332)
