[jira] [Commented] (ZOOKEEPER-2176) unclear error message should be info or warn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528739#comment-14528739
]
Hongchao Deng commented on ZOOKEEPER-2176:
--
The patch is trivial and LGTM. +1
I will commit this shortly.
unclear error message should be info or warn
Key: ZOOKEEPER-2176
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2176
Project: ZooKeeper
Issue Type: Improvement
Components: quorum
Affects Versions: 3.5.0, 3.5.1, 3.5.2
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Attachments: ZOOKEEPER-2176.patch
Hi [~shralex],
Looking at the CI output of ZOOKEEPER-2163 I see this:
{noformat}
[exec] [junit] 2015-04-17 17:36:23,750 [myid:] - ERROR
[QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:11235)(secure=disabled):QuorumPeer@1394]
- writeToDisk == true but configFilename == null
{noformat}
Though looking at QuorumPeer#setQuorumVerifier I see:
{noformat}
if (configFilename != null) {
try {
String dynamicConfigFilename = makeDynamicConfigFilename(
qv.getVersion());
QuorumPeerConfig.writeDynamicConfig(
dynamicConfigFilename, qv, false);
QuorumPeerConfig.editStaticConfig(configFilename,
dynamicConfigFilename,
needEraseClientInfoFromStaticConfig());
} catch (IOException e) {
LOG.error(Error closing file: , e.getMessage());
}
} else {
LOG.error(writeToDisk == true but configFilename == null);
}
{noformat}
there's no proper error handling so I guess maybe we should just make it a
warning? Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2176) unclear error message should be info or warn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522294#comment-14522294
]
Raul Gutierrez Segales commented on ZOOKEEPER-2176:
---
Well, changing a logging statement triggered a build failure. Clearly there's
something up w/ CI.
unclear error message should be info or warn
Key: ZOOKEEPER-2176
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2176
Project: ZooKeeper
Issue Type: Improvement
Components: quorum
Affects Versions: 3.5.0, 3.5.1, 3.5.2
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Attachments: ZOOKEEPER-2176.patch
Hi [~shralex],
Looking at the CI output of ZOOKEEPER-2163 I see this:
{noformat}
[exec] [junit] 2015-04-17 17:36:23,750 [myid:] - ERROR
[QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:11235)(secure=disabled):QuorumPeer@1394]
- writeToDisk == true but configFilename == null
{noformat}
Though looking at QuorumPeer#setQuorumVerifier I see:
{noformat}
if (configFilename != null) {
try {
String dynamicConfigFilename = makeDynamicConfigFilename(
qv.getVersion());
QuorumPeerConfig.writeDynamicConfig(
dynamicConfigFilename, qv, false);
QuorumPeerConfig.editStaticConfig(configFilename,
dynamicConfigFilename,
needEraseClientInfoFromStaticConfig());
} catch (IOException e) {
LOG.error(Error closing file: , e.getMessage());
}
} else {
LOG.error(writeToDisk == true but configFilename == null);
}
{noformat}
there's no proper error handling so I guess maybe we should just make it a
warning? Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2176) unclear error message should be info or warn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518526#comment-14518526
]
Raul Gutierrez Segales commented on ZOOKEEPER-2176:
---
cc: [~michim], [~hdeng]
unclear error message should be info or warn
Key: ZOOKEEPER-2176
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2176
Project: ZooKeeper
Issue Type: Improvement
Components: quorum
Affects Versions: 3.5.0, 3.5.1, 3.5.2
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Attachments: ZOOKEEPER-2176.patch
Hi [~shralex],
Looking at the CI output of ZOOKEEPER-2163 I see this:
{noformat}
[exec] [junit] 2015-04-17 17:36:23,750 [myid:] - ERROR
[QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:11235)(secure=disabled):QuorumPeer@1394]
- writeToDisk == true but configFilename == null
{noformat}
Though looking at QuorumPeer#setQuorumVerifier I see:
{noformat}
if (configFilename != null) {
try {
String dynamicConfigFilename = makeDynamicConfigFilename(
qv.getVersion());
QuorumPeerConfig.writeDynamicConfig(
dynamicConfigFilename, qv, false);
QuorumPeerConfig.editStaticConfig(configFilename,
dynamicConfigFilename,
needEraseClientInfoFromStaticConfig());
} catch (IOException e) {
LOG.error(Error closing file: , e.getMessage());
}
} else {
LOG.error(writeToDisk == true but configFilename == null);
}
{noformat}
there's no proper error handling so I guess maybe we should just make it a
warning? Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2176) unclear error message should be info or warn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518675#comment-14518675
]
Hadoop QA commented on ZOOKEEPER-2176:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12729015/ZOOKEEPER-2176.patch
against trunk revision 1676359.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2655//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2655//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2655//console
This message is automatically generated.
unclear error message should be info or warn
Key: ZOOKEEPER-2176
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2176
Project: ZooKeeper
Issue Type: Improvement
Components: quorum
Affects Versions: 3.5.0, 3.5.1, 3.5.2
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Attachments: ZOOKEEPER-2176.patch
Hi [~shralex],
Looking at the CI output of ZOOKEEPER-2163 I see this:
{noformat}
[exec] [junit] 2015-04-17 17:36:23,750 [myid:] - ERROR
[QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:11235)(secure=disabled):QuorumPeer@1394]
- writeToDisk == true but configFilename == null
{noformat}
Though looking at QuorumPeer#setQuorumVerifier I see:
{noformat}
if (configFilename != null) {
try {
String dynamicConfigFilename = makeDynamicConfigFilename(
qv.getVersion());
QuorumPeerConfig.writeDynamicConfig(
dynamicConfigFilename, qv, false);
QuorumPeerConfig.editStaticConfig(configFilename,
dynamicConfigFilename,
needEraseClientInfoFromStaticConfig());
} catch (IOException e) {
LOG.error(Error closing file: , e.getMessage());
}
} else {
LOG.error(writeToDisk == true but configFilename == null);
}
{noformat}
there's no proper error handling so I guess maybe we should just make it a
warning? Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
