[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973839#comment-14973839 ] Rakesh R commented on ZOOKEEPER-2239: - Committed to br3.5 : http://svn.apache.org/viewvc?view=revision&revision=1705796 cc: [~fpj], [~michim] Please add Kevin Lee to the contributors list and assign the issue to him. Thanks! > JMX State from LocalPeerBean incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708522#comment-14708522 ] Raul Gutierrez Segales commented on ZOOKEEPER-2239: --- I think so [~eribeiro], though I'd like to merge it for 3.5. [~michim]: ping - can I merge? > JMX State from LocalPeerBean incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701981#comment-14701981 ] Edward Ribeiro commented on ZOOKEEPER-2239: --- This issue can be closed as Resolved? Still pending 3.5 merging? /cc [~rgs] [~fournc] > JMX State from LocalPeerBean incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659960#comment-14659960 ] Hudson commented on ZOOKEEPER-2239: --- SUCCESS: Integrated in ZooKeeper-trunk #2776 (See [https://builds.apache.org/job/ZooKeeper-trunk/2776/]) ZOOKEEPER-2239: JMX State from LocalPeerBean incorrect (Kevin Lee via rgs) Signed-off-by: Raul Gutierrez S (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1694317) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LocalPeerBean.java > JMX State from LocalPeerBean incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658824#comment-14658824 ] Raul Gutierrez Segales commented on ZOOKEEPER-2239: --- Merged: trunk: https://github.com/apache/zookeeper/commit/5b1b668d33ccf7d93c31db2a53728177393fea90 3.4: https://github.com/apache/zookeeper/commit/da3e7e0d4b66ac5a25d40ae2d0102b1b57994b62 Waiting on [~michim] to merge to 3.5. Thanks [~kglee79]! > JMX State from LocalPeerBean incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean Incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658796#comment-14658796
]
Raul Gutierrez Segales commented on ZOOKEEPER-2239:
---
The failure is unrelated:
{code}
1 tests failed.
REGRESSION: org.apache.zookeeper.test.ReconfigTest.testPortChange
Error Message:
expected: but was:
Stack Trace:
junit.framework.AssertionFailedError: expected: but was:
at
org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:150)
at
org.apache.zookeeper.test.ReconfigTest.testPortChange(ReconfigTest.java:598)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
{code}
So merging regardless.
> JMX State from LocalPeerBean Incorrect
> --
>
> Key: ZOOKEEPER-2239
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239
> Project: ZooKeeper
> Issue Type: Bug
> Components: jmx
>Affects Versions: 3.4.6, 3.5.0, 3.5.1
> Environment: All
>Reporter: Kevin Lee
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2239.patch
>
>
> The "State" property of LocalPeerBean in package
> org.apache.zookeeper.server.quorum is returning the incorrect value. It is
> performing peer.getState() which is calling the getState() method on
> java.lang.Thread instead of getting the server state from
> org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within
> LocalPeerMXBean.java states that it should be returning the server state as
> well. The fix is to call peer.getServerState() in the getState() method of
> LocalPeerBean instead of peer.getState().toString(). This will return the
> states defined in QuorumStats.Provider (unknown, leaderelection, leading,
> following, and observing). This issue prevents JMX monitoring of the
> Zookeeper server state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean Incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658764#comment-14658764 ] Hadoop QA commented on ZOOKEEPER-2239: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12748705/ZOOKEEPER-2239.patch against trunk revision 1692989. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2818//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2818//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2818//console This message is automatically generated. > JMX State from LocalPeerBean Incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean Incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658703#comment-14658703 ] Raul Gutierrez Segales commented on ZOOKEEPER-2239: --- I'll merge this to trunk and 3.4 (for starters). [~michim]: shall I merge it to the 3.5 branch as well? > JMX State from LocalPeerBean Incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean Incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658697#comment-14658697 ] Raul Gutierrez Segales commented on ZOOKEEPER-2239: --- Thanks for the patch [~kglee79]! You need to press 'Submit patch' after uploading it to have CI run (I've just done it). Patch lgtm, I'll merge it once CI is happy. > JMX State from LocalPeerBean Incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6, 3.5.0, 3.5.1 > Environment: All >Reporter: Kevin Lee > Attachments: ZOOKEEPER-2239.patch > > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean Incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654064#comment-14654064 ] Rakesh R commented on ZOOKEEPER-2239: - Thanks [~kglee79] for reporting this. Would you mind creating a patch to fix this issue. Probably you can refer [HowToContribute|https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute] section to know about contributing patches. > JMX State from LocalPeerBean Incorrect > -- > > Key: ZOOKEEPER-2239 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Affects Versions: 3.4.6 > Environment: All >Reporter: Kevin Lee > > The "State" property of LocalPeerBean in package > org.apache.zookeeper.server.quorum is returning the incorrect value. It is > performing peer.getState() which is calling the getState() method on > java.lang.Thread instead of getting the server state from > org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within > LocalPeerMXBean.java states that it should be returning the server state as > well. The fix is to call peer.getServerState() in the getState() method of > LocalPeerBean instead of peer.getState().toString(). This will return the > states defined in QuorumStats.Provider (unknown, leaderelection, leading, > following, and observing). This issue prevents JMX monitoring of the > Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
