[jira] [Commented] (ZOOKEEPER-2270) Allow MBeanRegistry to be overridden for better unit tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738141#comment-14738141 ] Hudson commented on ZOOKEEPER-2270: --- SUCCESS: Integrated in ZooKeeper-trunk #2796 (See [https://builds.apache.org/job/ZooKeeper-trunk/2796/]) ZOOKEEPER-2270: Allow MBeanRegistry to be overridden for better unit tests (Jordan Zimmerman via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1702156) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java > Allow MBeanRegistry to be overridden for better unit tests > -- > > Key: ZOOKEEPER-2270 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2270 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.1 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman > Attachments: ZOOKEEPER-2270.2.patch, ZOOKEEPER-2270.patch > > > Apache Curator currently must use byte code re-writing to prevent the > MBeanRegistry from polluting the Platform MBeanServer. Provide a simple way > to avoid this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2270) Allow MBeanRegistry to be overridden for better unit tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737812#comment-14737812 ] Hadoop QA commented on ZOOKEEPER-2270: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12755010/ZOOKEEPER-2270.2.patch against trunk revision 1701505. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2866//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2866//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2866//console This message is automatically generated. > Allow MBeanRegistry to be overridden for better unit tests > -- > > Key: ZOOKEEPER-2270 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2270 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.1 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman > Attachments: ZOOKEEPER-2270.2.patch, ZOOKEEPER-2270.patch > > > Apache Curator currently must use byte code re-writing to prevent the > MBeanRegistry from polluting the Platform MBeanServer. Provide a simple way > to avoid this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2270) Allow MBeanRegistry to be overridden for better unit tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737660#comment-14737660 ] Raul Gutierrez Segales commented on ZOOKEEPER-2270: --- Oh, also - I would say drop the LOG.debug line. If you need it, add it to your unit tests. > Allow MBeanRegistry to be overridden for better unit tests > -- > > Key: ZOOKEEPER-2270 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2270 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.1 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman > Attachments: ZOOKEEPER-2270.patch > > > Apache Curator currently must use byte code re-writing to prevent the > MBeanRegistry from polluting the Platform MBeanServer. Provide a simple way > to avoid this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2270) Allow MBeanRegistry to be overridden for better unit tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14737658#comment-14737658 ] Raul Gutierrez Segales commented on ZOOKEEPER-2270: --- Thanks for the patch [~randgalt]. For consistency, can we just call the method setInstance? I don't think there is a risk of misuse, so no need for the special name. Other than, +1. > Allow MBeanRegistry to be overridden for better unit tests > -- > > Key: ZOOKEEPER-2270 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2270 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.1 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman > Attachments: ZOOKEEPER-2270.patch > > > Apache Curator currently must use byte code re-writing to prevent the > MBeanRegistry from polluting the Platform MBeanServer. Provide a simple way > to avoid this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
