[jira] [Commented] (ZOOKEEPER-2375) Prevent multiple initialization of login object in each ZooKeeperSaslClient instance
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175296#comment-15175296 ] Hudson commented on ZOOKEEPER-2375: --- SUCCESS: Integrated in ZooKeeper-trunk #2834 (See [https://builds.apache.org/job/ZooKeeper-trunk/2834/]) ZOOKEEPER-2375: Prevent multiple initialization of login object in each ZooKeeperSaslClient instance (yuemeng via rakeshr) (rakeshr: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733221]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java > Prevent multiple initialization of login object in each ZooKeeperSaslClient > instance > > > Key: ZOOKEEPER-2375 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2375 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.0, 3.5.1 >Reporter: yuemeng >Priority: Blocker > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2375.patch, ZOOKEEPER-2375_01.patch, > ZOOKEEPER-2375_02.patch > > > If there are exist many ZooKeeperSaslClient instance in one process,each > ZooKeeperSaslClient instance will be call synchronize method( > createSaslClient),But each ZooKeeperSaslClient instance will be lock the > current object(that is say ,the synchronize only for lock it's own object) > ,but many instances can access the static variable login,the synchronize > can't prevent other threads access the static login object,it will be cause > more than one ZooKeeperSaslClient instances use the same login object,and > login.startThreadIfNeeded() will be called more than one times for same login > object。 > it wll cause problem: > ERROR | [Executor task launch worker-1-SendThread(fi1:24002)] | Exception > while trying to create SASL client: java.lang.IllegalThreadStateException | > org.apache.zookeeper.client.ZooKeeperSaslClient.createSaslClient(ZooKeeperSaslClient.java:305) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2375) Prevent multiple initialization of login object in each ZooKeeperSaslClient instance
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175168#comment-15175168 ] Rakesh R commented on ZOOKEEPER-2375: - Hi PMCs, could someone please assign this issue to [~yuemeng]. Thanks! > Prevent multiple initialization of login object in each ZooKeeperSaslClient > instance > > > Key: ZOOKEEPER-2375 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2375 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.0, 3.5.1 >Reporter: yuemeng >Priority: Blocker > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2375.patch, ZOOKEEPER-2375_01.patch, > ZOOKEEPER-2375_02.patch > > > If there are exist many ZooKeeperSaslClient instance in one process,each > ZooKeeperSaslClient instance will be call synchronize method( > createSaslClient),But each ZooKeeperSaslClient instance will be lock the > current object(that is say ,the synchronize only for lock it's own object) > ,but many instances can access the static variable login,the synchronize > can't prevent other threads access the static login object,it will be cause > more than one ZooKeeperSaslClient instances use the same login object,and > login.startThreadIfNeeded() will be called more than one times for same login > object。 > it wll cause problem: > ERROR | [Executor task launch worker-1-SendThread(fi1:24002)] | Exception > while trying to create SASL client: java.lang.IllegalThreadStateException | > org.apache.zookeeper.client.ZooKeeperSaslClient.createSaslClient(ZooKeeperSaslClient.java:305) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
