[jira] [Commented] (ZOOKEEPER-2382) Make fsync.warningthresholdms property configurable through zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203098#comment-15203098
]
Patrick Hunt commented on ZOOKEEPER-2382:
-
No worries. It's not great code, a legacy of being around for a while. ;-)
> Make fsync.warningthresholdms property configurable through zoo.cfg
> ---
>
> Key: ZOOKEEPER-2382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2382
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Minor
> Attachments: ZOOKEEPER-2382-DRAFT.patch
>
>
> Currently {{fsync.warningthresholdms}} property can be set as a Java system
> property. But it would help if this property can be made configurable through
> {{zoo.cfg}} so that configuration management tools can leverage it. Also the
> Java system property name should be standardized (refer ZOOKEEPER-2316) so
> that the property is inline with the standard followed by other properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2382) Make fsync.warningthresholdms property configurable through zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199320#comment-15199320
]
Biju Nair commented on ZOOKEEPER-2382:
--
[~phunt] looking at
[QuorumPeerConfig.java|https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java#L216-L288]
"fsync.warningthresholdms" is not a property read from the zoo.cfg file. Also
the [admin
guide|https://zookeeper.apache.org/doc/trunk/zookeeperAdmin.html#sc_advancedConfiguration]
mentions that "fsync.warningthresholdms" can only be set as a system property.
> Make fsync.warningthresholdms property configurable through zoo.cfg
> ---
>
> Key: ZOOKEEPER-2382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2382
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Minor
> Attachments: ZOOKEEPER-2382-DRAFT.patch
>
>
> Currently {{fsync.warningthresholdms}} property can be set as a Java system
> property. But it would help if this property can be made configurable through
> {{zoo.cfg}} so that configuration management tools can leverage it. Also the
> Java system property name should be standardized (refer ZOOKEEPER-2316) so
> that the property is inline with the standard followed by other properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2382) Make fsync.warningthresholdms property configurable through zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198832#comment-15198832
]
Patrick Hunt commented on ZOOKEEPER-2382:
-
Once ZOOKEEPER-2195 is addressed this becomes a moot point, no? You can set
fsync.warningthresholdms in the config file and it will be handled correctly.
Am I missing something?
> Make fsync.warningthresholdms property configurable through zoo.cfg
> ---
>
> Key: ZOOKEEPER-2382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2382
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Minor
> Attachments: ZOOKEEPER-2382-DRAFT.patch
>
>
> Currently {{fsync.warningthresholdms}} property can be set as a Java system
> property. But it would help if this property can be made configurable through
> {{zoo.cfg}} so that configuration management tools can leverage it. Also the
> Java system property name should be standardized (refer ZOOKEEPER-2316) so
> that the property is inline with the standard followed by other properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2382) Make fsync.warningthresholdms property configurable through zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199575#comment-15199575
]
Patrick Hunt commented on ZOOKEEPER-2382:
-
Does this comment shed any light?
https://issues.apache.org/jira/browse/ZOOKEEPER-2195?focusedCommentId=15181928&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15181928
> Make fsync.warningthresholdms property configurable through zoo.cfg
> ---
>
> Key: ZOOKEEPER-2382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2382
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Minor
> Attachments: ZOOKEEPER-2382-DRAFT.patch
>
>
> Currently {{fsync.warningthresholdms}} property can be set as a Java system
> property. But it would help if this property can be made configurable through
> {{zoo.cfg}} so that configuration management tools can leverage it. Also the
> Java system property name should be standardized (refer ZOOKEEPER-2316) so
> that the property is inline with the standard followed by other properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2382) Make fsync.warningthresholdms property configurable through zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199931#comment-15199931
]
Biju Nair commented on ZOOKEEPER-2382:
--
Relied more on the comment in the [admin
guide|http://zookeeper.apache.org/doc/trunk/zookeeperAdmin.html#sc_advancedConfiguration]
and didn't look at the code carefully till the end. Sorry about that.
> Make fsync.warningthresholdms property configurable through zoo.cfg
> ---
>
> Key: ZOOKEEPER-2382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2382
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Minor
> Attachments: ZOOKEEPER-2382-DRAFT.patch
>
>
> Currently {{fsync.warningthresholdms}} property can be set as a Java system
> property. But it would help if this property can be made configurable through
> {{zoo.cfg}} so that configuration management tools can leverage it. Also the
> Java system property name should be standardized (refer ZOOKEEPER-2316) so
> that the property is inline with the standard followed by other properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2382) Make fsync.warningthresholdms property configurable through zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191632#comment-15191632
]
Biju Nair commented on ZOOKEEPER-2382:
--
The approach taken is to pass the config to ZK sub systems like Txn logging.
[~phunt] any feedback on this? Thx.
> Make fsync.warningthresholdms property configurable through zoo.cfg
> ---
>
> Key: ZOOKEEPER-2382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2382
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Minor
> Attachments: ZOOKEEPER-2382-DRAFT.patch
>
>
> Currently {{fsync.warningthresholdms}} property can be set as a Java system
> property. But it would help if this property can be made configurable through
> {{zoo.cfg}} so that configuration management tools can leverage it. Also the
> Java system property name should be standardized (refer ZOOKEEPER-2316) so
> that the property is inline with the standard followed by other properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
