[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475239#comment-15475239
]
Hudson commented on ZOOKEEPER-2557:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3071 (See
[https://builds.apache.org/job/ZooKeeper-trunk/3071/])
ZOOKEEPER-2557: Update gitignore to account for other file extensions. (Edward
Ribeiro via cnauroth) (cnauroth:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1759912])
* (edit) trunk/.gitignore
* (edit) trunk/CHANGES.txt
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474996#comment-15474996
]
Hadoop QA commented on ZOOKEEPER-2557:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12827652/ZOOKEEPER-2557-3.4.patch
against trunk revision 1759907.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3405//console
This message is automatically generated.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474973#comment-15474973
]
Michael Han commented on ZOOKEEPER-2557:
C files it ignores makes sense to me - those are files generated when ran 'ant
compilet-native' or 'ant test-core-cppunit'.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471695#comment-15471695
]
Edward Ribeiro commented on ZOOKEEPER-2557:
---
Chris and Patrick, totally agree with the superset approach across
3.4->3.5->trunk. Gonna work on that and check inconsistences before uploading
the new patch asap. Thanks for the feedback! :)
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch,
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471656#comment-15471656
]
Patrick Hunt commented on ZOOKEEPER-2557:
-
Superset makes sense to me.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch,
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471618#comment-15471618
]
Chris Nauroth commented on ZOOKEEPER-2557:
--
[~eribeiro], I was not able to apply ZOOKEEPER-2557-3.5.patch on branch-3.5.
However, ZOOKEEPER-2557.2.patch did apply cleanly. Does it make sense to
proceed with this, or did you want something specific for branch-3.5?
For the difference on branch-3.4, I noticed that ".idea/" is missing there.
Would you please add that?
Actually, for ease of maintenance, I think the ideal situation is to make
.gitignore identical across trunk, branch-3.5 and branch-3.4, containing the
full superset of all these entries. That way, future patches won't run into
merge conflicts. Let me know your thoughts on this.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch,
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471461#comment-15471461
]
Hadoop QA commented on ZOOKEEPER-2557:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12827422/ZOOKEEPER-2557-3.5.patch
against trunk revision 1757584.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3396//console
This message is automatically generated.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557-3.4.patch, ZOOKEEPER-2557-3.5.patch,
> ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471426#comment-15471426
]
Hadoop QA commented on ZOOKEEPER-2557:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12827411/ZOOKEEPER-2557.2.patch
against trunk revision 1757584.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3395//console
This message is automatically generated.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471400#comment-15471400
]
Patrick Hunt commented on ZOOKEEPER-2557:
-
Seems fine to me. I'd recommend committing to the active branches -
3.4/3.5/trunk. Chris feel free to commit.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471362#comment-15471362
]
Chris Nauroth commented on ZOOKEEPER-2557:
--
[~eribeiro], thank you for the update. +1 for patch revision 2. I'll hold off
committing in case Patrick wants to review again.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Attachments: ZOOKEEPER-2557.2.patch, ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471193#comment-15471193
]
Edward Ribeiro commented on ZOOKEEPER-2557:
---
Thanks for the feedback! :) I am gonna incorporate both suggestions of you
(nope, I didn't check SVN ignore list, but gonna do this now). If you come up
with any other inclusion/exclusion I am more than happy to change it.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471142#comment-15471142
]
Patrick Hunt commented on ZOOKEEPER-2557:
-
Hi Edward, this makes sense. Thanks. One question though, did you compare what
we have ignored in svn to your new list? Perhaps you could review and ensure
that everything we have in svn is replicated in git? I see the following:
svn propget -R svn:ignore .
. - build
.revision
.settings
.eclipse
.classpath
.project
src/c - *generated*
.cproject
.project
src/c/src - .dirstamp
src/java - .classpath
.project
generated
bin
src/java/lib - ivy-*.jar
ant-eclipse-*.jar
src/java/test - .classpath
.project
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471138#comment-15471138
]
Chris Nauroth commented on ZOOKEEPER-2557:
--
[~eribeiro], thank you for doing this. As an emacs user, thanks very much for
adding "*~"! :-)
While we're editing this, how about also adding "*.orig" and "*.rej"? These
are the files left behind by the patch command when it fails to apply the patch
file cleanly.
bq. My only concern here is if .class, .ear, .war and .jar files should be
included or not in the gitignore file.
I'd prefer to leave those out. We do have a couple of jars checked in:
{code}
> find . -name '*.jar'
./src/contrib/zooinspector/lib/jtoaster-1.0.4.jar
./src/java/lib/ivy-2.4.0.jar
{code}
I'd expect built binary artifacts to be fully covered by one of the other
rules, like "build/".
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2557) Update gitignore to account for other file extensions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468450#comment-15468450
]
Hadoop QA commented on ZOOKEEPER-2557:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12827214/ZOOKEEPER-2557.patch
against trunk revision 1757584.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3392//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3392//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3392//console
This message is automatically generated.
> Update gitignore to account for other file extensions
> -
>
> Key: ZOOKEEPER-2557
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.8
>Reporter: Edward Ribeiro
>Assignee: Edward Ribeiro
>Priority: Trivial
> Labels: easyfix
> Attachments: ZOOKEEPER-2557.patch
>
>
> We are in the process of moving from subversion to git, but I have seen that
> the current ZK's {{gitignore}} doesn't account for many spurious types of
> files (e.g., *.swp, *.tmp) as well as other files created by IDEs (Eclipse,
> Intellij and NetBeans), among other file extensions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
