[jira] [Commented] (ZOOKEEPER-2654) Support Fedora 25: use pkg-config instead of obsolete M4 macros
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770698#comment-15770698 ] Hadoop QA commented on ZOOKEEPER-2654: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12844437/ZOOKEEPER-2654.2.patch against trunk revision ef0a8ae686c100f1dc71d7526af962c635696466. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3553//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3553//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3553//console This message is automatically generated. > Support Fedora 25: use pkg-config instead of obsolete M4 macros > --- > > Key: ZOOKEEPER-2654 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2654 > Project: ZooKeeper > Issue Type: Bug > Components: build >Reporter: Olaf Flebbe >Assignee: Olaf Flebbe > Attachments: ZOOKEEPER-2654.2.patch > > > While compiling Bigtop on Fedora 25 we found that there is an issue with the > autoconf detection of cppunit: See BIGTOP-2642 for error. > Some background regarding the issue can be found here: > https://bugzilla.redhat.com/show_bug.cgi?id=1311694 > The fedora maintainers encourage use of pkg-config rather crufty *.m4 > autoconf magic by only supplying pkg-config files *.pc. > The patch is surprisingly easy but adds the additional requirement for > pkg-config which should be available on every well maintained system for ages. > Please see for me proposed patch. Works for me for Fedora 25, Centos 6, > MacOSX with HomeBrew. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2654) Support Fedora 25: use pkg-config instead of obsolete M4 macros
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770650#comment-15770650 ] Hadoop QA commented on ZOOKEEPER-2654: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12844435/ZOOKEEPER-2654.patch against trunk revision ef0a8ae686c100f1dc71d7526af962c635696466. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3552//console This message is automatically generated. > Support Fedora 25: use pkg-config instead of obsolete M4 macros > --- > > Key: ZOOKEEPER-2654 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2654 > Project: ZooKeeper > Issue Type: Bug > Components: build >Reporter: Olaf Flebbe >Assignee: Olaf Flebbe > Attachments: ZOOKEEPER-2654.patch > > > While compiling Bigtop on Fedora 25 we found that there is an issue with the > autoconf detection of cppunit: See BIGTOP-2642 for error. > Some background regarding the issue can be found here: > https://bugzilla.redhat.com/show_bug.cgi?id=1311694 > The fedora maintainers encourage use of pkg-config rather crufty *.m4 > autoconf magic by only supplying pkg-config files *.pc. > The patch is surprisingly easy but adds the additional requirement for > pkg-config which should be available on every well maintained system for ages. > Please see for me proposed patch. Works for me for Fedora 25, Centos 6, > MacOSX with HomeBrew. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2654) Support Fedora 25: use pkg-config instead of obsolete M4 macros
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770646#comment-15770646 ] Olaf Flebbe commented on ZOOKEEPER-2654: One additinal benefit of this patch is that one does not need to have cppunit installed when regenerating the autoconf files. > Support Fedora 25: use pkg-config instead of obsolete M4 macros > --- > > Key: ZOOKEEPER-2654 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2654 > Project: ZooKeeper > Issue Type: Bug > Components: build >Reporter: Olaf Flebbe >Assignee: Olaf Flebbe > Attachments: ZOOKEEPER-2654.patch > > > While compiling Bigtop on Fedora 25 we found that there is an issue with the > autoconf detection of cppunit: See BIGTOP-2642 for error. > Some background regarding the issue can be found here: > https://bugzilla.redhat.com/show_bug.cgi?id=1311694 > The fedora maintainers encourage use of pkg-config rather crufty *.m4 > autoconf magic by only supplying pkg-config files *.pc. > The patch is surprisingly easy but adds the additional requirement for > pkg-config which should be available on every well maintained system for ages. > Please see for me proposed patch. Works for me for Fedora 25, Centos 6, > MacOSX with HomeBrew. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
