[jira] [Commented] (ZOOKEEPER-2655) Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771848#comment-15771848
]
Rakesh R commented on ZOOKEEPER-2655:
-
Thanks [~eribeiro] for the reviews.
Thanks [~hanm] for the reviews and commits.
> Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
> --
>
> Key: ZOOKEEPER-2655
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2655
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: Rakesh R
>Assignee: Rakesh R
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
>
> This jira to improve the semantics of the following internal functions to
> make it more readable:
> # {{NIOServerCnxn#isZKServerRunning()}} => return true if the server is
> running, false otherwise.
> # {{AbstractFourLetterCommand#isZKServerRunning()}} => return true if the
> server is running, false otherwise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2655) Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771386#comment-15771386
]
Hudson commented on ZOOKEEPER-2655:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3207 (See
[https://builds.apache.org/job/ZooKeeper-trunk/3207/])
ZOOKEEPER-2655: Improve NIOServerCnxn#isZKServerRunning to reflect the (hanm:
rev f588e1982f382a586fea53a1fbb11914d48560de)
* (edit) src/java/main/org/apache/zookeeper/server/command/WatchCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/ConsCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
* (edit)
src/java/main/org/apache/zookeeper/server/command/AbstractFourLetterCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/ConfCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/IsroCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/DumpCommand.java
* (edit)
src/java/main/org/apache/zookeeper/server/command/CnxnStatResetCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/DirsCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/StatCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java
* (edit) src/java/main/org/apache/zookeeper/server/command/StatResetCommand.java
> Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
> --
>
> Key: ZOOKEEPER-2655
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2655
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: Rakesh R
>Assignee: Rakesh R
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
>
> This jira to improve the semantics of the following internal functions to
> make it more readable:
> # {{NIOServerCnxn#isZKServerRunning()}} => return true if the server is
> running, false otherwise.
> # {{AbstractFourLetterCommand#isZKServerRunning()}} => return true if the
> server is running, false otherwise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2655) Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771260#comment-15771260
]
ASF GitHub Bot commented on ZOOKEEPER-2655:
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/133
> Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
> --
>
> Key: ZOOKEEPER-2655
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2655
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: Rakesh R
>Assignee: Rakesh R
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
>
> This jira to improve the semantics of the following internal functions to
> make it more readable:
> # {{NIOServerCnxn#isZKServerRunning()}} => return true if the server is
> running, false otherwise.
> # {{AbstractFourLetterCommand#isZKServerRunning()}} => return true if the
> server is running, false otherwise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2655) Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770887#comment-15770887
]
ASF GitHub Bot commented on ZOOKEEPER-2655:
---
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/133
Thanks @eribeiro. I've modified the title.
> Improve NIOServerCnxn#isZKServerRunning to reflect the semantics correctly
> --
>
> Key: ZOOKEEPER-2655
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2655
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Rakesh R
>Assignee: Rakesh R
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
>
> This jira to improve the semantics of the following internal functions to
> make it more readable:
> # {{NIOServerCnxn#isZKServerRunning()}} => return true if the server is
> running, false otherwise.
> # {{AbstractFourLetterCommand#isZKServerRunning()}} => return true if the
> server is running, false otherwise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
