[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254683#comment-16254683 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- Github user Sniperwalnut commented on the issue: https://github.com/apache/zookeeper/pull/171 Who are you?Who Am I?Where am I? > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905362#comment-15905362 ] Michael Han commented on ZOOKEEPER-2692: I don't think anyone is working on fixing that issue. Feel free to go ahead and create a JIRA (and better, assign it to yourself and start fixing it:) > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904760#comment-15904760 ] Sneha Kanekar commented on ZOOKEEPER-2692: -- [~hanm] I am getting same error as you mentioned above(Testcase: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged). Any update on that issue? Or is there any jira created which i can refer to? > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876772#comment-15876772 ] Michael Han commented on ZOOKEEPER-2692: [~abrahamfine] I haven't looked into details on these tests but looks like your change was not impacting the failures here. Though I am pretty sure this flaky test is new, it sounds good to close this jira and open another one to track it. > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876550#comment-15876550 ] Abraham Fine commented on ZOOKEEPER-2692: - [~hanm] I am not convinced that this is a regression. Although the timing of the failure seems to indicate a regression, the WatcherTest class modified in ZOOKEEPER-2686 is unrelated to WatchEventWhenAutoResetTest. In addition we see this failure happening before this patch was committed here: https://builds.apache.org/job/ZooKeeper-trunk-solaris/1505/ Perhaps this deserves its own JIRA? > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868921#comment-15868921 ] Hudson commented on ZOOKEEPER-2692: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3283 (See [https://builds.apache.org/job/ZooKeeper-trunk/3283/]) ZOOKEEPER-2692: Fix race condition in testWatchAutoResetWithPending (hanm: rev d13d2f08c730a81d73d58f64a0ae448639dede2b) * (edit) src/java/test/org/apache/zookeeper/test/WatcherTest.java > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868918#comment-15868918 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/177 > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868869#comment-15868869 ] Michael Han commented on ZOOKEEPER-2692: Merged. Master: https://github.com/apache/zookeeper/commit/d13d2f08c730a81d73d58f64a0ae448639dede2b 3.5: https://github.com/apache/zookeeper/commit/1912fa8d63e6bbfdb5bb96bec85efa7c94e131e9 3.4: https://github.com/apache/zookeeper/commit/373b82bab843cc84c22b99f6511f8fea974fd2b4 > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868868#comment-15868868 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/177 merged, please close this PR @afine . Side note - the other day was discussing this with @rakeshadr. If we use the merge script without resolving the JIRA, or the JIRA was already resolved, the PR will be left open after the script execution. Not sure if this is a bug but fyi. > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.4.10, 3.5.3, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868863#comment-15868863 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/171 > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868853#comment-15868853 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/177 +1. Will merge this and the other one shortly. Thanks for spending time taking care of the tests @afine ! > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1589#comment-1589 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- GitHub user afine opened a pull request: https://github.com/apache/zookeeper/pull/177 ZOOKEEPER-2692: Fix race condition in testWatchAutoResetWithPending You can merge this pull request into a Git repository by running: $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2692_34 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/177.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #177 commit b9e1613bee5ca6aa37b45f900dbad8df7d862942 Author: Abraham Fine Date: 2017-02-14T21:04:56Z ZOOKEEPER-2692: Fix race condition in testWatchAutoResetWithPending > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864575#comment-15864575 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/171 +1. Chat with @afine offline, this is hard to reproduce without introducing some delays in the process callback. > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.4.9, 3.5.3, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2692) Fix race condition in testWatchAutoResetWithPending
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861622#comment-15861622 ] ASF GitHub Bot commented on ZOOKEEPER-2692: --- GitHub user afine opened a pull request: https://github.com/apache/zookeeper/pull/171 ZOOKEEPER-2692: Fix race condition in testWatchAutoResetWithPending We occasionally run into an issue with testWatchAutoResetWithPending where we get flaky test behavior due to not being able to reliably predict when the client has received notification from each watch that may be fired (perhaps due to resource contention on the box running the tests). This patch works around that by waiting for a one second quiet period, after which we can more safely assume all watches that will be fired have been fired. Here is an example of the test failure: https://builds.apache.org/job/ZooKeeper-trunk-jdk8/935/testReport/junit/org.apache.zookeeper.test/WatcherTest/testWatchAutoResetWithPending/ You can merge this pull request into a Git repository by running: $ git pull https://github.com/afine/zookeeper ZOOKEEPER-2692 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #171 commit f2d02bbef77f85e5786345d1ec75240add0d1504 Author: Abraham Fine Date: 2017-02-10T17:55:10Z ZOOKEEPER-2692: Fix race condition in testWatchAutoResetWithPending > Fix race condition in testWatchAutoResetWithPending > --- > > Key: ZOOKEEPER-2692 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2692 > Project: ZooKeeper > Issue Type: Sub-task > Components: tests >Affects Versions: 3.5.3 >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
