[jira] [Commented] (ZOOKEEPER-2724) Skip cert files for releaseaudit target.

2017-03-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930086#comment-15930086
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2724:
---

Github user hanm closed the pull request at:

https://github.com/apache/zookeeper/pull/194


> Skip cert files for releaseaudit target.
> 
>
> Key: ZOOKEEPER-2724
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2724
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Blocker
>  Labels: build
> Fix For: 3.5.3
>
>
> In branch-3.5 release auditing generating warnings against cert files as 
> these files don't contain Apache License (AL) header. I don't think these 
> files should be checked because they are not source files, and we skip them 
> in master branch. We should do the same for branch-3.5 by skipping these cert 
> files as well. This should be fixed before 3.5.3 release.
> Attach the snippet of warning for reference:
> {noformat}
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2724) Skip cert files for releaseaudit target.

2017-03-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928214#comment-15928214
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2724:
---

Github user skamille commented on the issue:

https://github.com/apache/zookeeper/pull/194
  
The lack of this appears to be breaking builds so this looks good to me. I 
will commit.


> Skip cert files for releaseaudit target.
> 
>
> Key: ZOOKEEPER-2724
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2724
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Blocker
>  Labels: build
> Fix For: 3.5.3
>
>
> In branch-3.5 release auditing generating warnings against cert files as 
> these files don't contain Apache License (AL) header. I don't think these 
> files should be checked because they are not source files, and we skip them 
> in master branch. We should do the same for branch-3.5 by skipping these cert 
> files as well. This should be fixed before 3.5.3 release.
> Attach the snippet of warning for reference:
> {noformat}
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2724) Skip cert files for releaseaudit target.

2017-03-15 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927049#comment-15927049
 ] 

Hadoop QA commented on ZOOKEEPER-2724:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/420//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/420//console

This message is automatically generated.

> Skip cert files for releaseaudit target.
> 
>
> Key: ZOOKEEPER-2724
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2724
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Blocker
>  Labels: build
> Fix For: 3.5.3
>
>
> In branch-3.5 release auditing generating warnings against cert files as 
> these files don't contain Apache License (AL) header. I don't think these 
> files should be checked because they are not source files, and we skip them 
> in master branch. We should do the same for branch-3.5 by skipping these cert 
> files as well. This should be fixed before 3.5.3 release.
> Attach the snippet of warning for reference:
> {noformat}
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2724) Skip cert files for releaseaudit target.

2017-03-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927013#comment-15927013
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2724:
---

GitHub user hanm opened a pull request:

https://github.com/apache/zookeeper/pull/194

ZOOKEEPER-2724: Skip cert files for releaseaudit target.

Skip the cert files as they are not source files, plus we already do the 
same for master branch..

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2724

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #194


commit bc51979fcde17d8472b1b16bbc9ed48483c9a559
Author: Michael Han 
Date:   2017-03-15T21:25:38Z

ZOOKEEPER-2724: Skip cert files for releaseaudit target.
Skip the cert files as they are not source files.




> Skip cert files for releaseaudit target.
> 
>
> Key: ZOOKEEPER-2724
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2724
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Blocker
>  Labels: build
> Fix For: 3.5.3
>
>
> In branch-3.5 release auditing generating warnings against cert files as 
> these files don't contain Apache License (AL) header. I don't think these 
> files should be checked because they are not source files, and we skip them 
> in master branch. We should do the same for branch-3.5 by skipping these cert 
> files as well. This should be fixed before 3.5.3 release.
> Attach the snippet of warning for reference:
> {noformat}
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer
> [rat:report]  !? 
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)