[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241843#comment-16241843
]
Andor Molnar commented on ZOOKEEPER-2934:
-
I've taken a look at other usages of LOG_DEBUG macro and it looks slightly
different in the C client library.
{code:c}
src/c/src/zookeeper.c:LOG_DEBUG(LOGCALLBACK(zh), "Sending request xid=%#x
for path [%s] to %s",h.xid,path,
{code}
wheres in the recipe code:
{code:c}
src/recipes/queue/src/c/src/zoo_queue.c:LOG_DEBUG(("Error! Called await
twice."));
{code}
I suspect that the macro has been changed recently and the recipe hasn't been
updated.
I'll take a closer look how to fix it later today.
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241851#comment-16241851
]
Andor Molnar commented on ZOOKEEPER-2934:
-
Caused by https://issues.apache.org/jira/browse/ZOOKEEPER-1400
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241898#comment-16241898
]
Andor Molnar commented on ZOOKEEPER-2934:
-
This problem exist in 'lock' recipe too.
I'm going to create patch for both of them.
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246664#comment-16246664
]
ASF GitHub Bot commented on ZOOKEEPER-2934:
---
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/416
ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes in
ZK client
LOG_DEBUG macro has been changed recently in
https://issues.apache.org/jira/browse/ZOOKEEPER-1400
This patch updates 'lock' and 'queue' recipes to follow the changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2934
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
commit 86dc7190aeda82ffb3cf32aaa45426294ab7395b
Author: Andor Molnár
Date: 2017-11-07T12:09:02Z
ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes in
ZK client
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246830#comment-16246830
]
Hadoop QA commented on ZOOKEEPER-2934:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1185//console
This message is automatically generated.
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254294#comment-16254294
]
ASF GitHub Bot commented on ZOOKEEPER-2934:
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/416
I ran "ant compile" and "ant test" from the toplevel and it worked fine for
me - passed.
+1 - I'm committing, if I missed something we can followup with another
jira.
Thanks Andor!
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254299#comment-16254299
]
ASF GitHub Bot commented on ZOOKEEPER-2934:
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/416
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254318#comment-16254318
]
ASF GitHub Bot commented on ZOOKEEPER-2934:
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/416
Ic - "ant .." is only exercising the java code. NM. Still committing this,
although it would be good to followup separately on Abe's comment.
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254350#comment-16254350
]
Hudson commented on ZOOKEEPER-2934:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3610 (See
[https://builds.apache.org/job/ZooKeeper-trunk/3610/])
ZOOKEEPER-2934: Updated usage of LOG_DEBUG in recipes to follow changes (phunt:
rev f6d2abf58adeda5a8c5da8192ea4a6549285e561)
* (edit) src/recipes/queue/src/c/src/zoo_queue.c
* (edit) src/recipes/queue/src/c/include/zoo_queue.h
* (edit) src/recipes/lock/src/c/src/zoo_lock.c
> c versions of election and queue recipes do not compile
> ---
>
> Key: ZOOKEEPER-2934
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
> Project: ZooKeeper
> Issue Type: Bug
> Components: recipes
>Affects Versions: 3.4.10, 3.5.3
>Reporter: Abraham Fine
>Assignee: Andor Molnar
> Fix For: 3.5.4, 3.6.0
>
>
> I see errors like:
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
> error: expected expression before ')' token
> log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
