[jira] [Commented] (ZOOKEEPER-3060) Logging the server local port to stderr
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524029#comment-16524029 ] Mohamed Jeelani commented on ZOOKEEPER-3060: Closing this as per discussion in the pull request - This is only useful when we don't use 0 as the port in the address, which won't happen in realistic for prod usage, so it's not that meaningful to have this patch. > Logging the server local port to stderr > > > Key: ZOOKEEPER-3060 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3060 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.12 >Reporter: Mohamed Jeelani >Assignee: Mohamed Jeelani >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > This simple straightforward patch adds logging of the server local port to > stderr which aids in simplifying debugging if you want to have to look that up -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3060) Logging the server local port to stderr
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510113#comment-16510113 ] Hadoop QA commented on ZOOKEEPER-3060: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1827//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1827//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1827//console This message is automatically generated. > Logging the server local port to stderr > > > Key: ZOOKEEPER-3060 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3060 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.12 >Reporter: Mohamed Jeelani >Assignee: Mohamed Jeelani >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > This simple straightforward patch adds logging of the server local port to > stderr which aids in simplifying debugging if you want to have to look that up -- This message was sent by Atlassian JIRA (v7.6.3#76005)
