[ https://issues.apache.org/jira/browse/ZOOKEEPER-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534462#comment-16534462 ]
Hadoop QA commented on ZOOKEEPER-3084: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1898//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1898//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1898//console This message is automatically generated. > Exit when zeus cannot bind to the leader election port > ------------------------------------------------------ > > Key: ZOOKEEPER-3084 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3084 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum, server > Reporter: Fangmin Lv > Assignee: Fangmin Lv > Priority: Minor > Labels: easyfix, pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > In QuorumCnxManager, the listener thread will exit if it cannot bind to the > election port after trying 3 times. Which will keep the server running but > unable to join a quorum, the process will be dangling there and only > rejecting requests. It seems it's better to exit instead of sitting there > doing nothing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)