[jira] [Commented] (ZOOKEEPER-3136) Reduce log in ClientBase in case of ConnectException
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606637#comment-16606637 ] Hudson commented on ZOOKEEPER-3136: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #180 (See [https://builds.apache.org/job/ZooKeeper-trunk/180/]) ZOOKEEPER-3136: Reduce log in ClientBase in case of ConnectException (hanm: rev 27db6bd28e3297cdafe19c204b42c3db20c45ad6) * (edit) src/java/test/org/apache/zookeeper/test/ClientBase.java > Reduce log in ClientBase in case of ConnectException > > > Key: ZOOKEEPER-3136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3136 > Project: ZooKeeper > Issue Type: Task > Components: tests >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h > Remaining Estimate: 0h > > While running tests you will always see spammy log lines like the ones below. > As we are expecting the server to be up, it is not useful to log such > stacktraces. > The patch simply reduce the log in this specific case, because it adds no > value and it is very annoying. > > {code:java} > [junit] 2018-08-31 23:31:49,173 [myid:] - INFO [main:ClientBase@292] - > server 127.0.0.1:11222 not up > [junit] java.net.ConnectException: Connection refused (Connection refused) > [junit] at java.net.PlainSocketImpl.socketConnect(Native Method) > [junit] at > java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) > [junit] at > java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) > [junit] at > java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) > [junit] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) > [junit] at java.net.Socket.connect(Socket.java:589) > [junit] at > org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:101) > [junit] at > org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:71) > [junit] at > org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:285) > [junit] at > org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:276) > {code} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3136) Reduce log in ClientBase in case of ConnectException
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599609#comment-16599609 ] Hadoop QA commented on ZOOKEEPER-3136: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2111//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2111//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2111//console This message is automatically generated. > Reduce log in ClientBase in case of ConnectException > > > Key: ZOOKEEPER-3136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3136 > Project: ZooKeeper > Issue Type: Task > Components: tests >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > While running tests you will always see spammy log lines like the ones below. > As we are expecting the server to be up, it is not useful to log such > stacktraces. > The patch simply reduce the log in this specific case, because it adds no > value and it is very annoying. > > {code:java} > [junit] 2018-08-31 23:31:49,173 [myid:] - INFO [main:ClientBase@292] - > server 127.0.0.1:11222 not up > [junit] java.net.ConnectException: Connection refused (Connection refused) > [junit] at java.net.PlainSocketImpl.socketConnect(Native Method) > [junit] at > java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) > [junit] at > java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) > [junit] at > java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) > [junit] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) > [junit] at java.net.Socket.connect(Socket.java:589) > [junit] at > org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:101) > [junit] at > org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:71) > [junit] at > org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:285) > [junit] at > org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:276) > {code} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3136) Reduce log in ClientBase in case of ConnectException
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599369#comment-16599369 ] Hadoop QA commented on ZOOKEEPER-3136: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2105//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2105//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2105//console This message is automatically generated. > Reduce log in ClientBase in case of ConnectException > > > Key: ZOOKEEPER-3136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3136 > Project: ZooKeeper > Issue Type: Task > Components: tests >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > While running tests you will always see spammy log lines like the ones below. > As we are expecting the server to be up, it is not useful to log such > stacktraces. > The patch simply reduce the log in this specific case, because it adds no > value and it is very annoying. > > {code:java} > [junit] 2018-08-31 23:31:49,173 [myid:] - INFO [main:ClientBase@292] - > server 127.0.0.1:11222 not up > [junit] java.net.ConnectException: Connection refused (Connection refused) > [junit] at java.net.PlainSocketImpl.socketConnect(Native Method) > [junit] at > java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) > [junit] at > java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) > [junit] at > java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) > [junit] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) > [junit] at java.net.Socket.connect(Socket.java:589) > [junit] at > org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:101) > [junit] at > org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:71) > [junit] at > org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:285) > [junit] at > org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:276) > {code} > -- This message was sent by Atlassian JIRA (v7.6.3#76005)