[jira] [Commented] (ZOOKEEPER-3146) Limit the maximum client connections per IP in NettyServerCnxnFactory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624537#comment-16624537 ] Hudson commented on ZOOKEEPER-3146: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #200 (See [https://builds.apache.org/job/ZooKeeper-trunk/200/]) ZOOKEEPER-3146: Limit the maximum client connections per IP in (hanm: rev 4ebb847bceb5ebd5c9fa53574f266c204f6f8ab7) * (edit) src/java/test/org/apache/zookeeper/test/SessionTest.java * (edit) src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java > Limit the maximum client connections per IP in NettyServerCnxnFactory > -- > > Key: ZOOKEEPER-3146 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3146 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > There is maximum connections per IP limit in NIOServerCnxnFactory > implementation, but not exist in Netty, this is useful to avoid spamming > happened on prod ensembles. > This Jira is going to add similar throttling logic in NettyServerCnxnFactory. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3146) Limit the maximum client connections per IP in NettyServerCnxnFactory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613753#comment-16613753 ] Hadoop QA commented on ZOOKEEPER-3146: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2161//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2161//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2161//console This message is automatically generated. > Limit the maximum client connections per IP in NettyServerCnxnFactory > -- > > Key: ZOOKEEPER-3146 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3146 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > There is maximum connections per IP limit in NIOServerCnxnFactory > implementation, but not exist in Netty, this is useful to avoid spamming > happened on prod ensembles. > This Jira is going to add similar throttling logic in NettyServerCnxnFactory. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3146) Limit the maximum client connections per IP in NettyServerCnxnFactory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612650#comment-16612650 ] Hadoop QA commented on ZOOKEEPER-3146: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2158//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2158//console This message is automatically generated. > Limit the maximum client connections per IP in NettyServerCnxnFactory > -- > > Key: ZOOKEEPER-3146 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3146 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 10m > Remaining Estimate: 0h > > There is maximum connections per IP limit in NIOServerCnxnFactory > implementation, but not exist in Netty, this is useful to avoid spamming > happened on prod ensembles. > This Jira is going to add similar throttling logic in NettyServerCnxnFactory. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
