[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524612#comment-16524612 ] Andor Molnar commented on ZOOKEEPER-451: Thanks [~plsnotracking] for testing. Are you willing to create a pull request on GitHub? Your contribution would be more than welcome. > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj >Priority: Major > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch, ZOOKEEPER-451.patch, > ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524477#comment-16524477 ] Vi commented on ZOOKEEPER-451: -- Hello, I see this feature had a patch which did not make it through. Any reason why we can't merge it? I currently took this patch and applied it over 3.5.3-beta to make it work with few changes, it seems to pass all tests. Please let me know. Thanks. > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj >Priority: Major > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch, ZOOKEEPER-451.patch, > ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366234#comment-15366234 ] Botond Hejj commented on ZOOKEEPER-451: --- Thanks for the comment Edward. I've made modifications based on your comment: - renamed the option to "enforceQuotaLimit" - fix the typo in zookeeper.c - Added documentation for the new option - Print the limit and stat in ZooKeeperMain on quota exceed > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch, ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364660#comment-15364660 ] Edward Ribeiro commented on ZOOKEEPER-451: -- Cool patch, [~botond.hejj], gonna take a closer look soon. :) Some preliminary review notes: I think "enableQuotaErrors" is not quite a good config setting name because it can lead to confusion. Why not something like "enforceQuotaLimit"? Ironically, you use this exact same name as field name down into the code. ;) IMHO, ZooKeeperMain.java should print out the exceeded amount and quora limit besides the path (making it easier to debug misconfigurations production). FYI, there's a typo in zooKeeper.c: "qouta" Last but not least, it is important to document this new parameter in the appropriate docs xml file. Your patch should include this too. Look for the documentation related to other ZK configs. Cheers! > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-451) ZK should enforce quota
[ https://issues.apache.org/jira/browse/ZOOKEEPER-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364574#comment-15364574 ] Botond Hejj commented on ZOOKEEPER-451: --- I have created a patch for this. This patch adds a new option "zookeeper.enableQuotaErrors" If it is set to "yes" than a QuotaExceededException will be thrown if a creation or set operation would violate the configured quota. I've also added the error to the c client. > ZK should enforce quota > --- > > Key: ZOOKEEPER-451 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-451 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.2.0 >Reporter: Raghu S >Assignee: Botond Hejj > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-451.patch > > > Email exchange with Mahadev: > Mahadev Konar wrote: > > Hi Raghu, > > We do have plans to enforce quota in future. Enforcing requires some more > > work then just reporting. Reporting is a good enough tool for operations to > > manage a zookeeper cluster but we would certainly like to enforce it in the > > near future. > > > > Thanks > > mahadev > > > > > > On 6/18/09 7:01 PM, "rag...@yahoo.com" wrote: > > > >> Is there a reason why node count/byte quota is not actually enforced but > >> rather ZK just warns? Are there any plans to enforce the quota in a future > >> release? > >> > >> Thanks > >> Raghu > >> > >> > >> > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
