[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-v5.patch I have updated the comment and renamed the diff file. > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-draft.patch, ZOOKEEPER-1699-draft.patch, > ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, ZOOKEEPER-1699-v3.patch, > ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699-v5.patch, > ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-draft.patch Forgot license header in a new file... just in case. > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-draft.patch, ZOOKEEPER-1699-draft.patch, > ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, ZOOKEEPER-1699-v3.patch, > ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-draft.patch What do you think of this, [~shralex]? I just shuffled things around a bit to make intention more clear. > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-draft.patch, ZOOKEEPER-1699-draft.patch, > ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, ZOOKEEPER-1699-v3.patch, > ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-v4.patch oops attached a 1807 patch here by mistake, resubmitting latest patch for 1699 > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, > ZOOKEEPER-1699-v3.patch, ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699-v4.patch, > ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: (was: ZOOKEEPER-1807-ver6.patch) > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, > ZOOKEEPER-1699-v3.patch, ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1807-ver6.patch > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, > ZOOKEEPER-1699-v3.patch, ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699.patch, > ZOOKEEPER-1807-ver6.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-v4.patch Hi Flavio, I actually like a lot that we can reuse the Proposal logic here and not duplicate it. Its not only the hasallquorums, but also the fact that we have potentially multiple quorumverifiers and we need to have a separate ackSet for each one, such that only appropriate voters have an ack in the appropriate ackSet. The reason is that the normal quorumverifier check for majority only checks that the number of votes is more than half, it doesn't check the votes themselves - we have to do that before adding the acks. I changed the name as you suggest. Thanks, Alex > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, > ZOOKEEPER-1699-v3.patch, ZOOKEEPER-1699-v4.patch, ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-v3.patch Thanks Ben! Attaching a new patch that reflects your comments. > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Assignee: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, > ZOOKEEPER-1699-v3.patch, ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-v2.patch Includes a new test. The test consistently fails without the changes in Leader.java and passes with the changes. Without the changes in Leader.java, instead of moving into LOOKING state, the servers remain in Leader/Follower state - leader has quorum of old config but is stuck waiting for an ACK it needs to complete a quorum of new config. > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699-v2.patch, > ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699-v1.patch > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699-v1.patch, ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Attachment: ZOOKEEPER-1699.patch Please take a look. Still need to figure out how to test this, any suggestions welcome. > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1699.patch > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Priority: Blocker (was: Major) > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer >Priority: Blocker > Fix For: 3.5.0 > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-1699: Summary: Leader should timeout and give up leadership when losing quorum of last proposed configuration (was: Leader should timeout and give up leadership when loosing quorum of last proposed configuration) > Leader should timeout and give up leadership when losing quorum of last > proposed configuration > -- > > Key: ZOOKEEPER-1699 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1699 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.0 >Reporter: Alexander Shraer > Fix For: 3.5.0 > > > A leader gives up leadership when losing a quorum of the current > configuration. > This doesn't take into account any proposed configuration. So, if > a reconfig operation is in progress and a quorum of the new configuration is > not > responsive, the leader will just get stuck waiting for it to ACK the reconfig > operation, and will never timeout. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
