Re: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2
ic - thanks! Patrick On Mon, Apr 8, 2019 at 4:38 AM Justin Ling Mao wrote: > ---> "That's cool, thanks Justin. I'd be interested to know - did you use > the legacy/old c client binaries from the github repo or did you rebuild > them? What about zkpython itself? I could see benefits or either/both." > @PatrickTo use that(your) benchmark tool, I did something like > following:cd zookeeper-3.5.5/src/c./configuremake make install# bulid > zkpython from source code:wget > https://files.pythonhosted.org/packages/14/38/a761465ab0a154405c11f7e5d6e81edf6e84584e114e152fddd340f7d6d3/zkpython-0.4.2.tar.gzpython > setup.py installexport LD_LIBRARY_PATH=/usr/local/lib/then I cd the > zk-smoketest dir,exec the following:./zk-latencies.py --servers > "localhost:2181" --root_znode="/zk-latencies_666" --znode_count=1 > --znode_size=100 --synchronous > - Original Message - > From: Patrick Hunt > To: DevZooKeeper , maoling199210...@sina.com > Subject: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2 > Date: 2019-04-08 12:24 > > > > On Sat, Apr 6, 2019 at 11:47 PM Justin Ling Mao > wrote: > Test for the 3.5.5 candidate 2: > -[0]: Jepsen consistency check had passed. +1. Look at the > attachment: jepsen_test_report.txt. how to use it: > https://github.com/apache/zookeeper/pull/883 > -[1] <https://github.com/apache/zookeeper/pull/883-%5B1%5D>: zk smoke and > latencies test passed, comparing to 3.5.4-beta, no any notable perfermance > improvement .+1. The tool: https://github.com/phunt/zk-smoketest >Env: 8 cores + 16GB Memory + 256GB SSD(my local Mac Pro 2015) > java version:"1.8.0_191" Look at the benchmark report: > https://docs.google.com/spreadsheets/d/1QnADbG9bCGMyTorEi67jQXWQSUVXQ1yQADgLV4LJHcg/edit#gid=0 > That's cool, thanks Justin. I'd be interested to know - did you use the > legacy/old c client binaries from the github repo or did you rebuild them? > What about zkpython itself? I could see benefits or either/both. > Regards, > Patrick -[2]: zkCli test passed.(base operation:create,set,get,delete > ...etc)+1. > > - Original Message - > From: Enrico Olivelli > To: DevZooKeeper > Subject: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2 > Date: 2019-04-06 17:49 > > Tamas, > Il sab 6 apr 2019, 10:47 Tamas Penzes ha > scritto: > > Hi Enrico, > > > > Just my 2cents. > > > > Having the sources jars in the binary package can be useful if you want > to > > debug without downloading the source tarball or checking out the whole > > project from github. In the same time it is not needed on the classpath. > > > > The docs html is generated from md files now, but the design didn't get > > updated. I wanted to do it (to have the same design as the website), but > > never had time for that. It doesn't look a blocker for me, can be done in > > any release later. > > > I agree, not all my points are blockers. > The most critical point is that the source tarball does not reflect the tag > and, important files are missing. > Cheers > Enrico > > Regards, Tamaas > > > > On Fri, Apr 5, 2019, 17:37 Enrico Olivelli wrote: > > > > > -1 (non binding) > > > > > > Good news: > > > I have build the sources with jdk-8 and all tests passed > > > checksums and signatures are ok > > > I run a few smoke tests running on JDK11, all is ok > > > > > > Bad news: > > > I see the following problems in the "binary package", not all blockers: > > > - we have a lib/cobertura directory, not useful > > > - we have zookeeper-3.5.5-sources.jar not needed in the "binary" > > > package on the classpath > > > - we also have all of the 'recipes' not needed in the "binary" package > > > on the classpath > > > - inside the "docs" directory I see a webside with a very old look and > > feel > > > > > > The source package does not reflect the repository, for instance > > > build.xml file, owaspSuppressions.xml, > > > excludeFindBugsFilter.xml.are missing. > > > I think we have to release in a "source package" a clean copy of ASF > > > repository at the released "git tag" > > > > > > > > > Enrico > > > > > > Il giorno ven 5 apr 2019 alle ore 14:35 Andor Molnar > > > ha scritto: > > > > > > > > This is the first stable release of 3.5 branch: 3.5.5. It resolves > 117 > > > issues, including Maven migration, Quorum TLS, TTL nodes and lots of > &
Re: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2
---> "That's cool, thanks Justin. I'd be interested to know - did you use the legacy/old c client binaries from the github repo or did you rebuild them? What about zkpython itself? I could see benefits or either/both." @PatrickTo use that(your) benchmark tool, I did something like following:cd zookeeper-3.5.5/src/c./configuremake make install# bulid zkpython from source code:wget https://files.pythonhosted.org/packages/14/38/a761465ab0a154405c11f7e5d6e81edf6e84584e114e152fddd340f7d6d3/zkpython-0.4.2.tar.gzpython setup.py installexport LD_LIBRARY_PATH=/usr/local/lib/then I cd the zk-smoketest dir,exec the following:./zk-latencies.py --servers "localhost:2181" --root_znode="/zk-latencies_666" --znode_count=1 --znode_size=100 --synchronous - Original Message - From: Patrick Hunt To: DevZooKeeper , maoling199210...@sina.com Subject: Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2 Date: 2019-04-08 12:24 On Sat, Apr 6, 2019 at 11:47 PM Justin Ling Mao wrote: Test for the 3.5.5 candidate 2: -[0]: Jepsen consistency check had passed. +1. Look at the attachment: jepsen_test_report.txt. how to use it: https://github.com/apache/zookeeper/pull/883 -[1]: zk smoke and latencies test passed, comparing to 3.5.4-beta, no any notable perfermance improvement .+1. The tool: https://github.com/phunt/zk-smoketest Env: 8 cores + 16GB Memory + 256GB SSD(my local Mac Pro 2015) java version:"1.8.0_191" Look at the benchmark report: https://docs.google.com/spreadsheets/d/1QnADbG9bCGMyTorEi67jQXWQSUVXQ1yQADgLV4LJHcg/edit#gid=0 That's cool, thanks Justin. I'd be interested to know - did you use the legacy/old c client binaries from the github repo or did you rebuild them? What about zkpython itself? I could see benefits or either/both. Regards, Patrick -[2]: zkCli test passed.(base operation:create,set,get,delete ...etc) +1. - Original Message - From: Enrico Olivelli To: DevZooKeeper Subject: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2 Date: 2019-04-06 17:49 Tamas, Il sab 6 apr 2019, 10:47 Tamas Penzes ha scritto: > Hi Enrico, > > Just my 2cents. > > Having the sources jars in the binary package can be useful if you want to > debug without downloading the source tarball or checking out the whole > project from github. In the same time it is not needed on the classpath. > > The docs html is generated from md files now, but the design didn't get > updated. I wanted to do it (to have the same design as the website), but > never had time for that. It doesn't look a blocker for me, can be done in > any release later. > I agree, not all my points are blockers. The most critical point is that the source tarball does not reflect the tag and, important files are missing. Cheers Enrico > Regards, Tamaas > > On Fri, Apr 5, 2019, 17:37 Enrico Olivelli wrote: > > > -1 (non binding) > > > > Good news: > > I have build the sources with jdk-8 and all tests passed > > checksums and signatures are ok > > I run a few smoke tests running on JDK11, all is ok > > > > Bad news: > > I see the following problems in the "binary package", not all blockers: > > - we have a lib/cobertura directory, not useful > > - we have zookeeper-3.5.5-sources.jar not needed in the "binary" > > package on the classpath > > - we also have all of the 'recipes' not needed in the "binary" package > > on the classpath > > - inside the "docs" directory I see a webside with a very old look and > feel > > > > The source package does not reflect the repository, for instance > > build.xml file, owaspSuppressions.xml, > > excludeFindBugsFilter.xml.are missing. > > I think we have to release in a "source package" a clean copy of ASF > > repository at the released "git tag" > > > > > > Enrico > > > > Il giorno ven 5 apr 2019 alle ore 14:35 Andor Molnar > > ha scritto: > > > > > > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 > > issues, including Maven migration, Quorum TLS, TTL nodes and lots of > other > > performance and stability improvements. > > > > > > The full release notes is available at: > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 > > > > > > *** Please download, test and vote by April 12th 2019, 23:59 UTC+0. *** > > > > > > Source files: > > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc2/ > > > > > > Maven staging repos: > > > > > > https://repository.apache.org/content/groups/staging/
Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2
On Sat, Apr 6, 2019 at 11:47 PM Justin Ling Mao wrote: > Test for the* 3.5.5 candidate 2*: > > -[0]: Jepsen consistency check had passed. +1. >Look at the attachment: *jepsen_test_report.txt.* >how to use it: https://github.com/apache/zookeeper/pull/883 > > -[1]: zk smoke and latencies test passed, comparing to *3.5.4-beta*, no > any notable perfermance improvement .+1. > The tool: https://github.com/phunt/zk-smoketest >Env: >*8 cores + 16GB Memory + 256GB SSD(my local Mac Pro 2015)* > * java version:"1.8.0_191"* >Look at the benchmark report: > https://docs.google.com/spreadsheets/d/1QnADbG9bCGMyTorEi67jQXWQSUVXQ1yQADgLV4LJHcg/edit#gid=0 > That's cool, thanks Justin. I'd be interested to know - did you use the legacy/old c client binaries from the github repo or did you rebuild them? What about zkpython itself? I could see benefits or either/both. Regards, Patrick > -[2]: zkCli test passed.(base operation:create,set,get,delete ...etc) > +1. > > > - Original Message ----- > From: Enrico Olivelli > To: DevZooKeeper > Subject: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2 > Date: 2019-04-06 17:49 > > Tamas, > Il sab 6 apr 2019, 10:47 Tamas Penzes ha > scritto: > > Hi Enrico, > > > > Just my 2cents. > > > > Having the sources jars in the binary package can be useful if you want > to > > debug without downloading the source tarball or checking out the whole > > project from github. In the same time it is not needed on the classpath. > > > > The docs html is generated from md files now, but the design didn't get > > updated. I wanted to do it (to have the same design as the website), but > > never had time for that. It doesn't look a blocker for me, can be done in > > any release later. > > > I agree, not all my points are blockers. > The most critical point is that the source tarball does not reflect the tag > and, important files are missing. > Cheers > Enrico > > Regards, Tamaas > > > > On Fri, Apr 5, 2019, 17:37 Enrico Olivelli wrote: > > > > > -1 (non binding) > > > > > > Good news: > > > I have build the sources with jdk-8 and all tests passed > > > checksums and signatures are ok > > > I run a few smoke tests running on JDK11, all is ok > > > > > > Bad news: > > > I see the following problems in the "binary package", not all blockers: > > > - we have a lib/cobertura directory, not useful > > > - we have zookeeper-3.5.5-sources.jar not needed in the "binary" > > > package on the classpath > > > - we also have all of the 'recipes' not needed in the "binary" package > > > on the classpath > > > - inside the "docs" directory I see a webside with a very old look and > > feel > > > > > > The source package does not reflect the repository, for instance > > > build.xml file, owaspSuppressions.xml, > > > excludeFindBugsFilter.xml.are missing. > > > I think we have to release in a "source package" a clean copy of ASF > > > repository at the released "git tag" > > > > > > > > > Enrico > > > > > > Il giorno ven 5 apr 2019 alle ore 14:35 Andor Molnar > > > ha scritto: > > > > > > > > This is the first stable release of 3.5 branch: 3.5.5. It resolves > 117 > > > issues, including Maven migration, Quorum TLS, TTL nodes and lots of > > other > > > performance and stability improvements. > > > > > > > > The full release notes is available at: > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 > > > > > > > > *** Please download, test and vote by April 12th 2019, 23:59 UTC+0. > *** > > > > > > > > Source files: > > > > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc2/ > > > > > > > > Maven staging repos: > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ > > > > > > > > The release candidate tag in git to be voted upon: release-3.5.5-rc2 > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > > http://www.apache.org/dist/zookeeper/KEYS > > > > > > > > Should we release this candidate? > > > > > > > > > >
Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2
On Fri, Apr 5, 2019 at 8:37 AM Enrico Olivelli wrote: > -1 (non binding) > > Good news: > I have build the sources with jdk-8 and all tests passed > checksums and signatures are ok > I run a few smoke tests running on JDK11, all is ok > > Bad news: > I see the following problems in the "binary package", not all blockers: > - we have a lib/cobertura directory, not useful > - we have zookeeper-3.5.5-sources.jar not needed in the "binary" > package on the classpath - we also have all of the 'recipes' not needed in the "binary" package > on the classpath > - inside the "docs" directory I see a webside with a very old look and feel > > The source package does not reflect the repository, for instance > build.xml file, owaspSuppressions.xml, > excludeFindBugsFilter.xml.are missing. > I think we have to release in a "source package" a clean copy of ASF > repository at the released "git tag" > Agree with Enrico's point here and previously on the list - we need make the new release artifact "source ony". Convenience binaries can also be made available, but separately from the actual "release". The source artifact should match the git tag (I typically use something like meld to verify on my other projects at apache). Patrick > > > Enrico > > Il giorno ven 5 apr 2019 alle ore 14:35 Andor Molnar > ha scritto: > > > > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 > issues, including Maven migration, Quorum TLS, TTL nodes and lots of other > performance and stability improvements. > > > > The full release notes is available at: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 > > > > *** Please download, test and vote by April 12th 2019, 23:59 UTC+0. *** > > > > Source files: > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc2/ > > > > Maven staging repos: > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ > > > > The release candidate tag in git to be voted upon: release-3.5.5-rc2 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > http://www.apache.org/dist/zookeeper/KEYS > > > > Should we release this candidate? > > >
Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2
Tamas, Il sab 6 apr 2019, 10:47 Tamas Penzes ha scritto: > Hi Enrico, > > Just my 2cents. > > Having the sources jars in the binary package can be useful if you want to > debug without downloading the source tarball or checking out the whole > project from github. In the same time it is not needed on the classpath. > > The docs html is generated from md files now, but the design didn't get > updated. I wanted to do it (to have the same design as the website), but > never had time for that. It doesn't look a blocker for me, can be done in > any release later. > I agree, not all my points are blockers. The most critical point is that the source tarball does not reflect the tag and, important files are missing. Cheers Enrico > Regards, Tamaas > > On Fri, Apr 5, 2019, 17:37 Enrico Olivelli wrote: > > > -1 (non binding) > > > > Good news: > > I have build the sources with jdk-8 and all tests passed > > checksums and signatures are ok > > I run a few smoke tests running on JDK11, all is ok > > > > Bad news: > > I see the following problems in the "binary package", not all blockers: > > - we have a lib/cobertura directory, not useful > > - we have zookeeper-3.5.5-sources.jar not needed in the "binary" > > package on the classpath > > - we also have all of the 'recipes' not needed in the "binary" package > > on the classpath > > - inside the "docs" directory I see a webside with a very old look and > feel > > > > The source package does not reflect the repository, for instance > > build.xml file, owaspSuppressions.xml, > > excludeFindBugsFilter.xml.are missing. > > I think we have to release in a "source package" a clean copy of ASF > > repository at the released "git tag" > > > > > > Enrico > > > > Il giorno ven 5 apr 2019 alle ore 14:35 Andor Molnar > > ha scritto: > > > > > > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 > > issues, including Maven migration, Quorum TLS, TTL nodes and lots of > other > > performance and stability improvements. > > > > > > The full release notes is available at: > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 > > > > > > *** Please download, test and vote by April 12th 2019, 23:59 UTC+0. *** > > > > > > Source files: > > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc2/ > > > > > > Maven staging repos: > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ > > > > > > The release candidate tag in git to be voted upon: release-3.5.5-rc2 > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > http://www.apache.org/dist/zookeeper/KEYS > > > > > > Should we release this candidate? > > > > > >
Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 2
-1 (non binding) Good news: I have build the sources with jdk-8 and all tests passed checksums and signatures are ok I run a few smoke tests running on JDK11, all is ok Bad news: I see the following problems in the "binary package", not all blockers: - we have a lib/cobertura directory, not useful - we have zookeeper-3.5.5-sources.jar not needed in the "binary" package on the classpath - we also have all of the 'recipes' not needed in the "binary" package on the classpath - inside the "docs" directory I see a webside with a very old look and feel The source package does not reflect the repository, for instance build.xml file, owaspSuppressions.xml, excludeFindBugsFilter.xml.are missing. I think we have to release in a "source package" a clean copy of ASF repository at the released "git tag" Enrico Il giorno ven 5 apr 2019 alle ore 14:35 Andor Molnar ha scritto: > > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 > issues, including Maven migration, Quorum TLS, TTL nodes and lots of other > performance and stability improvements. > > The full release notes is available at: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 > > *** Please download, test and vote by April 12th 2019, 23:59 UTC+0. *** > > Source files: > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc2/ > > Maven staging repos: > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ > > The release candidate tag in git to be voted upon: release-3.5.5-rc2 > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > http://www.apache.org/dist/zookeeper/KEYS > > Should we release this candidate? >
