Re: [jira] [Commented] (ZOOKEEPER-2064) Prevent resource leak in various classes

2014-11-24 Thread Flavio Junqueira
Thanks, Giorgio, but it is really your call. I think it is ready to get in and 
I don't have any concrete concern, so I'm just giving a heads up in the case 
anyone wants to comment.

-Flavio

> On 24 Nov 2014, at 13:45, Giorgio Zoppi  wrote:
> 
> If you need a review...just ask.
> 
> 2014-11-24 14:43 GMT+01:00 Flavio Junqueira (JIRA) :
> 
>> 
>>[
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222985#comment-14222985
>> ]
>> 
>> Flavio Junqueira commented on ZOOKEEPER-2064:
>> -
>> 
>> I'm +1 on this one, if no one else has anything to say, I'll check this in.
>> 
>>> Prevent resource leak in various classes
>>> 
>>> 
>>>Key: ZOOKEEPER-2064
>>>URL:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2064
>>>Project: ZooKeeper
>>> Issue Type: Bug
>>>   Reporter: Ted Yu
>>>   Assignee: Ted Yu
>>>   Priority: Critical
>>>Fix For: 3.4.7, 3.5.1, 3.6.0
>>> 
>>>Attachments: 2064-v1.txt, 2064-v2.txt, ZOOKEEPER-2064.patch
>>> 
>>> 
>>> In various classes, there is potential resource leak.
>>> e.g. LogIterator / RandomAccessFileReader is not closed upon return from
>> the method.
>>> Corresponding close() should be called to prevent resource leak.
>> 
>> 
>> 
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>> 
> 
> 
> 
> -- 
> Quiero ser el rayo de sol que cada día te despierta
> para hacerte respirar y vivir en me.
> "Favola -Moda".



Re: [jira] [Commented] (ZOOKEEPER-2064) Prevent resource leak in various classes

2014-11-24 Thread Giorgio Zoppi
If you need a review...just ask.

2014-11-24 14:43 GMT+01:00 Flavio Junqueira (JIRA) :

>
> [
> https://issues.apache.org/jira/browse/ZOOKEEPER-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222985#comment-14222985
> ]
>
> Flavio Junqueira commented on ZOOKEEPER-2064:
> -
>
> I'm +1 on this one, if no one else has anything to say, I'll check this in.
>
> > Prevent resource leak in various classes
> > 
> >
> > Key: ZOOKEEPER-2064
> > URL:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2064
> > Project: ZooKeeper
> >  Issue Type: Bug
> >Reporter: Ted Yu
> >Assignee: Ted Yu
> >Priority: Critical
> > Fix For: 3.4.7, 3.5.1, 3.6.0
> >
> > Attachments: 2064-v1.txt, 2064-v2.txt, ZOOKEEPER-2064.patch
> >
> >
> > In various classes, there is potential resource leak.
> > e.g. LogIterator / RandomAccessFileReader is not closed upon return from
> the method.
> > Corresponding close() should be called to prevent resource leak.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>



-- 
Quiero ser el rayo de sol que cada día te despierta
para hacerte respirar y vivir en me.
"Favola -Moda".