Re: jaasLoginRenew?

2016-03-28 Thread Patrick Hunt
Ok, good to know. Thanks Eugene.

Patrick

On Sun, Mar 27, 2016 at 7:55 AM, Eugene Koontz  wrote:
> Hi Patrick and Flavio,
>
> This property (jaasLoginRenew) variable can be removed from the wiki
> documentation. Looking at my github, I found that I was using this
> variable in a development branch at one point:
>
> https://github.com/ekoontz/zookeeper/blob/sasl-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java#L171
>
> and from there I must have added it to the wiki, but it was never used
> in the apache source tree as Patrick's grep command shows.
>
> I'll remove the variable from the wiki page today.
>
> -Eugene
>
> On 25/03/16 10:29 AM, Patrick Hunt wrote:
>> Interesting. Git reports that that's never existed in our code base.
>> "git rev-list --all | (while read revision; do git grep -F
>> 'jaasLoginRenew' $revision; done; )"
>> returns 0 results.
>>
>> Google indicates the first reference to this string was in 2011
>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL
>> All the edits on that page were from Eugene, perhaps he can shed some light.
>>
>> Patrick
>>
>> On Fri, Mar 25, 2016 at 7:15 AM, Flavio Junqueira  wrote:
>>> We have that property set and our "ZooKeeper and SASL" page says that we 
>>> need to set it, but I can't find where we use this property. A search over 
>>> the code doesn't reveal anything, does anyone have any insight here?
>>>
>>> -Flavio


Re: jaasLoginRenew?

2016-03-27 Thread Eugene Koontz
Hi Patrick and Flavio,

This property (jaasLoginRenew) variable can be removed from the wiki
documentation. Looking at my github, I found that I was using this
variable in a development branch at one point:

https://github.com/ekoontz/zookeeper/blob/sasl-3.4.0/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java#L171

and from there I must have added it to the wiki, but it was never used
in the apache source tree as Patrick's grep command shows.

I'll remove the variable from the wiki page today.

-Eugene

On 25/03/16 10:29 AM, Patrick Hunt wrote:
> Interesting. Git reports that that's never existed in our code base.
> "git rev-list --all | (while read revision; do git grep -F
> 'jaasLoginRenew' $revision; done; )"
> returns 0 results.
> 
> Google indicates the first reference to this string was in 2011
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL
> All the edits on that page were from Eugene, perhaps he can shed some light.
> 
> Patrick
> 
> On Fri, Mar 25, 2016 at 7:15 AM, Flavio Junqueira  wrote:
>> We have that property set and our "ZooKeeper and SASL" page says that we 
>> need to set it, but I can't find where we use this property. A search over 
>> the code doesn't reveal anything, does anyone have any insight here?
>>
>> -Flavio


Re: jaasLoginRenew?

2016-03-25 Thread Patrick Hunt
Interesting. Git reports that that's never existed in our code base.
"git rev-list --all | (while read revision; do git grep -F
'jaasLoginRenew' $revision; done; )"
returns 0 results.

Google indicates the first reference to this string was in 2011
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL
All the edits on that page were from Eugene, perhaps he can shed some light.

Patrick

On Fri, Mar 25, 2016 at 7:15 AM, Flavio Junqueira  wrote:
> We have that property set and our "ZooKeeper and SASL" page says that we need 
> to set it, but I can't find where we use this property. A search over the 
> code doesn't reveal anything, does anyone have any insight here?
>
> -Flavio