Re: Review Request: Fix compiler (eclipse) warnings: unused imports, unused variables, missing generics

2011-09-02 Thread Patrick Hunt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1709/#review1738
---

Ship it!


lgtm

- Patrick


On 2011-09-02 19:43:36, Thomas Koch wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1709/
> ---
> 
> (Updated 2011-09-02 19:43:36)
> 
> 
> Review request for zookeeper.
> 
> 
> Summary
> ---
> 
> .
> 
> 
> This addresses bug ZOOKEEPER-1170.
> https://issues.apache.org/jira/browse/ZOOKEEPER-1170
> 
> 
> Diffs
> -
> 
>   src/java/main/org/apache/jute/BinaryOutputArchive.java 213e203 
>   src/java/main/org/apache/jute/CsvInputArchive.java 3eb40ec 
>   src/java/main/org/apache/jute/CsvOutputArchive.java f6d60d8 
>   src/java/main/org/apache/jute/OutputArchive.java 4e084e8 
>   src/java/main/org/apache/jute/RecordReader.java 2977d3f 
>   src/java/main/org/apache/jute/RecordWriter.java 0adbd56 
>   src/java/main/org/apache/jute/XmlOutputArchive.java b65e9a0 
>   src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 626da04 
>   src/java/main/org/apache/zookeeper/Environment.java 9a66743 
>   src/java/main/org/apache/zookeeper/MultiResponse.java 70f7623 
>   src/java/main/org/apache/zookeeper/MultiTransactionRecord.java 801969a 
>   src/java/main/org/apache/zookeeper/ServerAdminClient.java da17fcf 
>   src/java/main/org/apache/zookeeper/Shell.java 789c481 
>   src/java/main/org/apache/zookeeper/server/DataTree.java 0690ce9 
>   src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 
> b690817 
>   src/java/main/org/apache/zookeeper/server/LogFormatter.java cd1347d 
>   src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 30ebf68 
>   src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 185c1e1 
>   src/java/main/org/apache/zookeeper/server/Request.java 80d2b99 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java c085bfb 
>   src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java 
> 05d8431 
>   
> src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
> cac7140 
>   src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
> a584adc 
>   src/java/main/org/apache/zookeeper/server/quorum/Follower.java ab3f288 
>   src/java/main/org/apache/zookeeper/server/quorum/Leader.java fb9dbde 
>   src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java 
> 77c27e7 
>   src/java/main/org/apache/zookeeper/server/quorum/Observer.java ee61a90 
>   
> src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
>  17ca8fb 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 
> 1b9c409 
>   src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 61f1f70 
>   
> src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
>  d37881f 
>   src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java e3d0633 
>   src/java/main/org/apache/zookeeper/server/upgrade/UpgradeSnapShotV1.java 
> aecc4d2 
> 
> Diff: https://reviews.apache.org/r/1709/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas
> 
>



Review Request: Fix compiler (eclipse) warnings: unused imports, unused variables, missing generics

2011-09-02 Thread Thomas Koch

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1709/
---

Review request for zookeeper.


Summary
---

.


This addresses bug ZOOKEEPER-1170.
https://issues.apache.org/jira/browse/ZOOKEEPER-1170


Diffs
-

  src/java/main/org/apache/jute/BinaryOutputArchive.java 213e203 
  src/java/main/org/apache/jute/CsvInputArchive.java 3eb40ec 
  src/java/main/org/apache/jute/CsvOutputArchive.java f6d60d8 
  src/java/main/org/apache/jute/OutputArchive.java 4e084e8 
  src/java/main/org/apache/jute/RecordReader.java 2977d3f 
  src/java/main/org/apache/jute/RecordWriter.java 0adbd56 
  src/java/main/org/apache/jute/XmlOutputArchive.java b65e9a0 
  src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 626da04 
  src/java/main/org/apache/zookeeper/Environment.java 9a66743 
  src/java/main/org/apache/zookeeper/MultiResponse.java 70f7623 
  src/java/main/org/apache/zookeeper/MultiTransactionRecord.java 801969a 
  src/java/main/org/apache/zookeeper/ServerAdminClient.java da17fcf 
  src/java/main/org/apache/zookeeper/Shell.java 789c481 
  src/java/main/org/apache/zookeeper/server/DataTree.java 0690ce9 
  src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java b690817 
  src/java/main/org/apache/zookeeper/server/LogFormatter.java cd1347d 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 30ebf68 
  src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 185c1e1 
  src/java/main/org/apache/zookeeper/server/Request.java 80d2b99 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java c085bfb 
  src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java 05d8431 
  src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
cac7140 
  src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
a584adc 
  src/java/main/org/apache/zookeeper/server/quorum/Follower.java ab3f288 
  src/java/main/org/apache/zookeeper/server/quorum/Leader.java fb9dbde 
  src/java/main/org/apache/zookeeper/server/quorum/LeaderElection.java 77c27e7 
  src/java/main/org/apache/zookeeper/server/quorum/Observer.java ee61a90 
  
src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java 
17ca8fb 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 
1b9c409 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 61f1f70 
  
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
 d37881f 
  src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java e3d0633 
  src/java/main/org/apache/zookeeper/server/upgrade/UpgradeSnapShotV1.java 
aecc4d2 

Diff: https://reviews.apache.org/r/1709/diff


Testing
---


Thanks,

Thomas