[magnolia-dev] [JIRA] (BLOSSOM-236) Add @Repeatable on @TemplateParam when going to Java 8

2016-04-29 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-236 
 
 
 
  Add @Repeatable on @TemplateParam when going to Java 8  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 When going to Java 8 @Repeatable should be added to @TemplateParam. Then it's no longer necessary to declare it within @TemplateParams.https://docs.oracle.com/javase/tutorial/java/annotations/repeating.html 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-236) Add @Repeatable on @TemplateParam when going to Java 8

2016-04-29 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-236 
 
 
 
  Add @Repeatable on @TemplateParam when going to Java 8  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  New Feature 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 29/Apr/16 2:27 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-235) Support for setting writable, movable and deletable with @Template

2016-04-29 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-235 
 
 
 
  Support for setting writable, movable and deletable with @Template  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  New Feature 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 29/Apr/16 9:43 AM 
 
 
 

Fix Versions:
 

 3.1.3 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



--

[magnolia-dev] [JIRA] (BLOSSOM-232) Annotations for declaring template parameters

2016-04-24 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-232 
 
 
 
  Annotations for declaring template parameters  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1.3 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-231) Blossom seems to have no location in metadata

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-231 
 
 
 
  Blossom seems to have no location in metadata  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1.3 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-234) Upgrade sample to Magnolia 5.4.6 and Spring 4.2.5

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-234 
 
 
 
  Upgrade sample to Magnolia 5.4.6 and Spring 4.2.5  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 Upgrade sample to Magnolia 5.4.6 and  Site module 1  Spring 4 . 0 2 .5 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-234) Upgrade sample to Magnolia 5.4.6 and Spring 4.2.5

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-234 
 
 
 
  Upgrade sample to Magnolia 5.4.6 and Spring 4.2.5  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Site module 1.0.6DAM 2.1.4 Should also include a site definition with template availability configured. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-234) Upgrade sample to Magnolia 5.4.6 and Site module 1.0.5

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-234 
 
 
 
  Upgrade sample to Magnolia 5.4.6 and Site module 1.0.5  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 Upgrade sample to Magnolia 5.4. 5 6  and Site module 1.0.5 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-232) Annotations for declaring template parameters

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-232 
 
 
 
  Annotations for declaring template parameters  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Right now template parameters can be set using a post create callback. For completeness it would be nice if these could be declared using annotations along with other template settings. Since parameters are defined on the RenderableDefinition interface this annotation should be usable on @Area too.The annotation is a candidate for a repeatable annotation as introduced in Java 8. Magnolia is currently on Java 7 so the annotation should be designed so that it can be used as a repeatable annotation once Magnolia goes to Java 8.https://docs.oracle.com/javase/tutorial/java/annotations/repeating.html In a class hierarchy the annotations should be evaluated from top to bottom (superclass first) so that a subclass can override parameters in its superclass. The post create callback style that's necessary now:{code:java}@PreRegisterpublic void preRegister(ConfiguredTemplateDefinition definition) {Map params = new HashMap<>();params.put("name", "value");definition.setParameters(params);}{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-232) Annotations for declaring template parameters

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-232 
 
 
 
  Annotations for declaring template parameters  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Right now template parameters can be set using a post create callback. For completeness it would be nice if these could be declared using annotations along with other template settings. Since parameters are defined on the RenderableDefinition interface this annotation should be usable on @Area too.The  annotation is a candidate for a repeatable annotation as introduced in Java 8. Magnolia is currently on Java 7 so the annotation should be designed so that it can be used as a repeatable annotation once Magnolia goes to Java 8.https://docs.oracle.com/javase/tutorial/java/annotations/repeating.htmlThe  post create callback style that's necessary now:{code:java}@PreRegisterpublic void preRegister(ConfiguredTemplateDefinition definition) {Map params = new HashMap<>();params.put("name", "value");definition.setParameters(params);}{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-232) Annotations for declaring template parameters

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-232 
 
 
 
  Annotations for declaring template parameters  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Right now template parameters can be set using a post create callback. For completeness it would be nice if these could be declared using annotations along with other template settings.  Since parameters are defined on the RenderableDefinition interface this annotation should be usable on @Area too. The post create callback style that's necessary now:{code:java}@PreRegisterpublic void preRegister(ConfiguredTemplateDefinition definition) {Map params = new HashMap<>();params.put("name", "value");definition.setParameters(params);}{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-234) Upgrade sample to Magnolia 5.4.5 and Site module 1.0.5

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-234 
 
 
 
  Upgrade sample to Magnolia 5.4.5 and Site module 1.0.5  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Should also include a site definition with template availability configured. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-234) Upgrade sample to Magnolia 5.4.5 and Site module 1.0.5

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-234 
 
 
 
  Upgrade sample to Magnolia 5.4.5 and Site module 1.0.5  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 22/Apr/16 10:07 AM 
 
 
 

Fix Versions:
 

 3.1.3 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



-

[magnolia-dev] [JIRA] (BLOSSOM-233) Duplicate registration of templates with multiple @RequestMapping methods

2016-04-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-233 
 
 
 
  Duplicate registration of templates with multiple @RequestMapping methods  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Affects Versions:
 

 3.1.2 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 22/Apr/16 9:57 AM 
 
 
 

Fix Versions:
 

 3.1.3 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
While this has no negative impact it is unnecessary and the log output lists the template more than once. 
TemplateExporter should skip registration for template ids that it has already registered. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
   

[magnolia-dev] [JIRA] (BLOSSOM-232) Annotations for declaring template parameters

2016-04-15 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-232 
 
 
 
  Annotations for declaring template parameters  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 15/Apr/16 3:22 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
Right now template parameters can be set using a post create callback. For completeness it would be nice if these could be declared using annotations along with other template settings. 
The post create callback style that's necessary now: 

 

@PreRegister
public void preRegister(ConfiguredTemplateDefinition definition) {
Map params = new HashMap<>();
params.put("name", "value");
definition.setParameters(params);
}
 

 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 

[magnolia-dev] [JIRA] (DOCU-705) Blossom - add sample for registering custom dialog action/s

2016-04-01 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Documentation /  DOCU-705 
 
 
 
  Blossom - add sample for registering custom dialog action/s  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-39) SiteAwareRendererWrapper fails to render optional areas

2016-02-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-39 
 
 
 
  SiteAwareRendererWrapper fails to render optional areas  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 1.0.5 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-39) SiteAwareRendererWrapper fails to render optional areas

2016-02-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-39 
 
 
 
  SiteAwareRendererWrapper fails to render optional areas  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Sprint:
 
 Kromeriz 29 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-39) SiteAwareRendererWrapper fails to render optional areas

2016-02-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-39 
 
 
 
  SiteAwareRendererWrapper fails to render optional areas  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 It fails with an NPE in  SiteAwareFreemarkerRenderer  SiteAwareRendererWrapper  on line 84 where it tries to use the content.It appears that optional areas are rendered without a content node. In AreaElement.java we have this code:{code:java}private boolean canRenderAreaScript() {if (!this.isAreaDefinitionEnabled) { // area script can be rendered only when area is enabledreturn false;}if (this.areaNode != null) {return true;}if (this.optional && this.getServer().isAdmin() && !MgnlContext.getAggregationState().isPreviewMode()) { // render script for optional areas when being in edit mode on author instancereturn true;}return false;}{code}So if areaNode is null and optional is true and we're in preview mode on an author instance then we go ahead and call the renderer without a content node. The template script is then rendered.This works fine in JspRenderer and FreemarkerRenderer but in  SiteAwareFreemarkerRenderer  SiteAwareRendererWrapper  throws an NPE.Without a content node  SiteAwareFreemarkerRenderer  SiteAwareRendererWrapper  can't get the current site, and can't decide if it's rendering a page (well it could look at the renderable definition id to see if it has pages/ in it but there's no point since it doesn't have a site to use anyway). SiteAwareFreemarkerRenderer SiteAwareRendererWrapper  should just skip template prototype merging altogether and proceed with rendering when content is null. Basically assuming that when content is null its an area so there's nothing to do anyway. With this change the fix would be a simple null check :{code:java}try {RenderableDefinition renderableDefinition = renderingCtx . getRenderableDefinition();if (content != null) {final Site site = getSite(content);// Merge in case of a pageif (NodeUtil.isNodeType(content, NodeTypes.Page.NAME)) {renderableDefinition = BeanMergerUtil.merge(renderableDefinition, site.getTemplates().getPrototype(), fallbackTemplateDefinition.getFallbackTemplateDefinition());}}renderingCtx.push(content, renderableDefinition);try {super.render(renderingCtx, contextObjects);} finally {renderingCtx.pop();}} catch (RepositoryException e) {throw new RenderException(String.format("Could not determine node type of node [%s]", content), e);}{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
  

[magnolia-dev] [JIRA] (MGNLSITE-39) SiteAwareRendererWrapper fails to render optional areas

2016-02-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-39 
 
 
 
  SiteAwareRendererWrapper fails to render optional areas  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 SiteAwareFreemarkerRenderer SiteAwareRendererWrapper  fails to render optional areas 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-43) Site aware renderer for JSPs

2016-01-15 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-43 
 
 
 
  Site aware renderer for JSPs  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Sprint:
 
 Kromeriz 27 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-47) Add sitefn context attribute to standard JSP renderer

2016-01-14 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-47 
 
 
 
  Add sitefn context attribute to standard JSP renderer  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Affects Versions:
 

 1.0.4 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 14/Jan/16 5:05 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
SiteModuleVersionHandler installs the sitefn attribute on the freemarker rendering renderer but doesn't for the JSP renderer. 
See info.magnolia.module.site.setup.SiteModuleVersionHandler#getExtraInstallTasks 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 

[magnolia-dev] [JIRA] (MGNLSITE-43) Site aware renderer for JSPs

2016-01-14 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-43 
 
 
 
  Site aware renderer for JSPs  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 1.0.5 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-43) Site aware renderer for JSPs

2016-01-08 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-43 
 
 
 
  Site aware renderer for JSPs  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-39) SiteAwareFreemarkerRenderer fails to render optional areas

2016-01-08 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-39 
 
 
 
  SiteAwareFreemarkerRenderer fails to render optional areas  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-41) ConfiguredSiteTemplateAvailability should deny availability of non-visible templates

2016-01-08 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-41 
 
 
 
  ConfiguredSiteTemplateAvailability should deny availability of non-visible templates  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-228) Compatibility with new I18n API

2015-11-13 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-228 
 
 
 
  Compatibility with new I18n API  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Since the first version of Blossom labels for tabs has been set in the @TabFactory annotation, Blossom will also set the name property to the same value. The reasoning behind this was that the name had little purpose when using Blossom.Also the order of tabs has been set with the @TabOrder annotation by specifying the tabs labels. With the old I18n system you'd specify i18n keys instead to have them translated.With the new i18n system you can leave tab labels empty and Magnolia will use a key generated by a convention to find the translation.Using the new API is cumbersome because Blossom will set the label, BLOSSOM-207. Sorting is not possible without replacing the default behavior, BLOSSOM-202.For backwards compatibility reasons its not straight forward to change this. . h2 .  Proposed solutionIntroduce two properties that control these behaviors. They would by default be set to keep the current behavior but allow for easy configuration without subclassing as in BLOSSOM-202. h2. Additional changes  Javadoc on @TabFactory should indicate that both name and label is set.The title attribute on @Template is currently required which doesn't make sense when translating it with the new API. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use o

[magnolia-dev] [JIRA] (BLOSSOM-228) Compatibility with new I18n API

2015-11-13 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-228 
 
 
 
  Compatibility with new I18n API  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Since the first version of Blossom labels for tabs has been set in the @TabFactory annotation, Blossom will also set the name property to the same value. The reasoning behind this was that the name had little purpose when using Blossom.Also the order of tabs has been set with the @TabOrder annotation by specifying the tabs labels. With the old I18n system you'd specify i18n keys instead to have them translated.With the new i18n system you can leave tab labels empty and Magnolia will use a key generated by a convention to find the translation.Using the new API is cumbersome because Blossom will set the label, BLOSSOM-207. Sorting is not possible without replacing the default behavior, BLOSSOM-202. For backwards compatibility reasons its not straight forward to change this..h2 Proposed solutionIntroduce two properties that control these behaviors. They would by default be set to keep the current behavior but allow for easy configuration without subclassing as in BLOSSOM-202. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-228) Compatibility with new I18n API

2015-11-13 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-228 
 
 
 
  Compatibility with new I18n API  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Since the first version of Blossom labels for tabs has been set in the @TabFactory annotation, Blossom will also set the name property to the same value. The reasoning behind this was that the name had little purpose when using Blossom.Also the order of tabs has been set with the @TabOrder annotation by specifying the tabs labels. With the old I18n system you'd specify i18n keys instead to have them translated.With the new i18n system you can leave tab labels empty and Magnolia will use a key generated by a convention to find the translation.Using the new API is cumbersome because Blossom will set the label, BLOSSOM-207. Sorting is not possible without replacing the default behavior, BLOSSOM-202.For backwards compatibility reasons its not straight forward to change this.h2. Proposed solutionIntroduce two properties that control these behaviors. They would by default be set to keep the current behavior but allow for easy configuration without subclassing as in BLOSSOM-202. *magnolia.blossom.sortTabsByLabel**magnolia.blossom.setTabLabels* h2. Additional changesJavadoc on @TabFactory should indicate that both name and label is set.The title attribute on @Template is currently required which doesn't make sense when translating it with the new API. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnoli

[magnolia-dev] [JIRA] (BLOSSOM-228) Compatibility with new I18n API

2015-11-13 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-228 
 
 
 
  Compatibility with new I18n API  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Since the first version of Blossom labels for tabs has been set in the @TabFactory annotation, Blossom will also set the name property to the same value. The reasoning behind this was that the name had little purpose when using Blossom.Also the order of tabs has been set with the @TabOrder annotation by specifying the tabs labels. With the old I18n system you'd specify i18n keys instead to have them translated.With the new i18n system you can leave tab labels empty and Magnolia will use a key generated by a convention to find the translation.Using the new API is cumbersome because Blossom will set the label, BLOSSOM-207. Sorting is not possible without replacing the default behavior, BLOSSOM-202. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-228) Compatibility with new I18n API

2015-11-13 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-228 
 
 
 
  Compatibility with new I18n API  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 13/Nov/15 6:20 PM 
 
 
 

Fix Versions:
 

 3.1.2 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For 

[magnolia-dev] [JIRA] (BLOSSOM-220) UuidRedirectView prefixes url with handle, ignores domain

2015-11-13 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-220 
 
 
 
  UuidRedirectView prefixes url with handle, ignores domain  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1.1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-226) Call to annotated method @RequestMapping on a template ends in Argument type mismatch

2015-10-30 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-226 
 
 
 
  Call to annotated method @RequestMapping on a template ends in Argument type mismatch  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 Call to  annoted  annotated  method @RequestMapping on a template ends in Argument type mismatch 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-226) Call to annoted method @RequestMapping on a template ends in Argument type mismatch

2015-10-19 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-226 
 
 
 
  Call to annoted method @RequestMapping on a template ends in Argument type mismatch  
 
 
 
 
 
 
 
 
 
 
Attached proposed fix. 
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Attachment:
 
 BlossomRequestMappingHandlerAdapter.java 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-226) Call to annoted method @RequestMapping on a template ends in Argument type mismatch

2015-10-19 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-226 
 
 
 
  Call to annoted method @RequestMapping on a template ends in Argument type mismatch  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Priority:
 
 Minor Major 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-226) Call to annoted method @RequestMapping on a template ends in Argument type mismatch

2015-10-19 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-226 
 
 
 
  Call to annoted method @RequestMapping on a template ends in Argument type mismatch  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1.2 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-226) Call to annoted method @RequestMapping on a template ends in Argument type mismatch

2015-10-19 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-226 
 
 
 
  Call to annoted method @RequestMapping on a template ends in Argument type mismatch  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Affects Version/s:
 
 3.0.2 
 
 
 

Affects Version/s:
 
 3.1.1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-226) Call to annoted method @RequestMapping on a template ends in Argument type mismatch

2015-10-19 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-226 
 
 
 
  Call to annoted method @RequestMapping on a template ends in Argument type mismatch  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Call to an annoted method @RequestMapping on a template ends in Argument type mismatch when I specify a parameter of type {{info.magnolia.context.Context}}Spring resolves the Context beeing an object of type {{org.springframework.validation.support.BindingAwareModelMap}} rather than a an instance of {{MgnlContext.getInstance()}} thus resulting in a Argument type mismatch.Here is the stack trace {noformat} HandlerMethod details: Controller [com.foo.bar.template.WebPage]Method [public java.lang.String com.foo.bar.template.WebPage.handleRequest(javax.servlet.http.HttpServletRequest,javax.servlet.http.HttpServletResponse,info.magnolia.context.Context,javax.jcr.Node) throws javax.jcr.RepositoryException]Resolved arguments: [0] [type=info.magnolia.module.blossom.support.ForwardRequestWrapper] [value=info.magnolia.module.blossom.support.ForwardRequestWrapper@20415821][1] [type=info.magnolia.cms.security.SecurityCallbackFilter$StatusSniffingResponseWrapper] [value=info.magnolia.cms.security.SecurityCallbackFilter$StatusSniffingResponseWrapper@2200ef12][2] [type=org.springframework.validation.support.BindingAwareModelMap] [value={}][3] [type=info.magnolia.audit.MgnlAuditLoggingContentDecoratorNodeWrapper] [value=node /Test]at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:225)at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:137)at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:111)at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:806)at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:729)at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:959)at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:893)at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)... 141 moreCaused by: java.lang.IllegalArgumentException: argument type mismatchat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)at java.lang.reflect.Method.invoke(Method.java:606)at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)... 149 more {noformat} 
 
 
 
 
 
 
 
 
  

[magnolia-dev] [JIRA] (BLOSSOM-225) Compatibility fixes for Spring 4.2

2015-10-02 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-225 
 
 
 
  Compatibility fixes for Spring 4.2  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 The deprecated AopUtils.isCglibProxyClass needs to be replaced with ClassUtils.isCglibProxyClass.Tests also need to be run with Servlet 3 jar on classpath.{code:xml}  javax.servlet  javax.servlet-api  3.0.1  provided{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-225) Compatibility fixes for Spring 4.2

2015-10-02 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-225 
 
 
 
  Compatibility fixes for Spring 4.2  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 02/Oct/15 4:52 PM 
 
 
 

Fix Versions:
 

 3.1.1 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




F

[magnolia-dev] [JIRA] (BLOSSOM-224) Update Blossom sample for site module support

2015-10-02 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-224 
 
 
 
  Update Blossom sample for site module support  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 An update to use Blossom 3.1.1, should:* Update to Magnolia 5.4.2*  Update to Spring 4.2.1*  Add dependency on the site module and its app* Change configuration to use {{SiteAwareFreemarkerRenderer}} and keep previous configuration with instructions on how to switch* Preconfigure the usual templating functions classes for all renderers* Switch from JSP to Freemarker for the page templateTo work around MAGNOLIA-6393 a dependency on magnolia-ui-dialog 5.4.2 had to be added.To work around MGNLSITE-40 a bootstrap file for config:/modules/site/config/site had to be added. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (ARCH-44) Update Blossom archetype for Blossom 3.1.1 and site module support

2015-10-02 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Maven Archetypes /  ARCH-44 
 
 
 
  Update Blossom archetype for Blossom 3.1.1 and site module support   
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Basically the same changes as in BLOSSOM-224 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-43) Site aware renderer for JSPs

2015-10-02 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-43 
 
 
 
  Site aware renderer for JSPs  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Attachment:
 
 SiteAwareJspRenderer.java 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-43) Site aware renderer for JSPs

2015-10-02 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-43 
 
 
 
  Site aware renderer for JSPs  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Affects Versions:
 

 1.0.2 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 02/Oct/15 11:27 AM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
It is currently only possible to use the template prototype configured on a site when using Freemarker templates. 
This is because the site module only has one renderer that is based on FreemarkerRenderer. 
To support JSPs we need a SiteAwareJspRenderer. It would be identical to SiteAwareFreemarkerRenderer except instead extend from JspRenderer and have other constructor arguments. 
It would need to have a specific renderType, for instance site-jsp. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 

[magnolia-dev] [JIRA] (ARCH-44) Update Blossom archetype for Blossom 3.1.1 and site module support

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Maven Archetypes /  ARCH-44 
 
 
 
  Update Blossom archetype for Blossom 3.1.1 and site module support   
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 25/Sep/15 6:30 PM 
 
 
 

Fix Versions:
 

 1.2.x 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



---

[magnolia-dev] [JIRA] (ARCH-43) Create new archetype version which reflects Magnolia 5.4

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Maven Archetypes /  ARCH-43 
 
 
 
  Create new archetype version which reflects Magnolia 5.4  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Would be nice to have an archetype which creates a Magnolia Module according to [Magnolia 5.4 Module structure | https://documentation.magnolia-cms.com/display/ DOCS54 DOCS /Module+structure]Latest version.Current "Option 4" (_An archetype to create STK Theme modules_) probably can be skipped. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-224) Update Blossom sample for site module support

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-224 
 
 
 
  Update Blossom sample for site module support  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  New Feature 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 25/Sep/15 6:26 PM 
 
 
 

Fix Versions:
 

 3.1.1 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
An update to use Blossom 3.1.1, should: 
 

Update to Magnolia 5.4.2
 

Add dependency on the site module and its app
 

Change configuration to use SiteAwareFreemarkerRenderer and keep previous configuration with instructions on how to switch
 

Preconfigure the usual templating functions classes for all renderers
 

Switch from JSP to Freemarker for the page template
 
 
To work around MAGNOLIA-6393 a dependency on magnolia-ui-dialog 5.4.2 had to be added. 
To work around MGNLSITE-40 a bootstrap file for config:/modules/site/config/sit

[magnolia-dev] [JIRA] (BLOSSOM-224) Update Blossom sample for site module support

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-224 
 
 
 
  Update Blossom sample for site module support  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Issue Type:
 
 New Feature Improvement 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLSITE-42) Allow site definition template availability on templates not using the site renderer

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-42 
 
 
 
  Allow site definition template availability on templates not using the site renderer  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  New Feature 
 
 
 

Affects Versions:
 

 1.0.2 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 25/Sep/15 5:51 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
This is kind of a big change but it would make sense to use the template availability configuration on the site definition also for templates not using the site renderer. 
For instance plain text templates or jsp templates. 
And for Blossom templates which is a special case in that those templates use the blossom renderer to call into Spring and then render their views using the site renderer. In this scenario SiteAwareTemplateAvailability checks the render type and sees blossom and therefor fallback to the default template availability strategy. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 

[magnolia-dev] [JIRA] (MGNLSITE-41) ConfiguredSiteTemplateAvailability should deny availability of non-visible templates

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-41 
 
 
 
  ConfiguredSiteTemplateAvailability should deny availability of non-visible templates  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 25/Sep/15 5:32 PM 
 
 
 

Priority:
 
  Trivial 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
TemplateDefinition has a property visible that hides the template in Admincentral. The default template availability strategy checks this flag and excludes templates that have it set. 
In DefaultTemplateAvailability: 

 

// Templates with no visible property, or visible=false are not available.
if (templateDefinition.getVisible() != null && !templateDefinition.getVisible()) {
return false;
}
 

 
This is probably not an issue since users can just not list the template in the site definition templates availability settings. But for consistency non-visible templates should be hidden even if listed in the site config. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 

[magnolia-dev] [JIRA] (BLOSSOM-222) Integration with site module

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-222 
 
 
 
  Integration with site module  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 25/Sep/15 5:06 PM 
 
 
 

Fix Versions:
 

 3.1.1 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
Should allow for these features: 
 

Interoperability with the site's template prototype
 

Interoperability with the site's template availability
 

Resolving of Site and Theme as arguments to @RequestMapping methods
 
 
Interoperability with the site's template prototype requires using the site renderer so there needs to be a new TemplateViewRenderer for it. The site renderer takes a number of dependencies as constructor arguments so there should be a FactoryBean that takes care of that. 
Interoperability with the site's template availability is achieved by defaulting to the default availability strategy unless one is implemented on the template using @Available. 
Resolving of Site and Theme arguments needs to be added in the Blossom HandlerMethodArgumentResolver and WebArgumentResolver. 
  

[magnolia-dev] [JIRA] (BLOSSOM-223) Support Channel as an argument to @RequestMapping methods

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-223 
 
 
 
  Support Channel as an argument to @RequestMapping methods  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 25/Sep/15 5:07 PM 
 
 
 

Fix Versions:
 

 3.1.1 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
Needs to be supported in both BlossomHandlerMethodArgumentResolver and BlossomWebArgumentResolver. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1

[magnolia-dev] [JIRA] (MGNLSITE-40) Site module does not bootstrap a config node for the site

2015-09-25 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-40 
 
 
 
  Site module does not bootstrap a config node for the site  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 1.0.2 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 25/Sep/15 3:55 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
Site module does not create the config:/modules/site/config/site node. Unless it's bootstrapped in by another module, such as STK or travel demo, rendering breaks and the site app is unusable with an empty actionbar. 
This commit back in 1.0-m2 is kind of related https://git.magnolia-cms.com/gitweb/?p=modules/site.git;a=commit;h=3ab8877546a32e0f8fc991e90710d87cce97ffa0 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

[magnolia-dev] [JIRA] (MGNLSITE-39) SiteAwareFreemarkerRenderer fails to render optional areas

2015-09-18 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-39 
 
 
 
  SiteAwareFreemarkerRenderer fails to render optional areas  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 It fails with an NPE in SiteAwareFreemarkerRenderer on line 84 where it tries to use the content.It appears that optional areas are rendered without a content node. In AreaElement.java we have this code:{code:java}private boolean canRenderAreaScript() {if (!this.isAreaDefinitionEnabled) { // area script can be rendered only when area is enabledreturn false;}if (this.areaNode != null) {return true;}if (this.optional && this.getServer().isAdmin() && !MgnlContext.getAggregationState().isPreviewMode()) { // render script for optional areas when being in edit mode on author instancereturn true;}return false;}{code}So if areaNode is null and optional is true and we're in preview mode on an author instance then we go ahead and call the renderer without a content node. The template script is then rendered.This works fine in JspRenderer and FreemarkerRenderer but in SiteAwareFreemarkerRenderer throws an NPE.Without a content node SiteAwareFreemarkerRenderer can't get the current site, and can't decide if it's rendering a page (well it could look at the renderable definition id to see if it has pages/ in it but there's no point since it doesn't have a site to use anyway).SiteAwareFreemarkerRenderer should just skip template prototype merging altogether and proceed with rendering when content is null. Basically assuming that when content is null its an area so there's nothing to do anyway.  With this change the fix would be a simple null check:{code:java}try {RenderableDefinition renderableDefinition = renderingCtx.getRenderableDefinition();if (content != null) {final Site site = getSite(content);// Merge in case of a pageif (NodeUtil.isNodeType(content, NodeTypes.Page.NAME)) {renderableDefinition = BeanMergerUtil.merge(renderableDefinition, site.getTemplates().getPrototype(), fallbackTemplateDefinition.getFallbackTemplateDefinition());}}renderingCtx.push(content, renderableDefinition);try {super.render(renderingCtx, contextObjects);} finally {renderingCtx.pop();}} catch (RepositoryException e) {throw new RenderException(String.format("Could not determine node type of node [%s]", content), e);}{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 

[magnolia-dev] [JIRA] (MGNLSITE-39) SiteAwareFreemarkerRenderer fails to render optional areas

2015-09-18 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Site Module /  MGNLSITE-39 
 
 
 
  SiteAwareFreemarkerRenderer fails to render optional areas  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 1.0.2 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 api 
 
 
 

Created:
 

 18/Sep/15 3:25 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
It fails with an NPE in SiteAwareFreemarkerRenderer on line 84 where it tries to use the content. 
It appears that optional areas are rendered without a content node. In AreaElement.java we have this code: 

 

private boolean canRenderAreaScript() {
if (!this.isAreaDefinitionEnabled) { // area script can be rendered only when area is enabled
return false;
}
if (this.areaNode != null) {
return true;
}
if (this.optional && this.getServer().isAdmin() && !MgnlContext.getAggregationState().isPreviewMode()) { // render script for optional areas when being in edit mode on author instance
return true;
}
return false;
}
 

 
So if areaNode i

[magnolia-dev] [JIRA] (BLOSSOM-221) Allow setting type and subtype on templates

2015-08-28 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-221 
 
 
 
  Allow setting type and subtype on templates  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 28/Aug/15 4:07 PM 
 
 
 

Fix Versions:
 

 3.1.1 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
An example: 

 

@Controller
@Template(title = "Main", id = "blossomSampleModule:pages/main", type="some-type", subtype="some-subtype")
public class MainTemplate {
 

 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 

[magnolia-dev] [JIRA] (BLOSSOM-104) Support for inheriting areas from super class

2015-08-28 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-104 
 
 
 
  Support for inheriting areas from super class  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Its common that many templates in a project have the same set of areas and it would be very useful if you could define them only once. Taking advantage of the class hierarchy is one way of doing this, just like blossom dialogs inherits tabs from the superclass.For example:{code}public abstract class Superclass {   @Controller @Area("headerArea") public static class HeaderArea {   @RequestMapping("/headerArea") public String render() { return "areas/headerArea"; } }}@Controller@Template(...)public class InheritedClass extends Superclass { //...}{code}h4. LimitationsIt is however not possible to extend a class and override a method annotated with @RequestMapping. This due to a limitation in Spring MVC which fails to see that the method in the parent is overridden.The resulting exception is:{noformat}Caused by: java.lang.IllegalStateException: Cannot map handler 'mainTemplateWithFooter' to URL path [/mainTemplate]: There is already handler of type [class info.magnolia.blossom.sample.module.MainTemplate] mapped. at org.springframework.web.servlet.handler.AbstractUrlHandlerMapping.registerHandler(AbstractUrlHandlerMapping.java:294) at org.springframework.web.servlet.handler.AbstractUrlHandlerMapping.registerHandler(AbstractUrlHandlerMapping.java:266) at org.springframework.web.servlet.handler.AbstractDetectingUrlHandlerMapping.detectHandlers(AbstractDetectingUrlHandlerMapping.java:82) at org.springframework.web.servlet.handler.AbstractDetectingUrlHandlerMapping.initApplicationContext(AbstractDetectingUrlHandlerMapping.java:58) at org.springframework.context.support.ApplicationObjectSupport.initApplicationContext(ApplicationObjectSupport.java:119) at org.springframework.web.context.support.WebApplicationObjectSupport.initApplicationContext(WebApplicationObjectSupport.java:72) at org.springframework.context.support.ApplicationObjectSupport.setApplicationContext(ApplicationObjectSupport.java:73) at org.springframework.context.support.ApplicationContextAwareProcessor.invokeAwareInterfaces(ApplicationContextAwareProcessor.java:117) at org.springframework.context.support.ApplicationContextAwareProcessor.postProcessBeforeInitialization(ApplicationContextAwareProcessor.java:92) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsBeforeInitialization(AbstractAutowireCapableBeanFactory.java:396) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1505) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:521) ... 79 more{noformat} 
 
 
 
 
 
 
 
 
 
 
 
 
  

[magnolia-dev] [JIRA] (BLOSSOM-216) Avoid using deprecated DamConfig for tab creation

2015-07-14 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-216 
 
 
 
  Avoid using deprecated DamConfig for tab creation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-216) Avoid using deprecated DamConfig for tab creation

2015-07-13 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-216 
 
 
 
  Avoid using deprecated DamConfig for tab creation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-210) Spring Loaded plugin for Blossom development

2015-07-03 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-210 
 
 
 
  Spring Loaded plugin for Blossom development  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Plugin for Spring Loaded that refreshes the application contexts of BlossomDispatcherServlets when a class annotated with @Controller or a type level Blossom annotation is reloaded.The behavior can be customized using these two system properties:*BlossomSpringLoadedPlugin.refreshOnAnyChange* will make the plugin refresh when any class is changed, not just those with Blossom annotations or the @Controller annotation.*BlossomSpringLoadedPlugin.refreshAllDispatcherServlets* will make the plugin also refresh plain DispatcherServlets.To use it first download Spring Loadedhttps://github.com/spring-projects/spring-loadedThen add it using JVM arguments, for instance:{noformat}-javaagent:/Users/user/Downloads/springloaded-1.2.3.RELEASE.jar-noverify-Xmx512m-XX:MaxPermSize=128M-DBlossomSpringLoadedPlugin.refreshOnAnyChange=true-DBlossomSpringLoadedPlugin.refreshAllDispatcherServlets=true{noformat}Then add the plugin JAR to your project:{code:xml}  info.magnolia.blossom  magnolia-blossom-spring-loaded  1.0. 2 3 {code}Spring Loaded 1.2.3 can't reload classes packaged in JAR files. This is coming in the next release, 1.2.4. In the mean time you can change your IDE to package classes into the WEB-INF/classes directory instead of making a JAR file in WEB-INF/lib. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: ht

[magnolia-dev] [JIRA] (BLOSSOM-214) Adapt to changed LocaleProvider in Magnolia 5.4

2015-06-26 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-214 
 
 
 
  Adapt to changed LocaleProvider in Magnolia 5.4  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 26/Jun/15 3:58 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-214) Adapt to changed LocaleProvider in Magnolia 5.4

2015-06-26 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-214 
 
 
 
  Adapt to changed LocaleProvider in Magnolia 5.4  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-215) Adapt to changes in template and dialog registries and providers in Magnolia 5.4

2015-06-26 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-215 
 
 
 
  Adapt to changes in template and dialog registries and providers in Magnolia 5.4  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 26/Jun/15 3:59 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-215) Adapt to changes in template and dialog registries and providers in Magnolia 5.4

2015-06-26 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-215 
 
 
 
  Adapt to changes in template and dialog registries and providers in Magnolia 5.4  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Fix Version/s:
 
 3.1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLUI-3458) Backwards compatibility in DialogDefinitionRegistry and providers

2015-06-26 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3458 
 
 
 
  Backwards compatibility in DialogDefinitionRegistry and providers  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Priority:
 
 Critical Neutral 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.7#64022-sha1:4cb2968) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLUI-3458) Backwards compatibility in DialogDefinitionRegistry and providers

2015-06-12 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3458 
 
 
 
  Backwards compatibility in DialogDefinitionRegistry and providers  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Priority set to critical because it prevents using Blossom with 5.4.h4. BackgroundBlossom creates its dialogs on demand when they're needed. Every time a dialog is to be displayed its definition is created from scratch. This allows the dialog creation code to adapt to the current context, for instance who's using it and what content it is being used for. The context is captured by a custom FormDialogPresenter and picked up by the dialog provider. It is therefore impossible to get the definition of a blossom dialog without a context. The definition can only be acquired from the provider when called from the custom FormDialogPresenter. h4. Magnolia 4.5 In 5.4 the whole registry and provider concept changes. These changes break Blossom because:* There's no longer a getPresenterClass() on the provider. It is instead read directly from the definition, which cannot be acquired. This is done in FormDialogPresenterFactoryImpl and in DialogDefinitionRegistry.* There's no way to register a legacy dialog definition provider. There needs to be a register() method in DialogDefintionRegistry for the legacy provider interface. The method should wrap the legacy interface to adapt it to the new interface. The new provider keeps an in memory representation of the definition which is acquired when the provider is created. This must not happen when registering a legacy provider.In 5.4 TemplateDefinitionRegistry has a backwards compatible register method. It works fine for Blossom because its template definitions are created once at startup and then never changed. Having said that, its design makes it impossible for implementations to have a provider that created the definition on demand.I have implemented very hackish workarounds for these issues and will commit them on branches. Should at least serve as some kind of example. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

   

[magnolia-dev] [JIRA] (MGNLUI-3458) Backwards compatibility in DialogDefinitionRegistry and providers

2015-06-12 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3458 
 
 
 
  Backwards compatibility in DialogDefinitionRegistry and providers  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 For legacy provider type. The equivalent already exists in TemplateDefinitionRegistry. Priority set to critical because it prevents using Blossom with 5.4. h4. BackgroundBlossom creates its dialogs on demand when they're needed. Every time a dialog is to be displayed its definition is created from scratch. This allows the dialog creation code to adapt to the current context, for instance who's using it and what content it is being used for. The context is captured by a custom FormDialogPresenter and picked up by the dialog provider. It is therefore impossible to get the definition of a blossom dialog without a context. The definition can only be acquired from the provider when called from the custom FormDialogPresenter.In 5.4 the whole registry and provider concept changes. These changes break Blossom because:* There's no longer a getPresenterClass() on the provider. It is instead read directly from the definition, which cannot be acquired. This is done in FormDialogPresenterFactoryImpl and in DialogDefinitionRegistry.* There's no way to register a legacy dialog definition provider. There needs to be a register() method in DialogDefintionRegistry for the legacy provider interface. The method should wrap the legacy interface to adapt it to the new interface. The new provider keeps an in memory representation of the definition which is acquired when the provider is created. This must not happen when registering a legacy provider.In 5.4 TemplateDefinitionRegistry has a backwards compatible register method. It works fine for Blossom because its template definitions are created once at startup and then never changed. Having said that, its design makes it impossible for implementations to have a provider that created the definition on demand.I have implemented very hackish workarounds for these issues and will commit them on branches. Should at least serve as some kind of example. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 

[magnolia-dev] [JIRA] (MGNLUI-3458) Backwards compatibility in DialogDefinitionRegistry and providers

2015-06-12 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3458 
 
 
 
  Backwards compatibility in DialogDefinitionRegistry and providers  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 Backwards  compatible register method  compatibility  in DialogDefinitionRegistry  and providers 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-213) NPE in Blossom Spring Loaded plugin when slashedTypeName is null

2015-06-12 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-213 
 
 
 
  NPE in Blossom Spring Loaded plugin when slashedTypeName is null  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Components:
 

 blossom-spring-loaded 
 
 
 

Created:
 

 12/Jun/15 12:59 PM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   



--

[magnolia-dev] [JIRA] (MGNLUI-3458) Backwards compatible register method in DialogDefinitionRegistry

2015-06-09 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia UI /  MGNLUI-3458 
 
 
 
  Backwards compatible register method in DialogDefinitionRegistry  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  New Feature 
 
 
 

Affects Versions:
 

 5.4 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 dialogs 
 
 
 

Created:
 

 09/Jun/15 1:22 PM 
 
 
 

Labels:
 

 dialog 
 
 
 

Priority:
 
  Critical 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 

Security Level:
 

 Public 
 
 
 
 
 
 
 
 
 
 
For legacy provider type. The equivalent already exists in TemplateDefinitionRegistry. 
Priority set to critical because it prevents using Blossom with 5.4. 
 
 
 
 
 

[magnolia-dev] [JIRA] (BLOSSOM-211) Change group id and artifact id of Blossom Spring Loaded plugin

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-211 
 
 
 
  Change group id and artifact id of Blossom Spring Loaded plugin  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 Group Change group  id  and artifact id  of  blossom-spring-loaded should be info.magnolia.blossom  Blossom Spring Loaded plugin 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-210) Spring Loaded plugin for Blossom development

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-210 
 
 
 
  Spring Loaded plugin for Blossom development  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Plugin for Spring Loaded that refreshes the application contexts of BlossomDispatcherServlets when a class annotated with @Controller or a type level Blossom annotation is reloaded.The behavior can be customized using these two system properties:*BlossomSpringLoadedPlugin.refreshOnAnyChange* will make the plugin refresh when any class is changed, not just those with Blossom annotations or the @Controller annotation.*BlossomSpringLoadedPlugin.refreshAllDispatcherServlets* will make the plugin also refresh plain DispatcherServlets.To use it first download Spring Loadedhttps://github.com/spring-projects/spring-loadedThen add it using JVM arguments, for instance:{noformat}-javaagent:/Users/user/Downloads/springloaded-1.2.3.RELEASE.jar-noverify-Xmx512m-XX:MaxPermSize=128M-DBlossomSpringLoadedPlugin.refreshOnAnyChange=true-DBlossomSpringLoadedPlugin.refreshAllDispatcherServlets=true{noformat}Then add the plugin JAR to your project:{code:xml}  info.magnolia.blossom   magnolia- blossom-spring-loaded  1.0. 1 2 {code}Spring Loaded 1.2.3 can't reload classes packaged in JAR files. This is coming in the next release, 1.2.4. In the mean time you can change your IDE to package classes into the WEB-INF/classes directory instead of making a JAR file in WEB-INF/lib. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: 

[magnolia-dev] [JIRA] (BLOSSOM-211) Change group id and artifact id of Blossom Spring Loaded plugin

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-211 
 
 
 
  Change group id and artifact id of Blossom Spring Loaded plugin  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 The groupId should be nfo.magnolia.blossomThe artifactId should be magnolia-blossom-spring-loaded 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-212) Spring application context in Magnolia

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-212 
 
 
 
  Spring application context in Magnolia  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Project:
 
 Documentation Magnolia Blossom Module 
 
 
 

Key:
 
 DOCU BLOSSOM - 565 212 
 
 
 

Workflow:
 
 Copy of default jira wf Product Dev Workflow 
 
 
 

Component/s:
 
 content 
 
 
 

Security:
 
 Public 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.ma

[magnolia-dev] [JIRA] (BLOSSOM-210) Spring Loaded plugin for Blossom development

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-210 
 
 
 
  Spring Loaded plugin for Blossom development  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Plugin for Spring Loaded that refreshes the application contexts of BlossomDispatcherServlets when a class annotated with @Controller or a type level Blossom annotation is reloaded.The behavior can be customized using these two system properties:*BlossomSpringLoadedPlugin.refreshOnAnyChange* will make the plugin refresh when any class is changed, not just those with Blossom annotations or the @Controller annotation.*BlossomSpringLoadedPlugin.refreshAllDispatcherServlets* will make the plugin also refresh plain DispatcherServlets.To use it first download Spring Loadedhttps://github.com/spring-projects/spring-loadedThen add it using JVM arguments, for instance:{noformat}-javaagent:/Users/user/Downloads/springloaded-1.2.3.RELEASE.jar-noverify-Xmx512m-XX:MaxPermSize=128M-DBlossomSpringLoadedPlugin.refreshOnAnyChange=true-DBlossomSpringLoadedPlugin.refreshAllDispatcherServlets=true{noformat}Then add the plugin JAR to your project:{code:xml}  info.magnolia .blossom   blossom-spring-loaded  1.0 -SNAPSHOT .1 {code}Spring Loaded 1.2.3 can't reload classes packaged in JAR files. This is coming in the next release, 1.2.4. In the mean time you can change your IDE to package classes into the WEB-INF/classes directory instead of making a JAR file in WEB-INF/lib. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For 

[magnolia-dev] [JIRA] (BLOSSOM-210) Spring Loaded plugin for Blossom development

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-210 
 
 
 
  Spring Loaded plugin for Blossom development  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Component/s:
 
 blossom-spring-loaded 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-211) Group id of blossom-spring-loaded should be info.magnolia.blossom

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-211 
 
 
 
  Group id of blossom-spring-loaded should be info.magnolia.blossom  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Component/s:
 
 blossom-spring-loaded 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-211) Group id of blossom-spring-loaded should be info.magnolia.blossom

2015-06-05 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-211 
 
 
 
  Group id of blossom-spring-loaded should be info.magnolia.blossom  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 05/Jun/15 9:37 AM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-210) Spring Loaded plugin for Blossom development

2015-05-29 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-210 
 
 
 
  Spring Loaded plugin for Blossom development  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Plugin for Spring Loaded that refreshes the application contexts of BlossomDispatcherServlets when a class annotated with @Controller or a type level Blossom annotation is reloaded.The behavior can be customized using these two system properties:*BlossomSpringLoadedPlugin.refreshOnAnyChange* will make the plugin refresh when any class is changed, not just those with Blossom annotations or the @Controller annotation.*BlossomSpringLoadedPlugin.refreshAllDispatcherServlets* will make the plugin also refresh plain DispatcherServlets.To use it first download Spring Loaded https://github.com/spring-projects/spring-loaded   Then add it using JVM arguments, for instance:{noformat}-javaagent:/Users/user/Downloads/springloaded-1.2.3.RELEASE.jar-noverify-Xmx512m-XX:MaxPermSize=128M-DBlossomSpringLoadedPlugin.refreshOnAnyChange=true-DBlossomSpringLoadedPlugin.refreshAllDispatcherServlets=true{noformat}Then add the plugin JAR to your project:{code:xml}  info.magnolia  blossom-spring-loaded  1.0-SNAPSHOT{code}Spring Loaded 1.2.3 can't reload classes packaged in JAR files. This is coming in the next release, 1.2.4. In the mean time you can change your IDE to package classes into the WEB-INF/classes directory instead of making a JAR file in WEB-INF/lib. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list detail

[magnolia-dev] [JIRA] (BLOSSOM-210) Spring Loaded plugin for Blossom development

2015-05-29 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-210 
 
 
 
  Spring Loaded plugin for Blossom development  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Plugin for Spring Loaded that refreshes the application contexts of BlossomDispatcherServlets when a class annotated with @Controller or a type level Blossom annotation is reloaded.The behavior can be customized using these two system properties:*BlossomSpringLoadedPlugin.refreshOnAnyChange* will make the plugin refresh when any class is changed, not just those with Blossom annotations or the @Controller annotation.*BlossomSpringLoadedPlugin.refreshAllDispatcherServlets* will make the plugin also refresh plain DispatcherServlets.To use it first download Spring LoadedThen add it using JVM arguments, for instance:{noformat}-javaagent:/Users/user/Downloads/springloaded-1.2.3.RELEASE.jar-noverify-Xmx512m-XX:MaxPermSize=128M-DBlossomSpringLoadedPlugin.refreshOnAnyChange=true-DBlossomSpringLoadedPlugin.refreshAllDispatcherServlets=true{noformat}Then add the plugin JAR to your project:{code:xml}  info.magnolia  blossom-spring-loaded  1.0-SNAPSHOT{code}Spring Loaded 1.2.3 can't reload classes packaged in JAR files. This is coming in the next release, 1.2.4. In the mean time you can change your IDE to package classes into the WEB-INF/classes directory instead of making a JAR file in WEB-INF/lib. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailin

[magnolia-dev] [JIRA] (BLOSSOM-197) Page Edit does not work after reload of Template with JRebel

2015-05-29 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-197 
 
 
 
  Page Edit does not work after reload of Template with JRebel  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 I'm currently trying to figure out a way to make jrebel reconfigure the blossom template definitions on a pagecontroller class reload.Trying to to that I came across a different problem, and I am not so sure if it is related to blossom at all. So please move it, if you thnk its not related to blossom.Start Mgnl/Blossom with current jrebel.Open a page template, add a componentReload Page Template with Jrebel Add another component ->  {noformat} info.magnolia.ui.api.action.ActionExecutionException: Action execution failed for action: addComponent at info.magnolia.ui.api.action.AbstractActionExecutor.execute(AbstractActionExecutor.java:64) at info.magnolia.pages.app.editor.PageEditorPresenter.onAction(PageEditorPresenter.java:127) at info.magnolia.ui.vaadin.editor.PageEditor$1.newComponent(PageEditor.java:78) at sun.reflect.GeneratedMethodAccessor1239.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Method.java:483) at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:168) at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:118) at com.vaadin.server.communication.ServerRpcHandler.handleBurst(ServerRpcHandler.java:214) at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:111) at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:91) at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:37) at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1371) at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:238) at info.magnolia.ui.admincentral.AdmincentralVaadinServlet.service(AdmincentralVaadinServlet.java:132) at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) at info.magnolia.cms.filters.ServletDispatchingFilter.doFilter(ServletDispatchingFilter.java:148) at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:82) at info.magnolia.cms.filters.CompositeFilter.doFilter(CompositeFilter.java:65) at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80) at info.magnolia.cms.filters.VirtualUriFilter.doFilter(VirtualUriFilter.java:68) at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:89) at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:80) at info.magnolia.module.cache.executor.Bypass.processCacheRequest(Bypass.java:58) at info.magnolia.module.cache.executor.CompositeExecutor.processCacheRequest(CompositeExecutor.java:66) at info

[magnolia-dev] [JIRA] (BLOSSOM-210) Spring Loaded plugin for Blossom development

2015-05-29 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-210 
 
 
 
  Spring Loaded plugin for Blossom development  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  New Feature 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 29/May/15 11:32 AM 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-209) BlossomDispatcherServlet should send BlossomDispatcherInitializedEvent on ApplicationContext refresh

2015-05-24 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-209 
 
 
 
  BlossomDispatcherServlet should send BlossomDispatcherInitializedEvent on ApplicationContext refresh  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 24/May/15 6:38 PM 
 
 
 

Fix Versions:
 

 3.0.7 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
After a refresh beans have been reinitialized and when running JRebel, Spring Loaded etc, they can have changes in annotations, methods added and so on. 
Since BlossomDispatcherInitializedEvent is only sent on startup these are not detected. 
Although, I'm not sure that JRebel does a refresh and Spring Loaded does not. But there are plugins for SL that does. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 

[magnolia-dev] [JIRA] (BLOSSOM-208) Permissions on components have no effect

2015-05-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-208 
 
 
 
  Permissions on components have no effect  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Permissions set on areas to control use of components within them have no effect on blossom components. This is caused by MAGNOLIA-6216 and should be fixed there.Blossom sets the name of templates to be the same as their ids. Which should be fine except the page editor incorrectly uses the name instead of the id.Blossom should try to set the name identically to how Content2Bean does just to be safe and circumvent this bug until its been fixed.These workarounds works in current and previous versions of Blossom.h5. Workaround using Java config{code:java}@Beanpublic TemplateExporter templateExporter() {TemplateExporter templateExporter = new TemplateExporter();templateExporter.setTemplateDefinitionBuilder( new TemplateDefinitionBuilder() {@Overridepublic BlossomTemplateDefinition buildTemplateDefinition(BlossomDispatcher dispatcher, DetectedHandlersMetaData detectedHandlers, HandlerMetaData template) {BlossomTemplateDefinition definition = super.buildTemplateDefinition(dispatcher, detectedHandlers, template);definition.setName(StringUtils.substringAfterLast(definition.getId(), "/"));return definition;}});return templateExporter;}{code}h5. Workaround using XML config{code:xml}{code} {code:java}package info.magnolia.blossom.sample.module;import info.magnolia.module.blossom.dispatcher.BlossomDispatcher;import info.magnolia.module.blossom.template.BlossomTemplateDefinition;import info.magnolia.module.blossom.template.DetectedHandlersMetaData;import info.magnolia.module.blossom.template.HandlerMetaData;import info.magnolia.module.blossom.template.TemplateDefinitionBuilder;import org.apache.commons.lang.StringUtils;public class CustomTemplateDefinitionBuilder extends TemplateDefinitionBuilder {@Overridepublic BlossomTemplateDefinition buildTemplateDefinition(BlossomDispatcher dispatcher, DetectedHandlersMetaData detectedHandlers, HandlerMetaData template) {BlossomTemplateDefinition definition = super.buildTemplateDefinition(dispatcher, detectedHandlers, template);definition.setName(StringUtils.substringAfterLast(definition.getId(), "/"));return definition;}}{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 

[magnolia-dev] [JIRA] (BLOSSOM-208) Permissions on components have no effect

2015-05-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-208 
 
 
 
  Permissions on components have no effect  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Permissions set on areas to control use of components within them have no effect on blossom components. This is caused by MAGNOLIA-6216 and should be fixed there.Blossom sets the name of templates to be the same as their ids. Which should be fine except the page editor incorrectly uses the name instead of the id.Blossom should try to set the name identically to how Content2Bean does just to be safe and circumvent this bug until its been fixed. These workarounds works in current and previous versions of Blossom.h5. Workaround using Java config{code:java}@Beanpublic TemplateExporter templateExporter() {TemplateExporter templateExporter = new TemplateExporter();templateExporter.setTemplateDefinitionBuilder( new TemplateDefinitionBuilder() {@Overridepublic BlossomTemplateDefinition buildTemplateDefinition(BlossomDispatcher dispatcher, DetectedHandlersMetaData detectedHandlers, HandlerMetaData template) {BlossomTemplateDefinition definition = super.buildTemplateDefinition(dispatcher, detectedHandlers, template);definition.setName(StringUtils.substringAfterLast(definition.getId(), "/"));return definition;}});return templateExporter;}{code}h5. Workaround using XML config{code:xml}{code} 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list detai

[magnolia-dev] [JIRA] (BLOSSOM-208) Permissions on components have no effect

2015-05-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-208 
 
 
 
  Permissions on components have no effect  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 Permissions set on areas to control use of components within them have no effect on blossom components. This is caused by MAGNOLIA-6216 and should be fixed there.Blossom sets the name of templates to be the same as their ids. Which should be fine except the page editor incorrectly uses the name instead of the id.Blossom should try to set the name identically to how Content2Bean does just to be safe and circumvent this bug until its been fixed. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-208) Permissions on components have no effect

2015-05-22 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-208 
 
 
 
  Permissions on components have no effect  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 3.0.6 
 
 
 

Assignee:
 
 Tobias Mattsson 
 
 
 

Created:
 

 22/May/15 4:31 PM 
 
 
 

Fix Versions:
 

 3.0.7 
 
 
 

Priority:
 
  Neutral 
 
 
 

Reporter:
 
 Tobias Mattsson 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.1#64016-sha1:5d75814) 
 
 
 
 

[magnolia-dev] [JIRA] (BLOSSOM-202) Customize tab sorting

2015-03-06 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-202 
 
 
 
  Customize tab sorting  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Issue Type:
 
 Bug Improvement 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 




[magnolia-dev] [JIRA] (BLOSSOM-202) Customize tab sorting

2015-03-06 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-202 
 
 
 
  Customize tab sorting  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 Tab order does not work Customize tab sorting 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 




[magnolia-dev] [JIRA] (BLOSSOM-205) Upgrade sample to Magnolia 5.3.7 and Spring 4.1.5 and organize templates in packages

2015-03-06 Thread JIRA (on behalf of Tobias Mattsson)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Mattsson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Magnolia Blossom Module /  BLOSSOM-205 
 
 
 
  Upgrade sample to Magnolia 5.3.7 and Spring 4.1.5 and organize templates in packages  
 
 
 
 
 
 
 
 
 

Change By:
 
 Tobias Mattsson 
 
 
 

Summary:
 
 Upgrade sample to Magnolia 5.3.7 and Spring 4.1. 4 5  and organize templates in packages 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   




Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 




[magnolia-dev] [JIRA] (MGNLUI-3365) Checkbox requires setting buttonLabel to blank to show field label

2015-03-02 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 updated  MGNLUI-3365


Checkbox requires setting buttonLabel to blank to show field label
















Change By:


Tobias Mattsson
(02/Mar/15 9:28 PM)




Attachment:


capture.png



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (MGNLUI-3365) Checkbox requires setting buttonLabel to blank to show field label

2015-03-02 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 created  MGNLUI-3365


Checkbox requires setting buttonLabel to blank to show field label















Issue Type:


Bug



Affects Versions:


5.3.7



Assignee:


Unassigned


Attachments:


capture.png



Components:


dialogs, forms



Created:


02/Mar/15 9:27 PM



Description:


Unless you set buttonLabel to blank Magnolia will show a message key as label. See the attached image.

I believe this was introduced with @I18nText.




Project:


Magnolia UI



Priority:


Neutral




Reporter:


Tobias Mattsson



Security Level:


Public 




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-202) Tab order does not work

2015-02-27 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 updated  BLOSSOM-202


Tab order does not work
















Change By:


Tobias Mattsson
(27/Feb/15 9:47 AM)




Fix Version/s:


2.0.8



























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-205) Upgrade sample to Magnolia 5.3.7 and Spring 4.1.4 and organize templates in packages

2015-02-20 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 created  BLOSSOM-205


Upgrade sample to Magnolia 5.3.7 and Spring 4.1.4 and organize templates in packages















Issue Type:


Improvement



Assignee:


Tobias Mattsson



Created:


20/Feb/15 5:46 PM



Fix Versions:


3.0.6



Project:


Magnolia Blossom Module



Priority:


Neutral




Reporter:


Tobias Mattsson




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (ARCH-42) Update Blossom archetype to use Spring java config

2015-02-20 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 created  ARCH-42


Update Blossom archetype to use Spring java config















Issue Type:


Improvement



Assignee:


Tobias Mattsson



Created:


20/Feb/15 5:17 PM



Fix Versions:


1.2.1



Project:


Magnolia Maven Archetypes



Priority:


Neutral




Reporter:


Tobias Mattsson




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-203) Enhancements for spring java config

2015-02-20 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 created  BLOSSOM-203


Enhancements for spring java config















Issue Type:


Improvement



Assignee:


Tobias Mattsson



Created:


20/Feb/15 11:32 AM



Description:



	BlossomModuleSupport should have init methods that takes classes for config
	BlossomHandlerMapping should implement Ordered interface
	View renderers should have method for registering context attribute with a single line of code






Fix Versions:


3.0.6



Project:


Magnolia Blossom Module



Priority:


Neutral




Reporter:


Tobias Mattsson




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-204) Use spring java config in sample module

2015-02-20 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 created  BLOSSOM-204


Use spring java config in sample module















Issue Type:


Improvement



Assignee:


Tobias Mattsson



Created:


20/Feb/15 11:32 AM



Fix Versions:


3.0.6



Project:


Magnolia Blossom Module



Priority:


Neutral




Reporter:


Tobias Mattsson




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-200) User and MgnlUser should be available as arguments for @DialogFactory @TabFactory and @PostCreate methods

2015-02-13 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 deleted  BLOSSOM-200


User and MgnlUser should be available as arguments for @DialogFactory @TabFactory and @PostCreate methods
























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-201) Provide support for additional arguments in dialog construction callbacks

2015-02-13 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 created  BLOSSOM-201


Provide support for additional arguments in dialog construction callbacks















Issue Type:


Improvement



Assignee:


Tobias Mattsson



Created:


13/Feb/15 3:40 PM



Description:


Callbacks using @TabFactory @DialogFactory and @PostCreate should all be able to use the same base set of arguments.


	ConfiguredFormDialogDefinition and its interfaces and super classes
	DialogCreationContext
	UiConfig and DamConfig
	Node and Item
	WebContext and Context
	MgnlUser and User



Callbacks for @Available should also have more argument candidates.


	WebContext and Context
	MgnlUser and User






Fix Versions:


3.0.6



Project:


Magnolia Blossom Module



Priority:


Neutral




Reporter:


Tobias Mattsson




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





[magnolia-dev] [JIRA] (BLOSSOM-200) User and MgnlUser should be available as arguments for @DialogFactory @TabFactory and @PostCreate methods

2015-01-30 Thread JIRA (on behalf of Tobias Mattsson)














































Tobias Mattsson
 created  BLOSSOM-200


User and MgnlUser should be available as arguments for @DialogFactory @TabFactory and @PostCreate methods















Issue Type:


Improvement



Assignee:


Tobias Mattsson



Created:


30/Jan/15 6:27 PM



Fix Versions:


3.0.6



Project:


Magnolia Blossom Module



Priority:


Neutral




Reporter:


Tobias Mattsson




























This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira








For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 





  1   2   3   4   5   6   7   8   9   10   >