[magnolia-dev] [JIRA] Issue Comment Edited: (MGNLSTK-623) Review all places where links are generated in STK
[
http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28562#action_28562
]
Jan Haderka edited comment on MGNLSTK-623 at 6/3/10 4:11 PM:
-
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:red}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink() is not site aware!{color}
{color:red}mgnl.createLink => LinkUtil.createAbsoluteLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:red}calendar.model.getEventLink => LinkUtil.createAbsoluteLink(){color}
{color:red}calendar.model.getDateEventLink =>
LinkUtil.createAbsoluteLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects links
to end with .html!!{color}
searchResult.item.link => mgnl.createLink()
searchResult.model.searchPageLink => STKTemplateModel.getSearchPageLink()
STKTemplateModel.getSearchPageLink() => mgnl.createLink()
image.link=>STK.getAsset().getLink()
downloadLink.model.link => mgnl.createLink()
externalLink.model.link => STKUtil.getExternalLink()
internalLink.model.link => mgnl.createLink()
pagination.pager.getPageLink() => parses current page link
AbstractItemListModel.pager => mgnl.createLink
{color:red}CategoryOverviewModel.pager => manually combine link from context
path and currentURI{color}
stageXL.model.teaserLink => AbstractTeaserModel.teaserLink
AbstractTeaserModel.teaserLink => mgnl.createLink()
stageXL.model.image.link => ImageModel.image => stk.getImageLink()
carouselItem.teaserLink => AbstractTeaserModel.teaserLink
downloadFile.model.teaserLink => AbstractTeaserModel.teaserLink
eventList.model.allEventsLink => mgnl.createLink()
externalPage.model.teaserLink => stk.externalLink()
fingerTabbedItem.model.teaserLink => AbstractTeaserModel.teaserLink
internalPage.model.teaserLink => AbstractTeaserModel.teaserLink
newsList.model.allNewsLink => mgnl.createLink()
stkTeaserSingleFeed.item.link => link from the feed
{color:blue}syndicate.model.link=>manually assemble virtual URI, which is OK
since the Virtual URI will be the same no matter which site and domain is
used.{color}
infoblock.model.externalLink => mgnl.createLink()
branding.model.logoImageLink => stk.assetLink
branding.model.printLogoImageLink => stk.assetLink
branding.model.searchPageLink => mgnl.createLink()
branding.model.homeLink => mgnl.createLink()
htmlHeader.cssFile.link => Resource.getLink()
htmlHeader.jsFile.link => Resource.getLink()
{color:red}Resource.getLink() => manually combine context path with
stk-resources prefix with site name and link{color}
mainAreaIntro.model.getCategoryLink => CategorizationSupport.categoryLink
CategorizationSupport.categoryLink => CategoryUtil.categoryLink
{color:red}CategoryUtil.categoryLink => manualy combine context path and handle
to category with name{color}
mainAreaIntro.imageModel.image.link => imaging.createLink()
@cms.links => manually assembles path from context and path to the script
{panel}
Items in read are either questionable or wrong.
In general most of the links (those in black) end up using
{{MagnoliaTemplatingUtils.createLink}} method that will create absolute link
which might not be correct in the multisite setup. However those can be
replaced by changing the output of {{LinkTransformerManager.getAbsolute()}} and
therefore can be customized to suit the special setups.
was (Author: had):
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:red}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink() is not site aware!{color}
{color:red}mgnl.createLink => LinkUtil.createAbsoluteLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:red}calendar.model.getEventLink => LinkUtil.createAbsoluteLink(){color}
{color:red}calendar.model.getDateEventLink =>
LinkUtil.createAbsoluteLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects links
to end with .html!!{color}
searchResult.item.link =>
[magnolia-dev] [JIRA] Issue Comment Edited: (MGNLSTK-623) Review all places where links are generated in STK
[
http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28562#action_28562
]
Jan Haderka edited comment on MGNLSTK-623 at 6/4/10 8:57 AM:
-
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:red}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink() is not site aware!{color}
{color:red}mgnl.createLink => LinkUtil.createAbsoluteLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:blue}calendar.model.getEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
{color:blue}calendar.model.getDateEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects links
to end with .html!!{color}
searchResult.item.link => mgnl.createLink()
searchResult.model.searchPageLink => STKTemplateModel.getSearchPageLink()
STKTemplateModel.getSearchPageLink() => mgnl.createLink()
image.link=>STK.getAsset().getLink()
downloadLink.model.link => mgnl.createLink()
externalLink.model.link => STKUtil.getExternalLink()
internalLink.model.link => mgnl.createLink()
pagination.pager.getPageLink() => parses current page link
AbstractItemListModel.pager => mgnl.createLink
{color:red}CategoryOverviewModel.pager => manually combine link from context
path and currentURI{color}
stageXL.model.teaserLink => AbstractTeaserModel.teaserLink
AbstractTeaserModel.teaserLink => mgnl.createLink()
stageXL.model.image.link => ImageModel.image => stk.getImageLink()
carouselItem.teaserLink => AbstractTeaserModel.teaserLink
downloadFile.model.teaserLink => AbstractTeaserModel.teaserLink
eventList.model.allEventsLink => mgnl.createLink()
externalPage.model.teaserLink => stk.externalLink()
fingerTabbedItem.model.teaserLink => AbstractTeaserModel.teaserLink
internalPage.model.teaserLink => AbstractTeaserModel.teaserLink
newsList.model.allNewsLink => mgnl.createLink()
stkTeaserSingleFeed.item.link => link from the feed
{color:blue}syndicate.model.link=>manually assemble virtual URI, which is OK
since the Virtual URI will be the same no matter which site and domain is
used.{color}
infoblock.model.externalLink => mgnl.createLink()
branding.model.logoImageLink => stk.assetLink
branding.model.printLogoImageLink => stk.assetLink
branding.model.searchPageLink => mgnl.createLink()
branding.model.homeLink => mgnl.createLink()
htmlHeader.cssFile.link => Resource.getLink()
htmlHeader.jsFile.link => Resource.getLink()
{color:red}Resource.getLink() => manually combine context path with
stk-resources prefix with site name and link{color}
mainAreaIntro.model.getCategoryLink => CategorizationSupport.categoryLink
CategorizationSupport.categoryLink => CategoryUtil.categoryLink
{color:red}CategoryUtil.categoryLink => manualy combine context path and handle
to category with name{color}
mainAreaIntro.imageModel.image.link => imaging.createLink()
@cms.links => manually assembles path from context and path to the script
{panel}
Items in read are either questionable or wrong.
In general most of the links (those in black) end up using
{{MagnoliaTemplatingUtils.createLink}} method that will create absolute link
which might not be correct in the multisite setup. However those can be
replaced by changing the output of {{LinkTransformerManager.getAbsolute()}} and
therefore can be customized to suit the special setups.
was (Author: had):
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:red}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink() is not site aware!{color}
{color:red}mgnl.createLink => LinkUtil.createAbsoluteLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:red}calendar.model.getEventLink => LinkUtil.createAbsoluteLink(){color}
{color:red}calendar.model.getDateEventLink =>
LinkUtil.createAbsoluteLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects links
to end wit
[magnolia-dev] [JIRA] Issue Comment Edited: (MGNLSTK-623) Review all places where links are generated in STK
[
http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28562#action_28562
]
Jan Haderka edited comment on MGNLSTK-623 at 6/4/10 9:24 AM:
-
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:blue}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink(){color}
{color:blue}mgnl.createLink => LinkUtil.createLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:blue}calendar.model.getEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
{color:blue}calendar.model.getDateEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects links
to end with .html!!{color}
searchResult.item.link => mgnl.createLink()
searchResult.model.searchPageLink => STKTemplateModel.getSearchPageLink()
STKTemplateModel.getSearchPageLink() => mgnl.createLink()
image.link=>STK.getAsset().getLink()
downloadLink.model.link => mgnl.createLink()
externalLink.model.link => STKUtil.getExternalLink()
internalLink.model.link => mgnl.createLink()
pagination.pager.getPageLink() => parses current page link
AbstractItemListModel.pager => mgnl.createLink
{color:red}CategoryOverviewModel.pager => manually combine link from context
path and currentURI{color}
stageXL.model.teaserLink => AbstractTeaserModel.teaserLink
AbstractTeaserModel.teaserLink => mgnl.createLink()
stageXL.model.image.link => ImageModel.image => stk.getImageLink()
carouselItem.teaserLink => AbstractTeaserModel.teaserLink
downloadFile.model.teaserLink => AbstractTeaserModel.teaserLink
eventList.model.allEventsLink => mgnl.createLink()
externalPage.model.teaserLink => stk.externalLink()
fingerTabbedItem.model.teaserLink => AbstractTeaserModel.teaserLink
internalPage.model.teaserLink => AbstractTeaserModel.teaserLink
newsList.model.allNewsLink => mgnl.createLink()
stkTeaserSingleFeed.item.link => link from the feed
{color:blue}syndicate.model.link=>manually assemble virtual URI, which is OK
since the Virtual URI will be the same no matter which site and domain is
used.{color}
infoblock.model.externalLink => mgnl.createLink()
branding.model.logoImageLink => stk.assetLink
branding.model.printLogoImageLink => stk.assetLink
branding.model.searchPageLink => mgnl.createLink()
branding.model.homeLink => mgnl.createLink()
htmlHeader.cssFile.link => Resource.getLink()
htmlHeader.jsFile.link => Resource.getLink()
{color:red}Resource.getLink() => manually combine context path with
stk-resources prefix with site name and link{color}
mainAreaIntro.model.getCategoryLink => CategorizationSupport.categoryLink
CategorizationSupport.categoryLink => CategoryUtil.categoryLink
{color:red}CategoryUtil.categoryLink => manualy combine context path and handle
to category with name{color}
mainAreaIntro.imageModel.image.link => imaging.createLink()
@cms.links => manually assembles path from context and path to the script
{panel}
Items in read are either questionable or wrong.
In general most of the links (those in black) end up using
{{MagnoliaTemplatingUtils.createLink}} method that will create absolute link
which might not be correct in the multisite setup. However those can be
replaced by changing the output of {{LinkTransformerManager.getAbsolute()}} and
therefore can be customized to suit the special setups.
was (Author: had):
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:red}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink() is not site aware!{color}
{color:red}mgnl.createLink => LinkUtil.createAbsoluteLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:blue}calendar.model.getEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
{color:blue}calendar.model.getDateEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects
[magnolia-dev] [JIRA] Issue Comment Edited: (MGNLSTK-623) Review all places where links are generated in STK
[
http://jira.magnolia-cms.com/browse/MGNLSTK-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=28562#action_28562
]
Jan Haderka edited comment on MGNLSTK-623 at 6/4/10 9:26 AM:
-
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:blue}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink(){color}
{color:blue}mgnl.createLink => LinkUtil.createLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:blue}calendar.model.getEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
{color:blue}calendar.model.getDateEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects links
to end with .html!!{color}
searchResult.item.link => mgnl.createLink()
searchResult.model.searchPageLink => STKTemplateModel.getSearchPageLink()
STKTemplateModel.getSearchPageLink() => mgnl.createLink()
image.link=>STK.getAsset().getLink()
downloadLink.model.link => mgnl.createLink()
externalLink.model.link => STKUtil.getExternalLink()
internalLink.model.link => mgnl.createLink()
pagination.pager.getPageLink() => parses current page link
AbstractItemListModel.pager => mgnl.createLink
{color:red}CategoryOverviewModel.pager => manually combine link from context
path and currentURI{color}
stageXL.model.teaserLink => AbstractTeaserModel.teaserLink
AbstractTeaserModel.teaserLink => mgnl.createLink()
stageXL.model.image.link => ImageModel.image => stk.getImageLink()
carouselItem.teaserLink => AbstractTeaserModel.teaserLink
downloadFile.model.teaserLink => AbstractTeaserModel.teaserLink
eventList.model.allEventsLink => mgnl.createLink()
externalPage.model.teaserLink => stk.externalLink()
fingerTabbedItem.model.teaserLink => AbstractTeaserModel.teaserLink
internalPage.model.teaserLink => AbstractTeaserModel.teaserLink
newsList.model.allNewsLink => mgnl.createLink()
stkTeaserSingleFeed.item.link => link from the feed
{color:blue}syndicate.model.link=>manually assemble virtual URI, which is OK
since the Virtual URI will be the same no matter which site and domain is
used.{color}
infoblock.model.externalLink => mgnl.createLink()
branding.model.logoImageLink => stk.assetLink
branding.model.printLogoImageLink => stk.assetLink
branding.model.searchPageLink => mgnl.createLink()
branding.model.homeLink => mgnl.createLink()
htmlHeader.cssFile.link => Resource.getLink()
htmlHeader.jsFile.link => Resource.getLink()
{color:red}Resource.getLink() => manually combine context path with
stk-resources prefix with site name and link{color}
mainAreaIntro.model.getCategoryLink => CategorizationSupport.categoryLink
CategorizationSupport.categoryLink => CategoryUtil.categoryLink
{color:red}CategoryUtil.categoryLink => manualy combine context path and handle
to category with name{color}
mainAreaIntro.imageModel.image.link => imaging.createLink()
@cms.links => manually assembles path from context and path to the script
{panel}
Items in read are either questionable or wrong.
was (Author: had):
Reviewed all templates and associated models. Reviewed items listed below.
{panel}
stk.getAssetLink() => mgnl.createLink() || imaging.createLink()
stk.getImageLink() => mgnl.createLink() || imaging.createLink()
stk.getAssetVariation.link => variation.createLink()
imaging.createLink => mgnl.createLink() || variation.createLink()
{color:blue}variation.createLink => VariationImpl,
ImageOperationProvidingVariation .createLink(){color}
{color:blue}mgnl.createLink => LinkUtil.createLink(){color}
flash.model.link => stk.getAssetLink
calendar.item.link => model.eventLink || model.dateEventLink
{color:blue}calendar.model.getEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
{color:blue}calendar.model.getDateEventLink => -LinkUtil.createAbsoluteLink()-
mgnl.createLink(){color}
eventOverview.model.prevLink => eventOverview.model.link.href
eventOverview.model.nextLink => eventOverview.model.link.href
{color:red}eventOverview.model.link.href => mgnl.createLink() !! expects links
to end with .html!!{color}
searchResult.item.link => mgnl.createLink()
searchResult.model.searchPageLink => STKTemplateModel.getSearchPageLink()
STKTemplateModel.getSearchPageLink() => mgnl.createLink()
image.link=>STK.getAsset().getLink()
downloadLink.model.link => mgnl.createLink()
externalLink.model.link => STKUtil.getExternalLink()
internalLink.model.lin
