[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3194) css: rect() needs comma-separated value
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grégory Joseph updated MAGNOLIA-3194:
-
Comment: was deleted
(was: Integrated in
!http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif!
[magnolia_main-trunk
#1597|http://hudson.magnolia-cms.com/job/magnolia_main-trunk/1597/]
MAGNOLIA-3194 css clip:rect() values have to be comma-separated
)
> css: rect() needs comma-separated value
> ---
>
> Key: MAGNOLIA-3194
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3194
> Project: Magnolia
> Issue Type: Bug
> Components: admininterface, gui, integration tests
>Reporter: Grégory Joseph
>Assignee: Philipp Bärfuss
> Fix For: 4.3.x
>
> Attachments: clip-rect-comma.patch, enablecss_in_tests.patch
>
>
> While browsers seem to be happy about the following css snippet:
> {code}
> clip: rect(0 0 100px 0);
> {code}
> .. the cssparser used by HtmlUnit isn't; it's following the spec a little
> closer, and enforce those values to be comma separated.
> This would be the correct syntax
> {code}
> clip:rect(0, 0, 100px, 0);
> {code}
> Attached is a patch that fixes the issue for magnolia-gui and
> m-m-admininterface. (hoping there are no other places where this property is
> set that weren't found with {{find . ! -path "*/target/*" ! -name "*.java" !
> -path "*/.svn/*" -exec grep -H rect\( {} \;}})
> Additional patch updates the version of HtmlUnit used in integration tests to
> 2.7, enables css parsing, and consequently fixes the issues we've had with
> integration tests since MAGNOLIA-3180 (MAGNOLIA-3180 did not break anything
> per se, since the tests were not checking the rendered results; the real
> issue is that we were disabling css in those tests, thus preventing the tree
> javascript to do its job; now that HtmlUnit supports css @import, we were
> able to enable css parsing)
> http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-Rect
> http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#value-def-shape
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3194) css: rect() needs comma-separated value
[
http://jira.magnolia-cms.com/browse/MAGNOLIA-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Haderka updated MAGNOLIA-3194:
--
Fix Version/s: 4.3.x
(was: 4.3.2)
> css: rect() needs comma-separated value
> ---
>
> Key: MAGNOLIA-3194
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3194
> Project: Magnolia
> Issue Type: Bug
> Components: admininterface, gui, integration tests
>Reporter: Grégory Joseph
>Assignee: Philipp Bärfuss
> Fix For: 4.3.x
>
> Attachments: clip-rect-comma.patch, enablecss_in_tests.patch
>
>
> While browsers seem to be happy about the following css snippet:
> {code}
> clip: rect(0 0 100px 0);
> {code}
> .. the cssparser used by HtmlUnit isn't; it's following the spec a little
> closer, and enforce those values to be comma separated.
> This would be the correct syntax
> {code}
> clip:rect(0, 0, 100px, 0);
> {code}
> Attached is a patch that fixes the issue for magnolia-gui and
> m-m-admininterface. (hoping there are no other places where this property is
> set that weren't found with {{find . ! -path "*/target/*" ! -name "*.java" !
> -path "*/.svn/*" -exec grep -H rect\( {} \;}})
> Additional patch updates the version of HtmlUnit used in integration tests to
> 2.7, enables css parsing, and consequently fixes the issues we've had with
> integration tests since MAGNOLIA-3180 (MAGNOLIA-3180 did not break anything
> per se, since the tests were not checking the rendered results; the real
> issue is that we were disabling css in those tests, thus preventing the tree
> javascript to do its job; now that HtmlUnit supports css @import, we were
> able to enable css parsing)
> http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-Rect
> http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#value-def-shape
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to:
