[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3204) aggregation state looses all information on forwards
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Haderka updated MAGNOLIA-3204: -- Fix Version/s: 4.3.x (was: 4.3.2) aggregation state looses all information on forwards Key: MAGNOLIA-3204 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3204 Project: Magnolia Issue Type: Bug Affects Versions: 4.3.1 Reporter: Philipp Bärfuss Assignee: Philipp Bärfuss Priority: Critical Fix For: 4.3.x Attachments: MAGNOLIA-3204.patch h4. The Problem The aggregation state is set to null on each forward. This is problematic as we also store the locale and site in the aggregation state. As a consequence all this information is lost after a virtual uri mapping which forwards. Example: # request to /de/page/param.html #- locale is set to de #- current uri is /page/param.html # virtual uri mapping #- forward to /page.html?param # re-execution #- ContentTypeFilter resets the aggregation state #- locale is now the default locale:en h4. Solution We could simply not reset the aggregation state but this conflicts with MAGNOLIA-3203 (resetting original URI on forward). So we can either fix MAGNOLIA-3203 or reset the aggregation state partially. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com
[magnolia-dev] [JIRA] Updated: (MAGNOLIA-3204) aggregation state looses all information on forwards
[ http://jira.magnolia-cms.com/browse/MAGNOLIA-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Bärfuss updated MAGNOLIA-3204: -- Attachment: MAGNOLIA-3204.patch Attached a solution having the least amount of impact: - set the original uri (even if this is wrong) - only reset the original uri - keep all other values aggregation state looses all information on forwards Key: MAGNOLIA-3204 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3204 Project: Magnolia Issue Type: Bug Affects Versions: 4.3.1 Reporter: Philipp Bärfuss Assignee: Boris Kraft Priority: Critical Fix For: 4.3.x Attachments: MAGNOLIA-3204.patch h4. The Problem The aggregation state is set to null on each forward. This is problematic as we also store the locale and site in the aggregation state. As a consequence all this information is lost after a virtual uri mapping which forwards. Example: # request to /de/page/param.html #- locale is set to de #- current uri is /page/param.html # virtual uri mapping #- forward to /page.html?param # re-execution #- ContentTypeFilter resets the aggregation state #- locale is now the default locale:en h4. Solution We could simply not reset the aggregation state but this conflicts with MAGNOLIA-3203 (resetting original URI on forward). So we can either fix MAGNOLIA-3203 or reset the aggregation state partially. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: dev-list-unsubscr...@magnolia-cms.com