Re: Announcing new test platform "Android 7.0 x86"
On 2018-11-01 3:06 PM, Nicholas Alexander wrote:
Like the existing "Android 4.2" and "Android 4.3" test platforms, these
tests run in an Android emulator running in a docker container (the same
Ubuntu-based image used for linux64 tests). The new platform runs an x86
emulator using kvm acceleration, enabling tests to run much, much faster
than on the older platforms. As a bonus, the new platform uses Android 7.0
("Nougat", API 24) - more modern, more relevant.
This is incredibly awesome news! For those not in the know, the reason
this is so noteworthy is that most cloud-based hosts don't expose KVM
acceleration, since it can be a sec concern. In particular, AWS doesn't
expose KVM to most (all?) instances. There's an awful lot of plumbing
required to get jobs running in different cloud hosts... but here we are.
Our Android test coverage has been sparse in the past because slow ARM
emulators and devices were a bottleneck. Being able to run Android tests
on x86 at "desktop speed" means we can greatly improve our test coverage
on Android!
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
Re: Announcing new test platform "Android 7.0 x86"
On Thu, Nov 1, 2018 at 2:44 PM Geoffrey Brown wrote:
> This week some familiar tier 1 test suites began running on a new test
> platform labelled "Android 7.0 x86" on treeherder. Only a few test suites
> are running so far; more are planned.
>
> Like the existing "Android 4.2" and "Android 4.3" test platforms, these
> tests run in an Android emulator running in a docker container (the same
> Ubuntu-based image used for linux64 tests). The new platform runs an x86
> emulator using kvm acceleration, enabling tests to run much, much faster
> than on the older platforms. As a bonus, the new platform uses Android 7.0
> ("Nougat", API 24) - more modern, more relevant.
>
This is incredibly awesome news! For those not in the know, the reason
this is so noteworthy is that most cloud-based hosts don't expose KVM
acceleration, since it can be a sec concern. In particular, AWS doesn't
expose KVM to most (all?) instances. There's an awful lot of plumbing
required to get jobs running in different cloud hosts... but here we are.
Bravo to everybody involved!
Nick
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
Announcing new test platform "Android 7.0 x86"
This week some familiar tier 1 test suites began running on a new test
platform labelled "Android 7.0 x86" on treeherder. Only a few test suites
are running so far; more are planned.
Like the existing "Android 4.2" and "Android 4.3" test platforms, these
tests run in an Android emulator running in a docker container (the same
Ubuntu-based image used for linux64 tests). The new platform runs an x86
emulator using kvm acceleration, enabling tests to run much, much faster
than on the older platforms. As a bonus, the new platform uses Android 7.0
("Nougat", API 24) - more modern, more relevant.
This test platform was added to support geckoview testing. Tests run in the
geckoview-based TestRunnerActivity (not Firefox for Android).
To reproduce the main elements of this test environment locally:
- build for Android x86 (mozconfig with --target=i686-linux-android)
- 'mach android-emulator' or explicitly 'mach android-emulator --version
x86-7.0'
- install the geckoview androidTest apk
- run your test command using --app to specify the geckoview test app,
something like 'mach mochitest ... --app=org.mozilla.geckoview.test'
Great thanks to the many people who have helped enable this test platform,
especially :wcosta for help with taskcluster and :jchen for investigating
test failures.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
Re: Test helper ok() will now fail if used with more than 2 arguments
Thank you for doing this! I cannot overstate how many times this has tripped me and others over in the past. Cheers, Ehsan On Thu, Nov 1, 2018 at 8:02 AM Julian Descottes wrote: > We are about to land https://bugzilla.mozilla.org/show_bug.cgi?id=1467712 > which changes the behavior of `ok()` test helpers provided by Assert.jsm, > SimpleTest.js and browser-test.js (as well as some test helpers based on > them). > > `ok()` used to accept up to four arguments: condition, name, > exception/diagnostic and stack. > After bug 1467712 lands, `ok()`will only accept the 2 first arguments and > will fail the test if more arguments are provided. > > The reason behind this change is that `ok()` was regularly used by mistake > instead of `is()`: > ok(value1, value2, "Check value1 == value2"); > // passes as long as value1 is truthy and won't detect regressions if > value1 != value2 > > We recently fixed all the incorrect uses of ok() in the code base in > https://bugzilla.mozilla.org/show_bug.cgi?id=1499096. `is()` is called > with > 3 arguments, so restricting the number of arguments for ok() will prevent > developers from making similar mistakes in the future. > > If you need the old `ok()` with 4 arguments, it has been moved to the > `record()` method and you can use it instead. > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > -- Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Intent to implement: Support Referrer Policy for
Oh, you are right, sorry that I used confusing words. After implementation, we expect they are all passed as OK, not FAIL. On Thu, Nov 1, 2018 at 12:24 PM James Graham wrote: > On 01/11/2018 11:03, Thomas Nguyen wrote: > > The link > > > https://searchfox.org/mozilla-central/search?q=script-tag%2Finsecure-protocol.keep-origin-redirect.http.html= > > is not covered all the tests. Thanks James for pointing it out. > > In fact, we have synced all script-tag tests which were added in > > > https://github.com/web-platform-tests/wpt/pull/10976/commits/78a3837eb9cc4fb1bd55f21a9823eda82694d3d2 > > The tests should provide sufficient coverage of the feature. All the > > tests are disabled now, for example: > > It looks like the tests are marked as expected: FAIL rather than > disabled, and checking treeherder I'm finding results so I think they > are indeed already running (sorry if this is a bit pedantic, I was just > making sure I understood the situation). > -- Best regards, = Thomas Nguyen IRC : tngu...@irc.mozilla.com Slack: tnguyen Email: tngu...@mozilla.com = ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Test helper ok() will now fail if used with more than 2 arguments
We are about to land https://bugzilla.mozilla.org/show_bug.cgi?id=1467712 which changes the behavior of `ok()` test helpers provided by Assert.jsm, SimpleTest.js and browser-test.js (as well as some test helpers based on them). `ok()` used to accept up to four arguments: condition, name, exception/diagnostic and stack. After bug 1467712 lands, `ok()`will only accept the 2 first arguments and will fail the test if more arguments are provided. The reason behind this change is that `ok()` was regularly used by mistake instead of `is()`: ok(value1, value2, "Check value1 == value2"); // passes as long as value1 is truthy and won't detect regressions if value1 != value2 We recently fixed all the incorrect uses of ok() in the code base in https://bugzilla.mozilla.org/show_bug.cgi?id=1499096. `is()` is called with 3 arguments, so restricting the number of arguments for ok() will prevent developers from making similar mistakes in the future. If you need the old `ok()` with 4 arguments, it has been moved to the `record()` method and you can use it instead. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Intent to implement: Support Referrer Policy for
On 01/11/2018 11:03, Thomas Nguyen wrote: The link https://searchfox.org/mozilla-central/search?q=script-tag%2Finsecure-protocol.keep-origin-redirect.http.html= is not covered all the tests. Thanks James for pointing it out. In fact, we have synced all script-tag tests which were added in https://github.com/web-platform-tests/wpt/pull/10976/commits/78a3837eb9cc4fb1bd55f21a9823eda82694d3d2 The tests should provide sufficient coverage of the feature. All the tests are disabled now, for example: It looks like the tests are marked as expected: FAIL rather than disabled, and checking treeherder I'm finding results so I think they are indeed already running (sorry if this is a bit pedantic, I was just making sure I understood the situation). ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Intent to implement: Support Referrer Policy for
The link https://searchfox.org/mozilla-central/search?q=script-tag%2Finsecure-protocol.keep-origin-redirect.http.html= is not covered all the tests. Thanks James for pointing it out. In fact, we have synced all script-tag tests which were added in https://github.com/web-platform-tests/wpt/pull/10976/commits/78a3837eb9cc4fb1bd55f21a9823eda82694d3d2 The tests should provide sufficient coverage of the feature. All the tests are disabled now, for example: https://searchfox.org/mozilla-central/source/testing/web-platform/meta/referrer-policy/no-referrer/attr-referrer/cross-origin/http-http/script-tag https://searchfox.org/mozilla-central/source/testing/web-platform/tests/referrer-policy/no-referrer/attr-referrer/cross-origin/http-http/script-tag https://searchfox.org/mozilla-central/source/testing/web-platform/meta/referrer-policy/origin/attr-referrer/cross-origin/http-http/script-tag https://searchfox.org/mozilla-central/source/testing/web-platform/meta/referrer-policy/origin/attr-referrer/same-origin/http-http/script-tag On Thu, Nov 1, 2018 at 11:28 AM James Graham wrote: > On 31/10/2018 14:03, Thomas Nguyen wrote: > > Summary: This implementation adds Referrer Policy support to the
Re: Intent to implement: Support Referrer Policy for
On 31/10/2018 14:03, Thomas Nguyen wrote: Summary: This implementation adds Referrer Policy support to the
