Re: DXR UI refresh is live!

[Joshua Cranmer 🐧]

On 2/11/2014 5:00 PM, Ehsan Akhgari wrote:
I don't think any of these are important features for us to focus on.  
I would say that we accept patches for the last three items, but I 
don't think we are interested in accepting patches for CVS support 
into DXR.




This statement is worth slightly qualifying: adding links to bonsai for 
CVS trees on DXR would be fine. Any deeper integration is almost 
certainly not worth the time.


On the other hand, since I think we have no remaining active projects on 
CVS, it may be worthwhile to convert the entire history of mozilla CVS 
into an appropriate DVCS (hg or git, I don't really care) and use that 
repo in DXR instead of the CVS tree.


--
Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Taras Glek]

Very happy now :)


Erik Rose 
Tuesday, February 11, 2014 14:50

I believe this is fixed now, a casualty of a needless use of JS, which 
is now gone. If you still see this behavior, please reopen 
https://bugzilla.mozilla.org/show_bug.cgi?id=965659.


Thanks for riding out the bumps!

Erik
Taras Glek 
Friday, February 7, 2014 14:42
that's pretty, but where did the list of classes & class members go 
when viewing files like 
http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp


- Original Message -
___
dev-static-analysis mailing list
dev-static-analy...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-static-analysis
Erik Rose 
Friday, February 7, 2014 13:26
https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/

Happy hacking!
___
dev-static-analysis mailing list
dev-static-analy...@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-static-analysis

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Ehsan Akhgari]

On 2/11/2014, 3:18 PM, Reed Loden wrote:

On Fri, 7 Feb 2014 16:26:19 -0500
Erik Rose  wrote:


https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/

Happy hacking!


I do like the slickness and quickness, but it still seems
greatly-lacking usability-wise (as compared to mxr)...


Can you please clarify how DXR is greatly-lacking usability-wise?


A few things off the top of my head:
* Where are the non-mozilla-central repositories?


There is ongoing work on multi-repository support.


* Where's the integration with CVS?
* Where are the links to see changes over the last day, week, month,
   etc.?
* Why do I have to click on "Navigation" just to get basic
   functionality?
* Why is it not accessible over SSL?


I don't think any of these are important features for us to focus on.  I 
would say that we accept patches for the last three items, but I don't 
think we are interested in accepting patches for CVS support into DXR.


Cheers,
Ehsan

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Erik Rose]

> that's pretty, but where did the list of classes & class members go when 
> viewing files like 
> http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp

I believe this is fixed now, a casualty of a needless use of JS, which is now 
gone. If you still see this behavior, please reopen 
https://bugzilla.mozilla.org/show_bug.cgi?id=965659.

Thanks for riding out the bumps!

Erik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Erik Rose]

Hi, Reed. Rest assured, many of your wishes are planned for the future. But 
when you have a big project, you've got to pick some things.

Last week's release was an important milestone: it was the minimal feature set 
that would yield a cohesive experience under a UI new design. The new design 
solves a lot of usability problems, removes some serious limitations, and gives 
us places to put several things planned for the near future. Now, ordinarily, I 
abhor big-red-lever launches, as evidenced by our continued rollout of features 
onto production while the UI work was in progress and the fact that we deployed 
7 times yesterday. However, you can't always iterate your way to big 
user-facing changes and make sense the whole time. So don't take the current 
state as an end; it's just an uncharacteristically large step, worthy of a 
release announcement.

Let me address your individual wishes:

> * Where are the non-mozilla-central repositories?

Coming! One of the big UI-branch features is improved support for multiple 
trees. The UI for that is hidden right now, since there's only one tree 
indexed. But we're working on comm-central right now. Aurora is next. Then 
we'll continue pulling in more, in order of the popularity they see on MXR. I 
think you'll like what you see.

> * Where's the integration with CVS?
> * Where are the links to see changes over the last day, week, month,
>  etc.?

A lower priority since there are plenty of other ways to poll version control. 
However, we have a flexible framework for VCS integration 
(https://github.com/mozilla/dxr/blob/master/dxr/plugins/omniglot/htmlifier.py), 
and this would be an easy first bug, if it's important to you. (If you can get 
a bunch of people to hoot and holler about how important it is, we'll move it 
up the roadmap.)

> * Why do I have to click on "Navigation" just to get basic functionality?

That was already ticketed, and I fixed it yesterday; the nav pane is now 
disclosed by default. More is planned: 
https://bugzilla.mozilla.org/show_bug.cgi?id=968020.

> * Why is it not accessible over SSL?

There's an IT bug filed about that, but indexing more trees is higher priority 
right now. Do you have a specific use case in mind?

Feel free to have a look at our roadmap (https://wiki.mozilla.org/DXR_Roadmap) 
and add constructively to it.

Cheers,
Erik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Robert O'Callahan]

On Wed, Feb 12, 2014 at 9:18 AM, Reed Loden  wrote:

> I do like the slickness and quickness, but it still seems
> greatly-lacking usability-wise (as compared to mxr)...
>
> A few things off the top of my head:
> * Where are the non-mozilla-central repositories?
> * Where's the integration with CVS?
>
* Where are the links to see changes over the last day, week, month,
>   etc.?
> * Why is it not accessible over SSL?
>

Personally I'm glad the team prioritized the work they did over these
features.

Rob
-- 
Jtehsauts  tshaei dS,o n" Wohfy  Mdaon  yhoaus  eanuttehrotraiitny  eovni
le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o  Whhei csha iids  teoa
stiheer :p atroa lsyazye,d  'mYaonu,r  "sGients  uapr,e  tfaokreg iyvoeunr,
'm aotr  atnod  sgaoy ,h o'mGee.t"  uTph eann dt hwea lmka'n?  gBoutt  uIp
waanndt  wyeonut  thoo mken.o w
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Reed Loden]

On Fri, 7 Feb 2014 16:26:19 -0500
Erik Rose  wrote:

> https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/
> 
> Happy hacking!

I do like the slickness and quickness, but it still seems
greatly-lacking usability-wise (as compared to mxr)...

A few things off the top of my head:
* Where are the non-mozilla-central repositories?
* Where's the integration with CVS?
* Where are the links to see changes over the last day, week, month,
  etc.?
* Why do I have to click on "Navigation" just to get basic
  functionality?
* Why is it not accessible over SSL?

~reed
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Erik Rose]

> Why are you double spacing the output and then "fixing" it by hard-coding .7 
> line spacing for the source and 1.4 for the line numbers?

That was weird. Nobody knew why. Fixed now: 
https://github.com/mozilla/dxr/commit/16784204ce30c428cc3e325d7f5ccd225346bfdf. 
This also makes copying and pasting code decent. Also went over the rest of 
that area for things that looked hacky and cleaned them up: 
https://github.com/mozilla/dxr/commit/3de9a9c7190de30be4e6ca551d625512bc6b1161.

Cheers,
Erik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Neil]

Edwin Flores wrote:


the "click here to view all search results" link

I wondered what this was, but it turns out I had disabled JavaScript in 
that browser.


--
Warning: May contain traces of nuts.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Erik Rose]

>> I notice the "click here to view all search results" link is at the top
>> of the code listing now, instead of being with the search bar. That
>> means it'll be invisible most of the time.
> 
> First, let me say that we're still moving error messages around. We'll 
> probably end up with something like this for "Type at least 3 chars" and 
> "That's a bad regex"-type 
> messages:https://people.mozilla.org/~erose/error-bubble.png.

> But getting back to your immediate question...invisible? How? Is it below the 
> fold for you?

Ah, it's not pinned, so when the viewport auto-scrolls to show the found line, 
the message is hidden. Good catch. We will pin it or stick it back on the 
search bar. It might be a candidate for one of those message bubbles.

Erik
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Erik Rose]

> I notice the "click here to view all search results" link is at the top
> of the code listing now, instead of being with the search bar. That
> means it'll be invisible most of the time.

First, let me say that we're still moving error messages around. We'll probably 
end up with something like this for "Type at least 3 chars" and "That's a bad 
regex"-type messages: https://people.mozilla.org/~erose/error-bubble.png.

But getting back to your immediate question...invisible? How? Is it below the 
fold for you?

Thanks,
Erik

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Edwin Flores]

On 08/02/14 10:26, Erik Rose wrote:
> https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/
> 
> Happy hacking!

Looks awesome! But... (there's always a but)

I notice the "click here to view all search results" link is at the top
of the code listing now, instead of being with the search bar. That
means it'll be invisible most of the time.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Neil]

Erik Rose wrote:


https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/
 

Why are you double spacing the output and then "fixing" it by 
hard-coding .7 line spacing for the source and 1.4 for the line numbers?


Also although most of your CSS uses classes, some of it uses 
:first-child (or equivalent) which makes it look inconsistent.


--
Warning: May contain traces of nuts.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Erik Rose]

Fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=969887#c1. It will take 
effect with the next re-index, in a few hours.

Good eye! Somehow, nobody caught this on staging or locally, though it seems 
obvious in retrospect. While I was at it, I stopped the code from jumping to 
the side when you click a long line number; that was silly, too. Keep the 
feedback coming, pro and con. We already have many little things on the 
chopping block: see the high-ID bugs at 
https://bugzilla.mozilla.org/buglist.cgi?product=Webtools&component=DXR&resolution=---&list_id=9393813.
 And of course, patches are welcome. :-)

Cheers,
Erik

On Feb 8, 2014, at 6:22 , Tom Schuster  wrote:

> The design looks really fresh, I really like the new colors. I am however 
> wondering about additional spaces that were introduced, they seem to even 
> break 
> indentation:http://dxr.mozilla.org/mozilla-central/source/js/src/jsapi.cpp#1426.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Tom Schuster]

The design looks really fresh, I really like the new colors. I am however
wondering about additional spaces that were introduced, they seem to even
break indentation:
http://dxr.mozilla.org/mozilla-central/source/js/src/jsapi.cpp#1426.

-Tom


On Sat, Feb 8, 2014 at 1:29 AM, Erik Rose  wrote:

> > that's pretty, but where did the list of classes & class members go when
> viewing files like
> http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp
>
> Coming back soon: https://bugzilla.mozilla.org/show_bug.cgi?id=965659.
> We're having some trouble reducing it to a test case smaller than
> moz-central.
>
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Erik Rose]

> that's pretty, but where did the list of classes & class members go when 
> viewing files like 
> http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp

Coming back soon: https://bugzilla.mozilla.org/show_bug.cgi?id=965659. We're 
having some trouble reducing it to a test case smaller than moz-central.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: DXR UI refresh is live!

[Taras Glek]

that's pretty, but where did the list of classes & class members go when 
viewing files like 
http://dxr.mozilla.org/mozilla-central/source/modules/libjar/nsZipArchive.cpp

- Original Message -
> From: "Erik Rose" 
> To: dev-platform@lists.mozilla.org, dev-static-analy...@lists.mozilla.org
> Sent: Friday, February 7, 2014 1:26:19 PM
> Subject: DXR UI refresh is live!
> 
> https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/
> 
> Happy hacking!
> ___
> dev-static-analysis mailing list
> dev-static-analy...@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-static-analysis
> 
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

DXR UI refresh is live!

[Erik Rose]

https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/

Happy hacking!
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform