Re: Intent to Implement and Ship: Make MOZ_QUIET the default, require opt-in for DOMWINDOW/DOCSHELL logs
This landed in https://hg.mozilla.org/mozilla-central/rev/724d7b936078 To replicate the prior output, use MOZ_LOG="DocShellAndDOMWindowLeak:3" Because it now includes the MOZ_LOG prefix, any custom scripts you had to parse the output will need to be updated. -tom On Fri, Nov 8, 2019 at 2:44 PM Tom Ritter wrote: > >> In https://bugzilla.mozilla.org/show_bug.cgi?id=1592297 I plan/hope to >> remove MOZ_QUIET and turn off the DOCSHELL/DOMWINDOW logging by default. >> It will automatically be enabled in browser-chrome tests where it is >> needed. (It actually will no longer be possible to disable it when running >> those tests also.) >> >> Once this lands, MOZ_QUIET will no longer do anything, and if you want >> this >> output you will need to explicitly set a new env var. (Current idea is >> MOZ_LOG_WINDOWS_DOCSHELLS but feel free to tell me what color for the >> bikeshed in phabricator, I have no preference.) >> >> I'm sending this before I finish the requested changes in phabricator to >> give folks an opportunity to raise objections; I hope to land it mid/late >> next week. >> >> -tom >> ___ >> dev-platform mailing list >> dev-platform@lists.mozilla.org >> https://lists.mozilla.org/listinfo/dev-platform >> > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Intent to Implement and Ship: Make MOZ_QUIET the default, require opt-in for DOMWINDOW/DOCSHELL logs
This sounds great. Is there a reason we can't just use MOZ_LOG for the docshell/domwindow logging? -e On Fri, Nov 8, 2019 at 2:44 PM Tom Ritter wrote: > In https://bugzilla.mozilla.org/show_bug.cgi?id=1592297 I plan/hope to > remove MOZ_QUIET and turn off the DOCSHELL/DOMWINDOW logging by default. > It will automatically be enabled in browser-chrome tests where it is > needed. (It actually will no longer be possible to disable it when running > those tests also.) > > Once this lands, MOZ_QUIET will no longer do anything, and if you want this > output you will need to explicitly set a new env var. (Current idea is > MOZ_LOG_WINDOWS_DOCSHELLS but feel free to tell me what color for the > bikeshed in phabricator, I have no preference.) > > I'm sending this before I finish the requested changes in phabricator to > give folks an opportunity to raise objections; I hope to land it mid/late > next week. > > -tom > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Intent to Implement and Ship: Make MOZ_QUIET the default, require opt-in for DOMWINDOW/DOCSHELL logs
Thank you for doing this. On Fri, Nov 8, 2019 at 2:44 PM Tom Ritter wrote: > In https://bugzilla.mozilla.org/show_bug.cgi?id=1592297 I plan/hope to > remove MOZ_QUIET and turn off the DOCSHELL/DOMWINDOW logging by default. > It will automatically be enabled in browser-chrome tests where it is > needed. (It actually will no longer be possible to disable it when running > those tests also.) > > Once this lands, MOZ_QUIET will no longer do anything, and if you want this > output you will need to explicitly set a new env var. (Current idea is > MOZ_LOG_WINDOWS_DOCSHELLS but feel free to tell me what color for the > bikeshed in phabricator, I have no preference.) > > I'm sending this before I finish the requested changes in phabricator to > give folks an opportunity to raise objections; I hope to land it mid/late > next week. > > -tom > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Intent to Implement and Ship: Make MOZ_QUIET the default, require opt-in for DOMWINDOW/DOCSHELL logs
In https://bugzilla.mozilla.org/show_bug.cgi?id=1592297 I plan/hope to remove MOZ_QUIET and turn off the DOCSHELL/DOMWINDOW logging by default. It will automatically be enabled in browser-chrome tests where it is needed. (It actually will no longer be possible to disable it when running those tests also.) Once this lands, MOZ_QUIET will no longer do anything, and if you want this output you will need to explicitly set a new env var. (Current idea is MOZ_LOG_WINDOWS_DOCSHELLS but feel free to tell me what color for the bikeshed in phabricator, I have no preference.) I'm sending this before I finish the requested changes in phabricator to give folks an opportunity to raise objections; I hope to land it mid/late next week. -tom ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
