Re: Intent to Unship: stream decoder for BinHex format

2017-10-25 Thread Eric Shepherd (Sheppy) 
Man… It’s weird that this makes me all nostalgic. :)


Eric Shepherd
Senior Technical Writer, MDN
MDN: https://developer.mozilla.org/
Blog: https://www.bitstampede.com/

On October 18, 2017 at 8:50:20 AM, Joshua Cranmer  (pidgeo...@gmail.com)
wrote:

FWIW, I've considered ripping out the binhex decoding from mailnews code
anyways.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to Unship: stream decoder for BinHex format

2017-10-18 Thread Joshua Cranmer  

On 10/17/2017 10:45 AM, Boris Zbarsky wrote:

On 10/17/17 5:47 AM, Shih-Chiang Chien wrote:

I intent to remove all the code that handling BinHex decoding, i.e.
nsBinHex.cpp, from mozilla-central if no other project is using it.


The code was originally added for mailnews.  See 
https://bugzilla.mozilla.org/show_bug.cgi?id=81352


Please double-check that this use case does not get broken, or 
condition the code to be mailnews-only or something.


FWIW, I've considered ripping out the binhex decoding from mailnews code 
anyways.


--
Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Boris Zbarsky 

On 10/17/17 8:12 PM, Myk Melez wrote:
Shouldn't the code rather move to comm-central if it's specific to 
mailnews?


That would be fine too, yes.

-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Myk Melez 

Boris Zbarsky 
2017 October 17 at 07:45
Please double-check that this use case does not get broken, or 
condition the code to be mailnews-only or something.

Shouldn't the code rather move to comm-central if it's specific to mailnews?

-myk

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Boris Zbarsky 

On 10/17/17 5:47 AM, Shih-Chiang Chien wrote:

I intent to remove all the code that handling BinHex decoding, i.e.
nsBinHex.cpp, from mozilla-central if no other project is using it.


The code was originally added for mailnews.  See 
https://bugzilla.mozilla.org/show_bug.cgi?id=81352


Please double-check that this use case does not get broken, or condition 
the code to be mailnews-only or something.


-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Shih-Chiang Chien 
Currently on non-Mac platform, firefox will decompression the content while
loading resource with MIME type "application/mac-binhex40". This introduces
the confusion like bug 1390708 when Firefox trying to decode BinHex file.
On Mac platform we already disabled stream decoding of BinHex file.

I tested with Google Chrome 61, Internet Explorer 11, and Safari 11. All
these browsers treat BinHex file as binary file and trigger file download
directly.

I intent to remove all the code that handling BinHex decoding, i.e.
nsBinHex.cpp, from mozilla-central if no other project is using it. This
will happen on Firefox 58 if no objection on mailing list and in bug
1390708.

Best Regards,
Shih-Chiang Chien
Mozilla Taiwan
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform