Re: Proposal: WebIDL generated bindings classes renamed from dom::FooBinding to dom::binding::Foo
On 6/7/18 4:24 PM, Kyle Machulis wrote: +1 on the namespace idea. We started using mozilla::dom::FooBinding::[ConstantName] namespace for constants in bug 792059, so we may also want to change that to dom::binding::Foo::[ConstantName] for consistency sake. Right, that change would be part of the proposal here. All FooBinding would become bindings::Foo. (I guess we have to watch out for bindings::Foo vs binding::Foo; I wonder whether we should just "namespace binding = bindings;" and let people spell it however.) -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Proposal: WebIDL generated bindings classes renamed from dom::FooBinding to dom::binding::Foo
+1 on the namespace idea. We started using mozilla::dom::FooBinding::[ConstantName] namespace for constants in bug 792059, so we may also want to change that to dom::binding::Foo::[ConstantName] for consistency sake. On Thu, Jun 7, 2018 at 1:03 PM, Jeff Gilbert wrote: > We have a name conflict under the current system when trying to use > these two classes from the webgpu sketch webidl: > - WebGPUBuffer > - WebGPUBufferBinding > > I'm proposing renaming the generated bindings classes from > dom::FooBinding to dom::binding::Foo. This seems like a reasonable use > of namespaces, and will be immune from naming collisions coming from > webidl. > > Also considered was dom::Foo_Binding. (webidl really shouldn't have > underscores, but technically could!) Talking with bz, > dom::bindings::Foo sounds better to us, though. > ___ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Proposal: WebIDL generated bindings classes renamed from dom::FooBinding to dom::binding::Foo
We have a name conflict under the current system when trying to use these two classes from the webgpu sketch webidl: - WebGPUBuffer - WebGPUBufferBinding I'm proposing renaming the generated bindings classes from dom::FooBinding to dom::binding::Foo. This seems like a reasonable use of namespaces, and will be immune from naming collisions coming from webidl. Also considered was dom::Foo_Binding. (webidl really shouldn't have underscores, but technically could!) Talking with bz, dom::bindings::Foo sounds better to us, though. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
