Re: FYI: We've forked the Breakpad client code

2017-02-13 Thread Nick Fitzgerald 
I can review the DWARF related bits in a pinch, too.

On Thu, Feb 9, 2017 at 2:04 PM, Mike Hommey  wrote:

> On Thu, Feb 09, 2017 at 12:41:07PM -0800, Jim Blandy wrote:
> > Under the circumstances, I'll volunteer to review, if that's feasible.
>
> I can too.
>
> > On Thu, Feb 9, 2017 at 12:37 PM, Ted Mielczarek 
> wrote:
> >
> > > On Thu, Feb 9, 2017, at 02:47 PM, Aaron Klotz wrote:
> > > > This is great news, Ted!
> > > >
> > > > Are you going to be creating a module for this? Who are the peers?
> > >
> > > I don't think a new module is necessary, we've covered the existing
> > > integration code (nsExceptionHandler.cpp etc) under the Toolkit module
> > > for a long time and I think it's been OK. If it becomes a problem we
> can
> > > certainly reevaluate. There aren't a lot of people that are comfortable
> > > reviewing this code, but that's not exactly a unique situation in
> Gecko.
> > >
> > > -Ted
> > > ___
> > > dev-platform mailing list
> > > dev-platform@lists.mozilla.org
> > > https://lists.mozilla.org/listinfo/dev-platform
> > >
> > ___
> > dev-platform mailing list
> > dev-platform@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-platform
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: FYI: We've forked the Breakpad client code

2017-02-09 Thread Mike Hommey 
On Thu, Feb 09, 2017 at 12:41:07PM -0800, Jim Blandy wrote:
> Under the circumstances, I'll volunteer to review, if that's feasible.

I can too.

> On Thu, Feb 9, 2017 at 12:37 PM, Ted Mielczarek  wrote:
> 
> > On Thu, Feb 9, 2017, at 02:47 PM, Aaron Klotz wrote:
> > > This is great news, Ted!
> > >
> > > Are you going to be creating a module for this? Who are the peers?
> >
> > I don't think a new module is necessary, we've covered the existing
> > integration code (nsExceptionHandler.cpp etc) under the Toolkit module
> > for a long time and I think it's been OK. If it becomes a problem we can
> > certainly reevaluate. There aren't a lot of people that are comfortable
> > reviewing this code, but that's not exactly a unique situation in Gecko.
> >
> > -Ted
> > ___
> > dev-platform mailing list
> > dev-platform@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-platform
> >
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: FYI: We've forked the Breakpad client code

2017-02-09 Thread Jim Blandy 
Under the circumstances, I'll volunteer to review, if that's feasible.

On Thu, Feb 9, 2017 at 12:37 PM, Ted Mielczarek  wrote:

> On Thu, Feb 9, 2017, at 02:47 PM, Aaron Klotz wrote:
> > This is great news, Ted!
> >
> > Are you going to be creating a module for this? Who are the peers?
>
> I don't think a new module is necessary, we've covered the existing
> integration code (nsExceptionHandler.cpp etc) under the Toolkit module
> for a long time and I think it's been OK. If it becomes a problem we can
> certainly reevaluate. There aren't a lot of people that are comfortable
> reviewing this code, but that's not exactly a unique situation in Gecko.
>
> -Ted
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: FYI: We've forked the Breakpad client code

2017-02-09 Thread Ted Mielczarek 
On Thu, Feb 9, 2017, at 02:47 PM, Aaron Klotz wrote:
> This is great news, Ted!
> 
> Are you going to be creating a module for this? Who are the peers?

I don't think a new module is necessary, we've covered the existing
integration code (nsExceptionHandler.cpp etc) under the Toolkit module
for a long time and I think it's been OK. If it becomes a problem we can
certainly reevaluate. There aren't a lot of people that are comfortable
reviewing this code, but that's not exactly a unique situation in Gecko.

-Ted
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: FYI: We've forked the Breakpad client code

2017-02-09 Thread Aaron Klotz 

This is great news, Ted!

Are you going to be creating a module for this? Who are the peers?

-Aaron

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform