Re: NSPR logging dropping log messages
On 12/6/2013, 11:59 AM, Honza Bambas wrote: On 12/6/2013 5:31 PM, Ehsan Akhgari wrote: Can you please file a bug about this so that we can try to get this patch landed? WTC recently indicated to me (in https://bugzilla.mozilla.org/show_bug.cgi?id=941854#c10) that we should probably start adding support for having our own NSPR patches, so I would expect that with a bit of fiddling in the client.py code to update NSPR, we should be able to take this patch on top of the upstream NSPR in our tree. There is one, quite old: https://bugzilla.mozilla.org/show_bug.cgi?id=534764, many patches from many authors, one better then other ;)) Also be aware of https://bugzilla.mozilla.org/show_bug.cgi?id=801209 but there is absolutely no progress recently on that one. IMO rather take small patches to NSPR then rewrite it all at the moment. I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: NSPR logging dropping log messages
On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My patch is probably not something that should be on by default IMO. It will create a new log file with .pid as an extension for every process we start, including the parent (main) process. So it can well fill out your disk when you are not careful. Also, you can easily get lost among all those files. Hmm... mach run command could delete or (preferably) trash them, but still. On the other hand, that patch is really a must for me personally. -hb- ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: NSPR logging dropping log messages
On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My patch is probably not something that should be on by default IMO. It will create a new log file with .pid as an extension for every process we start, including the parent (main) process. So it can well fill out your disk when you are not careful. Also, you can easily get lost among all those files. Hmm... mach run command could delete or (preferably) trash them, but still. On the other hand, that patch is really a must for me personally. What I was thinking about was that we would only create a log.pid file for anything that is not the main process. Ehsan ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: NSPR logging dropping log messages
On 12/6/2013 7:24 PM, Ehsan Akhgari wrote: On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My patch is probably not something that should be on by default IMO. It will create a new log file with .pid as an extension for every process we start, including the parent (main) process. So it can well fill out your disk when you are not careful. Also, you can easily get lost among all those files. Hmm... mach run command could delete or (preferably) trash them, but still. On the other hand, that patch is really a must for me personally. What I was thinking about was that we would only create a log.pid file for anything that is not the main process. Ehsan Something like https://bug534764.bugzilla.mozilla.org/attachment.cgi?id=481578 ? (Actually a platform bug) ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: NSPR logging dropping log messages
On 12/6/2013, 1:33 PM, Honza Bambas wrote: On 12/6/2013 7:24 PM, Ehsan Akhgari wrote: On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My patch is probably not something that should be on by default IMO. It will create a new log file with .pid as an extension for every process we start, including the parent (main) process. So it can well fill out your disk when you are not careful. Also, you can easily get lost among all those files. Hmm... mach run command could delete or (preferably) trash them, but still. On the other hand, that patch is really a must for me personally. What I was thinking about was that we would only create a log.pid file for anything that is not the main process. Ehsan Something like https://bug534764.bugzilla.mozilla.org/attachment.cgi?id=481578 ? (Actually a platform bug) Sure! ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: NSPR logging dropping log messages
Bill McCloskey pointed me to bug 924253, and his patch there fixed my problem. So basically, don't trust mochitest output until bug 924253 is fixed. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.rt sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r sGients uapr,e tfaokreg iyvoeunr, 'm aotr atnod sgaoy ,h o'mGee.t uTph eann dt hwea lmka'n? gBoutt uIp waanndt wyeonut thoo mken.o w ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: NSPR logging dropping log messages
On Thu, Dec 5, 2013 at 9:46 PM, Robert O'Callahan rob...@ocallahan.org wrote: bug 924253 I think we should also be careful that, when we have multiple processes (which is always, because of e10s-based about:newtab fetching), that those multiple processes are not clobbering each other's output, when NSPR_LOG_FILE is used. I am not sure what the current state of this is. Cheers, Brian -- Mozilla Networking/Crypto/Security (Necko/NSS/PSM) ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
