Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
Dave Townsend schrieb: Ideally you would have talked to the Toolkit module owner (i.e. me) before adding a new chunk of code to it but Toolkit has basically become the wild-west of modules and I'm not sure what purpose an owner is meant to have at this point. The Submodule page is probably hopelessly out of date at this point and I don't know if trying to save it is the right thing to do. Given that toolkit is pretty central to Firefox (as well as Thunderbird and SeaMonkey, probably also XULRunner-based applications), your post makes me pretty scared as a member of the module ownership group. What should we do there? KaiRo ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
I'm working on a plan, watch this space On Thu, Jan 23, 2014 at 9:38 AM, Robert Kaiser ka...@kairo.at wrote: Dave Townsend schrieb: Ideally you would have talked to the Toolkit module owner (i.e. me) before adding a new chunk of code to it but Toolkit has basically become the wild-west of modules and I'm not sure what purpose an owner is meant to have at this point. The Submodule page is probably hopelessly out of date at this point and I don't know if trying to save it is the right thing to do. Given that toolkit is pretty central to Firefox (as well as Thunderbird and SeaMonkey, probably also XULRunner-based applications), your post makes me pretty scared as a member of the module ownership group. What should we do there? KaiRo ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
Everyone who is a preferred reviewer should be a peer, if they aren't it's likely because I forgot to update the appropriate lists. Who do you see who is absent from the peer list? On Sat, Jan 18, 2014 at 11:51 AM, Matthew N. ma...@mozilla.com wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? Thanks, MattN [1] https://wiki.mozilla.org/Toolkit/Submodules [2] https://wiki.mozilla.org/Modules/Toolkit [3] https://wiki.mozilla.org/Toolkit/Code_Review ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
Thanks for clarifying. Myself, Jared Wein, and Paolo Amadini (Download Manager Owner) seem to be missing from the Toolkit peer list then. Thanks, Matthew On 1/19/14, 8:47 PM, Dave Townsend wrote: Everyone who is a preferred reviewer should be a peer, if they aren't it's likely because I forgot to update the appropriate lists. Who do you see who is absent from the peer list? On Sat, Jan 18, 2014 at 11:51 AM, Matthew N. ma...@mozilla.com wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? Thanks, MattN [1] https://wiki.mozilla.org/Toolkit/Submodules [2] https://wiki.mozilla.org/Modules/Toolkit [3] https://wiki.mozilla.org/Toolkit/Code_Review ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
On Sat, Jan 18, 2014 at 2:03 PM, Ms2ger ms2...@gmail.com wrote: On 01/18/2014 08:51 PM, Matthew N. wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? In general, all reviews should be done by peers, so people who are not peers should not be listed as preferred reviewers. HTH Ms2ger ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform Historically we have given great deference to module owners who choose to delegate reviews to people who are not listed as peers, especially of patches written by the owner and listed peers. There are many reasons to do this, including working to grow new reviewers, choosing someone who understands a particularly specialized piece of code (potentially better than the owner), or load-balancing review requests by assigning reviews that need less scrutiny to people who are familiar with but not experts on the code in question. I don't think it's at all correct to say that all reviews should be done by peers. - Kyle PS. Don't you do a fair number of reviews in content/ and dom/? :P ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
I refactorted and debugged most of the findbar code. Mike seems to the de facto owner, so I think it makes sense for me to do reviews. I doubt anybody else knows much about the code. There seems to be no submodule for it anyway? On Jan 19, 2014 10:40 PM, Matthew N. ma...@mozilla.com wrote: Thanks for clarifying. Myself, Jared Wein, and Paolo Amadini (Download Manager Owner) seem to be missing from the Toolkit peer list then. Thanks, Matthew On 1/19/14, 8:47 PM, Dave Townsend wrote: Everyone who is a preferred reviewer should be a peer, if they aren't it's likely because I forgot to update the appropriate lists. Who do you see who is absent from the peer list? On Sat, Jan 18, 2014 at 11:51 AM, Matthew N. ma...@mozilla.com wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? Thanks, MattN [1] https://wiki.mozilla.org/Toolkit/Submodules [2] https://wiki.mozilla.org/Modules/Toolkit [3] https://wiki.mozilla.org/Toolkit/Code_Review ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
I added a component for captive portal detection about a year ago. Should I update https://wiki.mozilla.org/Toolkit/Submodules myself? Best Regards, Shih-Chiang Chien Mozilla Taiwan On Jan 20, 2014, at 8:17 AM, Tom Schuster t...@schuster.me wrote: I refactorted and debugged most of the findbar code. Mike seems to the de facto owner, so I think it makes sense for me to do reviews. I doubt anybody else knows much about the code. There seems to be no submodule for it anyway? On Jan 19, 2014 10:40 PM, Matthew N. ma...@mozilla.com wrote: Thanks for clarifying. Myself, Jared Wein, and Paolo Amadini (Download Manager Owner) seem to be missing from the Toolkit peer list then. Thanks, Matthew On 1/19/14, 8:47 PM, Dave Townsend wrote: Everyone who is a preferred reviewer should be a peer, if they aren't it's likely because I forgot to update the appropriate lists. Who do you see who is absent from the peer list? On Sat, Jan 18, 2014 at 11:51 AM, Matthew N. ma...@mozilla.com wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? Thanks, MattN [1] https://wiki.mozilla.org/Toolkit/Submodules [2] https://wiki.mozilla.org/Modules/Toolkit [3] https://wiki.mozilla.org/Toolkit/Code_Review ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform signature.asc Description: Message signed with OpenPGP using GPGMail ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
Ideally you would have talked to the Toolkit module owner (i.e. me) before adding a new chunk of code to it but Toolkit has basically become the wild-west of modules and I'm not sure what purpose an owner is meant to have at this point. The Submodule page is probably hopelessly out of date at this point and I don't know if trying to save it is the right thing to do. On Sun, Jan 19, 2014 at 6:47 PM, Shih-Chiang Chien sch...@mozilla.comwrote: I added a component for captive portal detection about a year ago. Should I update https://wiki.mozilla.org/Toolkit/Submodules myself? Best Regards, Shih-Chiang Chien Mozilla Taiwan On Jan 20, 2014, at 8:17 AM, Tom Schuster t...@schuster.me wrote: I refactorted and debugged most of the findbar code. Mike seems to the de facto owner, so I think it makes sense for me to do reviews. I doubt anybody else knows much about the code. There seems to be no submodule for it anyway? On Jan 19, 2014 10:40 PM, Matthew N. ma...@mozilla.com wrote: Thanks for clarifying. Myself, Jared Wein, and Paolo Amadini (Download Manager Owner) seem to be missing from the Toolkit peer list then. Thanks, Matthew On 1/19/14, 8:47 PM, Dave Townsend wrote: Everyone who is a preferred reviewer should be a peer, if they aren't it's likely because I forgot to update the appropriate lists. Who do you see who is absent from the peer list? On Sat, Jan 18, 2014 at 11:51 AM, Matthew N. ma...@mozilla.com wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? Thanks, MattN [1] https://wiki.mozilla.org/Toolkit/Submodules [2] https://wiki.mozilla.org/Modules/Toolkit [3] https://wiki.mozilla.org/Toolkit/Code_Review ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? Thanks, MattN [1] https://wiki.mozilla.org/Toolkit/Submodules [2] https://wiki.mozilla.org/Modules/Toolkit [3] https://wiki.mozilla.org/Toolkit/Code_Review ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers
On 01/18/2014 08:51 PM, Matthew N. wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related submodule without oversight from the sub-module owner? 2) Is a sub-module Preferred Reviewer considered a Toolkit reviewer for the purposes of [3]? In general, all reviews should be done by peers, so people who are not peers should not be listed as preferred reviewers. HTH Ms2ger ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
