Re: [dev-servo] Fwd: Re: Suggested code review workflow
In Gecko, I have taken the habit of requesting long messages when the patch is not self-contained. Plus, I am currently working on bugs that would have been much easier to puzzle out if we (well, if I) had explained in the long message why some changes were made. In other words, +1 for requesting long messages. Cheers, David On 23/02/16 02:09, smaug wrote: > Well, even long commit messages tend to not capture all the key pieces > why certain change was made, and what it is supposed to do, and > often it is the comments from the reviewer which are valuable, and links > to other related bugs, dependency tracking etc. > But I know this is all very subjective. Some people like commit messages > and some prefer to read the bug. > Perhaps I had different opinion if Gecko had always used more > descriptive commit messages. > > > -Olli > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Suggested code review workflow
Very good point. In Gecko-land, some teams use multi-line commit messages as documentation and my experience shows that it's very useful. Cheers, David On 03/02/16 20:21, Boris Zbarsky wrote: > On 2/3/16 1:46 PM, Josh Matthews wrote: >> Nikki asked for suggestions for how to review code, so here's my first >> attempt at writing down a general suggested workflow for reviewing Servo >> code: >> >> https://github.com/servo/servo/wiki/Code-review > > Somewhere in there, one should read the commit messages too. Probably > before reading the code. And if it's not clear from the commit messages > what the goal of the code changes is, then they need fixing. > > -Boris > > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
[dev-servo] MozLando: Telemetry for Servo. Today at 11h10
I'll give a quick (unscheduled) talk about Telemetry for Servo today at 11h10 in Northern E4. Cheers, David ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Per-document event queues
Partially related question: are there plans for per-add-on event queue? On 21/07/15 16:31, Josh Matthews wrote: We currently have a model where each eTLD has a separate event queue. This is an improvement over Gecko (one event queue to rule them all), but I suspect we can do better. Specifically, I'm interested in moving to isolated event queues per document, then doing round-robin event processing on each on in an eTLD group. That would make the script event loop look something like this: -- David Rajchenbach-Teller, PhD Performance Team, Mozilla signature.asc Description: OpenPGP digital signature ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
