Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/Cpuid.h: Remove duplicated struct definition for leaf 1FH

[Dong, Eric]

Reviewed-by: Eric Dong 

> -Original Message-
> From: Ni, Ray
> Sent: Thursday, April 4, 2019 2:03 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Zeng, Star ; Qin,
> Zhiqiang 
> Subject: [PATCH v2 1/2] UefiCpuPkg/Cpuid.h: Remove duplicated struct
> definition for leaf 1FH
> 
> Per SDM CPUID.0BH and CPUID.1FH outputs the same format of data in
> EAX/EBX/ECX/EDX except CPUID.1FH reports more level types such as
> module, tile, die.
> 
> The patch removes the unnecessary duplicated structure definitions for
> CPUID.1FH because when the structure definitions for CPUID.0BH can be
> used for CPUID.1FH.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni 
> Cc: Eric Dong 
> Cc: Star Zeng 
> Cc: Zhiqiang Qin 
> ---
>  UefiCpuPkg/Application/Cpuid/Cpuid.c |  24 ++---
> UefiCpuPkg/Include/Register/Cpuid.h  | 126 ++-
>  2 files changed, 20 insertions(+), 130 deletions(-)
> 
> diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c
> b/UefiCpuPkg/Application/Cpuid/Cpuid.c
> index 67cacf2714..d229ac8e7b 100644
> --- a/UefiCpuPkg/Application/Cpuid/Cpuid.c
> +++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c
> @@ -1,7 +1,7 @@
>  /** @file
>UEFI Application to display CPUID leaf information.
> 
> -  Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
> +  Copyright (c) 2016 - 2019, Intel Corporation. All rights
> + reserved.
>This program and the accompanying materials
>are licensed and made available under the terms and conditions of the BSD
> License
>which accompanies this distribution.  The full text of the license may be
> found at @@ -1394,26 +1394,26 @@ CpuidV2ExtendedTopologyEnumeration
> (
>VOID
>)
>  {
> -  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EAX  Eax;
> -  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EBX  Ebx;
> -  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_ECX  Ecx;
> -  UINT32  Edx;
> +  CPUID_EXTENDED_TOPOLOGY_EAX  Eax;
> +  CPUID_EXTENDED_TOPOLOGY_EBX  Ebx;
> +  CPUID_EXTENDED_TOPOLOGY_ECX  Ecx;
> +  UINT32   Edx;
> 
> -  if (CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION >
> gMaximumBasicFunction) {
> +  if (CPUID_V2_EXTENDED_TOPOLOGY > gMaximumBasicFunction) {
>  return;
>}
> 
>AsmCpuidEx (
> -CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION,
> -CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF,
> +CPUID_V2_EXTENDED_TOPOLOGY,
> +0,
>  &Eax.Uint32, &Ebx.Uint32, &Ecx.Uint32, &Edx
>  );
> -  Print (L"CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION (Leaf %08x,
> Sub-Leaf %08x)\n", CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION,
> CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF);
> +  Print (L"CPUID_V2_EXTENDED_TOPOLOGY (Leaf %08x, Sub-Leaf %08x)\n",
> + CPUID_V2_EXTENDED_TOPOLOGY, 0);
>Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32,
> Ebx.Uint32, Ecx.Uint32, Edx);
> 
> -  PRINT_BIT_FIELD (Eax, BitsNum);
> -  PRINT_BIT_FIELD (Ebx, ProcessorsNum);
> -  PRINT_BIT_FIELD (Ecx, LevelNum);
> +  PRINT_BIT_FIELD (Eax, ApicIdShift);
> +  PRINT_BIT_FIELD (Ebx, LogicalProcessors);  PRINT_BIT_FIELD (Ecx,
> + LevelNumber);
>PRINT_BIT_FIELD (Ecx, LevelType);
>PRINT_VALUE (Edx, x2APICID);
>  }
> diff --git a/UefiCpuPkg/Include/Register/Cpuid.h
> b/UefiCpuPkg/Include/Register/Cpuid.h
> index fab199b6e2..e0f4f968f4 100644
> --- a/UefiCpuPkg/Include/Register/Cpuid.h
> +++ b/UefiCpuPkg/Include/Register/Cpuid.h
> @@ -6,7 +6,7 @@
>If a register returned is a single 32-bit value, then a data structure is
>not provided for that register.
> 
> -  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
> +  Copyright (c) 2015 - 2019, Intel Corporation. All rights
> + reserved.
>This program and the accompanying materials are licensed and made
> available under
>the terms and conditions of the BSD License which accompanies this
> distribution.
>The full text of the license may be found at @@ -3620,130 +3620,20 @@
> typedef union {
>number of logical processors available to BIOS/OS/Applications may be
> different from the
>value of EBX[15:0], depending on software and platform hardware
> configurations.
> 
> -  @param   EAX  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION
> (0x1F)
> -  @param   ECX
> CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF  (0x0)
> -
> -**/
> -#define CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION
> 0x1F
> -
> -/**
> -  CPUID V2 Extended Topology Enumeration Leaf
> -
> -  @param   EAX  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION
> (0x1F)
> -  @param   ECX
> CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF (0x00)
> -
> -  @retval  EAX  Returns V2 Extended Topology Enumeration Leaf described
> by
> -the type CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EAX.
> -  @retval  EBX  Returns V2 Extended Topology Enumeration Leaf described
> by
> -the type CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EBX.
> -  @retval  ECX  Returns V2 Extended Topology Enumeration Leaf described
> by
> -the type C

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/Cpuid: Dump leaf 1FH information correctly

[Dong, Eric]

Reviewed-by: Eric Dong 

> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Thursday, April 4, 2019 2:03 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Zeng, Star ; Qin,
> Zhiqiang 
> Subject: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/Cpuid: Dump leaf 1FH
> information correctly
> 
> Leaf 1FH is very similar to leaf 0BH. Both return the CPU topology 
> information.
> Leaf 0BH returns 3-level (Package/Core/Thread) CPU topology info.
> Leaf 1FH returns 6-level (Package/Die/Tile/Module/Core/Thread) CPU
> topology info.
> The logic to enumerate the topology info is the same.
> 
> But today's logic to handle 1FH is completely wrong.
> The patch combines them together to fix the 1FH issue.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ray Ni 
> Cc: Eric Dong 
> Cc: Star Zeng 
> Cc: Zhiqiang Qin 
> ---
>  UefiCpuPkg/Application/Cpuid/Cpuid.c | 72 +---
>  1 file changed, 23 insertions(+), 49 deletions(-)
> 
> diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c
> b/UefiCpuPkg/Application/Cpuid/Cpuid.c
> index d229ac8e7b..30d43e9631 100644
> --- a/UefiCpuPkg/Application/Cpuid/Cpuid.c
> +++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c
> @@ -717,7 +717,7 @@ CpuidArchitecturalPerformanceMonitoring (  **/
> VOID  CpuidExtendedTopology (
> -  VOID
> +  UINT32   LeafFunction
>)
>  {
>CPUID_EXTENDED_TOPOLOGY_EAX  Eax;
> @@ -726,27 +726,34 @@ CpuidExtendedTopology (
>UINT32   Edx;
>UINT32   LevelNumber;
> 
> -  if (CPUID_EXTENDED_TOPOLOGY > gMaximumBasicFunction) {
> +  if (LeafFunction > gMaximumBasicFunction) {
> +return;
> +  }
> +  if ((LeafFunction != CPUID_EXTENDED_TOPOLOGY) && (LeafFunction !=
> + CPUID_V2_EXTENDED_TOPOLOGY)) {
>  return;
>}
> 
>LevelNumber = 0;
> -  do {
> +  for (LevelNumber = 0; ; LevelNumber++) {
>  AsmCpuidEx (
> -  CPUID_EXTENDED_TOPOLOGY, LevelNumber,
> +  LeafFunction, LevelNumber,
>&Eax.Uint32, &Ebx.Uint32, &Ecx.Uint32, &Edx
>);
> -if (Eax.Bits.ApicIdShift != 0) {
> -  Print (L"CPUID_EXTENDED_TOPOLOGY (Leaf %08x, Sub-Leaf %08x)\n",
> CPUID_EXTENDED_TOPOLOGY, LevelNumber);
> -  Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32,
> Ebx.Uint32, Ecx.Uint32, Edx);
> -  PRINT_BIT_FIELD (Eax, ApicIdShift);
> -  PRINT_BIT_FIELD (Ebx, LogicalProcessors);
> -  PRINT_BIT_FIELD (Ecx, LevelNumber);
> -  PRINT_BIT_FIELD (Ecx, LevelType);
> -  PRINT_VALUE (Edx, x2APIC_ID);
> +if (Ecx.Bits.LevelType ==
> CPUID_EXTENDED_TOPOLOGY_LEVEL_TYPE_INVALID) {
> +  break;
>  }
> -LevelNumber++;
> -  } while (Eax.Bits.ApicIdShift != 0);
> +Print (
> +  L"%a (Leaf %08x, Sub-Leaf %08x)\n",
> +  LeafFunction == CPUID_EXTENDED_TOPOLOGY ?
> "CPUID_EXTENDED_TOPOLOGY" : "CPUID_V2_EXTENDED_TOPOLOGY",
> +  LeafFunction, LevelNumber
> +  );
> +Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32,
> Ebx.Uint32, Ecx.Uint32, Edx);
> +PRINT_BIT_FIELD (Eax, ApicIdShift);
> +PRINT_BIT_FIELD (Ebx, LogicalProcessors);
> +PRINT_BIT_FIELD (Ecx, LevelNumber);
> +PRINT_BIT_FIELD (Ecx, LevelType);
> +PRINT_VALUE (Edx, x2APIC_ID);
> +  }
>  }
> 
>  /**
> @@ -1385,39 +1392,6 @@ CpuidDeterministicAddressTranslationParameters
> (
>PRINT_BIT_FIELD (Edx, MaximumNum);
>  }
> 
> -/**
> -  Display CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION main leaf and
> sub-leafs.
> -
> -**/
> -VOID
> -CpuidV2ExtendedTopologyEnumeration (
> -  VOID
> -  )
> -{
> -  CPUID_EXTENDED_TOPOLOGY_EAX  Eax;
> -  CPUID_EXTENDED_TOPOLOGY_EBX  Ebx;
> -  CPUID_EXTENDED_TOPOLOGY_ECX  Ecx;
> -  UINT32   Edx;
> -
> -  if (CPUID_V2_EXTENDED_TOPOLOGY > gMaximumBasicFunction) {
> -return;
> -  }
> -
> -  AsmCpuidEx (
> -CPUID_V2_EXTENDED_TOPOLOGY,
> -0,
> -&Eax.Uint32, &Ebx.Uint32, &Ecx.Uint32, &Edx
> -);
> -  Print (L"CPUID_V2_EXTENDED_TOPOLOGY (Leaf %08x, Sub-Leaf %08x)\n",
> CPUID_V2_EXTENDED_TOPOLOGY, 0);
> -  Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32,
> Ebx.Uint32, Ecx.Uint32, Edx);
> -
> -  PRINT_BIT_FIELD (Eax, ApicIdShift);
> -  PRINT_BIT_FIELD (Ebx, LogicalProcessors);
> -  PRINT_BIT_FIELD (Ecx, LevelNumber);
> -  PRINT_BIT_FIELD (Ecx, LevelType);
> -  PRINT_VALUE (Edx, x2APICID);
> -}
> -
>  /**
>Display CPUID_EXTENDED_FUNCTION leaf.
> 
> @@ -1619,7 +1593,7 @@ UefiMain (
>CpuidStructuredExtendedFeatureFlags ();
>CpuidDirectCacheAccessInfo();
>CpuidArchitecturalPerformanceMonitoring ();
> -  CpuidExtendedTopology ();
> +  CpuidExtendedTopology (CPUID_EXTENDED_TOPOLOGY);
>CpuidExtendedStateMainLeaf ();
>CpuidIntelRdtMonitoringEnumerationSubLeaf ();
>CpuidIntelRdtMonitoringL3CacheCapabilitySubLeaf (); @@ -1630,7 +1604,7
> @@ UefiMain (
>CpuidProcessorFrequency ();
>CpuidSocVendor ();
>CpuidDeterministicAddressTranslat

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg/Cpuid: Dump leaf 1FH information correctly

[Ni, Ray]

Leaf 1FH is very similar to leaf 0BH. Both return the CPU topology
information.
Leaf 0BH returns 3-level (Package/Core/Thread) CPU topology info.
Leaf 1FH returns 6-level (Package/Die/Tile/Module/Core/Thread) CPU
topology info.
The logic to enumerate the topology info is the same.

But today's logic to handle 1FH is completely wrong.
The patch combines them together to fix the 1FH issue.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ray Ni 
Cc: Eric Dong 
Cc: Star Zeng 
Cc: Zhiqiang Qin 
---
 UefiCpuPkg/Application/Cpuid/Cpuid.c | 72 +---
 1 file changed, 23 insertions(+), 49 deletions(-)

diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c 
b/UefiCpuPkg/Application/Cpuid/Cpuid.c
index d229ac8e7b..30d43e9631 100644
--- a/UefiCpuPkg/Application/Cpuid/Cpuid.c
+++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c
@@ -717,7 +717,7 @@ CpuidArchitecturalPerformanceMonitoring (
 **/
 VOID
 CpuidExtendedTopology (
-  VOID
+  UINT32   LeafFunction
   )
 {
   CPUID_EXTENDED_TOPOLOGY_EAX  Eax;
@@ -726,27 +726,34 @@ CpuidExtendedTopology (
   UINT32   Edx;
   UINT32   LevelNumber;
 
-  if (CPUID_EXTENDED_TOPOLOGY > gMaximumBasicFunction) {
+  if (LeafFunction > gMaximumBasicFunction) {
+return;
+  }
+  if ((LeafFunction != CPUID_EXTENDED_TOPOLOGY) && (LeafFunction != 
CPUID_V2_EXTENDED_TOPOLOGY)) {
 return;
   }
 
   LevelNumber = 0;
-  do {
+  for (LevelNumber = 0; ; LevelNumber++) {
 AsmCpuidEx (
-  CPUID_EXTENDED_TOPOLOGY, LevelNumber,
+  LeafFunction, LevelNumber,
   &Eax.Uint32, &Ebx.Uint32, &Ecx.Uint32, &Edx
   );
-if (Eax.Bits.ApicIdShift != 0) {
-  Print (L"CPUID_EXTENDED_TOPOLOGY (Leaf %08x, Sub-Leaf %08x)\n", 
CPUID_EXTENDED_TOPOLOGY, LevelNumber);
-  Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32, 
Ebx.Uint32, Ecx.Uint32, Edx);
-  PRINT_BIT_FIELD (Eax, ApicIdShift);
-  PRINT_BIT_FIELD (Ebx, LogicalProcessors);
-  PRINT_BIT_FIELD (Ecx, LevelNumber);
-  PRINT_BIT_FIELD (Ecx, LevelType);
-  PRINT_VALUE (Edx, x2APIC_ID);
+if (Ecx.Bits.LevelType == CPUID_EXTENDED_TOPOLOGY_LEVEL_TYPE_INVALID) {
+  break;
 }
-LevelNumber++;
-  } while (Eax.Bits.ApicIdShift != 0);
+Print (
+  L"%a (Leaf %08x, Sub-Leaf %08x)\n",
+  LeafFunction == CPUID_EXTENDED_TOPOLOGY ? "CPUID_EXTENDED_TOPOLOGY" : 
"CPUID_V2_EXTENDED_TOPOLOGY",
+  LeafFunction, LevelNumber
+  );
+Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32, 
Ebx.Uint32, Ecx.Uint32, Edx);
+PRINT_BIT_FIELD (Eax, ApicIdShift);
+PRINT_BIT_FIELD (Ebx, LogicalProcessors);
+PRINT_BIT_FIELD (Ecx, LevelNumber);
+PRINT_BIT_FIELD (Ecx, LevelType);
+PRINT_VALUE (Edx, x2APIC_ID);
+  }
 }
 
 /**
@@ -1385,39 +1392,6 @@ CpuidDeterministicAddressTranslationParameters (
   PRINT_BIT_FIELD (Edx, MaximumNum);
 }
 
-/**
-  Display CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION main leaf and sub-leafs.
-
-**/
-VOID
-CpuidV2ExtendedTopologyEnumeration (
-  VOID
-  )
-{
-  CPUID_EXTENDED_TOPOLOGY_EAX  Eax;
-  CPUID_EXTENDED_TOPOLOGY_EBX  Ebx;
-  CPUID_EXTENDED_TOPOLOGY_ECX  Ecx;
-  UINT32   Edx;
-
-  if (CPUID_V2_EXTENDED_TOPOLOGY > gMaximumBasicFunction) {
-return;
-  }
-
-  AsmCpuidEx (
-CPUID_V2_EXTENDED_TOPOLOGY,
-0,
-&Eax.Uint32, &Ebx.Uint32, &Ecx.Uint32, &Edx
-);
-  Print (L"CPUID_V2_EXTENDED_TOPOLOGY (Leaf %08x, Sub-Leaf %08x)\n", 
CPUID_V2_EXTENDED_TOPOLOGY, 0);
-  Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32, 
Ebx.Uint32, Ecx.Uint32, Edx);
-
-  PRINT_BIT_FIELD (Eax, ApicIdShift);
-  PRINT_BIT_FIELD (Ebx, LogicalProcessors);
-  PRINT_BIT_FIELD (Ecx, LevelNumber);
-  PRINT_BIT_FIELD (Ecx, LevelType);
-  PRINT_VALUE (Edx, x2APICID);
-}
-
 /**
   Display CPUID_EXTENDED_FUNCTION leaf.
 
@@ -1619,7 +1593,7 @@ UefiMain (
   CpuidStructuredExtendedFeatureFlags ();
   CpuidDirectCacheAccessInfo();
   CpuidArchitecturalPerformanceMonitoring ();
-  CpuidExtendedTopology ();
+  CpuidExtendedTopology (CPUID_EXTENDED_TOPOLOGY);
   CpuidExtendedStateMainLeaf ();
   CpuidIntelRdtMonitoringEnumerationSubLeaf ();
   CpuidIntelRdtMonitoringL3CacheCapabilitySubLeaf ();
@@ -1630,7 +1604,7 @@ UefiMain (
   CpuidProcessorFrequency ();
   CpuidSocVendor ();
   CpuidDeterministicAddressTranslationParameters ();
-  CpuidV2ExtendedTopologyEnumeration ();
+  CpuidExtendedTopology (CPUID_V2_EXTENDED_TOPOLOGY);
   CpuidExtendedFunction ();
   CpuidExtendedCpuSig ();
   CpuidProcessorBrandString ();
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#37): https://edk2.groups.io/g/devel/message/37
Mute This Topic: https://groups.io/mt/30893914/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg/Cpuid.h: Remove duplicated struct definition for leaf 1FH

[Ni, Ray]

Per SDM CPUID.0BH and CPUID.1FH outputs the same format of data in
EAX/EBX/ECX/EDX except CPUID.1FH reports more level types such as
module, tile, die.

The patch removes the unnecessary duplicated structure definitions
for CPUID.1FH because when the structure definitions for CPUID.0BH
can be used for CPUID.1FH.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ray Ni 
Cc: Eric Dong 
Cc: Star Zeng 
Cc: Zhiqiang Qin 
---
 UefiCpuPkg/Application/Cpuid/Cpuid.c |  24 ++---
 UefiCpuPkg/Include/Register/Cpuid.h  | 126 ++-
 2 files changed, 20 insertions(+), 130 deletions(-)

diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c 
b/UefiCpuPkg/Application/Cpuid/Cpuid.c
index 67cacf2714..d229ac8e7b 100644
--- a/UefiCpuPkg/Application/Cpuid/Cpuid.c
+++ b/UefiCpuPkg/Application/Cpuid/Cpuid.c
@@ -1,7 +1,7 @@
 /** @file
   UEFI Application to display CPUID leaf information.
 
-  Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
+  Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD 
License
   which accompanies this distribution.  The full text of the license may be 
found at
@@ -1394,26 +1394,26 @@ CpuidV2ExtendedTopologyEnumeration (
   VOID
   )
 {
-  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EAX  Eax;
-  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EBX  Ebx;
-  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_ECX  Ecx;
-  UINT32  Edx;
+  CPUID_EXTENDED_TOPOLOGY_EAX  Eax;
+  CPUID_EXTENDED_TOPOLOGY_EBX  Ebx;
+  CPUID_EXTENDED_TOPOLOGY_ECX  Ecx;
+  UINT32   Edx;
 
-  if (CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION > gMaximumBasicFunction) {
+  if (CPUID_V2_EXTENDED_TOPOLOGY > gMaximumBasicFunction) {
 return;
   }
 
   AsmCpuidEx (
-CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION,
-CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF,
+CPUID_V2_EXTENDED_TOPOLOGY,
+0,
 &Eax.Uint32, &Ebx.Uint32, &Ecx.Uint32, &Edx
 );
-  Print (L"CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION (Leaf %08x, Sub-Leaf 
%08x)\n", CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION, 
CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF);
+  Print (L"CPUID_V2_EXTENDED_TOPOLOGY (Leaf %08x, Sub-Leaf %08x)\n", 
CPUID_V2_EXTENDED_TOPOLOGY, 0);
   Print (L"  EAX:%08x  EBX:%08x  ECX:%08x  EDX:%08x\n", Eax.Uint32, 
Ebx.Uint32, Ecx.Uint32, Edx);
 
-  PRINT_BIT_FIELD (Eax, BitsNum);
-  PRINT_BIT_FIELD (Ebx, ProcessorsNum);
-  PRINT_BIT_FIELD (Ecx, LevelNum);
+  PRINT_BIT_FIELD (Eax, ApicIdShift);
+  PRINT_BIT_FIELD (Ebx, LogicalProcessors);
+  PRINT_BIT_FIELD (Ecx, LevelNumber);
   PRINT_BIT_FIELD (Ecx, LevelType);
   PRINT_VALUE (Edx, x2APICID);
 }
diff --git a/UefiCpuPkg/Include/Register/Cpuid.h 
b/UefiCpuPkg/Include/Register/Cpuid.h
index fab199b6e2..e0f4f968f4 100644
--- a/UefiCpuPkg/Include/Register/Cpuid.h
+++ b/UefiCpuPkg/Include/Register/Cpuid.h
@@ -6,7 +6,7 @@
   If a register returned is a single 32-bit value, then a data structure is
   not provided for that register.
 
-  Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
+  Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
   This program and the accompanying materials are licensed and made available 
under
   the terms and conditions of the BSD License which accompanies this 
distribution.
   The full text of the license may be found at
@@ -3620,130 +3620,20 @@ typedef union {
   number of logical processors available to BIOS/OS/Applications may be 
different from the
   value of EBX[15:0], depending on software and platform hardware 
configurations.
 
-  @param   EAX  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION(0x1F)
-  @param   ECX  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF  (0x0)
-
-**/
-#define CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION 0x1F
-
-/**
-  CPUID V2 Extended Topology Enumeration Leaf
-
-  @param   EAX  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION   (0x1F)
-  @param   ECX  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_MAIN_LEAF (0x00)
-
-  @retval  EAX  Returns V2 Extended Topology Enumeration Leaf described by
-the type CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EAX.
-  @retval  EBX  Returns V2 Extended Topology Enumeration Leaf described by
-the type CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EBX.
-  @retval  ECX  Returns V2 Extended Topology Enumeration Leaf described by
-the type CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_ECX.
-  @retval  EDX  Returns x2APIC ID the current logical processor.
-
-  Example usage
-  @code
-  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EAX Eax;
-  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_EBX Ebx;
-  CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_ECX Ecx;
-  UINT32 Edx;
-
-  AsmCpuidEx (
-CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION,
-CPUID_V2_EXTENDED_TOPOLOGY_ENUMERATION_

[edk2-devel] [PATCH v2 0/2] Dump CPUID.1FH information correctly

[Ni, Ray]

v2: Removes the duplicated structure definitions introduced for leaf
1FH.

Ray Ni (2):
  UefiCpuPkg/Cpuid.h: Remove duplicated struct definition for leaf 1FH
  UefiCpuPkg/Cpuid: Dump leaf 1FH information correctly

 UefiCpuPkg/Application/Cpuid/Cpuid.c |  74 +---
 UefiCpuPkg/Include/Register/Cpuid.h  | 126 ++-
 2 files changed, 32 insertions(+), 168 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#36): https://edk2.groups.io/g/devel/message/36
Mute This Topic: https://groups.io/mt/30893913/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

[Wu, Hao A]

For KabylakeRvp3, it is using the HPET timer unconditionally. The PCD
'PcdUseHpetTimer' is not being used.

This commit will remove the usage of the above PCD in package DSC files.

Cc: Chasel Chiu 
Cc: Michael Kubacki 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc 
b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc
index bb06ff5a2a..f3d082ce41 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Platform configuration file.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
 #
 # This program and the accompanying materials are licensed and made available 
under
 # the terms and conditions of the BSD License which accompanies this 
distribution.
@@ -111,7 +111,6 @@ [PcdsFeatureFlag]
   gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE
-  gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE   # TRUE - 
HPET / FALSE - 8254 timer is used.
   gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE
 
-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#32): https://edk2.groups.io/g/devel/message/32
Mute This Topic: https://groups.io/mt/30893896/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 1/6] ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer'

[Wu, Hao A]

For N1xxWU, it is using the HPET timer unconditionally. The PCD
'PcdUseHpetTimer' is not being used.

This commit will remove the usage of the above PCD in package DSC files.

Cc: Michael Kubacki 
Cc: Ankit Sinha 
Cc: Nate DeSimone 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc 
b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
index b4b4763a36..2f7d386469 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
@@ -107,7 +107,6 @@ [PcdsFeatureFlag]
   gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE
-  gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE   # TRUE - 
HPET / FALSE - 8254 timer is used.
   gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE
 
-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#30): https://edk2.groups.io/g/devel/message/30
Mute This Topic: https://groups.io/mt/30893894/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

[Wu, Hao A]

For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of them
are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is not
being used.

This commit will remove the above PCD within KabylakeSiliconPkg.

Cc: Chasel Chiu 
Cc: Michael A Kubacki 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec  | 3 +--
 Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec 
b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
index 92b6d492ee..cca1a2e60d 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
+++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
@@ -1,7 +1,7 @@
 ## @file
 # Component description file for the Silicon Reference Code.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
 #
 # This program and the accompanying materials are licensed and made available 
under
 # the terms and conditions of the BSD License which accompanies this 
distribution.
@@ -592,7 +592,6 @@ [PcdsFeatureFlag]
 gSiPkgTokenSpaceGuid.PcdSerialGpioEnable |FALSE|BOOLEAN|0xF003
 gSiPkgTokenSpaceGuid.PcdAtaEnable|FALSE|BOOLEAN|0xF004
 gSiPkgTokenSpaceGuid.PcdSiCsmEnable  |FALSE|BOOLEAN|0xF005
-gSiPkgTokenSpaceGuid.PcdUseHpetTimer |FALSE|BOOLEAN|0xF006
 gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE |BOOLEAN|0xF008
 gSiPkgTokenSpaceGuid.PcdAcpiEnable   |TRUE |BOOLEAN|0xF009
 gSiPkgTokenSpaceGuid.PcdSourceDebugEnable|FALSE|BOOLEAN|0xF00B
diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc 
b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
index 7189ce6396..cbb2a8bec4 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
+++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Component description file for the SkyLake SiPkg DSC file.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
 #
 # This program and the accompanying materials are licensed and made available 
under
 # the terms and conditions of the BSD License which accompanies this 
distribution.
@@ -19,7 +19,6 @@ [PcdsFeatureFlag]
 gSiPkgTokenSpaceGuid.PcdSerialGpioEnable |FALSE
 gSiPkgTokenSpaceGuid.PcdAtaEnable|FALSE
 gSiPkgTokenSpaceGuid.PcdSiCsmEnable  |FALSE
-gSiPkgTokenSpaceGuid.PcdUseHpetTimer |FALSE
 gSiPkgTokenSpaceGuid.PcdSgEnable |TRUE
 gSiPkgTokenSpaceGuid.PcdAcpiEnable   |FALSE
 gSiPkgTokenSpaceGuid.PcdSourceDebugEnable|FALSE
-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#34): https://edk2.groups.io/g/devel/message/34
Mute This Topic: https://groups.io/mt/30893898/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD

[Wu, Hao A]

For KabylakeRvp3, none of its consumed modules is using the PCD:
gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask

Thus, this commit will remove the PCD consumption in the DSC file.

Cc: Chasel Chiu 
Cc: Michael Kubacki 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git 
a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc 
b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
index 35f383ecef..51d4e2ea46 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Platform description.
 #
-# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
 #
 # This program and the accompanying materials are licensed and made available 
under
 # the terms and conditions of the BSD License which accompanies this 
distribution.
@@ -194,9 +194,6 @@ [PcdsFixedAtBuild.IA32]
   gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x380
 
 [PcdsFixedAtBuild.X64]
-  gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask|0x0eB8
-
-
   # Default platform supported RFC 4646 languages: (American) English
   gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
 
-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#33): https://edk2.groups.io/g/devel/message/33
Mute This Topic: https://groups.io/mt/30893897/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg

[Wu, Hao A]

The series will do the below cleanups for platforms under
ClevoOpenBoardPkg and KabylakeOpenBoardPkg:

A) Remove unused PCD 'PcdUseHpetTimer';
B) Remove the unnecessary consumption of the 8259-related PCDs;
C) Remove the unused duplicated Legacy8259 protocol GUID.


Test done for the series:
Build pass for N1xxWU & KabyLakeRvp3 platforms.

Cc: Michael A Kubacki 
Cc: Chasel Chiu 
Cc: Ankit Sinha 
Cc: Nate DeSimone 

Hao Wu (6):
  ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer'
  ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD
  KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
  KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD
  KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'
  KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

 Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec  | 4 
+---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc  | 1 -
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc | 2 --
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc | 3 +--
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc| 5 
+
 Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +--
 6 files changed, 4 insertions(+), 14 deletions(-)

-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#29): https://edk2.groups.io/g/devel/message/29
Mute This Topic: https://groups.io/mt/30893893/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

[Wu, Hao A]

For modules consumed by platforms within KabylakeOpenBoardPkg &
ClevoOpenBoardPkg, none of them has the dependency on the Legacy8259
protocol. Thus, this commit will remove the duplicated Legacy8259 protocol
GUID within file SiPkg.dec.

Cc: Chasel Chiu 
Cc: Michael A Kubacki 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec 
b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
index cca1a2e60d..078d10c520 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
+++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
@@ -268,7 +268,6 @@ [Protocols]
 ##
 gEfiLegacyBiosProtocolGuid  =  {0xdb9a1e3d, 0x45cb, 0x4abb, {0x85, 0x3b, 0xe5, 
0x38, 0x7f, 0xdb, 0x2e, 0x2d}}
 gEfiLegacyInterruptProtocolGuid  =  {0x31ce593d, 0x108a, 0x485d, {0xad, 0xb2, 
0x78, 0xf2, 0x1f, 0x29, 0x66, 0xbe}}
-gEfiLegacy8259ProtocolGuid  =  {0x38321dba, 0x4fe0, 0x4e17, {0x8a, 0xec, 0x41, 
0x30, 0x55, 0xea, 0xed, 0xc1}}
 gEfiDataHubProtocolGuid  =  {0xae80d021, 0x618e, 0x11d4, {0xbc, 0xd7, 0x00, 
0x80, 0xc7, 0x3c, 0x88, 0x81}}
 ##
 ## MdeModulePkg
-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#35): https://edk2.groups.io/g/devel/message/35
Mute This Topic: https://groups.io/mt/30893899/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 2/6] ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD

[Wu, Hao A]

For N1xxWU, none of its consumed modules is using the PCD:
gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask

Thus, this commit will remove the PCD consumption in the DSC file.

Cc: Michael Kubacki 
Cc: Ankit Sinha 
Cc: Nate DeSimone 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu 
---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc 
b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
index bcb5ed98b4..1372dd81fc 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
@@ -187,8 +187,6 @@ [PcdsFixedAtBuild.IA32]
   gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x380
 
 [PcdsFixedAtBuild.X64]
-  gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask|0x0eB8
-
   # Default platform supported RFC 4646 languages: (American) English
   gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
 
-- 
2.12.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#31): https://edk2.groups.io/g/devel/message/31
Mute This Topic: https://groups.io/mt/30893895/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

[Andrew Fish via Groups.Io]

> On Apr 3, 2019, at 8:42 PM, Ni, Ray  wrote:
> 
> Mike, Laszlo,
> It's a good idea to store the shell binaries into the assets of each stable 
> tag.
> 
> If we go in this way, it means "build" requires network connection to 
> download the
> shell binary from the assets of a certain release.
> Do you think it's acceptable?
> 

Ray,

The other option would be to have a configuration step, like installing Python 
or the C compilers, that copies the binary. You need a network connection to 
clone the git repo and to stay in sync with it. I guess you could model that as 
a git submodule, or actually have a script that grabs the binary you want from 
a remote system, and fall back to the local copy if you don't have a network 
connection. 


> Or we can separate the binary download and build into two phases so build 
> phase
> can be independent on network connection.
> 
> Is there any known practice/solution for such requirement (stable 
> sub-component binaries
> needed by a production image generation)?
> 

I think to some extent this kind of thing is driven by the customers build 
rules. Basically what the customer think of as their manifest of parts for 
software version X.

 It might be possible for a build script to do something like this to just grab 
a specific version of the EFI Shell. I guess HEAD could really come from the 
manifest of what version you want, and the initial setup could run this command 
to make sure a backup version of Shell.efi is present in case the network is 
not present. 
git archive --remote=ssh://host/pathto/repo.git HEAD Shell.efi

I'm sure an organization building something as complex as an OS probably has 
custom tools to deal with the manifest, but we can probably do something simple 
with a script/makefile. 

Thanks,
 
Andrew Fish


> Thanks,
> Ray
> 
>> -Original Message-
>> From: Kinney, Michael D > >
>> Sent: Thursday, April 4, 2019 5:47 AM
>> To: Laszlo Ersek mailto:ler...@redhat.com>>; Ni, Ray 
>> mailto:ray...@intel.com>>; Bi,
>> Dandan mailto:dandan...@intel.com>>; 
>> devel@edk2.groups.io ; Kinney, Michael D
>> mailto:michael.d.kin...@intel.com>>
>> Cc: Cetola, Stephano > >; Gao, Liming
>> mailto:liming@intel.com>>; Carsey, Jaben 
>> mailto:jaben.car...@intel.com>>
>> Subject: RE: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master
>> 
>> Laszlo,
>> 
>> A PREBUILD action looks like a good idea.
>> 
>> Release artifacts in GitHub are available as an http link, so a python 
>> script to
>> download into a path in the build output directory and referenced by
>> DSC/FDF should work.
>> 
>> We could even post shell binaries for the past couple edk2-stable tags
>> because release content can be updated.
>> 
>> Mike
>> 
>>> -Original Message-
>>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>>> Sent: Wednesday, April 3, 2019 9:07 AM
>>> To: Kinney, Michael D ; Ni, Ray
>>> ; Bi, Dandan ;
>>> edk2-de...@lists.01.org
>>> Cc: Cetola, Stephano ; Gao, Liming
>>> ; Carsey, Jaben 
>>> Subject: Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master
>>> 
>>> On 04/03/19 17:49, Kinney, Michael D wrote:
 Laszlo,
 
 I think it makes sense to post validated shell
>>> binaries
 with the edk2-stable tag releases.  GitHub does
>>> support
 this when a release tag is made.
 
 However, we would need to make it simple for a
>>> platform
 to use a binary from that location.  We may need some enhancements
 to pull in binary artifacts from
>>> different
 locations to support a platform build that uses one
>>> or
 more pre-built binaries.
>>> 
>>> Can PREBUILD scripts (written by platform owners) download the
>>> required binaries?
>>> 
>>> Thanks,
>>> Laszlo
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#28): https://edk2.groups.io/g/devel/message/28
Mute This Topic: https://groups.io/mt/30886118/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [RFC PATCH v1 0/8] Duplicate 8259/8254 components in OvmfPkg

[Wu, Hao A]

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 03, 2019 9:01 PM
> To: Wu, Hao A; edk2-de...@lists.01.org
> Cc: Justen, Jordan L; David Woodhouse
> Subject: Re: [edk2] [RFC PATCH v1 0/8] Duplicate 8259/8254 components in
> OvmfPkg
> 
> On 04/03/19 14:13, Laszlo Ersek wrote:
> > On 04/03/19 14:10, Laszlo Ersek wrote:
> >> On 04/03/19 09:00, Hao Wu wrote:
> >>> This series is also available at:
> >>> https://github.com/hwu25/edk2/tree/ovmf_8259_8254_rfcv1
> >>>
> >>>
> >>> As a sub-task to remove the IntelFrameworkPkg (BZ-1604),
> >>>
> >>> 8259InterruptControllerDxe driver (PcAtChipsetPkg)
> >>> Legacy8259 protocol (IntelFrameworkPkg)
> >>> 8254TimerDxe driver (PcAtChipsetPkg)
> >>>
> >>> will be removed in the near future. Meanwhile, OVMF will still require
> >>> those components (due to CSM support & HPET emulation stability
> concern).
> >>>
> >>> Thus, the series will copy the below 8259/8254 components:
> >>>
> >>> A. 8259InterruptControllerDxe driver (PcAtChipsetPkg)
> >>> B. Two 8259 related PCDs (PcAtChipsetPkg)
> >>> C. Legacy8259 protocol (IntelFrameworkPkg)
> >>> D. 8254TimerDxe driver (PcAtChipsetPkg)
> >>>
> >>> in the OvmfPkg to address the above-mentioned issue.
> >>>
> >>>
> >>> Tests done for the proposed series:
> >>>
> >>> A. OvmfPkg build pass for VS2015 & GCC5 tool chains;
> >>> B. Boot to Shell with commands:
> >>>   qemu-system-x86_64.exe -pflash \OVMF.fd -debugcon
> file:boot.log -global isa-debugcon.iobase=0x402
> >>>   qemu-system-x86_64.exe -machine q35 -pflash
> \OVMF.fd -debugcon file:boot.log -global isa-
> debugcon.iobase=0x402
> >>> C. 'stall X' command under Shell to verify the timer is working properly.
> >>>
> >>>
> >>> (Please note that there will be a subsequent patch to remove the
> 8259/8254
> >>> components after platforms dropping the dependencies on them.)
> >>>
> >>> Cc: Jordan Justen 
> >>> Cc: Laszlo Ersek 
> >>> Cc: Ard Biesheuvel 
> >>> Cc: David Woodhouse 
> >>> Cc: Ray Ni 
> >>>
> >>>
> >>> Hao Wu (8):
> >>>   OvmfPkg: Copy 8259InterruptControllerDxe driver from PcAtChipsetPkg
> >>>   OvmfPkg: Copy Legacy8259 protocol definitions from
> IntelFrameworkPkg
> >>>   OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file
> >>>   OvmfPkg/8259InterruptControllerDxe: Update to make it build for
> OVMF
> >>>   OvmfPkg/AcpiPlatformDxe: Consume the 8259 PCD defined in OvmfPkg
> >>>   OvmfPkg: Copy 8254TimerDxe driver from PcAtChipsetPkg
> >>>   OvmfPkg/8254TimerDxe: Update to make it build for OVMF
> >>>   OvmfPkg: Update DSC/FDF files to consume 8259/8254 drivers in
> OvmfPkg
> >>
> >> While I'm reviewing the patches individually, let me make some general
> >> comments:
> >>
> >> - please don't push the series before April 9th (i.e., before the end of
> >> the file addition/removal freeze due to
> >> )
> >>
> >> - if/when you push the series, please make sure that *all* files added
> >> (copied) under OvmfPkg get the new license block format, i.e. the SPDX
> >> license identifier only.

Hello Laszlo,

Actually, I plan to send out another version of the series right after the
file add/remove freeze. If no new comments at that time, I will push the
changes then.

> >
> > ... in fact, at that time, the license blocks under the *source*
> > packages (PcAtChipsetPkg and IntelFrameworkPkg) will have been
> updated,
> > so you will have to redo the copying steps anyway (and you can verify
> > those on your end: "git show --find-copies-harder" should show now
> > modifications as part of the copy operations).
> 
> Sigh. I meant
> 
>   "git show --find-copies-harder" should show *no* modifications as part
>   of the copy operations

I will ensure this before sending out the new series.

Best Regards,
Hao Wu

> 
> Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#27): https://edk2.groups.io/g/devel/message/27
Mute This Topic: https://groups.io/mt/30893371/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

[Ni, Ray]

Mike, Laszlo,
It's a good idea to store the shell binaries into the assets of each stable tag.

If we go in this way, it means "build" requires network connection to download 
the
shell binary from the assets of a certain release.
Do you think it's acceptable?

Or we can separate the binary download and build into two phases so build phase
can be independent on network connection.

Is there any known practice/solution for such requirement (stable sub-component 
binaries
needed by a production image generation)?

Thanks,
Ray

> -Original Message-
> From: Kinney, Michael D 
> Sent: Thursday, April 4, 2019 5:47 AM
> To: Laszlo Ersek ; Ni, Ray ; Bi,
> Dandan ; devel@edk2.groups.io; Kinney, Michael D
> 
> Cc: Cetola, Stephano ; Gao, Liming
> ; Carsey, Jaben 
> Subject: RE: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master
> 
> Laszlo,
> 
> A PREBUILD action looks like a good idea.
> 
> Release artifacts in GitHub are available as an http link, so a python script 
> to
> download into a path in the build output directory and referenced by
> DSC/FDF should work.
> 
> We could even post shell binaries for the past couple edk2-stable tags
> because release content can be updated.
> 
> Mike
> 
> > -Original Message-
> > From: Laszlo Ersek [mailto:ler...@redhat.com]
> > Sent: Wednesday, April 3, 2019 9:07 AM
> > To: Kinney, Michael D ; Ni, Ray
> > ; Bi, Dandan ;
> > edk2-de...@lists.01.org
> > Cc: Cetola, Stephano ; Gao, Liming
> > ; Carsey, Jaben 
> > Subject: Re: [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master
> >
> > On 04/03/19 17:49, Kinney, Michael D wrote:
> > > Laszlo,
> > >
> > > I think it makes sense to post validated shell
> > binaries
> > > with the edk2-stable tag releases.  GitHub does
> > support
> > > this when a release tag is made.
> > >
> > > However, we would need to make it simple for a
> > platform
> > > to use a binary from that location.  We may need some enhancements
> > > to pull in binary artifacts from
> > different
> > > locations to support a platform build that uses one
> > or
> > > more pre-built binaries.
> >
> > Can PREBUILD scripts (written by platform owners) download the
> > required binaries?
> >
> > Thanks,
> > Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#26): https://edk2.groups.io/g/devel/message/26
Mute This Topic: https://groups.io/mt/30886118/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF

[Zhang, Shenglei]

A commit(50cb4b90311fa5353df921fce42de5ad188da658) has been pushed to fix the 
build failure.

Thanks,
Shenglei

> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, April 3, 2019 7:31 PM
> To: Zhang, Shenglei 
> Subject: RE: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S in INF
> 
> Do you check CI result?
> 
> > -Original Message-
> > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> shenglei
> > Sent: Wednesday, April 3, 2019 2:32 PM
> > To: edk2-de...@lists.01.org
> > Cc: Wu, Hao A 
> > Subject: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S in INF
> >
> > AsmFuncs.S is removed at c7d22535f7dc90b8fef70153ef98549228569680.
> > And also it should be removed in SecPeiDebugAgentLib.inf and
> > SmmDebugAgentLib.inf.
> >
> > Cc: Hao Wu 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang 
> > ---
> >  SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf | 2 -
> -
> >  SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf| 2 -
> -
> >  2 files changed, 4 deletions(-)
> >
> > diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > index 03ebbb6e74..8b81795d96 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >DebugAgentCommon/Ia32/AsmFuncs.nasm
> >DebugAgentCommon/Ia32/ArchDebugSupport.h
> >DebugAgentCommon/Ia32/ArchDebugSupport.c
> >DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >DebugAgentCommon/X64/AsmFuncs.nasm
> >DebugAgentCommon/X64/ArchDebugSupport.h
> >DebugAgentCommon/X64/ArchDebugSupport.c
> > diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > index 08ed1777be..f1b32daab3 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > +++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >DebugAgentCommon/Ia32/AsmFuncs.nasm
> >DebugAgentCommon/Ia32/ArchDebugSupport.h
> >DebugAgentCommon/Ia32/ArchDebugSupport.c
> >DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >DebugAgentCommon/X64/AsmFuncs.nasm
> >DebugAgentCommon/X64/ArchDebugSupport.h
> >DebugAgentCommon/X64/ArchDebugSupport.c
> > --
> > 2.18.0.windows.1
> >
> > ___
> > edk2-devel mailing list
> > edk2-de...@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#25): https://edk2.groups.io/g/devel/message/25
Mute This Topic: https://groups.io/mt/30893055/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [RFC PATCH v1 4/8] OvmfPkg/8259InterruptControllerDxe: Update to make it build for OVMF

[Wu, Hao A]

> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, April 03, 2019 8:47 PM
> To: Wu, Hao A; edk2-de...@lists.01.org
> Cc: Justen, Jordan L; David Woodhouse
> Subject: Re: [edk2] [RFC PATCH v1 4/8] OvmfPkg/8259InterruptControllerDxe:
> Update to make it build for OVMF
> 
> On 04/03/19 09:00, Hao Wu wrote:
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496
> >
> > Several updates have been made to the
> > OvmfPkg/8259InterruptControllerDxe driver to make it build under
> OvmfPkg:
> >
> > A) Update the driver INF file to consume PCDs defined within OvmfPkg;
> > B) Remove the unnecessary dependency on the IntelFrameworkPkg
> header file
> >'FrameworkDxe.h';
> > C) Remove the IntelFrameworkPkg & PcAtChipsetPkg DEC files
> dependency in
> >the driver INF file.
> >
> > A new GUID has been updated for the INF file.
> >
> > Corresponding changes have been made in OVMF DSC files as well in order
> to
> > verify the build.
> 
> (1) This patch is really well done, but we need an extra hint here, in
> the last paragraph of the commit message, namely that the DSC and FDF
> files will get a final update (= removals) later in this series.

Agree. I will update the log message to reflect this.

Best Regards,
Hao Wu

> 
> With that spelled out:
> 
> Reviewed-by: Laszlo Ersek 
> 
> Thanks
> Laszlo
> 
> >
> > Cc: Jordan Justen 
> > Cc: Laszlo Ersek 
> > Cc: Ard Biesheuvel 
> > Cc: David Woodhouse 
> > Cc: Ray Ni 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Hao Wu 
> > ---
> >  OvmfPkg/OvmfPkgIa32.dsc |  2 ++
> >  OvmfPkg/OvmfPkgIa32X64.dsc  |  2 ++
> >  OvmfPkg/OvmfPkgX64.dsc  |  2 ++
> >  OvmfPkg/8259InterruptControllerDxe/8259.inf | 11 +--
> >  OvmfPkg/8259InterruptControllerDxe/8259.h   |  4 +---
> >  5 files changed, 12 insertions(+), 9 deletions(-)
> >
> > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> > index f55ab5a3d2..47182f0cad 100644
> > --- a/OvmfPkg/OvmfPkgIa32.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32.dsc
> > @@ -517,6 +517,7 @@
> >
> ># IRQs 5, 9, 10, 11 are level-triggered
> >gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0E20
> > +  gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0E20
> >
> ># Point to the MdeModulePkg/Application/UiApp/UiApp.inf
> >gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21,
> 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66,
> 0x23, 0x31 }
> > @@ -669,6 +670,7 @@
> >
> >MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> >PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > +  OvmfPkg/8259InterruptControllerDxe/8259.inf
> >UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> >UefiCpuPkg/CpuDxe/CpuDxe.inf
> >PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc
> b/OvmfPkg/OvmfPkgIa32X64.dsc
> > index 5c9bdf034e..d9603a7107 100644
> > --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> > @@ -523,6 +523,7 @@
> >
> ># IRQs 5, 9, 10, 11 are level-triggered
> >gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0E20
> > +  gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0E20
> >
> ># Point to the MdeModulePkg/Application/UiApp/UiApp.inf
> >gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21,
> 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66,
> 0x23, 0x31 }
> > @@ -678,6 +679,7 @@
> >
> >MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> >PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > +  OvmfPkg/8259InterruptControllerDxe/8259.inf
> >UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> >UefiCpuPkg/CpuDxe/CpuDxe.inf
> >PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> > index 2943e9e8af..2cc39d54b0 100644
> > --- a/OvmfPkg/OvmfPkgX64.dsc
> > +++ b/OvmfPkg/OvmfPkgX64.dsc
> > @@ -522,6 +522,7 @@
> >
> ># IRQs 5, 9, 10, 11 are level-triggered
> >gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0E20
> > +  gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0E20
> >
> ># Point to the MdeModulePkg/Application/UiApp/UiApp.inf
> >gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21,
> 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66,
> 0x23, 0x31 }
> > @@ -676,6 +677,7 @@
> >
> >MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> >PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
> > +  OvmfPkg/8259InterruptControllerDxe/8259.inf
> >UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
> >UefiCpuPkg/CpuDxe/CpuDxe.inf
> >PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
> > diff --git a/OvmfPkg/8259InterruptControllerDxe/8259.inf
> b/OvmfPkg/8259InterruptControllerDxe/8259.inf
> > index 1d9be675e3..c5a1385418 100644
> > --- a/OvmfPkg/8259InterruptControllerDxe/8259.inf
> > +++ b/OvmfPkg/8259

Re: [edk2-devel] [edk2] [RFC PATCH v1 3/8] OvmfPkg/OvmfPkg.dec: Add 8259-related PCDs in OVMF DEC file

[Wu, Hao A]

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 03, 2019 8:39 PM
> To: Wu, Hao A; edk2-de...@lists.01.org
> Cc: Justen, Jordan L; David Woodhouse
> Subject: Re: [edk2] [RFC PATCH v1 3/8] OvmfPkg/OvmfPkg.dec: Add 8259-
> related PCDs in OVMF DEC file
> 
> On 04/03/19 09:00, Hao Wu wrote:
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496
> >
> > According to the DEC file in PcAtChipsetPkg, this commit adds the two
> > 8259-driver-related PCDs into the OvmfPkg DEC file.
> >
> > Cc: Jordan Justen 
> > Cc: Laszlo Ersek 
> > Cc: Ard Biesheuvel 
> > Cc: David Woodhouse 
> > Cc: Ray Ni 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Hao Wu 
> > ---
> >  OvmfPkg/OvmfPkg.dec | 26 
> >  1 file changed, 26 insertions(+)
> >
> > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> > index fb89ebf3ad..cb838422aa 100644
> > --- a/OvmfPkg/OvmfPkg.dec
> > +++ b/OvmfPkg/OvmfPkg.dec
> > @@ -128,6 +128,32 @@
> >
> gUefiOvmfPkgTokenSpaceGuid.PcdGuidedExtractHandlerTableSize|0x0|UIN
> T32|0x1a
> >
> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDecompressionScratchEnd|0x0|UI
> NT32|0x1f
> >
> > +  ## Pcd8259LegacyModeMask defines the default mask value for
> platform. This
> > +  #  value is determined.
> > +  #  1) If platform only support pure UEFI, value should be set to 0x 
> > or
> > +  # 0xFFFE; Because only clock interrupt is allowed in legacy mode in
> pure
> > +  # UEFI platform.
> > +  #  2) If platform install CSM and use thunk module:
> > +  # a) If thunk call provided by CSM binary requires some legacy
> interrupt
> > +  #support, the corresponding bit should be opened as 0.
> > +  #For example, if keyboard interfaces provided CSM binary use 
> > legacy
> > +  #keyboard interrupt in 8259 bit 1, then the value should be set 
> > to
> > +  #0xFFFC.
> > +  # b) If all thunk call provied by CSM binary do not require legacy
> > +  #interrupt support, value should be set to 0x or 0xFFFE.
> > +  #
> > +  #  The default value of legacy mode mask could be changed by
> > +  #  EFI_LEGACY_8259_PROTOCOL->SetMask(). But it is rarely need change
> it
> > +  #  except some special cases such as when initializing the CSM binary, it
> > +  #  should be set to 0x to mask all legacy interrupt. Please restore 
> > the
> > +  #  original legacy mask value if changing is made for these special case.
> > +
> gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeMask|0x|UINT16|
> 0x28
> > +
> > +  ## Pcd8259LegacyModeEdgeLevel defines the default edge level for
> legacy
> > +  #  mode's interrrupt controller.
> > +  #  For the corresponding bits, 0 = Edge triggered and 1 = Level 
> > triggered.
> > +
> gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x|UIN
> T16|0x29
> > +
> >  [PcdsDynamic, PcdsDynamicEx]
> >gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent|0|UINT64|2
> >
> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable|FALSE|BOOL
> EAN|0x10
> >
> 
> Thank you for wrapping the comments so nicely!
> 
> 
> (1) In PcAtChipsetPkg.dec, both PCDs are declared under:
> 
> [PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx, PcdsPatchableInModule]
> 
> but in OvmfPkg, this patch introduces both PCDs under just
> 
> [PcdsFixedAtBuild]
> 
> I think that's fine for now, but please mention this change in the
> commit message.

Yes, I will address this one.

> 
> 
> (2) OVMF's PCD token space seems to have some holes, namely at: 3
> decimal, 5 decimal, and 0x17.
> 
> Can you introduce the new PCDs with tokens 3 and 5, just to decrease the
> fragmentation?

Sure.

Best Regards,
Hao Wu

> 
> 
> With (1) and (2) addressed:
> 
> Reviewed-by: Laszlo Ersek 
> 
> Thanks,
> Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#23): https://edk2.groups.io/g/devel/message/23
Mute This Topic: https://groups.io/mt/30892915/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [RFC PATCH v1 2/8] OvmfPkg: Copy Legacy8259 protocol definitions from IntelFrameworkPkg

[Wu, Hao A]

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 03, 2019 8:24 PM
> To: Wu, Hao A; edk2-de...@lists.01.org
> Cc: Justen, Jordan L; David Woodhouse
> Subject: Re: [edk2] [RFC PATCH v1 2/8] OvmfPkg: Copy Legacy8259 protocol
> definitions from IntelFrameworkPkg
> 
> On 04/03/19 09:00, Hao Wu wrote:
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1496
> >
> > This commit copies the exact Legacy8259 protocol header file from
> > IntelFrameworkPkg to OvmfPkg. Also, the protocol GUID definition is
> > duplicated in the OvmfPkg DEC file.
> >
> > Cc: Jordan Justen 
> > Cc: Laszlo Ersek 
> > Cc: Ard Biesheuvel 
> > Cc: David Woodhouse 
> > Cc: Ray Ni 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Hao Wu 
> > ---
> >  OvmfPkg/OvmfPkg.dec   |   3 +-
> >  OvmfPkg/Include/Protocol/Legacy8259.h | 297 
> >  2 files changed, 299 insertions(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> > index e50c6179a2..fb89ebf3ad 100644
> > --- a/OvmfPkg/OvmfPkg.dec
> > +++ b/OvmfPkg/OvmfPkg.dec
> > @@ -1,7 +1,7 @@
> >  ## @file
> >  #  EFI/Framework Open Virtual Machine Firmware (OVMF) platform
> >  #
> > -#  Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.
> > +#  Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> >  #
> >  #  This program and the accompanying materials
> >  #  are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -89,6 +89,7 @@
> >gXenBusProtocolGuid = {0x3d3ca290, 0xb9a5, 0x11e3, 
> > {0xb7, 0x5d,
> 0xb8, 0xac, 0x6f, 0x7d, 0x65, 0xe6}}
> >gXenIoProtocolGuid  = {0x6efac84f, 0x0ab0, 0x4747, 
> > {0x81, 0xbe,
> 0x85, 0x55, 0x62, 0x59, 0x04, 0x49}}
> >gIoMmuAbsentProtocolGuid= {0xf8775d50, 0x8abd, 0x4adf, {0x92,
> 0xac, 0x85, 0x3e, 0x51, 0xf6, 0xc8, 0xdc}}
> > +  gEfiLegacy8259ProtocolGuid  = {0x38321dba, 0x4fe0, 0x4e17, {0x8a,
> 0xec, 0x41, 0x30, 0x55, 0xea, 0xed, 0xc1}}
> >
> >  [PcdsFixedAtBuild]
> >gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|0x0|UINT32|0
> 
> (This comment is not about the patch, but your git setup.)
> 
> Please update your git config so that "git format-patch" and its friends
> display the INI-style section, such as [Protocols], in the diff hunk
> headers. The expected result is:
> 
> @@ -89,6 +89,7 @@ [Protocols]
>   ^^^
> 
> You can find documentation at:
> 
> -
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-
> guide-for-edk2-contributors-and-maintainers#contrib-05
> (see the 'diff.ini.xfuncname' setting)
> 
> -
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-
> guide-for-edk2-contributors-and-maintainers#contrib-09

Settings are done.
Should reflect in the next version of the series (for license change).

Best Regards,
Hao Wu

> 
> For this patch:
> 
> Reviewed-by: Laszlo Ersek 
> 
> Thanks
> Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#22): https://edk2.groups.io/g/devel/message/22
Mute This Topic: https://groups.io/mt/30892819/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [PATCH V2] Change EDK II to BSD+Patent License

[Yao, Jiewen]

Resend to the new mail list.

> > -Original Message-
> > From: Yao, Jiewen [mailto:jiewen@intel.com]
> > Sent: Thursday, April 4, 2019 9:54 AM
> > To: Kinney, Michael D ;
> > edk2-de...@lists.01.org; Kinney, Michael D 
> > Subject: RE: [edk2] [PATCH V2] Change EDK II to BSD+Patent License
> >
> > SignedCapsulePkg: Reviewed-by: Jiewen Yao 
> > SecurityPkg: Reviewed-by: Jiewen Yao 
> > StandaloneMmPkg: Reviewed-by: Jiewen Yao 
> >
> > Thank you
> > Yao Jiewen
> >
> > > -Original Message-
> > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
> Of
> > > Kinney, Michael D
> > > Sent: Saturday, March 23, 2019 10:25 AM
> > > To: edk2-de...@lists.01.org; Kinney, Michael D
> > > 
> > > Subject: [edk2] [PATCH V2] Change EDK II to BSD+Patent License
> > >
> > > Hello,
> > >
> > > New in V2
> > > =
> > > * Remove Cc lines from commit messages
> > > * Remove branch reference from commit messages
> > > * Change license in 2 files missed in OvmfPkg
> > > * Update OvmfPkg/License.txt to BSD+Patent as the default license
> > > * Move the portions of Contributions.txt in the root of edk2 to
> > >   Readme.md in the root of edk2 that describe how to contribute
> > >   along with the commit message format.
> > > * Add to Readme.md in the root of edk2 that Signed-off-by means that
> > >   the contributor certifies compliance to the Developer's Certificate
> > >   of Origin 1.1.  https://developercertificate.org
> > > =
> > >
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> > >
> > > This change is based on the following emails:
> > >   https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
> > >   https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
> > >
> > > RFCs with detailed process for the license change:
> > >   V3:
> https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
> > >   V2:
> https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
> > >   V1:
> https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
> > >
> > > I have posted the patch series for review on the following branch using
> > > edk2-stable201903 as the base for the patch series.
> > >
> > >
> > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense_V2
> > >
> > > The commits in patch series can be viewed here:
> > >
> > >
> > >
> >
> https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense_
> > > V2
> > >
> > > The patch series has one patch per package along with a few patches
> > > to update the license information in the root of the edk2 repository
> > > as described in the RFC V3.
> > >
> > > Due to the size of the patch series, I prefer to not send the
> > > patch emails.  Instead, please perform code reviews using content
> > > from the branch.
> > >
> > > All EDK II package maintainers and package reviewers should provide
> > > review feedback for their packages.  The critical part of the review
> > > is:
> > > 1) Any changes that cause build breaks or logic changes.  These code
> > >changes are intended to only modify license contents in comment
> > >blocks.
> > > 2) Any file that has been changed to BSD+Patent, but should remain
> > >with the current license.
> > > 3) Any file that that has not changed to BSD+Patent, but should be
> > >changed to BSD+Patent.
> > >
> > > Feedback and Reviewed-by emails should identify the patch the feedback
> > > applies using the patch summary listed below.  The goal is to complete
> > > all reviews to support the commit of these patches on April 9, 2019.
> > >
> > > 2a7d2c56bc edk2: Remove Contributions.txt and update Readme.md
> > > f9d59ccdc5 OvmfPkg: Change License.txt from 2-Clause BSD to
> > BSD+Patent
> > > ce3fbf929e StdLibPrivateInternalFiles: Replace BSD License with
> > BSD+Patent
> > > License
> > > aa8a3692c7 StdLib: Replace BSD License with BSD+Patent License
> > > 2dfbe1e1ee AppPkg: Replace BSD License with BSD+Patent License
> > > b2161f6dd8 Vlv2TbltDevicePkg: Replace BSD License with BSD+Patent
> > > License
> > > 3688c33755 Vlv2DeviceRefCodePkg: Replace BSD License with
> BSD+Patent
> > > License
> > > 8170308c98 UefiCpuPkg: Replace BSD License with BSD+Patent License
> > > 4b68832cdc StandaloneMmPkg: Replace BSD License with BSD+Patent
> > > License
> > > 327dc18122 SourceLevelDebugPkg: Replace BSD License with
> BSD+Patent
> > > License
> > > 6c4c506a5e SignedCapsulePkg: Replace BSD License with BSD+Patent
> > > License
> > > 2fdd514aff ShellPkg: Replace BSD License with BSD+Patent License
> > > c667724cb9 ShellBinPkg: Replace BSD License with BSD+Patent License
> > > 76f9e555b8 SecurityPkg: Replace BSD License with BSD+Patent License
> > > 89a588c1be QuarkSocPkg: Replace BSD License with BSD+Patent License
> > > 454f280e0c QuarkPlatformPkg: Replace BSD License with BSD+Patent
> > > License
> > > 935319af35 PcAtChipsetPkg: Replace BSD License with BSD+Patent
> License
> > > e39d07266d OvmfPkg: Replace BSD License with BSD+Patent L

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][Patch] AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.

[Kubacki, Michael A]

/AcpiDebug/AcpiDebug.asl
  1. Is "Trigger the SMI to print" meant to be "// Triggle the SMI to print" on 
line 97?

/AdvancedFeaturePkg/AcpiDebug/AcpiDebug.c
  1. Correct file description comment in file header "  Smbios basic entry 
point."

  2. InitializeAcpiDebugSmm ( ) should return with an error if the 
LocateProtocol ( ) fails. The assert does not change control flow and is not 
effective in all situation which can lead to an invalid pointer dereference. 
Please do the same for similar scenarios in the file.

 InitializeAcpiDebugSmm (
   IN EFI_HANDLE ImageHandle,
   IN EFI_SYSTEM_TABLE   *SystemTable
 )

  3. There's some minor style guideline violations such as a missing space 
before opening parenthesis on line 378. Please check these.
   while((*(CHAR8 *) (UINTN) mAcpiDebug->Head == '\0')

  4. I am curious. Is there a reason this uses mSmst as opposed to gSmst in 
SmmServicesTableLib?

/AcpiDebug/AcpiDebugDxe.inf
  1. Correct file description comment in file header "# Component description 
file for Smbios Misc module."

/AcpiDebug/AcpiDebugSmm.inf
  1. Correct file description comment in file header "# Component description 
file for Smbios Misc module."

/AdvancedFeaturePkg/AcpiDebug/Readme.txt
  1. SETUP->Advanced->ACPI DEBUG is not guaranteed to exist, please just use 
the PCD to enable/disable the feature
  2. Please remove the other setup related comments

/AdvancedFeaturePkg/AdvancedFeaturePkg.dec
  1. Update copyright year

/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc
  1. Update copyright year

> -Original Message-
> From: Dong, Eric
> Sent: Monday, April 1, 2019 5:12 PM
> To: edk2-de...@lists.01.org
> Cc: Wu, Hao A ; Kubacki, Michael A
> ; Desimone, Nathaniel L
> 
> Subject: [edk2-platforms/devel-MinPlatform][Patch]
> AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.
> 
> V2 change:
> Update the patch header.
> 
> Add new AcpiDebug modules which provide ACPI Debug feature.
> Detail about this feature see the readme.txt in the patch.
> 
> Cc: Hao Wu 
> Cc: Michael Kubacki 
> Cc: Nate Desimone 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong 
> ---
>  .../AcpiDebug/AcpiDebug.asl   | 109 
>  .../AdvancedFeaturePkg/AcpiDebug/AcpiDebug.c  | 485
> ++
>  .../AcpiDebug/AcpiDebugDxe.inf|  63 +++
>  .../AcpiDebug/AcpiDebugSmm.inf|  65 +++
>  .../AdvancedFeaturePkg/AcpiDebug/Readme.txt   |  47 ++
>  .../AdvancedFeaturePkg/AdvancedFeaturePkg.dec |   6 +
>  .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc |   2 +
>  7 files changed, 777 insertions(+)
>  create mode 100644
> Platform/Intel/AdvancedFeaturePkg/AcpiDebug/AcpiDebug.asl
>  create mode 100644
> Platform/Intel/AdvancedFeaturePkg/AcpiDebug/AcpiDebug.c
>  create mode 100644
> Platform/Intel/AdvancedFeaturePkg/AcpiDebug/AcpiDebugDxe.inf
>  create mode 100644
> Platform/Intel/AdvancedFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
>  create mode 100644
> Platform/Intel/AdvancedFeaturePkg/AcpiDebug/Readme.txt
> 
> diff --git a/Platform/Intel/AdvancedFeaturePkg/AcpiDebug/AcpiDebug.asl
> b/Platform/Intel/AdvancedFeaturePkg/AcpiDebug/AcpiDebug.asl
> new file mode 100644
> index 000..62d2a1b
> --- /dev/null
> +++ b/Platform/Intel/AdvancedFeaturePkg/AcpiDebug/AcpiDebug.asl
> @@ -0,0 +1,109 @@
> +/** @file
> +  Acpi Debug ASL code.
> +
> +Copyright (c) 2019, Intel Corporation. All rights reserved. This
> +program and the accompanying materials are licensed and made available
> +under the terms and conditions of the BSD License which accompanies
> +this distribution.  The full text of the license may be found at
> +http://opensource.org/licenses/bsd-license.php
> +
> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +
> +**/
> +
> +DefinitionBlock (
> +  "AcpiDebug.aml",
> +  "SSDT",
> +  2,
> +  "Intel ",
> +  "ADebTabl",
> +  0x1000
> +  )
> +{
> +  Scope(\)
> +  {
> +//
> +// These pointers are patched during POST.
> +//
> +Name (DPTR, 0x8000) // Address of Acpi debug memory buffer, fixed
> up during POST
> +Name (EPTR, 0x8000) // End of Acpi debug memory buffer, fixed up
> during POST
> +Name (CPTR, 0x8000) // Current pointer used as an index into
> +the buffer(starts after the Acpi Debug head), fixed up during POST
> +
> +//
> +// Use a Mutex to prevent multiple calls from simutaneously writing to
> the same memory.
> +//
> +Mutex (MMUT, 0)
> +
> +//
> +// Operational region for SMI port access
> +//
> +OperationRegion (ADBP, SystemIO, 0xB2, 2)
> +Field (ADBP, ByteAcc, NoLock, Preserve)
> +{
> +B2PT, 8,
> +B3PT, 8,
> +}
> +
> +//
> +// Write a string to a memory buffer
> +//
> +Method (MDBG, 1, Serialized)
> +{
> +  OperationRegion (ADHD, SystemMemory, DPTR, 32) // Op

[edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Michael D Kinney]

Hello,

New in V3
=
* Update the base of the patch series from edk2-stable201903 to
  7ed72121b7 that is after the file add/remove freeze:

  https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html

* Replace copyright line in License.txt in root with a single copyright
  for "TianoCore and contributors".
* Clarify commit message for changes to License.txt to state the text 
  differences are larger than expected due to differences in line breaks.
* There is one less patch in the series than V2 due to the retirement
  of the EdkCompatibilityPkg.
* The git feature "git range-diff" can be used to compare the V2 and
  V3 branches even though they have different bases.  If you have both
  the V2 and V3 branches in your local repo, you can use the following 
  command to see the changes.  Most are due to the removal of .S files
  in March.  If you pipe through grep looking for "diff --git" you will
  see the list of files with differences.

  git range-diff edk2-stable201903..Bug_1373_BsdPatentLicense_V2 
7ed72121b7..Bug_1373_BsdPatentLicense_V3

New in V2
=
* Remove Cc lines from commit messages
* Remove branch reference from commit messages
* Change license in 2 files missed in OvmfPkg
* Update OvmfPkg/License.txt to BSD+Patent as the default license
* Move the portions of Contributions.txt in the root of edk2 to
  Readme.md in the root of edk2 that describe how to contribute
  along with the commit message format.
* Add to Readme.md in the root of edk2 that Signed-off-by means that
  the contributor certifies compliance to the Developer's Certificate
  of Origin 1.1.  https://developercertificate.org
=

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373

This change is based on the following emails:
  https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
  https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html

RFCs with detailed process for the license change:
  V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
  V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
  V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html

I have posted the patch series for review on the following branch using
7ed72121b7 as the base for the patch series.

  https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense_V3

The commits in patch series can be viewed here:

  https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense_V3

The patch series has one patch per package along with a few patches
to update the license information in the root of the edk2 repository
as described in the RFC V3.

Due to the size of the patch series, I prefer to not send the
patch emails.  Instead, please perform code reviews using content
from the branch.

All EDK II package maintainers and package reviewers should provide
review feedback for their packages.  The critical part of the review
is:
1) Any changes that cause build breaks or logic changes.  These code
   changes are intended to only modify license contents in comment
   blocks.
2) Any file that has been changed to BSD+Patent, but should remain
   with the current license.
3) Any file that that has not changed to BSD+Patent, but should be
   changed to BSD+Patent. 

Feedback and Reviewed-by emails should identify the patch the feedback
applies using the patch summary listed below.  The goal is to complete
all reviews to support the commit of these patches on April 9, 2019.

eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent
f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with BSD+Patent 
License
845b945044 StdLib: Replace BSD License with BSD+Patent License
e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with BSD+Patent License
6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent License
a67328cbb4 UefiCpuPkg: Replace BSD License with BSD+Patent License
248d91c908 StandaloneMmPkg: Replace BSD License with BSD+Patent License
415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent License
4cd6c3f31f SignedCapsulePkg: Replace BSD License with BSD+Patent License
9ffa4947d3 ShellPkg: Replace BSD License with BSD+Patent License
fdb6510955 ShellBinPkg: Replace BSD License with BSD+Patent License
dc5f8d93d9 SecurityPkg: Replace BSD License with BSD+Patent License
841d42a913 QuarkSocPkg: Replace BSD License with BSD+Patent License
75c3756e18 QuarkPlatformPkg: Replace BSD License with BSD+Patent License
657491e5a3 PcAtChipsetPkg: Replace BSD License with BSD+Patent License
4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
521b8139c7 OptionRomPkg: Replace BSD License with BSD+Patent License
ec339f8320 Omap35xxPkg: Replace BSD License with BSD+Patent License
ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License
aa99b9adeb NetworkPkg: Replace BSD License with BSD+Pat

Re: [edk2-devel] [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh

[Jordan Justen]

$ git grep GdbRun
EmulatorPkg/Unix/Host/Host.c:  // has a break point script to source the GdbRun 
script.
EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/default.pbxuser: 
command = "set gInXcode=1\nsource ../../../../EmulatorPkg/Unix/GdbRun";
EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/default.pbxuser: 
command = "set gInXcode=1\nsource ../../../../EmulatorPkg/Unix/GdbRun";
EmulatorPkg/build.sh:  /usr/bin/gdb $BUILD_ROOT_ARCH/Host -q 
-cd=$BUILD_ROOT_ARCH -x $WORKSPACE/EmulatorPkg/Unix/GdbRun

If those are updated,

Reviewed-by: Jordan Justen 

On 2019-04-03 14:54:39, Kinney, Michael D wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1657
> 
> Add .sh file extension to the shell script GdbRun so
> changes to this file will pass PatchCheck.py.
> 
> Cc: Jordan Justen 
> Cc: Andrew Fish 
> Cc: Ray Ni 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney 
> ---
>  EmulatorPkg/Unix/{GdbRun => GdbRun.sh} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename EmulatorPkg/Unix/{GdbRun => GdbRun.sh} (100%)
> 
> diff --git a/EmulatorPkg/Unix/GdbRun b/EmulatorPkg/Unix/GdbRun.sh
> similarity index 100%
> rename from EmulatorPkg/Unix/GdbRun
> rename to EmulatorPkg/Unix/GdbRun.sh
> -- 
> 2.21.0.windows.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#18): https://edk2.groups.io/g/devel/message/18
Mute This Topic: https://groups.io/mt/30886171/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch 2/4] ArmPkg: Normalize line endings to CRLF

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=1659

Normalize line endings to use CRLF to pass PatchCheck.py

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c  |  44 +++
 .../ArmSmcPsciResetSystemLib/AArch64/Reset.S  |  60 -
 .../AArch64/Reset.asm |  70 +-
 .../ArmSmcPsciResetSystemLib/Arm/Reset.S  |  58 
 .../ArmSmcPsciResetSystemLib/Arm/Reset.asm|  68 +-
 ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 124 +-
 ArmPkg/Library/GccLto/liblto-aarch64.s|  54 
 ArmPkg/Library/GccLto/liblto-arm.s| 122 -
 8 files changed, 300 insertions(+), 300 deletions(-)

diff --git a/ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c 
b/ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c
index e5d4e51133..393fc1a922 100644
--- a/ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c
+++ b/ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c
@@ -1,22 +1,22 @@
-//
-//  Copyright (c) 2016, Linaro Limited. All rights reserved.
-//
-//  This program and the accompanying materials
-//  are licensed and made available under the terms and conditions of the BSD 
License
-//  which accompanies this distribution.  The full text of the license may be 
found at
-//  http://opensource.org/licenses/bsd-license.php
-//
-//  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.
-//
-//
-
-#include 
-#include 
-
-VOID
-ArmCallSmc (
-  IN OUT ARM_SMC_ARGS *Args
-  )
-{
-}
+//
+//  Copyright (c) 2016, Linaro Limited. All rights reserved.
+//
+//  This program and the accompanying materials
+//  are licensed and made available under the terms and conditions of the BSD 
License
+//  which accompanies this distribution.  The full text of the license may be 
found at
+//  http://opensource.org/licenses/bsd-license.php
+//
+//  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.
+//
+//
+
+#include 
+#include 
+
+VOID
+ArmCallSmc (
+  IN OUT ARM_SMC_ARGS *Args
+  )
+{
+}
diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S 
b/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
index 1edca941cb..208422b8a6 100644
--- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
+++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
@@ -1,30 +1,30 @@
-/** @file
-  ResetSystemLib implementation using PSCI calls
-
-  Copyright (c) 2018, Linaro Ltd. All rights reserved.
-
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution. The full text of the license may be 
found at
-  http://opensource.org/licenses/bsd-license.php
-
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#include 
-
-ASM_FUNC(DisableMmuAndReenterPei)
-  stp   x29, x30, [sp, #-16]!
-  mov   x29, sp
-
-  blArmDisableMmu
-
-  // no memory accesses after MMU and caches have been disabled
-
-  MOV64 (x0, FixedPcdGet64 (PcdFvBaseAddress))
-  blr   x0
-
-  // never returns
-  nop
+/** @file
+  ResetSystemLib implementation using PSCI calls
+
+  Copyright (c) 2018, Linaro Ltd. All rights reserved.
+
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD 
License
+  which accompanies this distribution. The full text of the license may be 
found at
+  http://opensource.org/licenses/bsd-license.php
+
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#include 
+
+ASM_FUNC(DisableMmuAndReenterPei)
+  stp   x29, x30, [sp, #-16]!
+  mov   x29, sp
+
+  blArmDisableMmu
+
+  // no memory accesses after MMU and caches have been disabled
+
+  MOV64 (x0, FixedPcdGet64 (PcdFvBaseAddress))
+  blr   x0
+
+  // never returns
+  nop
diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm 
b/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
index 9e30c13329..090035178f 100644
--- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
+++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
@@ -1,35 +1,35 @@
-;/** @file
-;  ResetSystemLib implementation using PSCI calls
-;
-;  Copyright (c) 2018, Linaro Ltd. All rights reserved.
-;
-;  This program and the accompanying materials
-;  are licensed and made available under the terms and conditions of the BSD 
License
-;  which accompanies this distribution. The full text of the license may be 
found at
-;  http://opensource.org/licenses/bsd-license.php
-;
-;  THE PROGRAM IS D

[edk2-devel] [Patch 1/4] ArmPkg/ArmScmiDxe: Remove non-ASCII character in comment

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=1659

Remove non-ASCII character in comment that makes it
more challenging to process with python-based
scanning tools.

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h 
b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h
index 4514f45a9f..da0cd2b34b 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h
+++ b/ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h
@@ -29,7 +29,7 @@
 #define NUM_REMAIN_PERF_LEVELS(Lvls) (Lvls >> NUM_REMAIN_PERF_LEVELS_SHIFT)
 
 /** Return values for SCMI_MESSAGE_ID_PERFORMANCE_DESCRIBE_LEVELS command.
-  SCMI Spec � 4.5.2.5
+  SCMI Spec 4.5.2.5
 **/
 typedef struct {
   UINT32 NumLevels;
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#14): https://edk2.groups.io/g/devel/message/14
Mute This Topic: https://groups.io/mt/30886237/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch 4/4] ArmPlatformPkg: Normalize line endings to CRLF

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=1659

Normalize line endings to use CRLF to pass PatchCheck.py

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 ArmPlatformPkg/Scripts/Ds5/profile.py | 668 +-
 1 file changed, 334 insertions(+), 334 deletions(-)

diff --git a/ArmPlatformPkg/Scripts/Ds5/profile.py 
b/ArmPlatformPkg/Scripts/Ds5/profile.py
index 2e55993c60..38342c62d5 100644
--- a/ArmPlatformPkg/Scripts/Ds5/profile.py
+++ b/ArmPlatformPkg/Scripts/Ds5/profile.py
@@ -1,334 +1,334 @@
-#!/usr/bin/python
-
-#
-#  Copyright (c) 2014, ARM Limited. All rights reserved.
-#
-#  This program and the accompanying materials
-#  are licensed and made available under the terms and conditions of the BSD 
License
-#  which accompanies this distribution.  The full text of the license may be 
found at
-#  http://opensource.org/licenses/bsd-license.php
-#
-#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR 
IMPLIED.
-#
-
-import getopt
-import operator
-import os
-import pickle
-import sys
-from sys import argv
-from cStringIO import StringIO
-
-modules = {}
-functions = {}
-functions_addr = {}
-
-def usage():
-   print "-t,--trace: Location of the Trace file"
-   print "-s,--symbols: Location of the symbols and modules"
-
-def get_address_from_string(address):
-   return int(address.strip("S:").strip("N:").strip("EL2:").strip("EL1:"), 
16)
-
-def get_module_from_addr(modules, addr):
-   for key,value in modules.items():
-   if (value['start'] <= addr) and (addr <= value['end']):
-   return key
-   return None
-
-def add_cycles_to_function(functions, func_name, addr, cycles):
-   if func_name != "":
-   # Check if we are still in the previous function
-   if add_cycles_to_function.prev_func_name == func_name:
-   add_cycles_to_function.prev_entry['cycles'] += cycles
-   return (add_cycles_to_function.prev_func_name, 
add_cycles_to_function.prev_module_name)
-
-   if func_name in functions.keys():
-   for module_name, module_value in 
functions[func_name].iteritems():
-   if (module_value['start'] <= addr) and (addr < 
module_value['end']):
-   module_value['cycles'] += cycles
-
-   add_cycles_to_function.prev_func_name   
= func_name
-   add_cycles_to_function.prev_module_name 
= module_name
-   add_cycles_to_function.prev_entry   
= module_value
-   return (func_name, module_name)
-   elif (module_value['end'] == 0):
-   module_value['cycles'] += cycles
-
-   add_cycles_to_function.prev_func_name   
= func_name
-   add_cycles_to_function.prev_module_name 
= module_name
-   add_cycles_to_function.prev_entry   
= module_value
-   return (func_name, module_name)
-
-   # Workaround to fix the 'info func' limitation that does not 
expose the 'static' function
-   module_name = get_module_from_addr(modules, addr)
-   functions[func_name] = {}
-   functions[func_name][module_name] = {}
-   functions[func_name][module_name]['start']  = 0
-   functions[func_name][module_name]['end']= 0
-   functions[func_name][module_name]['cycles'] = cycles
-   functions[func_name][module_name]['count']  = 0
-
-   add_cycles_to_function.prev_func_name   = func_name
-   add_cycles_to_function.prev_module_name = module_name
-   add_cycles_to_function.prev_entry   = 
functions[func_name][module_name]
-   return (func_name, module_name)
-   else:
-   # Check if we are still in the previous function
-   if (add_cycles_to_function.prev_entry is not None) and 
(add_cycles_to_function.prev_entry['start'] <= addr) and (addr < 
add_cycles_to_function.prev_entry['end']):
-   add_cycles_to_function.prev_entry['cycles'] += cycles
-   return (add_cycles_to_function.prev_func_name, 
add_cycles_to_function.prev_module_name)
-
-   # Generate the key for the given address
-   key = addr & ~0x0FFF
-
-   if key not in functions_addr.keys():
-   if 'Unknown' not in functions.keys():
-   functions['Unknown'] = {}
-   if 'Unknown' not in functions['Unknown'].keys():
-

[edk2-devel] [Patch 3/4] ArmVirtPkg: Normalize line endings to CRLF

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=1659

Normalize line endings to use CRLF to pass PatchCheck.py

Cc: Laszlo Ersek 
Cc: Ard Biesheuvel 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 ArmVirtPkg/Include/Platform/Hidden.h | 56 ++--
 1 file changed, 28 insertions(+), 28 deletions(-)

diff --git a/ArmVirtPkg/Include/Platform/Hidden.h 
b/ArmVirtPkg/Include/Platform/Hidden.h
index fbd3467471..997866ff50 100644
--- a/ArmVirtPkg/Include/Platform/Hidden.h
+++ b/ArmVirtPkg/Include/Platform/Hidden.h
@@ -1,28 +1,28 @@
-/** @file
-
-  Copyright (c) 2018, Linaro Limited. All rights reserved.
-
-  This program and the accompanying materials
-  are licensed and made available under the terms and conditions of the BSD 
License
-  which accompanies this distribution.  The full text of the license may be 
found at
-  http://opensource.org/licenses/bsd-license.php
-
-  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
-  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
-
-**/
-
-#ifndef __PLATFORM_HIDDEN_H
-#define __PLATFORM_HIDDEN_H
-
-//
-// Setting the GCC -fvisibility=hidden command line option is not quite the 
same
-// as setting the pragma below: the former only affects definitions, whereas 
the
-// pragma affects extern declarations as well. So if we want to ensure that no
-// GOT indirected symbol references are emitted, we need to use the pragma, or
-// GOT based cross object references could be emitted, e.g., in libraries, and
-// these cannot be relaxed to ordinary symbol references at link time.
-//
-#pragma GCC visibility push (hidden)
-
-#endif
+/** @file
+
+  Copyright (c) 2018, Linaro Limited. All rights reserved.
+
+  This program and the accompanying materials
+  are licensed and made available under the terms and conditions of the BSD 
License
+  which accompanies this distribution.  The full text of the license may be 
found at
+  http://opensource.org/licenses/bsd-license.php
+
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef __PLATFORM_HIDDEN_H
+#define __PLATFORM_HIDDEN_H
+
+//
+// Setting the GCC -fvisibility=hidden command line option is not quite the 
same
+// as setting the pragma below: the former only affects definitions, whereas 
the
+// pragma affects extern declarations as well. So if we want to ensure that no
+// GOT indirected symbol references are emitted, we need to use the pragma, or
+// GOT based cross object references could be emitted, e.g., in libraries, and
+// these cannot be relaxed to ordinary symbol references at link time.
+//
+#pragma GCC visibility push (hidden)
+
+#endif
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#15): https://edk2.groups.io/g/devel/message/15
Mute This Topic: https://groups.io/mt/30886238/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch 0/4] Normalize line endings to CRLF in ARM packages

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=1659

Normalize line endings to use CRLF to pass PatchCheck.py

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Cc: Laszlo Ersek 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 

Kinney, Michael D (4):
  ArmPkg/ArmScmiDxe: Remove non-ASCII character in comment
  ArmPkg: Normalize line endings to CRLF
  ArmVirtPkg: Normalize line endings to CRLF
  ArmPlatformPkg: Normalize line endings to CRLF

 .../ArmScmiPerformanceProtocolPrivate.h   |   2 +-
 ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.c  |  44 +-
 .../ArmSmcPsciResetSystemLib/AArch64/Reset.S  |  60 +-
 .../AArch64/Reset.asm |  70 +-
 .../ArmSmcPsciResetSystemLib/Arm/Reset.S  |  58 +-
 .../ArmSmcPsciResetSystemLib/Arm/Reset.asm|  68 +-
 ArmPkg/Library/CompilerIntrinsicsLib/memset.c | 124 ++--
 ArmPkg/Library/GccLto/liblto-aarch64.s|  54 +-
 ArmPkg/Library/GccLto/liblto-arm.s| 122 ++--
 ArmPlatformPkg/Scripts/Ds5/profile.py | 668 +-
 ArmVirtPkg/Include/Platform/Hidden.h  |  56 +-
 11 files changed, 663 insertions(+), 663 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#12): https://edk2.groups.io/g/devel/message/12
Mute This Topic: https://groups.io/mt/30886235/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh

[Michael D Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=1657

Add .sh file extension to the shell script GdbRun so
changes to this file will pass PatchCheck.py.

Cc: Jordan Justen 
Cc: Andrew Fish 
Cc: Ray Ni 
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney 
---
 EmulatorPkg/Unix/{GdbRun => GdbRun.sh} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename EmulatorPkg/Unix/{GdbRun => GdbRun.sh} (100%)

diff --git a/EmulatorPkg/Unix/GdbRun b/EmulatorPkg/Unix/GdbRun.sh
similarity index 100%
rename from EmulatorPkg/Unix/GdbRun
rename to EmulatorPkg/Unix/GdbRun.sh
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#11): https://edk2.groups.io/g/devel/message/11
Mute This Topic: https://groups.io/mt/30886171/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2] [RFC] Plan to delete ShellBinPkg from edk2/master

[Michael D Kinney]

Laszlo,

A PREBUILD action looks like a good idea.

Release artifacts in GitHub are available as an http
link, so a python script to download into a path
in the build output directory and referenced by DSC/FDF
should work.

We could even post shell binaries for the past couple
edk2-stable tags because release content can be updated.

Mike

> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 3, 2019 9:07 AM
> To: Kinney, Michael D ; Ni,
> Ray ; Bi, Dandan
> ; edk2-de...@lists.01.org
> Cc: Cetola, Stephano ; Gao,
> Liming ; Carsey, Jaben
> 
> Subject: Re: [edk2] [RFC] Plan to delete ShellBinPkg
> from edk2/master
> 
> On 04/03/19 17:49, Kinney, Michael D wrote:
> > Laszlo,
> >
> > I think it makes sense to post validated shell
> binaries
> > with the edk2-stable tag releases.  GitHub does
> support
> > this when a release tag is made.
> >
> > However, we would need to make it simple for a
> platform
> > to use a binary from that location.  We may need some
> > enhancements to pull in binary artifacts from
> different
> > locations to support a platform build that uses one
> or
> > more pre-built binaries.
> 
> Can PREBUILD scripts (written by platform owners)
> download the required
> binaries?
> 
> Thanks,
> Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#10): https://edk2.groups.io/g/devel/message/10
Mute This Topic: https://groups.io/mt/30886118/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] TianoCore Bug Triage - EMEA / NAMO - Mon, 04/08/2019 7:00am-8:00am #cal-reminder

[devel@edk2.groups.io Calendar]

"TianoCore Bug Triage - EMEA / NAMO" Reminder

When:  Monday, 8 April 2019
   7:00am to 8:00am
   (GMT-07:00) America/Los Angeles

Where: https://zoom.us/j/670172897

Description: Join Zoom Meeting

https://zoom.us/j/670172897 ( https://zoom.us/j/670172897 )

 

One tap mobile

+17207072699,,670172897# US

+16465588656,,670172897# US (New York)

 

Dial by your location

   +1 720 707 2699 US

   +1 646 558 8656 US (New York)

Meeting ID: 670 172 897

Find your local number: https://zoom.us/u/adoVHelw9Z

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#9): https://edk2.groups.io/g/devel/message/9
Mute This Topic: https://groups.io/mt/30880788/21656
Mute #cal-reminder: https://groups.io/mk?hashtag=cal-reminder&subid=3846945
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-