Re: [edk2-devel] [PATCH] MdeModulePkg/Variable/Pei: Update the condition in if statement
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, October 17, 2019 11:20 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Gao, Liming
> Subject: [PATCH] MdeModulePkg/Variable/Pei: Update the condition in if
> statement
>
> IndexTable->Length is used as index in array IndexTable->Index[].
> So IndexTable->Length needs to be checked, which should be less than
> the array size.
>
> Cc: Hao A Wu
> Cc: Liming Gao
> Signed-off-by: Shenglei Zhang
> ---
> MdeModulePkg/Universal/Variable/Pei/Variable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/Variable/Pei/Variable.c
> b/MdeModulePkg/Universal/Variable/Pei/Variable.c
> index 715802f33c29..f61465fc3045 100644
> --- a/MdeModulePkg/Universal/Variable/Pei/Variable.c
> +++ b/MdeModulePkg/Universal/Variable/Pei/Variable.c
> @@ -896,7 +896,7 @@ FindVariableEx (
>//
>if ((IndexTable != NULL) && !StopRecord) {
> Offset = (UINTN) Variable - (UINTN) LastVariable;
> -if ((Offset > 0x0) || (IndexTable->Length == sizeof
> (IndexTable->Index)
> / sizeof (IndexTable->Index[0]))) {
> +if ((Offset > 0x0) || (IndexTable->Length >= sizeof (IndexTable-
> >Index) / sizeof (IndexTable->Index[0]))) {
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
>//
>// Stop to record if the distance of two neighbouring VAR_ADDED
> variable is larger than the allowable scope(UINT16),
>// or the record buffer is full.
> --
> 2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49636): https://edk2.groups.io/g/devel/message/49636
Mute This Topic: https://groups.io/mt/34668808/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap
> -Original Message-
> From: Zhang, Shenglei
> Sent: Wednesday, October 16, 2019 9:47 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray
> Subject: [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable
> RequestMap
>
> RequestMap is used but not Initialized.
>
> Cc: Hao A Wu
> Cc: Ray Ni
> Signed-off-by: Shenglei Zhang
> ---
> MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> index b897c3f82ce6..a05834da3c4a 100644
> --- a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> +++ b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> @@ -274,6 +274,8 @@ UhcControlTransfer (
>
>PktID = INPUT_PACKET_ID;
>
> + RequestMap = NULL;
Hello,
Is this a real issue or just a false positive report by some compiler or static
analyzer?
If is a real issue, could you help to describe the issue in more detail? If it
is a false positive report, could you help to add some comments together with
the change? Thanks in advance.
Best Regards,
Hao Wu
> +
>if (Request == NULL || TransferResult == NULL) {
> return EFI_INVALID_PARAMETER;
>}
> --
> 2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49634): https://edk2.groups.io/g/devel/message/49634
Mute This Topic: https://groups.io/mt/34556041/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/EhciPei: Initialize the variable Map
> -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, October 16, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH 1/3] MdeModulePkg/EhciPei: Initialize the variable Map > > Map is used but not Initialized. > > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > index 7c6a6a5f9716..995ccd2463d2 100644 > --- a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > +++ b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > @@ -534,6 +534,8 @@ EhcCreateUrb ( >PEI_URB *Urb; >VOID *Map; > > + Map = NULL; > + Hello, Is this a real issue or just a false positive report by some compiler or static analyzer? If is a real issue, could you help to describe the issue in more detail? If it is a false positive report, could you help to add some comments together with the change? Thanks in advance. Best Regards, Hao Wu >Urb = Ehc->Urb; >Urb->Signature = EHC_URB_SIG; >InitializeListHead (&Urb->UrbList); > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49635): https://edk2.groups.io/g/devel/message/49635 Mute This Topic: https://groups.io/mt/34556040/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
Qing:
Thanks for your update. Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: Huang, Qing
>Sent: Wednesday, October 30, 2019 12:55 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming
>Subject: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2309
>Add EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO definition into UEFI
>specification header file.
>
>Signed-off-by: Qing Huang
>Cc: Liming Gao
>---
> MdePkg/Include/Uefi/UefiSpec.h | 20
> 1 file changed, 20 insertions(+)
>
>diff --git a/MdePkg/Include/Uefi/UefiSpec.h
>b/MdePkg/Include/Uefi/UefiSpec.h
>index 44a0a6a7fa..5d58faf7ed 100644
>--- a/MdePkg/Include/Uefi/UefiSpec.h
>+++ b/MdePkg/Include/Uefi/UefiSpec.h
>@@ -82,6 +82,26 @@ typedef enum {
> // If all memory has the same reliability, then this bit is not used.
> //
> #define EFI_MEMORY_MORE_RELIABLE0x0001ULL
>+
>+//
>+// Note: UEFI spec 2.8 and following:
>+//
>+// Specific-purpose memory (SPM). The memory is earmarked for
>+// specific purposes such as for specific device drivers or applications.
>+// The SPM attribute serves as a hint to the OS to avoid allocating this
>+// memory for core OS data or code that can not be relocated.
>+//
>+#define EFI_MEMORY_SP 0x0004ULL
>+//
>+// If this flag is set, the memory region is capable of being
>+// protected with the CPU’s memory cryptographic
>+// capabilities. If this flag is clear, the memory region is not
>+// capable of being protected with the CPU’s memory
>+// cryptographic capabilities or the CPU does not support CPU
>+// memory cryptographic capabilities.
>+//
>+#define EFI_MEMORY_CPU_CRYPTO 0x0008ULL
>+
> //
> // Runtime memory attribute
> //
>--
>2.17.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49633): https://edk2.groups.io/g/devel/message/49633
Mute This Topic: https://groups.io/mt/36927089/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make PlatformRecovery work regardless of OsIndications
Pushed at b15646484eaffcf7cc464fdea0214498f26addc2 Regards, Jian > -Original Message- > From: Wang, Sunny (HPS SW) > Sent: Wednesday, October 23, 2019 7:20 PM > To: devel@edk2.groups.io; Ni, Ray ; Wang, Jian J > ; Gao, Zhichao ; > ler...@redhat.com; Wu, Hao A > Cc: Li, Walon ; Wang, Sunny (HPS SW) > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make > PlatformRecovery work regardless of OsIndications > > Thanks for checking and reviewing this, Ray and Jian. > I attached my updated patch which addressed Zhichao's comment about the > commit message and passed PatchCheck.py. > Jian, since the change is just the commit message change (no code change), I > didn't send an email to edk2-devel again. However, if resending an patch email > to edk2-devel is needed, feel free to let me know. > > Regards, > Sunny Wang > > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Wednesday, October 23, 2019 1:58 PM > To: Wang, Jian J ; Wang, Sunny (HPS SW) > ; Gao, Zhichao ; > devel@edk2.groups.io; ler...@redhat.com; Wu, Hao A > Cc: Li, Walon > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make > PlatformRecovery work regardless of OsIndications > Importance: High > > With Zhichao's comments addressed, Reviewed-by: Ray Ni > > > -Original Message- > > From: Wang, Jian J > > Sent: Tuesday, October 22, 2019 9:27 PM > > To: Wang, Sunny (HPS SW) ; Gao, Zhichao > > ; devel@edk2.groups.io; ler...@redhat.com; Wu, > > Hao A ; Ni, Ray > > Cc: Li, Walon > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make > > PlatformRecovery work regardless of OsIndications > > > > I'm not familiar this part of code. Ray is expert. > > > > Acked-by: Jian J Wang > > > > > -Original Message- > > > From: Wang, Sunny (HPS SW) > > > Sent: Wednesday, October 16, 2019 5:43 PM > > > To: Gao, Zhichao ; devel@edk2.groups.io; > > > ler...@redhat.com; Wang, Jian J ; Wu, Hao A > > > > > > Cc: Ni, Ray ; Li, Walon ; Wang, > > > Sunny (HPS SW) > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make > > > PlatformRecovery work regardless of OsIndications > > > > > > Thanks for catching this, Laszlo. > > > Thanks for the suggestion and information, Zhichao. Next time, I > > > will definitely take care of this in the first place. > > > > > > Hi Jian and Hao, > > > I forgot to add both of you in Cc. Sorry about that. I will send you > > > guys a new patch with the updated commit message below. If you guys > > > need me to resend an email to edk2-devel for the new patch, feel free to > > > let > me know. > > > > > > === > > > MdeModulePkg/BdsDxe: Fix PlatformRecovery issue > > > > > > For now, PlatformRecovery doesn't work if OsIndications variable > > > doesn't exist, which is wrong. > > > According to the UEFI specification section 3.4.1 and 3.4.2, if > > > processing of BootOrder does not result in success, the OsRecovery > > > and PlatformRecovery options should still be processed regardless of > > > the existence of the OsIndications variable. > > > Therefore, update the code to check PcdPlatformRecoverySupport > > > instead of the value of OsIndications variable (PlatformRecovery) to > > > fix this issue. > > > > > > Cc: Jian J Wang > > > Cc: Hao Wu > > > Cc: Ray Ni > > > Cc: Zhichao Gao > > > Cc: Walon Li > > > Signed-off-by: Sunny Wang > > > = > > > > > > Regards, > > > Sunny Wang > > > > > > -Original Message- > > > From: Gao, Zhichao [mailto:zhichao@intel.com] > > > Sent: Wednesday, October 16, 2019 4:36 PM > > > To: devel@edk2.groups.io; ler...@redhat.com; Wang, Sunny (HPS SW) > > > > > > Cc: Ni, Ray ; Li, Walon > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/BdsDxe: Make > > > PlatformRecovery work regardless of OsIndications > > > Importance: High > > > > > > MdeModulePkg/BdsDxe: Do PlatformRecovery regardless of OsIndications > > > > > > According to the UEFI specification section 3.4.1 and 3.4.2, the > > > OsRecovery and PlatformRecovery options should still be processed > > > regardless of the value of OsIndications variable if processing of > > > BootOrder > does not result in success. > > > Therefore, update the code to check PcdPlatformRecoverySupport > > > instead of the value of OsIndications variable (PlatformRecovery). > > > > > > I suggest to use the above title because of the length limitation. > > > And I also break the commit message into serval lines. > > > Here is the development process for edk open source link: > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Develop > > > ment- Process. That would help you to send a patch in a basic > > > correct format. > > > With the commit massage issue addressed, Reviewed-by: Zhichao Gao > > > > > > > > > Thanks, > > > Zhichao > > > > > > > -Original Message- > > > > From: devel@edk2.groups.io [mailto:devel@edk2.
[edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49631): https://edk2.groups.io/g/devel/message/49631 Mute This Topic: https://groups.io/mt/36927089/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2] [EmulatorPkg] using __debugbreak()
Kilian:
I normally modify the source code and insert CpuBreakpoint() function. That
will trig VS debugger for the source code.
Thanks
Liming
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Kilian
Kegel
Sent: Monday, October 28, 2019 9:01 PM
To: Gao, Liming
Cc: devel@edk2.groups.io; Richardson, Brian ;
Kinney, Michael D
Subject: [edk2-devel] [edk2] [EmulatorPkg] using __debugbreak()
Hi Liming,
If have observed in newer Windows 10 versions, when using __debugbreak()in any
application that Windows just terminates the app, instead offering to debug it.
So in WinHost.exe too.
That's why I usually insert the code snippet below to run into getchar()
when the program was started with the /debug command line switch.
As long as the App waits for the next keystroke, I can start the debugger
(VS2019)
and connect to WinHost.exe process for debugging.
Do you have a better solution without modifying the source code?
Thanks,
Kilian
if(1){
int i;
SecPrint
("##\n");
SecPrint ("add \"/debug\" command line switch, to connect to the
debugger at the very beginning of POST emulation\n");
SecPrint
("##\n");
if(Argc > 1){
for(i = 1 ; i < Argc ; i++){
if(0 == strcmp("/debug", Argv[i])){
//SecPrint("IF YOU WANT TO DEBUG from the very
beginning of the EMULATION:\n\t1. start the TASKMGR\n\t2. connect WinHost.exe
to the debugger\n\t3. and press ENTER in this command box\nOR\n");
SecPrint("\t1. start Visual Studio\n");
SecPrint("\t2. DEBUG->ATTACH TO PROCESS (CTRL + ALT +
P) --> WinHost.exe\n");
SecPrint("\t3. Break All (CTRL + ALT + Break) -->
WinHost.exe\n");
SecPrint("\t4. SET A SOFTWARE BREAKPOINT (F9) in line
445\n");
SecPrint("\t5. and press ENTER in this command box\n");
SecPrint("\t6. go back to Visual Studio an RUN/SINGLE
STEP the application\n");
SecPrint("\t7. otherwise press enter to continue...\n");
getchar();
//
// 1. SET A SOFTWARE BREAKPOINT TO THE NEXT LINE of
code below -->> SecPrint("");
// 2. switch to the command box and press ENTER
// 3. start single stepping the entire boot/emulation
process, good luck...
//
SecPrint("");//now you can single step the entire
boot/emulation process, good luck...
}
}
}
}
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49630): https://edk2.groups.io/g/devel/message/49630
Mute This Topic: https://groups.io/mt/38879075/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
Qing:
Please send patch mail instead of the attachment.
Thanks
Liming
>-Original Message-
>From: Huang, Qing
>Sent: Wednesday, October 30, 2019 11:35 AM
>To: Gao, Liming ; devel@edk2.groups.io
>Subject: RE: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory
>attributes
>
>Add V2 patch to add some description for these new memory type from UEFI
>2.8 spec.
>
>Thanks & Best regards,
>Huang, Qing
>
>
>> -Original Message-
>> From: Gao, Liming
>> Sent: Wednesday, October 30, 2019 9:17 AM
>> To: Huang, Qing ; devel@edk2.groups.io
>> Subject: RE: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory
>> attributes
>>
>> Reviewed-by: Liming Gao
>>
>> >-Original Message-
>> >From: Huang, Qing
>> >Sent: Thursday, October 24, 2019 10:34 AM
>> >To: devel@edk2.groups.io
>> >Cc: Gao, Liming
>> >Subject: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory
>attributes
>> >
>> >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2309
>> >Add EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO definition into
>UEFI
>> >specification header file.
>> >
>> >Signed-off-by: Qing Huang
>> >Cc: Liming Gao
>> >---
>> > MdePkg/Include/Uefi/UefiSpec.h | 7 +++
>> > 1 file changed, 7 insertions(+)
>> >
>> >diff --git a/MdePkg/Include/Uefi/UefiSpec.h
>> >b/MdePkg/Include/Uefi/UefiSpec.h index 44a0a6a7fa..50fae6f013 100644
>> >--- a/MdePkg/Include/Uefi/UefiSpec.h
>> >+++ b/MdePkg/Include/Uefi/UefiSpec.h
>> >@@ -82,6 +82,13 @@ typedef enum {
>> > // If all memory has the same reliability, then this bit is not used.
>> > //
>> > #define EFI_MEMORY_MORE_RELIABLE0x0001ULL
>> >+
>> >+//
>> >+// Note: UEFI spec 2.8 and following:
>> >+//
>> >+#define EFI_MEMORY_SP 0x0004ULL
>> >+#define EFI_MEMORY_CPU_CRYPTO 0x0008ULL
>> >+
>> > //
>> > // Runtime memory attribute
>> > //
>> >--
>> >2.17.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49629): https://edk2.groups.io/g/devel/message/49629
Mute This Topic: https://groups.io/mt/36927089/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
Add V2 patch to add some description for these new memory type from UEFI 2.8
spec.
Thanks & Best regards,
Huang, Qing
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, October 30, 2019 9:17 AM
> To: Huang, Qing ; devel@edk2.groups.io
> Subject: RE: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory
> attributes
>
> Reviewed-by: Liming Gao
>
> >-Original Message-
> >From: Huang, Qing
> >Sent: Thursday, October 24, 2019 10:34 AM
> >To: devel@edk2.groups.io
> >Cc: Gao, Liming
> >Subject: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
> >
> >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2309
> >Add EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO definition into UEFI
> >specification header file.
> >
> >Signed-off-by: Qing Huang
> >Cc: Liming Gao
> >---
> > MdePkg/Include/Uefi/UefiSpec.h | 7 +++
> > 1 file changed, 7 insertions(+)
> >
> >diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> >b/MdePkg/Include/Uefi/UefiSpec.h index 44a0a6a7fa..50fae6f013 100644
> >--- a/MdePkg/Include/Uefi/UefiSpec.h
> >+++ b/MdePkg/Include/Uefi/UefiSpec.h
> >@@ -82,6 +82,13 @@ typedef enum {
> > // If all memory has the same reliability, then this bit is not used.
> > //
> > #define EFI_MEMORY_MORE_RELIABLE0x0001ULL
> >+
> >+//
> >+// Note: UEFI spec 2.8 and following:
> >+//
> >+#define EFI_MEMORY_SP 0x0004ULL
> >+#define EFI_MEMORY_CPU_CRYPTO 0x0008ULL
> >+
> > //
> > // Runtime memory attribute
> > //
> >--
> >2.17.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49628): https://edk2.groups.io/g/devel/message/49628
Mute This Topic: https://groups.io/mt/36927089/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
0001-MdePkg-UefiSpec.h-Add-UEFI-2.8-new-memory-attributes-V2.patch
Description: 0001-MdePkg-UefiSpec.h-Add-UEFI-2.8-new-memory-attributes-V2.patch
[edk2-devel] [PATCH] Support skipping automatic BM enumeration
Right now, any and every handle with a BlockIO or SimpleFileSystem or LoadFile protocol installed on the system is used to enumerate BM automatically. There may be cases where on a platform, some of these are not desirable to be enumerated automatically. This patch adds support for skipping this automatic enumeration if on the same handle, a new protocol defined as EdkiiSkipBmAutoEnumerate is found to be installed. Ashish Singhal (1): MdeModulePkg/UefiBootManagerLib: Support skipping BM enumeration .../Include/Protocol/SkipBmAutoEnumerate.h | 25 ++ MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 40 +- .../Library/UefiBootManagerLib/InternalBm.h| 1 + .../UefiBootManagerLib/UefiBootManagerLib.inf | 1 + MdeModulePkg/MdeModulePkg.dec | 3 ++ 5 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 MdeModulePkg/Include/Protocol/SkipBmAutoEnumerate.h -- 2.7.4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49626): https://edk2.groups.io/g/devel/message/49626 Mute This Topic: https://groups.io/mt/39747302/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Support skipping BM enumeration
Allow support for skipping auto enumeration of a BlockIO or
SimpleFileSystem or LoadFile protocol based on a new protocol
installed on the same handle. EdkiiSkipBmAutoEnumerate protocol
has been added for that purpose.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/SkipBmAutoEnumerate.h | 25 ++
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 40 +-
.../Library/UefiBootManagerLib/InternalBm.h| 1 +
.../UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
MdeModulePkg/MdeModulePkg.dec | 3 ++
5 files changed, 69 insertions(+), 1 deletion(-)
create mode 100644 MdeModulePkg/Include/Protocol/SkipBmAutoEnumerate.h
diff --git a/MdeModulePkg/Include/Protocol/SkipBmAutoEnumerate.h
b/MdeModulePkg/Include/Protocol/SkipBmAutoEnumerate.h
new file mode 100644
index 000..7efca7a
--- /dev/null
+++ b/MdeModulePkg/Include/Protocol/SkipBmAutoEnumerate.h
@@ -0,0 +1,25 @@
+/** @file
+ Skip Boot Manager Auto Enumerate protocol header file.
+
+ This is used to skip auto boot manager enumeration. This protocol can
+ be installed on any handle having BlockIo or SimpleFileSystem or LoadFile
+ protocol and UEFI boot manager would skip its enumeration.
+
+Copyright (c) 2019, NVIDIA Corporation. All rights reserved.
+
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef _SKIP_BM_AUTO_ENUMERATE_PROTOCOL_H_
+#define _SKIP_BM_AUTO_ENUMERATE_PROTOCOL_H_
+
+///
+/// Global ID for the EDKII SKIP BM AUTO ENUMERATE Protocol.
+///
+#define EDKII_SKIP_BM_AUTO_ENUMERATE_PROTOCOL_GUID \
+ { 0x2733f321, 0x5a7e, 0x4178, { 0x86, 0xcc, 0x21, 0x65, 0xd2, 0x0c, 0xec,
0x1e }}
+
+extern EFI_GUID gEdkiiSkipBmAutoEnumerateProtocolGuid;
+
+#endif
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
index 760d764..7b5f176 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
@@ -2080,6 +2080,7 @@ BmEnumerateBootOptions (
UINTN HandleCount;
EFI_HANDLE*Handles;
EFI_BLOCK_IO_PROTOCOL *BlkIo;
+ VOID *SkipBmAutoEnumerate;
UINTN Removable;
UINTN Index;
CHAR16*Description;
@@ -2111,6 +2112,18 @@ BmEnumerateBootOptions (
continue;
}
+ Status = gBS->HandleProtocol (
+ Handles[Index],
+ &gEdkiiSkipBmAutoEnumerateProtocolGuid,
+ (VOID **) &SkipBmAutoEnumerate
+ );
+ if (!EFI_ERROR (Status)) {
+//
+// Skip if the file system handle supports a SkipBmAutoEnumerate
protocol
+//
+continue;
+ }
+
//
// Skip the logical partitions
//
@@ -2169,12 +2182,25 @@ BmEnumerateBootOptions (
&gEfiBlockIoProtocolGuid,
(VOID **) &BlkIo
);
- if (!EFI_ERROR (Status)) {
+if (!EFI_ERROR (Status)) {
//
// Skip if the file system handle supports a BlkIo protocol, which
we've handled in above
//
continue;
}
+
+Status = gBS->HandleProtocol (
+Handles[Index],
+&gEdkiiSkipBmAutoEnumerateProtocolGuid,
+(VOID **) &SkipBmAutoEnumerate
+);
+if (!EFI_ERROR (Status)) {
+ //
+ // Skip if the file system handle supports a SkipBmAutoEnumerate
protocol
+ //
+ continue;
+}
+
Description = BmGetBootDescription (Handles[Index]);
BootOptions = ReallocatePool (
sizeof (EFI_BOOT_MANAGER_LOAD_OPTION) * (*BootOptionCount),
@@ -2212,6 +2238,18 @@ BmEnumerateBootOptions (
&Handles
);
for (Index = 0; Index < HandleCount; Index++) {
+Status = gBS->HandleProtocol (
+Handles[Index],
+&gEdkiiSkipBmAutoEnumerateProtocolGuid,
+(VOID **) &SkipBmAutoEnumerate
+);
+if (!EFI_ERROR (Status)) {
+ //
+ // Skip if the file system handle supports a SkipBmAutoEnumerate
protocol
+ //
+ continue;
+}
+
//
// Ignore BootManagerMenu. its boot option will be created by
EfiBootManagerGetBootManagerMenu().
//
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
index 027eb25..f95e58f 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
+++ b/MdeModulePkg/Library/UefiBootManagerLib/InternalBm.h
@@ -41,6 +41,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include
#include
#include
+#include
#include
#include
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
b/MdeModulePkg/Library/UefiBootManagerLib/Uefi
[edk2-devel] [PATCH] EmbeddedPkg/DtPlatformDxe: Add DT/ACPI Default Flexibility
Add a PCD to govern whether to use DT or ACPI in case the
variable governing this is not found or is not valid.
Signed-off-by: Ashish Singhal
---
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c | 16 ++--
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf | 3 +++
EmbeddedPkg/EmbeddedPkg.dec | 5 +
3 files changed, 18 insertions(+), 6 deletions(-)
diff --git a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c
b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c
index 907d46a..e35ca33 100644
--- a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c
+++ b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c
@@ -124,18 +124,22 @@ DtPlatformDxeEntryPoint (
Status = gRT->GetVariable(DT_ACPI_VARIABLE_NAME, &gDtPlatformFormSetGuid,
NULL, &BufferSize, &DtAcpiPref);
if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_WARN, "%a: no DT/ACPI preference found, defaulting to
DT\n",
-__FUNCTION__));
- DtAcpiPref.Pref = DT_ACPI_SELECT_DT;
+ DEBUG ((DEBUG_WARN, "%a: no DT/ACPI preference found, defaulting to
%s\n",
+__FUNCTION__, PcdGetBool (PcdDefaultDtPref) ? L"DT" : L"ACPI"));
+ DtAcpiPref.Pref = PcdGetBool (PcdDefaultDtPref) ?
+ DT_ACPI_SELECT_DT :
+ DT_ACPI_SELECT_ACPI;
}
}
if (!EFI_ERROR (Status) &&
DtAcpiPref.Pref != DT_ACPI_SELECT_ACPI &&
DtAcpiPref.Pref != DT_ACPI_SELECT_DT) {
-DEBUG ((DEBUG_WARN, "%a: invalid value for %s, defaulting to DT\n",
- __FUNCTION__, DT_ACPI_VARIABLE_NAME));
-DtAcpiPref.Pref = DT_ACPI_SELECT_DT;
+DEBUG ((DEBUG_WARN, "%a: invalid value for %s, defaulting to %s\n",
+ __FUNCTION__, DT_ACPI_VARIABLE_NAME, PcdGetBool (PcdDefaultDtPref) ?
L"DT" : L"ACPI"));
+DtAcpiPref.Pref = PcdGetBool (PcdDefaultDtPref) ?
+DT_ACPI_SELECT_DT :
+DT_ACPI_SELECT_ACPI;
Status = EFI_INVALID_PARAMETER; // trigger setvar below
}
diff --git a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf
b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf
index b68f154..450ea29 100644
--- a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf
+++ b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf
@@ -46,6 +46,9 @@
gEdkiiPlatformHasAcpiGuid
gFdtTableGuid
+[Pcd]
+ gEmbeddedTokenSpaceGuid.PcdDefaultDtPref
+
[Depex]
gEfiVariableArchProtocolGuidAND
gEfiVariableWriteArchProtocolGuid
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
index bbaadc5..8812a6d 100644
--- a/EmbeddedPkg/EmbeddedPkg.dec
+++ b/EmbeddedPkg/EmbeddedPkg.dec
@@ -185,3 +185,8 @@
# truncation on overflow to specify negative offsets.
#
gEmbeddedTokenSpaceGuid.PcdDmaDeviceOffset|0x0|UINT64|0x058
+
+ #
+ # Selection between DT and ACPI as a default
+ #
+ gEmbeddedTokenSpaceGuid.PcdDefaultDtPref|TRUE|BOOLEAN|0x059
--
2.7.4
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49624): https://edk2.groups.io/g/devel/message/49624
Mute This Topic: https://groups.io/mt/39747241/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] Add DT/ACPI Default Flexibility
Some platforms which support both DT as well as ACPI may need the flexibility to allow either of these 2 as default preference. This change introduces a boolean PCD which tells whether DT is the default preference or not. Ashish Singhal (1): EmbeddedPkg/DtPlatformDxe: Add DT/ACPI Default Flexibility EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c | 16 ++-- EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf | 3 +++ EmbeddedPkg/EmbeddedPkg.dec | 5 + 3 files changed, 18 insertions(+), 6 deletions(-) -- 2.7.4 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49625): https://edk2.groups.io/g/devel/message/49625 Mute This Topic: https://groups.io/mt/39747242/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v3] CryptoPkg: Upgrade OpenSSL to 1.1.1d
Update openssl from 1.1.1b to 1.1.1d.
Something needs to be noticed is that, there is a bug existing in the
released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
which causes build failure. So we switch the code base to a usable
version, which is 2 commits later than the stable tag.
Now we use the version c3656cc594daac8167721dde7220f0e59ae146fc.
This log is to fix the build failure.
https://bugzilla.tianocore.org/show_bug.cgi?id=2226
Besides, the absense of "DSO_NONE" in dso_conf.h causes build failure
in OvmfPkg. So update process_files.pl to generate information from
"crypto/include/internal/dso_conf.h.in".
This patch has been tested on Kaby Lake platform.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
v2: Revert the changes in OpensslLib.inf and OpensslLibCrypto.inf.
The removed header files could be auto-generated by process_files.pl now.
v3: Add display information for dso_conf.h.
CryptoPkg/Library/Include/internal/dso_conf.h | 16
CryptoPkg/Library/OpensslLib/openssl | 2 +-
CryptoPkg/Library/OpensslLib/process_files.pl | 15 ++-
3 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/CryptoPkg/Library/Include/internal/dso_conf.h
b/CryptoPkg/Library/Include/internal/dso_conf.h
index e69de29bb2d1..43c891588bc2 100644
--- a/CryptoPkg/Library/Include/internal/dso_conf.h
+++ b/CryptoPkg/Library/Include/internal/dso_conf.h
@@ -0,0 +1,16 @@
+/* WARNING: do not edit! */
+/* Generated from crypto/include/internal/dso_conf.h.in */
+/*
+ * Copyright 2016-2019 The OpenSSL Project Authors. All Rights Reserved.
+ *
+ * Licensed under the OpenSSL license (the "License"). You may not use
+ * this file except in compliance with the License. You can obtain a copy
+ * in the file LICENSE in the source distribution or at
+ * https://www.openssl.org/source/license.html
+ */
+
+#ifndef HEADER_DSO_CONF_H
+# define HEADER_DSO_CONF_H
+# define DSO_NONE
+# define DSO_EXTENSION ".so"
+#endif
diff --git a/CryptoPkg/Library/OpensslLib/openssl
b/CryptoPkg/Library/OpensslLib/openssl
index 50eaac9f3337..c3656cc594da 16
--- a/CryptoPkg/Library/OpensslLib/openssl
+++ b/CryptoPkg/Library/OpensslLib/openssl
@@ -1 +1 @@
-Subproject commit 50eaac9f3337667259de725451f201e784599687
+Subproject commit c3656cc594daac8167721dde7220f0e59ae146fc
diff --git a/CryptoPkg/Library/OpensslLib/process_files.pl
b/CryptoPkg/Library/OpensslLib/process_files.pl
index e13c0acb4dda..80dc3548bfba 100755
--- a/CryptoPkg/Library/OpensslLib/process_files.pl
+++ b/CryptoPkg/Library/OpensslLib/process_files.pl
@@ -106,6 +106,14 @@ BEGIN {
) == 0 ||
die "Failed to generate opensslconf.h!\n";
+# Generate dso_conf.h per config data
+system(
+"perl -I. -Mconfigdata util/dofile.pl " .
+"crypto/include/internal/dso_conf.h.in " .
+"> include/internal/dso_conf.h"
+) == 0 ||
+die "Failed to generate dso_conf.h!\n";
+
chdir($basedir) ||
die "Cannot change to base directory \"" . $basedir . "\"";
@@ -221,12 +229,17 @@ rename( $new_inf_file, $inf_file ) ||
print "Done!";
#
-# Copy opensslconf.h generated from OpenSSL Configuration
+# Copy opensslconf.h and dso_conf.h generated from OpenSSL Configuration
#
print "\n--> Duplicating opensslconf.h into Include/openssl ... ";
copy($OPENSSL_PATH . "/include/openssl/opensslconf.h",
$OPENSSL_PATH . "/../../Include/openssl/") ||
die "Cannot copy opensslconf.h!";
+print "Done!";
+print "\n--> Duplicating dso_conf.h into Include/internal ... ";
+copy($OPENSSL_PATH . "/include/internal/dso_conf.h",
+ $OPENSSL_PATH . "/../../Include/internal/") ||
+ die "Cannot copy dso_conf.h!";
print "Done!\n";
print "\nProcessing Files Done!\n";
--
2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49623): https://edk2.groups.io/g/devel/message/49623
Mute This Topic: https://groups.io/mt/39747034/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file
OK, if it makes a difference for tools (and security updates), let's try to keep it. (*grumble*) *But* given its too-generic name, can we add a big bold comment header to the file explaining what it is? Some quick searching suggests lines starting with # are ignored, so hopefully this should be possible? Best Regards, Leif On Tue, Oct 29, 2019 at 07:52:48PM -0700, Sean via Groups.Io wrote: > It is a convention for projects using python. It definitely isn't required > but there are some features that come for free when using that filename. > > https://github.blog/2018-07-12-security-vulnerability-alerts-for-python/ > and > https://help.github.com/en/github/visualizing-repository-data-with-graphs/listing-the-packages-that-a-repository-depends-on > > You can also get more insight from github into dependencies and dependents. > example: > https://github.com/tianocore/edk2-pytool-extensions/network/dependencies > > I did notice on the example from above that github picked up the > requirements.publisher.txt so i don't know what their pattern matching does > exactly. > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49622): https://edk2.groups.io/g/devel/message/49622 Mute This Topic: https://groups.io/mt/39614157/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v3 22/22] Readme.md: Add CI build status badges
On Tue, Oct 29, 2019 at 12:55:17PM -0700, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2315 > > Update Readme.md with status badges from the most recent > EDK II Continuous Integration(CI) build. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > Readme.md | 29 ++--- > 1 file changed, 22 insertions(+), 7 deletions(-) > > diff --git a/Readme.md b/Readme.md > index 27e4ce0771..37183c3265 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -3,6 +3,19 @@ > A modern, feature-rich, cross-platform firmware development environment > for the UEFI and PI specifications from www.uefi.org. > > +## Build Status > + > +| Host Type | Toolchain | Branch | Build Status | Test Status | Code > Coverage | This may sound like nitpicking, but I think it's important for messaging: we aren't listing tolchains, we are listing toolchain profiles. For VS, we are actually adding new profiles for each version, so that statement is not misleading. However, GCC5 is highly misleading (it is the profile we use for anything gcc5 onwards). I don't think we can usefully pull in information about the toolchain actually used, so I think the name of the column should really be toolchain profile. Even given that, I think it is time we create an abstracted GCC_CURRENT toolchain profile, pointing to GCC5. But if we rename the column, that may not be a prerequisite for this set. > +| : | : | : | :- | : | :--- | > +| Windows | VS2019 | master | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=14&branchName=master) > | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=14&branchName=master) > | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=14&branchName=master)| > +| Ubuntu | GCC5 | master | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=15&branchName=master) > | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=15&branchName=master) > | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=15&branchName=master) > | I have one problem with the above, which is that it turns an otherwise very readable in text mode file (which is half the point of .md) into what looks a little bit like a transmission error. While I agree there is value in having this on the default loaded github webpage, do we have other options? > + > +[More CI Build information](ci/readme.md) I don't see this file in the tree? Which is good, beacuse it doesn't follow name standards. > + > +## License Details > + > +[](License.txt) > + I don't mind this addition, but I think it should be a separate patch. I also think it would be best to hold this back until we've submoduled some of those otherwise licensed components. There is a very real likelihood of people skimming, seeing the image and ignoring the text. > The majority of the content in the EDK II open source project uses a > [BSD-2-Clause Plus Patent License](License.txt). The EDK II open source > project > contains the following components that are covered by additional licenses: > @@ -20,7 +33,8 @@ contains the following components that are covered by > additional licenses: > The EDK II Project is composed of packages. The maintainers for each package > are listed in [Maintainers.txt](Maintainers.txt). > > -# Resources > +## Resources > + No objections to change, but it is unrelated to this patch. > * [TianoCore](http://www.tianocore.org) > * [EDK II](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II) > * [Getting Started with EDK > II](https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with-EDK-II) > @@ -29,7 +43,8 @@ are listed in [Maintainers.txt](Maintainers.txt). > * [How To > Contribute](https://github.com/tianocore/tianocore.github.io/wiki/How-To-Contribute) > * [Release > Planning](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning) > > -# Code Contributions > +## Code Contributions > + No objection to change, but it is unrelated to this patch. > To make a contribution to a TianoCore project, follow these steps. > 1. Create a change description in the format specified b
Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file
It is a convention for projects using python. It definitely isn't required but there are some features that come for free when using that filename. https://github.blog/2018-07-12-security-vulnerability-alerts-for-python/ and https://help.github.com/en/github/visualizing-repository-data-with-graphs/listing-the-packages-that-a-repository-depends-on You can also get more insight from github into dependencies and dependents. example: https://github.com/tianocore/edk2-pytool-extensions/network/dependencies I did notice on the example from above that github picked up the requirements.publisher.txt so i don't know what their pattern matching does exactly. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49620): https://edk2.groups.io/g/devel/message/49620 Mute This Topic: https://groups.io/mt/39614157/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct Platform Hook Library references
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Wednesday, October 30, 2019 7:05 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct > Platform Hook Library references > > Many file descriptions reference "Platform Hook Library" when the file is not > related to the PlatformHookLib library class. This change updates those > references in WhiskeylakeOpenBoardPkg to a more accurate description. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Signed-off-by: Michael Kubacki > --- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.inf | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmMultiBoardAcpiSupportLib.inf | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmBoardAcpiEnableLib.c | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmSiliconAcpiEnableLib.c | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardA > cpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiBoardInitPostMemLib.c | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiBoardInitPreMemLib.c | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiMultiBoardInitPostMemLib.c | 2 +- > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardI > nitLib/PeiMultiBoardInitPreMemLib.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) > > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.inf > index c3fd60007a..7c360a8043 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmBoardAcpiEnableLib.inf > @@ -1,5 +1,5 @@ > ## @file > -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB. > +# Whiskey Lake U RVP SMM Board ACPI Enable library > # > # > # Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.inf > index eaf46ad4ef..32e63b15ce 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmMultiBoardAcpiSupportLib.inf > @@ -1,5 +1,5 @@ > ## @file > -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB. > +# Whiskey Lake U RVP SMM Multi-Board ACPI Support library > # > # > # Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.c > index e7acbda03a..1554b568d7 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmBoardAcpiEnableLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmBoardAcpiEnableLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP SMM Board ACPI Enable library > > >Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.c > index 5fc61861a6..6ff78c2946 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > +++ rdAcpiLib/SmmMultiBoardAcpiSupportLib.c > @@ -1,5 +1,5 @@ > /** @file > - Platform Hook Library instances > + Whiskey Lake U RVP SMM Multi-Board ACPI Support library > > >Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boar > dAcpiLib/SmmSiliconAcpiEnableLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/W
Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Correct Platform Hook Library references
Reviewed-by: Chasel Chiu > -Original Message- > From: Kubacki, Michael A > Sent: Wednesday, October 30, 2019 7:05 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Jeremy Soller > Subject: [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Correct > Platform Hook Library references > > Many file descriptions reference "Platform Hook Library" when the file is not > related to the PlatformHookLib library class. This change updates those > references in KabylakeOpenBoardPkg to a more accurate description. > > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Jeremy Soller > Signed-off-by: Michael Kubacki > --- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf| 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmBoardAcpiEnableLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Sm > mGalagoPro3AcpiEnableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.c | 4 ++-- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeKabylakeRvp3AcpiTableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmBoardAcpiEnableLib.c | 4 ++-- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmKabylakeRvp3AcpiEnableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmSiliconAcpiEnableLib.c | 10 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiBoardInitPostMemLib.c| 4 ++-- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiBoardInitPreMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c| 2 +- > 16 files changed, 23 insertions(+), 23 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeBoardAcpiTableLib.inf > index e7a30a726a..bfb58e868f 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeBoardAcpiTableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeBoardAcpiTableLib.inf > @@ -1,5 +1,5 @@ > ### @file > -# Platform Hook Library instance for Kaby Lake RVP3. > +# Kaby Lake RVP 3 Board ACPI library > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.inf > index 0bd821ffbb..00cdbe80ce 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.inf > @@ -1,5 +1,5 @@ > ### @file > -# Platform Hook Library instance for Kaby Lake RVP3. > +# Kaby Lake RVP 3 Multi-Board ACPI Support library > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmBoardAcpiEnableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmBoardAcpiEnableLib.inf > index cad0caa79c..46a714dc1d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmBoardAcpiEnableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmBoardAcpiEnableLib.inf > @@ -1,5 +1,5 @@ > ### @file > -# Platform Hook Library instance for Kaby Lake RVP3. > +# Kaby Lake RVP 3 SMM Board ACPI Enable library > # > # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmMultiBoardAcpiSupportLib.inf > index 6628d30b6b..fca63c8314 100644 > --- > a/P
Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to generate .h files
Pushed at 9f4fbd56d43054cc73d722c1643659f9741c0fcf Regards, Jian > -Original Message- > From: Lu, XiaoyuX > Sent: Tuesday, October 29, 2019 6:01 PM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: RE: [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to > generate .h files > > Reviewed-by: Xiaoyu Lu > > > -Original Message- > > From: Zhang, Shenglei > > Sent: Tuesday, October 29, 2019 3:43 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, XiaoyuX > > Subject: [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to > > generate .h files > > > > There are missing headers added into INF files at 8906f076de35b222a.. > > They are now manually added but not auto-generated. So we update the > > perl script to enable this feature. > > Meanwhile, update the order of the .h files in INF files, which are > > auto-generated now. > > https://bugzilla.tianocore.org/show_bug.cgi?id=2085 > > > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Signed-off-by: Shenglei Zhang > > --- > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 103 +- > > .../Library/OpensslLib/OpensslLibCrypto.inf | 96 > > CryptoPkg/Library/OpensslLib/process_files.pl | 28 + > > 3 files changed, 129 insertions(+), 98 deletions(-) > > > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > index b40d82783b4b..b28dd9e4800c 100644 > > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > > @@ -34,9 +34,7 @@ [Sources] > >$(OPENSSL_PATH)/crypto/aes/aes_misc.c > >$(OPENSSL_PATH)/crypto/aes/aes_ofb.c > >$(OPENSSL_PATH)/crypto/aes/aes_wrap.c > > - $(OPENSSL_PATH)/crypto/aes/aes_locl.h > >$(OPENSSL_PATH)/crypto/aria/aria.c > > - $(OPENSSL_PATH)/crypto/arm_arch.h > >$(OPENSSL_PATH)/crypto/asn1/a_bitstr.c > >$(OPENSSL_PATH)/crypto/asn1/a_d2i_fp.c > >$(OPENSSL_PATH)/crypto/asn1/a_digest.c > > @@ -101,21 +99,12 @@ [Sources] > >$(OPENSSL_PATH)/crypto/asn1/x_sig.c > >$(OPENSSL_PATH)/crypto/asn1/x_spki.c > >$(OPENSSL_PATH)/crypto/asn1/x_val.c > > - $(OPENSSL_PATH)/crypto/asn1/standard_methods.h > > - $(OPENSSL_PATH)/crypto/asn1/charmap.h > > - $(OPENSSL_PATH)/crypto/asn1/tbl_standard.h > > - $(OPENSSL_PATH)/crypto/asn1/asn1_item_list.h > > - $(OPENSSL_PATH)/crypto/asn1/asn1_locl.h > >$(OPENSSL_PATH)/crypto/async/arch/async_null.c > >$(OPENSSL_PATH)/crypto/async/arch/async_posix.c > >$(OPENSSL_PATH)/crypto/async/arch/async_win.c > >$(OPENSSL_PATH)/crypto/async/async.c > >$(OPENSSL_PATH)/crypto/async/async_err.c > >$(OPENSSL_PATH)/crypto/async/async_wait.c > > - $(OPENSSL_PATH)/crypto/async/arch/async_win.h > > - $(OPENSSL_PATH)/crypto/async/async_locl.h > > - $(OPENSSL_PATH)/crypto/async/arch/async_posix.h > > - $(OPENSSL_PATH)/crypto/async/arch/async_null.h > >$(OPENSSL_PATH)/crypto/bio/b_addr.c > >$(OPENSSL_PATH)/crypto/bio/b_dump.c > >$(OPENSSL_PATH)/crypto/bio/b_sock.c > > @@ -138,7 +127,6 @@ [Sources] > >$(OPENSSL_PATH)/crypto/bio/bss_mem.c > >$(OPENSSL_PATH)/crypto/bio/bss_null.c > >$(OPENSSL_PATH)/crypto/bio/bss_sock.c > > - $(OPENSSL_PATH)/crypto/bio/bio_lcl.h > >$(OPENSSL_PATH)/crypto/bn/bn_add.c > >$(OPENSSL_PATH)/crypto/bn/bn_asm.c > >$(OPENSSL_PATH)/crypto/bn/bn_blind.c > > @@ -170,9 +158,6 @@ [Sources] > >$(OPENSSL_PATH)/crypto/bn/bn_srp.c > >$(OPENSSL_PATH)/crypto/bn/bn_word.c > >$(OPENSSL_PATH)/crypto/bn/bn_x931p.c > > - $(OPENSSL_PATH)/crypto/bn/rsaz_exp.h > > - $(OPENSSL_PATH)/crypto/bn/bn_prime.h > > - $(OPENSSL_PATH)/crypto/bn/bn_lcl.h > >$(OPENSSL_PATH)/crypto/buffer/buf_err.c > >$(OPENSSL_PATH)/crypto/buffer/buffer.c > >$(OPENSSL_PATH)/crypto/cmac/cm_ameth.c > > @@ -181,7 +166,6 @@ [Sources] > >$(OPENSSL_PATH)/crypto/comp/c_zlib.c > >$(OPENSSL_PATH)/crypto/comp/comp_err.c > >$(OPENSSL_PATH)/crypto/comp/comp_lib.c > > - $(OPENSSL_PATH)/crypto/comp/comp_lcl.h > >$(OPENSSL_PATH)/crypto/conf/conf_api.c > >$(OPENSSL_PATH)/crypto/conf/conf_def.c > >$(OPENSSL_PATH)/crypto/conf/conf_err.c > > @@ -190,8 +174,6 @@ [Sources] > >$(OPENSSL_PATH)/crypto/conf/conf_mod.c > >$(OPENSSL_PATH)/crypto/conf/conf_sap.c > >$(OPENSSL_PATH)/crypto/conf/conf_ssl.c > > - $(OPENSSL_PATH)/crypto/conf/conf_lcl.h > > - $(OPENSSL_PATH)/crypto/conf/conf_def.h > >$(OPENSSL_PATH)/crypto/cpt_err.c > >$(OPENSSL_PATH)/crypto/cryptlib.c > >$(OPENSSL_PATH)/crypto/ctype.c > > @@ -215,8 +197,6 @@ [Sources] > >$(OPENSSL_PATH)/crypto/des/set_key.c > >$(OPENSSL_PATH)/crypto/des/str2key.c > >$(OPENSSL_PATH)/crypto/des/xcbc_enc.c > > - $(OPENSSL_PATH)/crypto/des/spr.h > > - $(OPENSSL_PATH)/crypto/des/des_locl.h > >$(OPENSSL_PATH)/crypto/dh/dh_ameth.c > >$(OPENSSL_PATH)/crypto/dh/dh_asn1.c > >$(OPENSSL_PATH)/crypto/dh/dh_check.c > > @@ -231,7 +211,6 @@ [Sources] > >$(OPE
Re: [edk2-devel] [Patch v3 01/22] Maintainers.txt: Add continuous integration(CI) directories
On Tue, Oct 29, 2019 at 12:54:56PM -0700, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=2315 > > Add maintainers and reviewers for the directories associated > with continuous integration steps. > * .azurepipelines > * .mergify > * .pytool > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney Reviewed-by: Leif Lindholm With the added preference that the addition be moved before the EDK II Packages: section (since C comes before P). But it is just a preference. / Leif > --- > Maintainers.txt | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 71a34a2845..1fb38ddc5b 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -460,3 +460,26 @@ F: StandaloneMmPkg/ > M: Achin Gupta > M: Jiewen Yao > R: Supreeth Venkatesh > + > +EDK II Continuous Integration: > +-- > +.azurepipelines/ > +F: .azurepipelines/ > +M: Sean Brogan > +M: Bret Barkelew > +R: Michael D Kinney > +R: Liming Gao > + > +.mergify/ > +F: .mergify/ > +M: Michael D Kinney > +M: Liming Gao > +R: Sean Brogan > +R: Bret Barkelew > + > +.pytool/ > +F: .pytool/ > +M: Sean Brogan > +M: Bret Barkelew > +R: Michael D Kinney > +R: Liming Gao > -- > 2.21.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49616): https://edk2.groups.io/g/devel/message/49616 Mute This Topic: https://groups.io/mt/39614153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode
On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D Kinney wrote: > From: Sean Brogan > > https://bugzilla.tianocore.org/show_bug.cgi?id=2315 > > Update .gitignore to ignore .pyc files and __pycache__ > directories. Python based plugins can be added to any > package or platform, so these files and directories may > be present outside of BaseTools. > > Ignore _extdep directories that are generated by the > pytool external dependency feature. > > Ignore .vscode directories generated by the VS Code > editor. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Kinney Reviewed-by: Leif Lindholm (This one could be merged independently of rest of set, it's useful on its own.) > --- > .gitignore | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/.gitignore b/.gitignore > index 97f22c348c..71679478ac 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,3 +1,8 @@ > Build/ > tags/ > .DS_Store > +*.pyc > +__pycache__/ > +*_extdep/ > + > +.vscode/ > -- > 2.21.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49615): https://edk2.groups.io/g/devel/message/49615 Mute This Topic: https://groups.io/mt/39614156/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file
On Tue, Oct 29, 2019 at 12:54:58PM -0700, Michael D Kinney wrote: > From: Sean Brogan > > https://bugzilla.tianocore.org/show_bug.cgi?id=2315 > > Add pip requirements file that is used to install the > python pip modules build from the edk2-pytool-library and > edk2-pytool-extensions repositories. > > These python modules provide the extensions required to > perform EDK II Continuous Integration(CI) builds. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > requirements.txt | 2 ++ This ia an extremely generic name for a file with very specific content. Is this a magic name, or could we rename it (for example) pip-requirements.txt? / Leif > 1 file changed, 2 insertions(+) > create mode 100644 requirements.txt > > diff --git a/requirements.txt b/requirements.txt > new file mode 100644 > index 00..d4610f81c5 > --- /dev/null > +++ b/requirements.txt > @@ -0,0 +1,2 @@ > +edk2-pytool-library==0.10.* > +edk2-pytool-extensions==0.12.* > -- > 2.21.0.windows.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49614): https://edk2.groups.io/g/devel/message/49614 Mute This Topic: https://groups.io/mt/39614157/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
Reviewed-by: Liming Gao
>-Original Message-
>From: Huang, Qing
>Sent: Thursday, October 24, 2019 10:34 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming
>Subject: [PATCH] MdePkg-UefiSpec.h: Add UEFI 2.8 new memory attributes
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2309
>Add EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO definition into UEFI
>specification header file.
>
>Signed-off-by: Qing Huang
>Cc: Liming Gao
>---
> MdePkg/Include/Uefi/UefiSpec.h | 7 +++
> 1 file changed, 7 insertions(+)
>
>diff --git a/MdePkg/Include/Uefi/UefiSpec.h
>b/MdePkg/Include/Uefi/UefiSpec.h
>index 44a0a6a7fa..50fae6f013 100644
>--- a/MdePkg/Include/Uefi/UefiSpec.h
>+++ b/MdePkg/Include/Uefi/UefiSpec.h
>@@ -82,6 +82,13 @@ typedef enum {
> // If all memory has the same reliability, then this bit is not used.
> //
> #define EFI_MEMORY_MORE_RELIABLE0x0001ULL
>+
>+//
>+// Note: UEFI spec 2.8 and following:
>+//
>+#define EFI_MEMORY_SP 0x0004ULL
>+#define EFI_MEMORY_CPU_CRYPTO 0x0008ULL
>+
> //
> // Runtime memory attribute
> //
>--
>2.17.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49613): https://edk2.groups.io/g/devel/message/49613
Mute This Topic: https://groups.io/mt/36927089/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressPei: Fix Opal S3 unlock issue
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Monday, October 28, 2019 1:43 PM > To: Chu, Maggie; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Dong, Eric > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressPei: Fix Opal S3 > unlock issue > > > -Original Message- > > From: Chu, Maggie > > Sent: Monday, October 28, 2019 1:08 PM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A; Wang, Jian J; Ni, Ray; Zeng, Star; Dong, Eric > > Subject: [PATCH] MdeModulePkg/NvmExpressPei: Fix Opal S3 unlock issue > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=2312 > > > > This patch is for fixing unexpected system hang during S3 unlock process. > > FatPei driver maintained and updated internal BlockIo devices list > > when there is new BlockIo PPI has installed, and it relied on BlockIo PPI > service > > to get data from devices. Because BlockIo Ppi leverage NvmExpressPei Ppi to > > transit > > Nvm command to device, we should make sure NvmePassThruPpi installed > > before BlockIo PPI. > > > The change is good to me, > Reviewed-by: Hao A Wu > > If no other comment, I will adjust the length of some commit log message lines > when pushing this patch, since the PatchCheck.py script is complaining: > > The commit message format is not valid: > * Line 7 of commit message is too long. > * Line 8 of commit message is too long. > * Line 9 of commit message is too long. Patch has been pushed via commit dc254af6a4. Best Regards, Hao Wu > > Best Regards, > Hao Wu > > > > > > Signed-off-by: Maggie Chu > > Cc: Hao A Wu > > Cc: Jian J Wang > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Eric Dong > > --- > > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c | 43 > - > > - > > 1 file changed, 23 insertions(+), 20 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c > > b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c > > index 987eed420e..a8cb7f3a67 100644 > > --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c > > +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c > > @@ -376,6 +376,29 @@ NvmExpressPeimEntry ( > >continue; > > > > } > > > > > > > > +// > > > > +// Nvm Express Pass Thru PPI > > > > +// > > > > +Private->PassThruMode.Attributes= > > EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_PHYSICAL | > > > > + > > EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_LOGICAL | > > > > + > > EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_CMD_SET_NVM; > > > > +Private->PassThruMode.IoAlign = sizeof (UINTN); > > > > +Private->PassThruMode.NvmeVersion = > > EDKII_PEI_NVM_EXPRESS_PASS_THRU_PPI_REVISION; > > > > +Private->NvmePassThruPpi.Mode = &Private->PassThruMode; > > > > +Private->NvmePassThruPpi.GetDevicePath = > > NvmePassThruGetDevicePath; > > > > +Private->NvmePassThruPpi.GetNextNameSpace = > > NvmePassThruGetNextNameSpace; > > > > +Private->NvmePassThruPpi.PassThru = NvmePassThru; > > > > +CopyMem ( > > > > + &Private->NvmePassThruPpiList, > > > > + &mNvmePassThruPpiListTemplate, > > > > + sizeof (EFI_PEI_PPI_DESCRIPTOR) > > > > + ); > > > > +Private->NvmePassThruPpiList.Ppi= > > &Private->NvmePassThruPpi; > > > > +PeiServicesInstallPpi (&Private->NvmePassThruPpiList); > > > > + > > > > +// > > > > +// Block Io PPI > > > > +// > > > > Private->BlkIoPpi.GetNumberOfBlockDevices = > > NvmeBlockIoPeimGetDeviceNo; > > > > Private->BlkIoPpi.GetBlockDeviceMediaInfo = > > NvmeBlockIoPeimGetMediaInfo; > > > > Private->BlkIoPpi.ReadBlocks = NvmeBlockIoPeimReadBlocks; > > > > @@ -398,26 +421,6 @@ NvmExpressPeimEntry ( > > Private->BlkIo2PpiList.Ppi = &Private->BlkIo2Ppi; > > > > PeiServicesInstallPpi (&Private->BlkIoPpiList); > > > > > > > > -// > > > > -// Nvm Express Pass Thru PPI > > > > -// > > > > -Private->PassThruMode.Attributes= > > EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_PHYSICAL | > > > > - > > EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_LOGICAL | > > > > - > > EFI_NVM_EXPRESS_PASS_THRU_ATTRIBUTES_CMD_SET_NVM; > > > > -Private->PassThruMode.IoAlign = sizeof (UINTN); > > > > -Private->PassThruMode.NvmeVersion = > > EDKII_PEI_NVM_EXPRESS_PASS_THRU_PPI_REVISION; > > > > -Private->NvmePassThruPpi.Mode = &Private->PassThruMode; > > > > -Private->NvmePassThruPpi.GetDevicePath = > > NvmePassThruGetDevicePath; > > > > -Private->NvmePassThruPpi.GetNextNameSpace = > > NvmePassThruGetNextNameSpace; > > > > -Private->NvmePassThruPpi.PassThru = NvmePassThru; > > > > -CopyMem ( > > > > - &Private->NvmePassThruPpiList, > > > > - &mNvmePassThruPpiListTemplate, > > > > - sizeof (EFI_PEI_PPI_DESCRIPTOR) > > > > - ); > > > > -Private->NvmePa
[edk2-devel] [edk2-platforms][PATCH V1 0/2] Correct Platform Hook Library references
Many file descriptions reference "Platform Hook Library" when the file is not related to the PlatformHookLib library class. This change updates those references in KabylakeOpenBoardPkg and WhiskeylakeOpenBoardPkg to a more accurate description. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Jeremy Soller Signed-off-by: Michael Kubacki Michael Kubacki (2): KabylakeOpenBoardPkg: Correct Platform Hook Library references WhiskeylakeOpenBoardPkg: Correct Platform Hook Library references Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/SmmGalagoPro3AcpiEnableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeKabylakeRvp3AcpiTableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmKabylakeRvp3AcpiEnableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c | 10 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiBoardInitPostMemLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiBoardInitPreMemLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPostMemLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiBoardInitPostMemLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiBoardInitPreMemLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiMultiBoardInitPostMemLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.c | 2 +- 26 files changed, 33 insertions(+), 33 deletions(-) -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49609): https://edk2.groups.io/g/devel/message/49609 Mute This Topic: https://groups.io/mt/39695950/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH V1 2/2] WhiskeylakeOpenBoardPkg: Correct Platform Hook Library references
Many file descriptions reference "Platform Hook Library" when the file is not related to the PlatformHookLib library class. This change updates those references in WhiskeylakeOpenBoardPkg to a more accurate description. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmWhiskeylakeURvpAcpiEnableLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiBoardInitPostMemLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiBoardInitPreMemLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiMultiBoardInitPostMemLib.c | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf index c3fd60007a..7c360a8043 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf @@ -1,5 +1,5 @@ ## @file -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB. +# Whiskey Lake U RVP SMM Board ACPI Enable library # # # Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf index eaf46ad4ef..32e63b15ce 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf @@ -1,5 +1,5 @@ ## @file -# Platform Hook Library instance for Whiskeylake Mobile/Desktop CRB. +# Whiskey Lake U RVP SMM Multi-Board ACPI Support library # # # Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c index e7acbda03a..1554b568d7 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Whiskey Lake U RVP SMM Board ACPI Enable library Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c index 5fc61861a6..6ff78c2946 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Whiskey Lake U RVP SMM Multi-Board ACPI Support library Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c index 9daceaa25c..6d04e83be2 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Whiskey Lake U RVP SMM Silicon ACPI Enable library Copyright (c) 2019, Intel Corporation. All rights reserved. diff --git a/Platform/Intel/WhiskeylakeOpenB
[edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Correct Platform Hook Library references
Many file descriptions reference "Platform Hook Library" when the file is not related to the PlatformHookLib library class. This change updates those references in KabylakeOpenBoardPkg to a more accurate description. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/SmmGalagoPro3AcpiEnableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeKabylakeRvp3AcpiTableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmKabylakeRvp3AcpiEnableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c | 10 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiBoardInitPostMemLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiBoardInitPreMemLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPostMemLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPreMemLib.c | 2 +- 16 files changed, 23 insertions(+), 23 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf index e7a30a726a..bfb58e868f 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 Board ACPI library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf index 0bd821ffbb..00cdbe80ce 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 Multi-Board ACPI Support library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf index cad0caa79c..46a714dc1d 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 SMM Board ACPI Enable library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf index 6628d30b6b..fca63c8314 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 SMM Multi-Board ACPI Support library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved. # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/SmmGalagoPro3AcpiEnableLib.c b/Platform/Intel/KabylakeO
[edk2-devel] [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Add CmosAccessLib to BoardX58Ich10
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2164
Replaced Cmos.c and Cmos.h with BoardModulePkg's
Cmos library CmosAccessLib
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../BoardX58Ich10/OpenBoardPkg.dsc| 2 +
.../Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.c | 57 ---
.../Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.h | 50
.../SimicsOpenBoardPkg/SimicsPei/MemDetect.c | 4 +-
.../SimicsOpenBoardPkg/SimicsPei/Platform.c | 4 +-
.../SimicsPei/SimicsPei.inf | 3 +-
6 files changed, 8 insertions(+), 112 deletions(-)
delete mode 100644 Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.c
delete mode 100644 Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.h
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
index 4f8ab4170d..67f1680a4f 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
@@ -115,6 +115,8 @@
SerializeVariablesLib|$(BOARD_PKG)/Library/SerializeVariablesLib/SerializeVariablesLib.inf
SiliconPolicyInitLib|$(BOARD_PKG)/Policy/Library/SiliconPolicyInitLib/SiliconPolicyInitLib.inf
SiliconPolicyUpdateLib|$(BOARD_PKG)/Policy/Library/SiliconPolicyUpdateLib/SiliconPolicyUpdateLib.inf
+
PlatformCmosAccessLib|BoardModulePkg/Library/PlatformCmosAccessLibNull/PlatformCmosAccessLibNull.inf
+ CmosAccessLib|BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
[LibraryClasses.common.SEC]
###
diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.c
b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.c
deleted file mode 100644
index b34ba9283b..00
--- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.c
+++ /dev/null
@@ -1,57 +0,0 @@
-/** @file
- PC/AT CMOS access routines
-
- Copyright (c) 2006 - 2019 Intel Corporation. All rights reserved.
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-**/
-
-#include "Cmos.h"
-#include "Library/IoLib.h"
-
-/**
- Reads 8-bits of CMOS data.
-
- Reads the 8-bits of CMOS data at the location specified by Index.
- The 8-bit read value is returned.
-
- @param Index The CMOS location to read.
-
- @return The value read.
-
-**/
-UINT8
-EFIAPI
-CmosRead8 (
- IN UINTN Index
- )
-{
- IoWrite8 (0x70, (UINT8) Index);
- return IoRead8 (0x71);
-}
-
-
-/**
- Writes 8-bits of CMOS data.
-
- Writes 8-bits of CMOS data to the location specified by Index
- with the value specified by Value and returns Value.
-
- @param Index The CMOS location to write.
- @param Value The value to write to CMOS.
-
- @return The value written to CMOS.
-
-**/
-UINT8
-EFIAPI
-CmosWrite8 (
- IN UINTN Index,
- IN UINT8 Value
- )
-{
- IoWrite8 (0x70, (UINT8) Index);
- IoWrite8 (0x71, Value);
- return Value;
-}
-
diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.h
b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.h
deleted file mode 100644
index 07fa2e2d11..00
--- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Cmos.h
+++ /dev/null
@@ -1,50 +0,0 @@
-/** @file
- PC/AT CMOS access routines
-
- Copyright (c) 2006 - 2019 Intel Corporation. All rights reserved.
-
- SPDX-License-Identifier: BSD-2-Clause-Patent
-**/
-
-#ifndef __CMOS_H__
-#define __CMOS_H__
-
-/**
- Reads 8-bits of CMOS data.
-
- Reads the 8-bits of CMOS data at the location specified by Index.
- The 8-bit read value is returned.
-
- @param Index The CMOS location to read.
-
- @return The value read.
-
-**/
-UINT8
-EFIAPI
-CmosRead8 (
- IN UINTN Index
- );
-
-/**
- Writes 8-bits of CMOS data.
-
- Writes 8-bits of CMOS data to the location specified by Index
- with the value specified by Value and returns Value.
-
- @param Index The CMOS location to write.
- @param Value The value to write to CMOS.
-
- @return The value written to CMOS.
-
-**/
-UINT8
-EFIAPI
-CmosWrite8 (
- IN UINTN Index,
- IN UINT8 Value
- );
-
-
-#endif
-
diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
index ee0eead5a8..4d16fd2fac 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
@@ -22,11 +22,11 @@
#include
#include
#include
+#include
#include
#include
#include "Platform.h"
-#include "Cmos.h"
UINT8 mPhysMemAddressWidth;
@@ -105,7 +105,7 @@ GetSystemMemorySizeAbove4gb (
)
{
UINT32 Size;
- UINTN CmosIndex;
+ UINT8 CmosIndex;
//
// CMOS 0x5b-0x5d specifies the system memory above 4GB MB.
diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/Platform.c
b/Platform/Intel/SimicsOpenBoardPkg/Simi
[edk2-devel] [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Change Build Output Directory
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2250
Changed BoardX558ich10's build directory to
Build/SimicsOpenBoardPkg/BoardX58Ich10 to align it with
align with the other Intel board packages
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../BoardX58Ich10/OpenBoardPkg.dsc | 13 +++--
.../BoardX58Ich10/OpenBoardPkg.fdf | 2 +-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
index 4f8ab4170d..78f1e80990 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
@@ -20,16 +20,17 @@
DEFINE PCH_PKG = SimicsIch10Pkg
DEFINE DXE_ARCH = X64
DEFINE PEI_ARCH = IA32
+ DEFINE PROJECT = $(BOARD_PKG)/$(BOARD_NAME)
PLATFORM_NAME = SimicsX58
PLATFORM_GUID = EE8EBB5A-CC95-412f-9987-2AF70F88B69A
PLATFORM_VERSION = 0.1
DSC_SPECIFICATION = 0x00010005
- OUTPUT_DIRECTORY = Build/SimicsX58Ia32X64
+ OUTPUT_DIRECTORY = Build/$(PROJECT)
SUPPORTED_ARCHITECTURES= IA32|X64
BUILD_TARGETS = DEBUG|RELEASE|NOOPT
SKUID_IDENTIFIER = DEFAULT
- FLASH_DEFINITION = $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkg.fdf
+ FLASH_DEFINITION = $(PROJECT)/OpenBoardPkg.fdf
DEFINE SMM_REQUIRE = TRUE
@@ -41,7 +42,7 @@
DEFINE NETWORK_ISCSI_ENABLE = FALSE
DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
- !include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgPcd.dsc
+ !include $(PROJECT)/OpenBoardPkgPcd.dsc
!include NetworkPkg/NetworkDefines.dsc.inc
@@ -80,7 +81,7 @@
###
# Build Option Includes
###
-!include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgBuildOption.dsc
+!include $(PROJECT)/OpenBoardPkgBuildOption.dsc
#
@@ -175,11 +176,11 @@
#
$(PLATFORM_PACKAGE)/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf {
-
BoardInitLib|$(BOARD_PKG)/$(BOARD_NAME)/Library/BoardInitLib/PeiBoardInitPreMemLib.inf
+ BoardInitLib|$(PROJECT)/Library/BoardInitLib/PeiBoardInitPreMemLib.inf
}
$(PLATFORM_PACKAGE)/PlatformInit/PlatformInitPei/PlatformInitPostMem.inf {
-
BoardInitLib|$(BOARD_PKG)/$(BOARD_NAME)/Library/BoardInitLib/PeiBoardInitPostMemLib.inf
+ BoardInitLib|$(PROJECT)/Library/BoardInitLib/PeiBoardInitPostMemLib.inf
}
$(PLATFORM_PACKAGE)/PlatformInit/ReportFv/ReportFvPei.inf
$(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem.inf
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
index 0c27cb0ef2..39226251a7 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf
@@ -13,7 +13,7 @@
# Build the variable store and the firmware code as one unified flash device
# image.
#
-[FD.SIMICSX58IA32X64]
+[FD.BOARDX58ICH10]
BaseAddress = $(FW_BASE_ADDRESS)
Size = $(FW_SIZE)
ErasePolarity = 1
--
2.19.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49607): https://edk2.groups.io/g/devel/message/49607
Mute This Topic: https://groups.io/mt/39638257/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 02/22] .gitignore: Ignore python compiled files, extdeps, and vscode
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Update .gitignore to ignore .pyc files and __pycache__ directories. Python based plugins can be added to any package or platform, so these files and directories may be present outside of BaseTools. Ignore _extdep directories that are generated by the pytool external dependency feature. Ignore .vscode directories generated by the VS Code editor. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Kinney --- .gitignore | 5 + 1 file changed, 5 insertions(+) diff --git a/.gitignore b/.gitignore index 97f22c348c..71679478ac 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,8 @@ Build/ tags/ .DS_Store +*.pyc +__pycache__/ +*_extdep/ + +.vscode/ -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49586): https://edk2.groups.io/g/devel/message/49586 Mute This Topic: https://groups.io/mt/39614156/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 22/22] Readme.md: Add CI build status badges
https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Update Readme.md with status badges from the most recent EDK II Continuous Integration(CI) build. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- Readme.md | 29 ++--- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/Readme.md b/Readme.md index 27e4ce0771..37183c3265 100644 --- a/Readme.md +++ b/Readme.md @@ -3,6 +3,19 @@ A modern, feature-rich, cross-platform firmware development environment for the UEFI and PI specifications from www.uefi.org. +## Build Status + +| Host Type | Toolchain | Branch | Build Status | Test Status | Code Coverage | +| : | : | : | :- | : | :--- | +| Windows | VS2019 | master | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=14&branchName=master) | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=14&branchName=master) | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=14&branchName=master)| +| Ubuntu | GCC5 | master | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=15&branchName=master) | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=15&branchName=master) | [](https://dev.azure.com/tianocore/edk2-ci-play/_build/latest?definitionId=15&branchName=master) | + +[More CI Build information](ci/readme.md) + +## License Details + +[](License.txt) + The majority of the content in the EDK II open source project uses a [BSD-2-Clause Plus Patent License](License.txt). The EDK II open source project contains the following components that are covered by additional licenses: @@ -20,7 +33,8 @@ contains the following components that are covered by additional licenses: The EDK II Project is composed of packages. The maintainers for each package are listed in [Maintainers.txt](Maintainers.txt). -# Resources +## Resources + * [TianoCore](http://www.tianocore.org) * [EDK II](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II) * [Getting Started with EDK II](https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-with-EDK-II) @@ -29,7 +43,8 @@ are listed in [Maintainers.txt](Maintainers.txt). * [How To Contribute](https://github.com/tianocore/tianocore.github.io/wiki/How-To-Contribute) * [Release Planning](https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning) -# Code Contributions +## Code Contributions + To make a contribution to a TianoCore project, follow these steps. 1. Create a change description in the format specified below to use in the source control commit log. @@ -57,7 +72,7 @@ To make a contribution to a TianoCore project, follow these steps. Contributions using other licenses might be accepted, but further review will be required. -# Developer Certificate of Origin +## Developer Certificate of Origin Your change description should use the standard format for a commit message, and must include your `Signed-off-by` signature. @@ -104,7 +119,7 @@ By making a contribution to this project, I certify that: this project or the open source license(s) involved. ``` -# Sample Change Description / Commit Message +## Sample Change Description / Commit Message ``` From: Contributor Name @@ -115,14 +130,14 @@ Full-commit-message Signed-off-by: Contributor Name ``` -## Notes for sample patch email +### Notes for sample patch email * The first line of commit message is taken from the email's subject line following `[Repository/Branch PATCH]`. The remaining portion of the commit message is the email's content. * `git format-patch` is one way to create this format -## Definitions for sample patch email +### Definitions for sample patch email * `Repository` is the identifier of the repository the patch applies. This identifier should only be provided for repositories other than @@ -141,7 +156,7 @@ Signed-off-by: Contributor Name * `Signed-off-by` is the contributor's signature identifying them by their real/legal name and their email address. -# Submodules +## Submodules Submodule in EDK II is allowed but submodule chain should be avoided as possible as we can. Currently EDK II contains two submodules -- 2.21.0.wind
[edk2-devel] [Patch v3 08/22] CryptoPkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Kinney
---
CryptoPkg/CryptoPkg.ci.yaml | 48 +
1 file changed, 48 insertions(+)
create mode 100644 CryptoPkg/CryptoPkg.ci.yaml
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
new file mode 100644
index 00..a20ac79d0e
--- /dev/null
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -0,0 +1,48 @@
+##
+# CI configuration for CryptoPkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "CryptoPkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+"CryptoPkg/CryptoPkg.dec",
+#"SecurityPkg/SecurityPkg.dec"
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"DscPath": "CryptoPkg.dsc",
+"IgnoreInf": []
+},
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": [],
+"IgnoreFoldersAndFiles": []
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+
+## options defined ci/Plugin/SpellCheck
+"SpellCheck": {
+"skip": True,
+"IgnoreFiles": [], # use gitignore syntax to ignore errors
in matching files
+"ExtendWords": [], # words to extend to the dictionary for
this package
+"IgnoreStandardPaths": [], # Standard Plugin defined paths that
should be ignore
+"AdditionalIncludePaths": [] # Additional paths to spell check
(wildcards supported)
+}
+}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49592): https://edk2.groups.io/g/devel/message/49592
Mute This Topic: https://groups.io/mt/39614177/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 19/22] .pytool: Add CISettings.py and Readme.md
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add main python script for EDK II Continuous Integration (CI)
builds along with a Readme.md that provides a summary of the
packages, platforms, and checks performs during a CI build.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
.pytool/CISettings.py | 173 ++
.pytool/Readme.md | 128 +++
2 files changed, 301 insertions(+)
create mode 100644 .pytool/CISettings.py
create mode 100644 .pytool/Readme.md
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
new file mode 100644
index 00..a78e8b974c
--- /dev/null
+++ b/.pytool/CISettings.py
@@ -0,0 +1,173 @@
+# @file
+#
+# Copyright (c) 2018, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+import os
+import logging
+from edk2toolext.environment import shell_environment
+from edk2toolext.invocables.edk2_ci_build import CiBuildSettingsManager
+from edk2toolext.invocables.edk2_setup import SetupSettingsManager,
RequiredSubmodule
+from edk2toolext.invocables.edk2_update import UpdateSettingsManager
+from edk2toolext.invocables.edk2_pr_eval import PrEvalSettingsManager
+from edk2toollib.utility_functions import GetHostInfo
+
+
+class Settings(CiBuildSettingsManager, UpdateSettingsManager,
SetupSettingsManager, PrEvalSettingsManager):
+
+def __init__(self):
+self.ActualPackages = []
+self.ActualTargets = []
+self.ActualArchitectures = []
+self.ActualToolChainTag = ""
+
+#
###
#
+# Extra CmdLine configuration
#
+#
###
#
+
+def AddCommandLineOptions(self, parserObj):
+pass
+
+def RetrieveCommandLineOptions(self, args):
+pass
+
+#
###
#
+#Default Support for this Ci Build
#
+#
###
#
+
+def GetPackagesSupported(self):
+''' return iterable of edk2 packages supported by this build.
+These should be edk2 workspace relative paths '''
+
+return ("MdePkg",
+"MdeModulePkg",
+"NetworkPkg",
+"PcAtChipsetPkg",
+"SecurityPkg",
+"UefiCpuPkg",
+"FmpDevicePkg",
+"ShellPkg",
+"FatPkg",
+"CryptoPkg"
+)
+
+def GetArchitecturesSupported(self):
+''' return iterable of edk2 architectures supported by this build '''
+return ("IA32",
+"X64",
+"ARM",
+"AARCH64")
+
+def GetTargetsSupported(self):
+''' return iterable of edk2 target tags supported by this build '''
+return ("DEBUG", "RELEASE", "NO-TARGET", "NOOPT")
+
+#
###
#
+# Verify and Save requested Ci Build Config
#
+#
###
#
+
+def SetPackages(self, list_of_requested_packages):
+''' Confirm the requested package list is valid and configure
SettingsManager
+to build the requested packages.
+
+Raise UnsupportedException if a requested_package is not supported
+'''
+unsupported = set(list_of_requested_packages) - \
+set(self.GetPackagesSupported())
+if(len(unsupported) > 0):
+logging.critical(
+"Unsupported Package Requested: " + " ".join(unsupported))
+raise Exception("Unsupported Package Requested: " +
+" ".join(unsupported))
+self.ActualPackages = list_of_requested_packages
+
+def SetArchitectures(self, list_of_requested_architectures):
+''' Confirm the requests architecture list is valid and configure
SettingsManager
+to run only the requested architectures.
+
+Raise Exception if a list_of_requested_architectures is not supported
+'''
+unsupported = set(list_of_requested_architectures) - \
+set(self.GetArchitecturesSupported())
+if(len(unsupported) > 0):
+logging.critical(
+"Unsupported Architecture Requested: " + " ".join(unsupported))
+raise Exception(
+"Unsupported Architecture Requested: " + " ".join(unsupported))
+self.ActualArchitectures = list_of_requested_architectures
+
+def SetTargets(self, list_of_
[edk2-devel] [Patch v3 09/22] FatPkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Ray Ni
Signed-off-by: Michael D Kinney
---
FatPkg/FatPkg.ci.yaml | 50 +++
1 file changed, 50 insertions(+)
create mode 100644 FatPkg/FatPkg.ci.yaml
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg.ci.yaml
new file mode 100644
index 00..d584eea0a7
--- /dev/null
+++ b/FatPkg/FatPkg.ci.yaml
@@ -0,0 +1,50 @@
+##
+# CI configuration for FatPkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "FatPkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"IgnoreInf": [],
+"DscPath": "FatPkg.dsc"
+},
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": [],
+"IgnoreFoldersAndFiles": []
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+"SpellCheck": {
+"ExtendWords": [
+"ELTORITO",
+"FHAND",
+"IFILE",
+"OFILE",
+"FDISKed",
+"Lfnbuffer",
+"L",
+"CDVOL",
+"DMDEPKG"
+]
+}
+}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49593): https://edk2.groups.io/g/devel/message/49593
Mute This Topic: https://groups.io/mt/39614180/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 04/22] BaseTools/tools_def.template: Add RC_PATH define
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Add use of RC_PATH define that provides the path to the resource compiler that is typically provided in a Windows SDK. The path changes with different Windows SDK releases. This define is set to the WINSDK_PATH_FOR_RC_EXE environment variable. This environment variable must be set to the path to the currently installed resource compiler (rc.exe). Cc: Bob Feng Cc: Liming Gao Signed-off-by: Kinney --- BaseTools/Conf/tools_def.template | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index dce6c5875a..afa13a7cae 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tools_def.template @@ -4,9 +4,18 @@ # Portions copyright (c) 2011 - 2014, ARM Ltd. All rights reserved. # Copyright (c) 2015, Hewlett-Packard Development Company, L.P. # (C) Copyright 2016 Hewlett Packard Enterprise Development LP +# Copyright (c) Microsoft Corporation # # SPDX-License-Identifier: BSD-2-Clause-Patent # +# +# Increase this version tag any time you want user to get warning about updating this +# file in the Conf dir. By default it does not do update existing conf dirs. +# +# 2.00 - Initial version with changes for CI +# - Change RC path to use plugin +# +#!VERSION=2.00 IDENTIFIER = Default TOOL_CHAIN_CONF @@ -71,6 +80,11 @@ DEFINE VS2019_BIN_X64 = DEF(VS2019_BIN)\HostDEF(VS_HOST)\x64 DEFINE VS2019_BIN_ARM = DEF(VS2019_BIN)\HostDEF(VS_HOST)\arm DEFINE VS2019_BIN_AARCH64 = DEF(VS2019_BIN)\HostDEF(VS_HOST)\arm64 +# +# Resource compiler +# +DEFINE RC_PATH= ENV(WINSDK_PATH_FOR_RC_EXE)\rc.exe + DEFINE WINSDK_BIN = ENV(WINSDK_PREFIX) DEFINE WINSDKx86_BIN= ENV(WINSDKx86_PREFIX) @@ -1566,7 +1580,7 @@ NOOPT_VS2015x86_X64_DLINK_FLAGS= /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF *_VS2017_*_MAKE_PATH = DEF(VS2017_BIN_HOST)\nmake.exe *_VS2017_*_MAKE_FLAG = /nologo -*_VS2017_*_RC_PATH = DEF(WINSDK10_BIN)\rc.exe +*_VS2017_*_RC_PATH = DEF(RC_PATH) *_VS2017_*_MAKE_FLAGS = /nologo *_VS2017_*_SLINK_FLAGS = /NOLOGO /LTCG @@ -1729,7 +1743,7 @@ NOOPT_VS2017_AARCH64_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF *_VS2019_*_MAKE_PATH = DEF(VS2019_BIN_HOST)\nmake.exe *_VS2019_*_MAKE_FLAG = /nologo -*_VS2019_*_RC_PATH = DEF(WINSDK10_BIN)\rc.exe +*_VS2019_*_RC_PATH = DEF(RC_PATH) *_VS2019_*_MAKE_FLAGS = /nologo *_VS2019_*_SLINK_FLAGS = /NOLOGO /LTCG -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49588): https://edk2.groups.io/g/devel/message/49588 Mute This Topic: https://groups.io/mt/39614159/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 03/22] requirements.txt: Add python pip requirements file
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Add pip requirements file that is used to install the python pip modules build from the edk2-pytool-library and edk2-pytool-extensions repositories. These python modules provide the extensions required to perform EDK II Continuous Integration(CI) builds. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- requirements.txt | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 requirements.txt diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 00..d4610f81c5 --- /dev/null +++ b/requirements.txt @@ -0,0 +1,2 @@ +edk2-pytool-library==0.10.* +edk2-pytool-extensions==0.12.* -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49587): https://edk2.groups.io/g/devel/message/49587 Mute This Topic: https://groups.io/mt/39614157/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 17/22] UefiCpuPkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Michael D Kinney
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 51 +++
1 file changed, 51 insertions(+)
create mode 100644 UefiCpuPkg/UefiCpuPkg.ci.yaml
diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
new file mode 100644
index 00..81da29b878
--- /dev/null
+++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
@@ -0,0 +1,51 @@
+##
+# CI configuration for UefiCpuPkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "UefiCpuPkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+"UefiCpuPkg/UefiCpuPkg.dec"
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"DscPath": "UefiCpuPkg.dsc",
+"IgnoreInf": [
+"UefiCpuPkg/ResetVector/FixupVtf/Vtf.inf",
+"UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf"
+]
+},
+"GuidCheck": {
+"IgnoreGuidName": ["SecCore", "ResetVector"], # Expected duplication
for gEfiFirmwareVolumeTopFileGuid
+"IgnoreGuidValue": [],
+"IgnoreFoldersAndFiles": [],
+"IgnoreDuplicates": []
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+
+## options defined ci/Plugin/SpellCheck
+"SpellCheck": {
+"AuditOnly": True, # Fails test but run in AuditOnly mode to
collect log
+"IgnoreFiles": [], # use gitignore syntax to ignore errors
in matching files
+"ExtendWords": [], # words to extend to the dictionary for
this package
+"IgnoreStandardPaths": [], # Standard Plugin defined paths that
should be ignore
+"AdditionalIncludePaths": [] # Additional paths to spell check
(wildcards supported)
+}
+}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49601): https://edk2.groups.io/g/devel/message/49601
Mute This Topic: https://groups.io/mt/39614210/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 18/22] SignedCapsulePkg: Use BaseCryptLibNull to reduce package CI time
https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Use BaseCryptLibNull for package CI builds to reduce package build times. Enabled with PYTOOL_CONTINUOUS_INTEGRATION in YAML files. By default PYTOOL_CONTINUOUS_INTEGRATION is not defined, and the original lib mappings are preserved. Cc: Jiewen Yao Cc: Chao Zhang Signed-off-by: Michael D Kinney --- SignedCapsulePkg/SignedCapsulePkg.dsc | 38 +-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc index 03f714f9a7..c5080ec1dd 100644 --- a/SignedCapsulePkg/SignedCapsulePkg.dsc +++ b/SignedCapsulePkg/SignedCapsulePkg.dsc @@ -87,8 +87,6 @@ [LibraryClasses] AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf - IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf - OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf EdkiiSystemCapsuleLib|SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf @@ -116,7 +114,13 @@ [LibraryClasses.common.PEIM] HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf +!ifdef CONTINUOUS_INTEGRATION + BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf +!else + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf +!endif [LibraryClasses.common.DXE_CORE] HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf @@ -125,7 +129,13 @@ [LibraryClasses.common.DXE_CORE] [LibraryClasses.common.DXE_DRIVER] HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf +!ifdef CONTINUOUS_INTEGRATION + BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf +!else + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf +!endif CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf @@ -133,7 +143,13 @@ [LibraryClasses.common.DXE_RUNTIME_DRIVER] HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf +!ifdef CONTINUOUS_INTEGRATION + BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf +!else + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf +!endif CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf @@ -150,19 +166,37 @@ [LibraryClasses.common.DXE_SMM_DRIVER] MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllocationLib.inf SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTableLib.inf SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf +!ifdef CONTINUOUS_INTEGRATION + BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf +!else + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf +!endif [LibraryClasses.common.UEFI_DRIVER] HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf +!ifdef CONTINUOUS_INTEGRATION + BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf +!else + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf +!endif [LibraryClasses.common.UEFI_APPLICATION] HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf +!ifdef CONTINUOUS_INTEGRATION + BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf +!else + IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf + OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf +!endif [PcdsFixedAtBuild] gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- G
[edk2-devel] [Patch v3 15/22] SecurityPkg: Add YAML files for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Use BaseCryptLibNull for package CI builds to reduce package
build times. Enabled with CONTINUOUS_INTEGRATION in YAML
files. By default CONTINUOUS_INTEGRATION is not defined,
and the original lib mappings are preserved.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Michael D Kinney
---
SecurityPkg/SecurityPkg.ci.yaml | 80 +
SecurityPkg/SecurityPkg.dsc | 32 -
2 files changed, 110 insertions(+), 2 deletions(-)
create mode 100644 SecurityPkg/SecurityPkg.ci.yaml
diff --git a/SecurityPkg/SecurityPkg.ci.yaml b/SecurityPkg/SecurityPkg.ci.yaml
new file mode 100644
index 00..c7e309fcda
--- /dev/null
+++ b/SecurityPkg/SecurityPkg.ci.yaml
@@ -0,0 +1,80 @@
+##
+# CI configuration for SecurityPkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "SecurityPkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+"SecurityPkg/SecurityPkg.dec",
+"CryptoPkg/CryptoPkg.dec"
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"DscPath": "SecurityPkg.dsc",
+"IgnoreInf": []
+},
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": ["----"],
+"IgnoreFoldersAndFiles": [],
+"IgnoreDuplicates": [
+"Tpm2InstanceLibDTpm=gEfiTpmDeviceInstanceTpm20DtpmGuid", # by
design
+]
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+
+## options defined ci/Plugin/SpellCheck
+"SpellCheck": {
+"AuditOnly": True, # Fails test but run in AuditOnly mode to
collect log
+"ExtendWords": [ # words to extend to the dictionary for
this package
+"shortformed", # tpm acpi
+"autodetect",
+"blocksid",
+"comid",
+"cpinsidpin", #OpalSScV2
+"ecdsa", # TPM
+"ecschnorr", # TPM
+"eisaid", # ACPI
+"harddisk",
+"hashall",
+"hashto",
+"kek's",
+"lfanew", # PE/COFF
+"pcrindex",
+"pkglength",
+"ppuser",
+"preos",
+"stclear",
+"toctou",
+"tpm's",
+"tpmcmdbuflength",
+"tpmcommlib",
+"tpmnvvaluelength",
+"wrlocked",
+"xored"
+],
+"IgnoreStandardPaths": [], # Standard Plugin defined paths that
should be ignore
+"AdditionalIncludePaths": [] # Additional paths to spell check
(wildcards supported)
+},
+
+"Defines": {
+"BLD_*_CONTINUOUS_INTEGRATION": "TRUE",
+}
+}
diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc
index 9a254087a3..a2eeadda7a 100644
--- a/SecurityPkg/SecurityPkg.dsc
+++ b/SecurityPkg/SecurityPkg.dsc
@@ -44,8 +44,6 @@ [LibraryClasses]
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
- IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
- OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
TpmCommLib|SecurityPkg/Library/TpmCommLib/TpmCommLib.inf
PlatformSecureLib|SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
@@ -84,7 +82,13 @@ [LibraryClasses.common.PEIM]
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
+!ifdef CONTINUOUS_INTEGRATION
+ BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
+!else
+ IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
+ OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
+!endif
HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
Tpm12DeviceLib|SecurityPkg/Library/Tpm12DeviceLibDTpm/Tpm12DeviceLibDTpm.inf
@@ -95,7 +99,13 @@ [LibraryClasses.common.PEIM]
[LibraryClasses.common.DXE_DRIVER]
HobLib|MdePkg
[edk2-devel] [Patch v3 10/22] FmpDevicePkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Use BaseCryptLibNull for package CI builds to reduce package
build times. Enabled with CONTINUOUS_INTEGRATION in YAML
files. By default CONTINUOUS_INTEGRATION is not defined,
and the original lib mappings are preserved.
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 43 +++
FmpDevicePkg/FmpDevicePkg.dsc | 6 -
2 files changed, 48 insertions(+), 1 deletion(-)
create mode 100644 FmpDevicePkg/FmpDevicePkg.ci.yaml
diff --git a/FmpDevicePkg/FmpDevicePkg.ci.yaml
b/FmpDevicePkg/FmpDevicePkg.ci.yaml
new file mode 100644
index 00..f089932556
--- /dev/null
+++ b/FmpDevicePkg/FmpDevicePkg.ci.yaml
@@ -0,0 +1,43 @@
+##
+# CI configuration for FmpDevicePkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "FmpDevicePkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+"FmpDevicePkg/FmpDevicePkg.dec",
+"CryptoPkg/CryptoPkg.dec"
+],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"DscPath": "FmpDevicePkg.dsc",
+"IgnoreInf": []
+},
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": [],
+"IgnoreFoldersAndFiles": []
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+"SpellCheck": {
+"ExtendWords": [
+"FMPSTATE",
+]
+},
+"Defines": {
+"BLD_*_CONTINUOUS_INTEGRATION": "TRUE",
+}
+}
diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc
index 67b5aa7a32..f4093d3837 100644
--- a/FmpDevicePkg/FmpDevicePkg.dsc
+++ b/FmpDevicePkg/FmpDevicePkg.dsc
@@ -48,9 +48,13 @@ [LibraryClasses]
DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
- OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+!ifdef CONTINUOUS_INTEGRATION
+ BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
+!else
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
+ OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
+!endif
FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpdatePolicyLibNull.inf
FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLibV1.inf
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49594): https://edk2.groups.io/g/devel/message/49594
Mute This Topic: https://groups.io/mt/39614183/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 20/22] .azurepipelines: Add Azure Pipelines YML configuration files
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YML configuration files used to run the EDK II Continuous
Integration (CI) checks on Azure Pipelines agents.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
.azurepipelines/Ubuntu-GCC5.yml | 18 +++
.azurepipelines/Ubuntu-PatchCheck.yml | 35 +
.azurepipelines/Windows-VS2019.yml| 18 +++
.../templates/basetools-build-steps.yml | 36 +
.../templates/pr-gate-build-job.yml | 60
.azurepipelines/templates/pr-gate-steps.yml | 129 ++
.../templates/spell-check-prereq-steps.yml| 21 +++
7 files changed, 317 insertions(+)
create mode 100644 .azurepipelines/Ubuntu-GCC5.yml
create mode 100644 .azurepipelines/Ubuntu-PatchCheck.yml
create mode 100644 .azurepipelines/Windows-VS2019.yml
create mode 100644 .azurepipelines/templates/basetools-build-steps.yml
create mode 100644 .azurepipelines/templates/pr-gate-build-job.yml
create mode 100644 .azurepipelines/templates/pr-gate-steps.yml
create mode 100644 .azurepipelines/templates/spell-check-prereq-steps.yml
diff --git a/.azurepipelines/Ubuntu-GCC5.yml b/.azurepipelines/Ubuntu-GCC5.yml
new file mode 100644
index 00..191bda8a91
--- /dev/null
+++ b/.azurepipelines/Ubuntu-GCC5.yml
@@ -0,0 +1,18 @@
+##
+# Azure Pipeline build file for a build using ubuntu and GCC5
+#
+# Copyright (c) 2019, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+trigger:
+- master
+pr:
+- master
+
+jobs:
+- template: templates/pr-gate-build-job.yml
+ parameters:
+tool_chain_tag: 'GCC5'
+vm_image: 'ubuntu-latest'
+arch_list: "IA32,X64,ARM,AARCH64"
+
diff --git a/.azurepipelines/Ubuntu-PatchCheck.yml
b/.azurepipelines/Ubuntu-PatchCheck.yml
new file mode 100644
index 00..dff8f579b6
--- /dev/null
+++ b/.azurepipelines/Ubuntu-PatchCheck.yml
@@ -0,0 +1,35 @@
+## @file
+# Azure Pipielines YML file that evalues the patch series in a PR using the
+# python script BaseTools/Scripts/PatchCheck.py.
+#
+# NOTE: This example monitors pull requests against the edk2-ci branch. Most
+# environments would replace 'edk2-ci' with 'master'.
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+# https://github.com/tianocore
+#
+##
+
+trigger: none
+
+pr:
+- master
+
+pool:
+ vmImage: 'ubuntu-latest'
+
+steps:
+- checkout: self
+ clean: true
+
+- task: UsePythonVersion@0
+ inputs:
+versionSpec: '3.7.x'
+architecture: 'x64'
+
+- script: |
+git fetch origin
$(System.PullRequest.TargetBranch):$(System.PullRequest.TargetBranch)
+python BaseTools/Scripts/PatchCheck.py
$(System.PullRequest.TargetBranch)..$(System.PullRequest.SourceCommitId)
+ displayName: 'Use PatchCheck.py to verify patch series in pull request'
diff --git a/.azurepipelines/Windows-VS2019.yml
b/.azurepipelines/Windows-VS2019.yml
new file mode 100644
index 00..2143162e02
--- /dev/null
+++ b/.azurepipelines/Windows-VS2019.yml
@@ -0,0 +1,18 @@
+##
+# Azure Pipeline build file for a build using Windows and VS2019
+#
+# Copyright (c) 2019, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+trigger:
+- master
+
+pr:
+- master
+
+jobs:
+- template: templates/pr-gate-build-job.yml
+ parameters:
+tool_chain_tag: 'VS2019'
+vm_image: 'windows-latest'
+arch_list: "IA32,X64"
diff --git a/.azurepipelines/templates/basetools-build-steps.yml
b/.azurepipelines/templates/basetools-build-steps.yml
new file mode 100644
index 00..dc1fdffd64
--- /dev/null
+++ b/.azurepipelines/templates/basetools-build-steps.yml
@@ -0,0 +1,36 @@
+# File templates/basetools-build-job.yml
+#
+# template file to build basetools
+#
+# Copyright (c) 2019, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+parameters:
+ tool_chain_tag: ''
+
+steps:
+- ${{ if contains(parameters.tool_chain_tag, 'GCC') }}:
+ - bash: sudo apt-get update
+displayName: Update apt
+condition: and(gt(variables.pkg_count, 0), succeeded())
+
+ - bash: sudo apt-get install gcc g++ make uuid-dev
+displayName: Install required tools
+condition: and(gt(variables.pkg_count, 0), succeeded())
+
+- task: CmdLine@1
+ displayName: Build Base Tools from source
+ inputs:
+filename: python
+arguments: BaseTools/Edk2ToolsBuild.py -t ${{ parameters.tool_chain_tag }}
+ condition: and(gt(variables.pkg_count, 0), succeeded())
+
+- task: CopyFiles@2
+ displayName: "Copy base tools build log"
+ inputs:
+targetFolder: '$(Build.ArtifactStagingDirectory)'
+SourceFolder: 'BaseTools/BaseToolsBuild'
+contents: |
+ BASETOOLS_BUILD*.*
+flattenFolders: true
+ condition: succeededOrFailed()
diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
new file mode 100644
index 00..98e0ee7877
--- /dev/null
+++ b/
[edk2-devel] [Patch v3 12/22] MdePkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
MdePkg/MdePkg.ci.yaml | 90 +++
1 file changed, 90 insertions(+)
create mode 100644 MdePkg/MdePkg.ci.yaml
diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
new file mode 100644
index 00..4015c07f16
--- /dev/null
+++ b/MdePkg/MdePkg.ci.yaml
@@ -0,0 +1,90 @@
+##
+# CI configuration for MdePkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+## options defined ci/Plugin/CompilerPlugin
+"CompilerPlugin": {
+"DscPath": "MdePkg.dsc"
+},
+
+## options defined ci/Plugin/CharEncodingCheck
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+
+## options defined ci/Plugin/DependencyCheck
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec"
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+
+## options defined ci/Plugin/DscCompleteCheck
+"DscCompleteCheck": {
+"IgnoreInf": [],
+"DscPath": "MdePkg.dsc"
+},
+
+## options defined ci/Plugin/GuidCheck
+"GuidCheck": {
+"IgnoreGuidName": [
+"gEfiFirmwareVolumeTopFileGuid" # sec modules must be set to this
guid
+],
+"IgnoreGuidValue": ["----"],
+"IgnoreFoldersAndFiles": [],
+"IgnoreDuplicates": [
+
"gEfiFirmwareVolumeBlockProtocolGuid=gEfiFirmwareVolumeBlock2ProtocolGuid",
+"gEfiMmAccessProtocolGuid=gEfiSmmAccess2ProtocolGuid",
+"gEfiSmmCommunicationProtocolGuid=gEfiMmCommunicationProtocolGuid",
+
"gEfiMmPciRootBridgeIoProtocolGuid=gEfiSmmPciRootBridgeIoProtocolGuid",
+"gEfiTrEEProtocolGuid=gEfiTcg2ProtocolGuid",
+
"gEfiSmmPowerButtonDispatch2ProtocolGuid=gEfiMmPowerButtonDispatchProtocolGuid",
+"gEfiSmmBase2ProtocolGuid=gEfiMmBaseProtocolGuid",
+"gEfiSmmUsbDispatch2ProtocolGuid=gEfiMmUsbDispatchProtocolGuid",
+"gEfiSmmCpuProtocolGuid=gEfiMmCpuProtocolGuid",
+"gEfiAcpiTableGuid=gEfiAcpi20TableGuid",
+"gEfiSmmControl2ProtocolGuid=gEfiMmControlProtocolGuid",
+
"gEfiSmmStandbyButtonDispatch2ProtocolGuid=gEfiMmStandbyButtonDispatchProtocolGuid",
+"gEfiSmmStatusCodeProtocolGuid=gEfiMmStatusCodeProtocolGuid",
+
"gEfiDxeSmmReadyToLockProtocolGuid=gEfiDxeMmReadyToLockProtocolGuid",
+
"gEfiSmmIoTrapDispatch2ProtocolGuid=gEfiMmIoTrapDispatchProtocolGuid",
+"gEfiSmmReadyToLockProtocolGuid=gEfiMmReadyToLockProtocolGuid",
+"gEfiSmmSxDispatch2ProtocolGuid=gEfiMmSxDispatchProtocolGuid",
+"gEfiPeiCapsulePpiGuid=gPeiCapsulePpiGuid",
+"gEfiSmmCpuIo2ProtocolGuid=gEfiMmCpuIoProtocolGuid",
+"gEfiSmmRscHandlerProtocolGuid=gEfiMmRscHandlerProtocolGuid",
+"gEfiSmmConfigurationProtocolGuid=gEfiMmConfigurationProtocolGuid",
+"gEfiSmmGpiDispatch2ProtocolGuid=gEfiMmGpiDispatchProtocolGuid",
+"gEfiSmmEndOfDxeProtocolGuid=gEfiMmEndOfDxeProtocolGuid",
+"gEfiSmmSwDispatch2ProtocolGuid=gEfiMmSwDispatchProtocolGuid",
+
"gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevicePathGuid",
## is this a bug
+
"gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid",
## is this a bug
+
"gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchProtocolGuid",
+"gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
+"gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
+"gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
+]
+},
+
+## options defined ci/Plugin/LibraryClassCheck
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+
+## options defined ci/Plugin/SpellCheck
+"SpellCheck": {
+"AuditOnly": True, # Fails test but run in AuditOnly mode to
collect log
+"IgnoreFiles": [], # use gitignore syntax to ignore errors
in matching files
+"ExtendWords": [], # words to extend to the dictionary for
this package
+"IgnoreStandardPaths": [], # Standard Plugin defined paths that
should be ignore
+"AdditionalIncludePaths": [] # Additional paths to spell check
(wildcards supported)
+}
+}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49596): https://edk2.groups.io/g/devel/message/49596
Mute This Topic: https://groups.io/mt/39614194/21
[edk2-devel] [Patch v3 01/22] Maintainers.txt: Add continuous integration(CI) directories
https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Add maintainers and reviewers for the directories associated with continuous integration steps. * .azurepipelines * .mergify * .pytool Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- Maintainers.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 71a34a2845..1fb38ddc5b 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -460,3 +460,26 @@ F: StandaloneMmPkg/ M: Achin Gupta M: Jiewen Yao R: Supreeth Venkatesh + +EDK II Continuous Integration: +-- +.azurepipelines/ +F: .azurepipelines/ +M: Sean Brogan +M: Bret Barkelew +R: Michael D Kinney +R: Liming Gao + +.mergify/ +F: .mergify/ +M: Michael D Kinney +M: Liming Gao +R: Sean Brogan +R: Bret Barkelew + +.pytool/ +F: .pytool/ +M: Sean Brogan +M: Bret Barkelew +R: Michael D Kinney +R: Liming Gao -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49585): https://edk2.groups.io/g/devel/message/49585 Mute This Topic: https://groups.io/mt/39614153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 16/22] ShellPkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Michael D Kinney
---
ShellPkg/ShellPkg.ci.yaml | 55 +++
1 file changed, 55 insertions(+)
create mode 100644 ShellPkg/ShellPkg.ci.yaml
diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml
new file mode 100644
index 00..5bf7330c1a
--- /dev/null
+++ b/ShellPkg/ShellPkg.ci.yaml
@@ -0,0 +1,55 @@
+##
+# CI configuration for ShellPkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "ShellPkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+"ShellPkg/ShellPkg.dec",
+"NetworkPkg/NetworkPkg.dec"
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"DscPath": "ShellPkg.dsc",
+"IgnoreInf": [
+"ShellPkg/Application/ShellCTestApp/ShellCTestApp.inf",
+"ShellPkg/Application/ShellExecTestApp/SA.inf",
+"ShellPkg/Application/ShellSortTestApp/ShellSortTestApp.inf"
+]
+},
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": [],
+"IgnoreFoldersAndFiles": [],
+"IgnoreDuplicates": [
+"Shell=gUefiShellFileGuid", # by design
+]
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+
+## options defined ci/Plugin/SpellCheck
+"SpellCheck": {
+"AuditOnly": True, # Fails test but run in AuditOnly mode to
collect log
+"IgnoreFiles": [], # use gitignore syntax to ignore errors
in matching files
+"ExtendWords": [], # words to extend to the dictionary for
this package
+"IgnoreStandardPaths": [], # Standard Plugin defined paths that
should be ignore
+"AdditionalIncludePaths": [] # Additional paths to spell check
(wildcards supported)
+}
+}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49600): https://edk2.groups.io/g/devel/message/49600
Mute This Topic: https://groups.io/mt/39614206/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 14/22] PcAtChipsetPkg: Add YAML files for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Ray Ni
Signed-off-by: Michael D Kinney
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 46 +++
1 file changed, 46 insertions(+)
create mode 100644 PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
new file mode 100644
index 00..6ab9f11761
--- /dev/null
+++ b/PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml
@@ -0,0 +1,46 @@
+##
+# CI configuration for PcAtChipsetPkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "PcAtChipsetPkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"PcAtChipsetPkg/PcAtChipsetPkg.dec",
+"UefiCpuPkg/UefiCpuPkg.dec"
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"DscPath": "PcAtChipsetPkg.dsc",
+"IgnoreInf": []
+},
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": [],
+"IgnoreFoldersAndFiles": [],
+ "IgnoreDuplicates": []
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+"SpellCheck": {
+"ExtendWords": [
+"ENUMER", # this is part of an IDE enum
+"PCATCHIPSET",
+"TXRDY"
+]
+}
+}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49598): https://edk2.groups.io/g/devel/message/49598
Mute This Topic: https://groups.io/mt/39614200/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 00/22] Enable Phase 1 of EDK II CI
https://bugzilla.tianocore.org/show_bug.cgi?id=2315 RFC Proposals: * https://edk2.groups.io/g/rfc/message/93 * https://edk2.groups.io/g/devel/message/46607 Wiki Page: * https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Continuous-Integration Branch for review: * https://github.com/tianocore/edk2-staging/tree/edk2-ci_V3 Previous versions of branches for reference: * https://github.com/tianocore/edk2-staging/tree/edk2-ci_V2 * https://github.com/tianocore/edk2-staging/tree/edk2-ci_V1 Active branch for testing/evaluation: * https://github.com/tianocore/edk2-staging/tree/edk2-ci * To test, fork edk2-staging repo, create a branch with a change, and submit a pull request targeting edk2-staging/edk2-ci. NOTE: the default branch for the edk2-staging is 'about'. You must select the 'edk2-ci' branch when a pull request is opened. Set the 'push' label to require commit if all checks pass. Pull request history on active branch for testing/evaluation: * https://github.com/tianocore/edk2-staging/pulls?q=is%3Apr+is%3Aclosed This patch series enables pre-commit and post-commit checks on edk2/master The goal is to improve quality of code submissions by requiring all pre-commit checks to pass before any change is committed to edk2/master. In order to minimize the impact to the developer process, when an EDK II Maintainer is ready to commit changes to edk2/master, the EDK II Maintainer pushes a branch to their personal fork of the edk2 repository and opens a pull request targeting edk2/master and sets the 'push' label. If all checks pass, then the pull request is automatically committed. A developer that wants to know if a patch series passes all checks can either run the checks locally or open a pull request without setting the 'push' label. The post-commit checks build all packages and provide status badges and links to reports in the Readme.md file at the root of edk2/master. A combination of GitHub, Azure Pipelines, Mergify, and edk2-pytool features are used to implement this feature. GitHub and Azure Pipelines configuration steps are required to activate this feature on edk2/master. Once this feature is active and shown to be stable for 1-2 weeks, write access to the edk2 repository will be removed for all EDK II Maintainers. Only admins will retain write access, and admins should avoid use of direct push to resolve an issue unless there is no method to resolve the issue using the pull request method. The following checks are made available by this patch series. Not all checks are enabled for all packages. Enabling all checks on all packages can be done incrementally as well as adding more checks over time. * PatchCheck * CharEncodingCheck * CompilerPlugin * DependencyCheck * DscCompleteCheck * GuidCheck * LibraryClassCheck * SpellCheck Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Cc: Bob Feng Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Ray Ni Cc: Hao A Wu Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Jiewen Yao Cc: Chao Zhang Cc: Zhichao Gao Cc: Eric Dong Signed-off-by: Michael D Kinney Michael D Kinney (14): Maintainers.txt: Add continuous integration(CI) directories CryptoPkg: Add YAML file for CI builds FatPkg: Add YAML file for CI builds FmpDevicePkg: Add YAML file for CI builds MdeModulePkg: Add YAML file for CI builds MdePkg: Add YAML file for CI builds NetworkPkg: Add YAML file for CI builds PcAtChipsetPkg: Add YAML files for CI builds SecurityPkg: Add YAML files for CI builds ShellPkg: Add YAML file for CI builds UefiCpuPkg: Add YAML file for CI builds SignedCapsulePkg: Use BaseCryptLibNull to reduce package CI time .merify: Add Megify YML pull request rules configuration file Readme.md: Add CI build status badges Sean Brogan (8): .gitignore: Ignore python compiled files, extdeps, and vscode requirements.txt: Add python pip requirements file BaseTools/tools_def.template: Add RC_PATH define BaseTools: Add YAML files with path env and tool extdeps BaseTools: Add BaseTools plugins to support CI .pytool/Plugin: Add CI plugins .pytool: Add CISettings.py and Readme.md .azurepipelines: Add Azure Pipelines YML configuration files .azurepipelines/Ubuntu-GCC5.yml | 18 ++ .azurepipelines/Ubuntu-PatchCheck.yml | 35 +++ .azurepipelines/Windows-VS2019.yml| 18 ++ .../templates/basetools-build-steps.yml | 36 +++ .../templates/pr-gate-build-job.yml | 60 + .azurepipelines/templates/pr-gate-steps.yml | 129 + .../templates/spell-check-prereq-steps.yml| 21 ++ .gitignore| 5 + .mergify/config.yml | 71 + .pytool/CISettings.py | 173 .../CharEncodingCheck/CharEncodingCheck.py| 118 .../CharEncodingCheck_plug_in.yaml| 11 + .pytool/Plugin/CharEncodingCheck/Readme.md| 13 + .../Plugin/C
[edk2-devel] [Patch v3 07/22] .pytool/Plugin: Add CI plugins
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add .pytool directory to the edk2 repository with the
following plugins. These plugins are in a top level
directory because that can be used with all packages
and platforms.
* CharEncodingCheck
* CompilerPlugin
* DependencyCheck
* DscCompleteCheck
* GuidCheck
* LibraryClassCheck
* SpellCheck
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
.../CharEncodingCheck/CharEncodingCheck.py| 118
.../CharEncodingCheck_plug_in.yaml| 11 +
.pytool/Plugin/CharEncodingCheck/Readme.md| 13 +
.../Plugin/CompilerPlugin/CompilerPlugin.py | 102 +++
.../CompilerPlugin/Compiler_plug_in.yaml | 11 +
.../Plugin/DependencyCheck/DependencyCheck.py | 120 +
.../DependencyCheck_plug_in.yaml | 13 +
.../DscCompleteCheck/DscCompleteCheck.py | 118
.../DscCompleteCheck_plug_in.yaml | 12 +
.pytool/Plugin/DscCompleteCheck/readme.md | 22 ++
.pytool/Plugin/GuidCheck/GuidCheck.py | 251 ++
.../Plugin/GuidCheck/GuidCheck_plug_in.yaml | 11 +
.pytool/Plugin/GuidCheck/Readme.md| 60 +
.../LibraryClassCheck/LibraryClassCheck.py| 153 +++
.../LibraryClassCheck_plug_in.yaml| 11 +
.pytool/Plugin/LibraryClassCheck/readme.md| 22 ++
.pytool/Plugin/SpellCheck/Readme.md | 100 +++
.pytool/Plugin/SpellCheck/SpellCheck.py | 216 +++
.../Plugin/SpellCheck/SpellCheck_plug_in.yaml | 11 +
.pytool/Plugin/SpellCheck/cspell.base.yaml| 165
20 files changed, 1540 insertions(+)
create mode 100644 .pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
create mode 100644
.pytool/Plugin/CharEncodingCheck/CharEncodingCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/CharEncodingCheck/Readme.md
create mode 100644 .pytool/Plugin/CompilerPlugin/CompilerPlugin.py
create mode 100644 .pytool/Plugin/CompilerPlugin/Compiler_plug_in.yaml
create mode 100644 .pytool/Plugin/DependencyCheck/DependencyCheck.py
create mode 100644 .pytool/Plugin/DependencyCheck/DependencyCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py
create mode 100644
.pytool/Plugin/DscCompleteCheck/DscCompleteCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/DscCompleteCheck/readme.md
create mode 100644 .pytool/Plugin/GuidCheck/GuidCheck.py
create mode 100644 .pytool/Plugin/GuidCheck/GuidCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/GuidCheck/Readme.md
create mode 100644 .pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py
create mode 100644
.pytool/Plugin/LibraryClassCheck/LibraryClassCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/LibraryClassCheck/readme.md
create mode 100644 .pytool/Plugin/SpellCheck/Readme.md
create mode 100644 .pytool/Plugin/SpellCheck/SpellCheck.py
create mode 100644 .pytool/Plugin/SpellCheck/SpellCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/SpellCheck/cspell.base.yaml
diff --git a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
new file mode 100644
index 00..54a2424875
--- /dev/null
+++ b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
@@ -0,0 +1,118 @@
+# @file CharEncodingCheck.py
+#
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+
+import os
+import logging
+from edk2toolext.environment.plugintypes.ci_build_plugin import ICiBuildPlugin
+from edk2toolext.environment.var_dict import VarDict
+
+##
+# map
+##
+EcodingMap = {
+".md": 'utf-8',
+".dsc": 'utf-8',
+".dec": 'utf-8',
+".c": 'utf-8',
+".h": 'utf-8',
+".asm": 'utf-8',
+".masm": 'utf-8',
+".nasm": 'utf-8',
+".s": 'utf-8',
+".inf": 'utf-8',
+".asl": 'utf-8',
+".uni": 'utf-8',
+".py": 'utf-8'
+}
+
+
+class CharEncodingCheck(ICiBuildPlugin):
+"""
+A CiBuildPlugin that scans each file in the code tree and confirms the
encoding is correct.
+
+Configuration options:
+"CharEncodingCheck": {
+"IgnoreFiles": []
+}
+"""
+
+def GetTestName(self, packagename: str, environment: VarDict) -> tuple:
+""" Provide the testcase name and classname for use in reporting
+testclassname: a descriptive string for the testcase can include
whitespace
+classname: should be patterned ..
+
+Args:
+ packagename: string containing name of package to build
+ environment: The VarDict for the test to run in
+Returns:
+a tuple containing the testcase name and the classname
+(testcasename, classname)
+"""
+return ("Check for valid file encoding for " + packagename,
packagename + ".CharEncodingCheck")
+
+##
+# External function of plugin. This function is used to perform th
[edk2-devel] [Patch v3 06/22] BaseTools: Add BaseTools plugins to support CI
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add the following plugins that are required to support
EDK II Continuous Integration (CI) builds. These plugins
are added to BaseTools because that support EDK II BaseTools
features.
* BuildToolsReportGenerator
* LinuxGcc5ToolChain
* WindowsResourceCompiler
* WindowsVsToolChain
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
.../BuildToolsReportGenerator.py | 69 ++
.../BuildToolsReportGenerator_plug_in.yaml| 12 ++
.../BuildToolsReport_Template.html| 126 ++
.../LinuxGcc5ToolChain/LinuxGcc5ToolChain.py | 85
.../LinuxGcc5ToolChain_plug_in.yaml | 12 ++
.../WindowsResourceCompiler/WinRcPath.py | 29
.../WinRcPath_plug_in.yaml| 13 ++
.../WindowsVsToolChain/WindowsVsToolChain.py | 126 ++
.../WindowsVsToolChain_plug_in.yaml | 11 ++
9 files changed, 483 insertions(+)
create mode 100644
BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator.py
create mode 100644
BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator_plug_in.yaml
create mode 100644
BaseTools/Plugin/BuildToolsReport/BuildToolsReport_Template.html
create mode 100644 BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain.py
create mode 100644
BaseTools/Plugin/LinuxGcc5ToolChain/LinuxGcc5ToolChain_plug_in.yaml
create mode 100644 BaseTools/Plugin/WindowsResourceCompiler/WinRcPath.py
create mode 100644
BaseTools/Plugin/WindowsResourceCompiler/WinRcPath_plug_in.yaml
create mode 100644 BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain.py
create mode 100644
BaseTools/Plugin/WindowsVsToolChain/WindowsVsToolChain_plug_in.yaml
diff --git a/BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator.py
b/BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator.py
new file mode 100644
index 00..d5df9f2f9b
--- /dev/null
+++ b/BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator.py
@@ -0,0 +1,69 @@
+##
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+import os
+import logging
+import json
+
+try:
+from edk2toolext.environment.plugintypes.uefi_build_plugin import
IUefiBuildPlugin
+
+class BuildToolsReportGenerator(IUefiBuildPlugin):
+def do_report(self, thebuilder):
+try:
+from edk2toolext.environment import version_aggregator
+except ImportError:
+logging.critical("Loading BuildToolsReportGenerator failed,
please update your Edk2-PyTool-Extensions")
+return 0
+
+OutputReport =
os.path.join(thebuilder.env.GetValue("BUILD_OUTPUT_BASE"), "BUILD_TOOLS_REPORT")
+OutputReport = os.path.normpath(OutputReport)
+if not os.path.isdir(os.path.dirname(OutputReport)):
+os.makedirs(os.path.dirname(OutputReport))
+
+Report = BuildToolsReport()
+
Report.MakeReport(version_aggregator.GetVersionAggregator().GetAggregatedVersionInformation(),
OutputReport=OutputReport)
+
+def do_pre_build(self, thebuilder):
+self.do_report(thebuilder)
+return 0
+
+def do_post_build(self, thebuilder):
+self.do_report(thebuilder)
+return 0
+
+except ImportError:
+pass
+
+
+class BuildToolsReport(object):
+MY_FOLDER = os.path.dirname(os.path.realpath(__file__))
+VERSION = "1.00"
+
+def __init__(self):
+pass
+
+def MakeReport(self, BuildTools, OutputReport="BuildToolsReport"):
+logging.info("Writing BuildToolsReports to {0}".format(OutputReport))
+versions_list = []
+for key, value in BuildTools.items():
+versions_list.append(value)
+versions_list = sorted(versions_list, key=lambda k: k['type'])
+json_dict = {"modules": versions_list,
+ "PluginVersion": BuildToolsReport.VERSION}
+
+htmlfile = open(OutputReport + ".html", "w")
+jsonfile = open(OutputReport + ".json", "w")
+template = open(os.path.join(BuildToolsReport.MY_FOLDER,
"BuildToolsReport_Template.html"), "r")
+
+for line in template.readlines():
+if "%TO_BE_FILLED_IN_BY_PYTHON_SCRIPT%" in line:
+line = line.replace("%TO_BE_FILLED_IN_BY_PYTHON_SCRIPT%",
json.dumps(json_dict))
+htmlfile.write(line)
+
+jsonfile.write(json.dumps(versions_list, indent=4))
+
+jsonfile.close()
+template.close()
+htmlfile.close()
diff --git
a/BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator_plug_in.yaml
b/BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator_plug_in.yaml
new file mode 100644
index 00..50afd53926
--- /dev/null
+++ b/BaseTools/Plugin/BuildToolsReport/BuildToolsReportGenerator_plug_in.yaml
@@ -0,0 +1,12 @@
+##
+# Build Plugin used to output html rep
[edk2-devel] [Patch v3 13/22] NetworkPkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Use BaseCryptLibNull and TlsLibNull for package CI
builds to reduce package build times. Enabled with
CONTINUOUS_INTEGRATION in YAML files. By default
CONTINUOUS_INTEGRATION is not defined, and the
original lib mappings are preserved.
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Michael D Kinney
---
NetworkPkg/NetworkPkg.ci.yaml | 62 +++
NetworkPkg/NetworkPkg.dsc | 5 +++
2 files changed, 67 insertions(+)
create mode 100644 NetworkPkg/NetworkPkg.ci.yaml
diff --git a/NetworkPkg/NetworkPkg.ci.yaml b/NetworkPkg/NetworkPkg.ci.yaml
new file mode 100644
index 00..ea41c9db66
--- /dev/null
+++ b/NetworkPkg/NetworkPkg.ci.yaml
@@ -0,0 +1,62 @@
+##
+# CI configuration for NetworkPkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+"CompilerPlugin": {
+"DscPath": "NetworkPkg.dsc"
+},
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+"NetworkPkg/NetworkPkg.dec",
+"CryptoPkg/CryptoPkg.dec"
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[
+"ShellPkg/ShellPkg.dec"
+],
+"IgnoreInf": []
+},
+"DscCompleteCheck": {
+"DscPath": "NetworkPkg.dsc",
+"IgnoreInf": []
+},
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": [],
+"IgnoreFoldersAndFiles": []
+},
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+
+## options defined ci/Plugin/SpellCheck
+"SpellCheck": {
+"AuditOnly": True, # Fails test but run in AuditOnly mode to
collect log
+"IgnoreFiles": [], # use gitignore syntax to ignore errors
in matching files
+"ExtendWords": [], # words to extend to the dictionary for
this package
+"IgnoreStandardPaths": [], # Standard Plugin defined paths that
should be ignore
+"AdditionalIncludePaths": [] # Additional paths to spell check
(wildcards supported)
+},
+
+"Defines": {
+"BLD_*_CONTINUOUS_INTEGRATION": "TRUE",
+"BLD_*_NETWORK_ENABLE": "TRUE",
+"BLD_*_NETWORK_SNP_ENABLE": "TRUE",
+"BLD_*_NETWORK_VLAN_ENABLE": "TRUE",
+"BLD_*_NETWORK_IP4_ENABLE": "TRUE",
+"BLD_*_NETWORK_IP6_ENABLE": "TRUE",
+"BLD_*_NETWORK_TLS_ENABLE": "TRUE",
+"BLD_*_NETWORK_HTTP_BOOT_ENABLE": "TRUE",
+"BLD_*_NETWORK_ISCSI_ENABLE": "TRUE",
+}
+}
diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
index 11a2981261..b149453d26 100644
--- a/NetworkPkg/NetworkPkg.dsc
+++ b/NetworkPkg/NetworkPkg.dsc
@@ -41,10 +41,15 @@ [LibraryClasses]
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
+!ifdef CONTINUOUS_INTEGRATION
+ BaseCryptLib|CryptoPkg/Library/BaseCryptLibNull/BaseCryptLibNull.inf
+ TlsLib|CryptoPkg/Library/TlsLibNull/TlsLibNull.inf
+!else
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
+!endif
DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49597): https://edk2.groups.io/g/devel/message/49597
Mute This Topic: https://groups.io/mt/39614197/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 05/22] BaseTools: Add YAML files with path env and tool extdeps
From: Sean Brogan
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Michael D Kinney
---
BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21 +++
BaseTools/Bin/gcc_arm_linux_ext_dep.yaml | 21 +++
BaseTools/Bin/iasl_ext_dep.yaml | 21 +++
BaseTools/Bin/nasm_ext_dep.yaml | 18 ++
.../BinWrappers/PosixLike/posix_path_env.yaml | 10 ++
.../WindowsLike/win_build_tools_path_env.yaml | 10 ++
BaseTools/Edk2ToolsBuild.py | 163 ++
.../basetool_tiano_python_path_env.yaml | 11 ++
BaseTools/basetools_calling_path_env.yaml | 11 ++
BaseTools/basetools_path_env.yaml | 11 ++
10 files changed, 297 insertions(+)
create mode 100644 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
create mode 100644 BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
create mode 100644 BaseTools/Bin/iasl_ext_dep.yaml
create mode 100644 BaseTools/Bin/nasm_ext_dep.yaml
create mode 100644 BaseTools/BinWrappers/PosixLike/posix_path_env.yaml
create mode 100644
BaseTools/BinWrappers/WindowsLike/win_build_tools_path_env.yaml
create mode 100644 BaseTools/Edk2ToolsBuild.py
create mode 100644 BaseTools/Source/Python/basetool_tiano_python_path_env.yaml
create mode 100644 BaseTools/basetools_calling_path_env.yaml
create mode 100644 BaseTools/basetools_path_env.yaml
diff --git a/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
b/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
new file mode 100644
index 00..69648c89d8
--- /dev/null
+++ b/BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml
@@ -0,0 +1,21 @@
+##
+# Download GCC AARCH64 compiler from Linaro's release site
+# Set shell variable GCC5_AARCH64_INSTALL to this folder
+#
+# This is only downloaded when a build activates scope gcc_aarch64_linux
+#
+# Copyright (c) 2019, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "scope": "gcc_aarch64_linux",
+ "type": "web",
+ "name": "gcc_aarch64_linux",
+ "source":
"http://releases.linaro.org/components/toolchain/binaries/7.4-2019.02/aarch64-linux-gnu/gcc-linaro-7.4.1-2019.02-x86_64_aarch64-linux-gnu.tar.xz";,
+ "version": "7.4.1",
+ "sha256": "27f1dc2c491ed61ae8f0d4b0c11de59cd2f7dd9c94761ee7153006fcac1bf9ab",
+ "compression_type": "tar",
+ "internal_path": "/gcc-linaro-7.4.1-2019.02-x86_64_aarch64-linux-gnu/",
+ "flags": ["set_shell_var", ],
+ "var_name": "GCC5_AARCH64_INSTALL"
+}
diff --git a/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
b/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
new file mode 100644
index 00..e108aaad2a
--- /dev/null
+++ b/BaseTools/Bin/gcc_arm_linux_ext_dep.yaml
@@ -0,0 +1,21 @@
+##
+# Download GCC ARM compiler from Linaro's release site
+# Set shell variable GCC5_ARM_INSTALL to this folder
+#
+# This is only downloaded when a build activates scope gcc_arm_linux
+#
+# Copyright (c) 2019, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "scope": "gcc_arm_linux",
+ "type": "web",
+ "name": "gcc_arm_linux",
+ "source":
"https://releases.linaro.org/components/toolchain/binaries/7.4-2019.02/arm-linux-gnueabihf/gcc-linaro-7.4.1-2019.02-x86_64_arm-linux-gnueabihf.tar.xz";,
+ "version": "7.4.1",
+ "sha256": "3C951CF1941D0FA06D64CC0D5E88612B209D8123B273FA26C16D70BD7BC6B163",
+ "compression_type": "tar",
+ "internal_path": "/gcc-linaro-7.4.1-2019.02-x86_64_arm-linux-gnueabihf/",
+ "flags": ["set_shell_var", ],
+ "var_name": "GCC5_ARM_INSTALL"
+}
diff --git a/BaseTools/Bin/iasl_ext_dep.yaml b/BaseTools/Bin/iasl_ext_dep.yaml
new file mode 100644
index 00..1c63921367
--- /dev/null
+++ b/BaseTools/Bin/iasl_ext_dep.yaml
@@ -0,0 +1,21 @@
+##
+# Download iasl executable tool from a nuget.org package
+# - package contains different binaries based on host
+# Add the folder with the tool to the path
+#
+# This is only downloaded for scope cibuild thus
+# should have no impact on the asl compiler used by any
+# given platform to build.
+#
+# Copyright (c) 2019, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "id": "iasl-ci-1",
+ "scope": "cibuild",
+ "type": "nuget",
+ "name": "iasl",
+ "source": "https://api.nuget.org/v3/index.json";,
+ "version": "20190215.0.0",
+ "flags": ["set_path", "host_specific"]
+}
diff --git a/BaseTools/Bin/nasm_ext_dep.yaml b/BaseTools/Bin/nasm_ext_dep.yaml
new file mode 100644
index 00..8894516b5a
--- /dev/null
+++ b/BaseTools/Bin/nasm_ext_dep.yaml
@@ -0,0 +1,18 @@
+##
+# Download nasm x86 assembler executable tool from a nuget.org package
+# - package contains different binaries based on host
+# Put on the tool on the path
+#
+#
+# Copyright (c) 2019, Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+ "id": "nasm-1",
+ "scope": "edk2-build",
+ "type": "nuget",
+ "name": "mu_nasm",
+ "source": "https://api.nuget.org/v3/index.json";,
+ "version": "2.14.02",
+ "flags": ["set_path", "host_specific"]
+}
diff --git a/Bas
[edk2-devel] [Patch v3 21/22] .merify: Add Megify YML pull request rules configuration file
https://bugzilla.tianocore.org/show_bug.cgi?id=2315 Add directory for the Mergify YML configuration files that provides rules and actions used to process a pull request. * Auto commit a PR from EDK II Maintainer with 'push' label set and all CI checks pass * Auto close a PR from any developers without 'push' label set and all CI checks pass. * Auto close a PR from a non EDK II Maintainer that has the 'push' label set. * Post a comment to a PR that has a merge conflict. Submitter can resolved conflicts and reopen the PR. * Post a comment to a PR that fails PatchCheck.py Submitter can resolve PatchCheck.py issues and reopen the PR. Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael D Kinney --- .mergify/config.yml | 71 + 1 file changed, 71 insertions(+) create mode 100644 .mergify/config.yml diff --git a/.mergify/config.yml b/.mergify/config.yml new file mode 100644 index 00..86674ce366 --- /dev/null +++ b/.mergify/config.yml @@ -0,0 +1,71 @@ +## @file +# Mergify YML file that automatically merges a GitHub pull request against +# edk2-ci if all of the GitHub branch protections have passed. It also +# contains rules to: +# * auto close branches that are not from an EDK II Maintainer +# * post a comment on pull requests that have merge conflicts. +# * post a comment on pull requests that have PatchCheck.py errors. +# +# Configuration Notes: +# * Update the 'base=edk2-ci' statements with the name of the branch to merge +# pull requests. +# +# * Update the 'status-failure' statement with the name of the name of the Azure +# Pipelines Build that performs the EDK II Maintainer check. +# +# * This file must be checked into the 'default' branch of a repo. Copies +# of this file on other branches of a repo are ignored by Mergify. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved. +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +# https://github.com/apps/mergify +# https://doc.mergify.io/ +# +## + +pull_request_rules: + - name: automatic merge when GitHub branch protection passes and 'push' label is present +conditions: + - base=master + - label=push + - author=@tianocore/edk-ii-maintainers + - status-success=tianocore.PatchCheck + - status-success=Ubuntu GCC5 PR + - status-success=Windows VS2019 PR +actions: + merge: +strict: true +method: rebase + - name: automatic close when GitHub branch protection passes and 'push' label is not present +conditions: + - base=master + - label!=push + - status-success=tianocore.PatchCheck + - status-success=Ubuntu GCC5 PR + - status-success=Windows VS2019 PR +actions: + close: +message: All checks passed. Auto close personal build. + - name: post a comment on a PR that can not be merged due to a merge conflict +conditions: + - base=master + - conflict +actions: + comment: +message: PR can not be merged due to conflict. Please rebase and resubmit + - name: automatically close a PR that fails the EDK II Maintainers membership check and 'push' label is present +conditions: + - base=master + - label=push + - -author=@tianocore/edk-ii-maintainers +actions: + close: +message: PR submitter is not a member of the Tianocore EDK II Maintainers team + - name: post a comment on a PR that does not pass PatchCheck.py checks +conditions: + - base=master + - status-failure=tianocore.PatchCheck +actions: + comment: +message: PR can not be merged due to PatchCheck errors. Please resolve and resubmit -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49605): https://edk2.groups.io/g/devel/message/49605 Mute This Topic: https://groups.io/mt/39614223/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [Patch v3 11/22] MdeModulePkg: Add YAML file for CI builds
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Add YAML file to the package directory with the
configuration of the checks to perform during a
CI build.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Michael D Kinney
---
MdeModulePkg/MdeModulePkg.ci.yaml | 81 +++
1 file changed, 81 insertions(+)
create mode 100644 MdeModulePkg/MdeModulePkg.ci.yaml
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
b/MdeModulePkg/MdeModulePkg.ci.yaml
new file mode 100644
index 00..6ae58d5379
--- /dev/null
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -0,0 +1,81 @@
+##
+# CI configuration for MdeModulePkg
+#
+# Copyright (c) Microsoft Corporation
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+## options defined ci/Plugin/CompilerPlugin
+"CompilerPlugin": {
+"DscPath": "MdeModulePkg.dsc"
+},
+
+## options defined ci/Plugin/CharEncodingCheck
+"CharEncodingCheck": {
+"IgnoreFiles": []
+},
+
+## options defined ci/Plugin/DependencyCheck
+"DependencyCheck": {
+"AcceptableDependencies": [
+"MdePkg/MdePkg.dec",
+"MdeModulePkg/MdeModulePkg.dec",
+"StandaloneMmPkg/StandaloneMmPkg.dec",
+"ArmPkg/ArmPkg.dec" # this should be fixed by promoting an
abstraction
+],
+# For host based unit tests
+"AcceptableDependencies-HOST_APPLICATION":[],
+# For UEFI shell based apps
+"AcceptableDependencies-UEFI_APPLICATION":[],
+"IgnoreInf": []
+},
+
+## options defined ci/Plugin/DscCompleteCheck
+"DscCompleteCheck": {
+"IgnoreInf": [],
+"DscPath": "MdeModulePkg.dsc"
+},
+
+## options defined ci/Plugin/GuidCheck
+"GuidCheck": {
+"IgnoreGuidName": [],
+"IgnoreGuidValue": ["----"],
+"IgnoreFoldersAndFiles": [],
+"IgnoreDuplicates": [
+"gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
+"gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
+"gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
+"gEdkiiSerialPortLibVendorGuid=SerialDxe" # Is this a bug
+]
+},
+
+## options defined ci/Plugin/LibraryClassCheck
+"LibraryClassCheck": {
+"IgnoreHeaderFile": []
+},
+
+## options defined ci/Plugin/SpellCheck
+"SpellCheck": {
+"AuditOnly": True, # Fails test but run in AuditOnly mode to
collect log
+"IgnoreStandardPaths": [ # Standard Plugin defined paths that
should be ignore
+"*.c", "*.asm", "*.h", "*.nasm", "*.s", "*.asl", "*.inf"
+],
+"IgnoreFiles": [ # use gitignore syntax to ignore errors
in matching files
+"Library/LzmaCustomDecompressLib/Sdk/DOC/*"
+],
+"ExtendWords": [ # words to extend to the dictionary for
this package
+"LIGHTGRAY",
+"DARKGRAY",
+"LIGHTBLUE",
+"LIGHTGREEN",
+"LIGHTCYAN",
+"LIGHTRED",
+"LIGHTMAGENTA",
+"FVMAIN",
+"VARCHECKPCD",
+"Getxx",
+"lzturbo"
+],
+"AdditionalIncludePaths": [] # Additional paths to spell check
relative to package root (wildcards supported)
+}
+}
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49595): https://edk2.groups.io/g/devel/message/49595
Mute This Topic: https://groups.io/mt/39614188/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] How /sys/firmware/fdt getting created
Hi All,
I am working on Ubuntu-18.04 with UEFI on ARM64(64 bit) platform. The
UEFI used is having ACPI tables.
I am trying to understand where and how /sys/firmware/fdt is getting
created. is it created by UEFI or grub and passed to Linux?
below is the dts format of /sys/firmware/fdt.
/dts-v1/;
/ {
chosen {
linux,uefi-mmap-desc-ver = <0x1>;
linux,uefi-mmap-desc-size = <0x30>;
linux,uefi-mmap-size = <0xcc0>;
linux,uefi-mmap-start = <0x0 0xeda13018>;
linux,uefi-system-table = <0x0 0xfafd0018>;
bootargs = "BOOT_IMAGE=/boot/vmlinuz-5.4.0-rc4+
root=UUID=798a858c-4f20-4b99-aa40-99bff9394093 ro crashkernel=2G
console=ttyAMA0";
linux,initrd-end = <0x0 0xeb381a34>;
linux,initrd-start = <0x0 0xdd5f5000>;
};
};
also, under what scenario/config fields is getting added fdt.
#size-cells = <0x02>;
#address-cells = <0x02>;
--prabhakar (pk)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49583): https://edk2.groups.io/g/devel/message/49583
Mute This Topic: https://groups.io/mt/39480086/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2] NOOPT and PcdOptimizeCompilerEnable
Hi, All: I have a question about NOOPT and PcdOptimizeCompilerEnable. If Target = NOOPT, then will disable all optimizations. And PcdOptimizeCompilerEnable has the same function. So, What's the relationship between PcdOptimizeCompilerEnable and NOOPT? Thanks Best wishes, ? ? CONFIDENTIAL NOTE: This email contains confidential or legally privileged information and is for the sole use of its intended recipient. Any unauthorized review, use, copying or forwarding of this email or the content of this email is strictly prohibited. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49582): https://edk2.groups.io/g/devel/message/49582 Mute This Topic: https://groups.io/mt/39414231/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to generate .h files
Reviewed-by: Xiaoyu Lu > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, October 29, 2019 3:43 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > Subject: [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to > generate .h files > > There are missing headers added into INF files at 8906f076de35b222a.. > They are now manually added but not auto-generated. So we update the > perl script to enable this feature. > Meanwhile, update the order of the .h files in INF files, which are > auto-generated now. > https://bugzilla.tianocore.org/show_bug.cgi?id=2085 > > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: Shenglei Zhang > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 103 +- > .../Library/OpensslLib/OpensslLibCrypto.inf | 96 > CryptoPkg/Library/OpensslLib/process_files.pl | 28 + > 3 files changed, 129 insertions(+), 98 deletions(-) > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index b40d82783b4b..b28dd9e4800c 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -34,9 +34,7 @@ [Sources] >$(OPENSSL_PATH)/crypto/aes/aes_misc.c >$(OPENSSL_PATH)/crypto/aes/aes_ofb.c >$(OPENSSL_PATH)/crypto/aes/aes_wrap.c > - $(OPENSSL_PATH)/crypto/aes/aes_locl.h >$(OPENSSL_PATH)/crypto/aria/aria.c > - $(OPENSSL_PATH)/crypto/arm_arch.h >$(OPENSSL_PATH)/crypto/asn1/a_bitstr.c >$(OPENSSL_PATH)/crypto/asn1/a_d2i_fp.c >$(OPENSSL_PATH)/crypto/asn1/a_digest.c > @@ -101,21 +99,12 @@ [Sources] >$(OPENSSL_PATH)/crypto/asn1/x_sig.c >$(OPENSSL_PATH)/crypto/asn1/x_spki.c >$(OPENSSL_PATH)/crypto/asn1/x_val.c > - $(OPENSSL_PATH)/crypto/asn1/standard_methods.h > - $(OPENSSL_PATH)/crypto/asn1/charmap.h > - $(OPENSSL_PATH)/crypto/asn1/tbl_standard.h > - $(OPENSSL_PATH)/crypto/asn1/asn1_item_list.h > - $(OPENSSL_PATH)/crypto/asn1/asn1_locl.h >$(OPENSSL_PATH)/crypto/async/arch/async_null.c >$(OPENSSL_PATH)/crypto/async/arch/async_posix.c >$(OPENSSL_PATH)/crypto/async/arch/async_win.c >$(OPENSSL_PATH)/crypto/async/async.c >$(OPENSSL_PATH)/crypto/async/async_err.c >$(OPENSSL_PATH)/crypto/async/async_wait.c > - $(OPENSSL_PATH)/crypto/async/arch/async_win.h > - $(OPENSSL_PATH)/crypto/async/async_locl.h > - $(OPENSSL_PATH)/crypto/async/arch/async_posix.h > - $(OPENSSL_PATH)/crypto/async/arch/async_null.h >$(OPENSSL_PATH)/crypto/bio/b_addr.c >$(OPENSSL_PATH)/crypto/bio/b_dump.c >$(OPENSSL_PATH)/crypto/bio/b_sock.c > @@ -138,7 +127,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/bio/bss_mem.c >$(OPENSSL_PATH)/crypto/bio/bss_null.c >$(OPENSSL_PATH)/crypto/bio/bss_sock.c > - $(OPENSSL_PATH)/crypto/bio/bio_lcl.h >$(OPENSSL_PATH)/crypto/bn/bn_add.c >$(OPENSSL_PATH)/crypto/bn/bn_asm.c >$(OPENSSL_PATH)/crypto/bn/bn_blind.c > @@ -170,9 +158,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/bn/bn_srp.c >$(OPENSSL_PATH)/crypto/bn/bn_word.c >$(OPENSSL_PATH)/crypto/bn/bn_x931p.c > - $(OPENSSL_PATH)/crypto/bn/rsaz_exp.h > - $(OPENSSL_PATH)/crypto/bn/bn_prime.h > - $(OPENSSL_PATH)/crypto/bn/bn_lcl.h >$(OPENSSL_PATH)/crypto/buffer/buf_err.c >$(OPENSSL_PATH)/crypto/buffer/buffer.c >$(OPENSSL_PATH)/crypto/cmac/cm_ameth.c > @@ -181,7 +166,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/comp/c_zlib.c >$(OPENSSL_PATH)/crypto/comp/comp_err.c >$(OPENSSL_PATH)/crypto/comp/comp_lib.c > - $(OPENSSL_PATH)/crypto/comp/comp_lcl.h >$(OPENSSL_PATH)/crypto/conf/conf_api.c >$(OPENSSL_PATH)/crypto/conf/conf_def.c >$(OPENSSL_PATH)/crypto/conf/conf_err.c > @@ -190,8 +174,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/conf/conf_mod.c >$(OPENSSL_PATH)/crypto/conf/conf_sap.c >$(OPENSSL_PATH)/crypto/conf/conf_ssl.c > - $(OPENSSL_PATH)/crypto/conf/conf_lcl.h > - $(OPENSSL_PATH)/crypto/conf/conf_def.h >$(OPENSSL_PATH)/crypto/cpt_err.c >$(OPENSSL_PATH)/crypto/cryptlib.c >$(OPENSSL_PATH)/crypto/ctype.c > @@ -215,8 +197,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/des/set_key.c >$(OPENSSL_PATH)/crypto/des/str2key.c >$(OPENSSL_PATH)/crypto/des/xcbc_enc.c > - $(OPENSSL_PATH)/crypto/des/spr.h > - $(OPENSSL_PATH)/crypto/des/des_locl.h >$(OPENSSL_PATH)/crypto/dh/dh_ameth.c >$(OPENSSL_PATH)/crypto/dh/dh_asn1.c >$(OPENSSL_PATH)/crypto/dh/dh_check.c > @@ -231,7 +211,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/dh/dh_prn.c >$(OPENSSL_PATH)/crypto/dh/dh_rfc5114.c >$(OPENSSL_PATH)/crypto/dh/dh_rfc7919.c > - $(OPENSSL_PATH)/crypto/dh/dh_locl.h >$(OPENSSL_PATH)/crypto/dso/dso_dl.c >$(OPENSSL_PATH)/crypto/dso/dso_dlfcn.c >$(OPENSSL_PATH)/crypto/dso/dso_err.c > @@ -239,7 +218,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/dso/dso_openssl.c >$(OPENSSL_PATH)/crypto/dso/dso_vms.c >$(OPENSSL_PATH)/crypto/dso/dso_win32.c > - $(OPENSSL_PATH)/crypto/dso/dso_locl.h >$(OPENSSL_PATH)/crypto/ebcdic.c >
Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to generate .h files
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, October 29, 2019 3:43 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > Subject: [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to generate .h > files > > There are missing headers added into INF files at 8906f076de35b222a.. > They are now manually added but not auto-generated. So we update the > perl script to enable this feature. > Meanwhile, update the order of the .h files in INF files, which are > auto-generated now. > https://bugzilla.tianocore.org/show_bug.cgi?id=2085 > > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: Shenglei Zhang > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 103 +- > .../Library/OpensslLib/OpensslLibCrypto.inf | 96 > CryptoPkg/Library/OpensslLib/process_files.pl | 28 + > 3 files changed, 129 insertions(+), 98 deletions(-) > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index b40d82783b4b..b28dd9e4800c 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -34,9 +34,7 @@ [Sources] >$(OPENSSL_PATH)/crypto/aes/aes_misc.c >$(OPENSSL_PATH)/crypto/aes/aes_ofb.c >$(OPENSSL_PATH)/crypto/aes/aes_wrap.c > - $(OPENSSL_PATH)/crypto/aes/aes_locl.h >$(OPENSSL_PATH)/crypto/aria/aria.c > - $(OPENSSL_PATH)/crypto/arm_arch.h >$(OPENSSL_PATH)/crypto/asn1/a_bitstr.c >$(OPENSSL_PATH)/crypto/asn1/a_d2i_fp.c >$(OPENSSL_PATH)/crypto/asn1/a_digest.c > @@ -101,21 +99,12 @@ [Sources] >$(OPENSSL_PATH)/crypto/asn1/x_sig.c >$(OPENSSL_PATH)/crypto/asn1/x_spki.c >$(OPENSSL_PATH)/crypto/asn1/x_val.c > - $(OPENSSL_PATH)/crypto/asn1/standard_methods.h > - $(OPENSSL_PATH)/crypto/asn1/charmap.h > - $(OPENSSL_PATH)/crypto/asn1/tbl_standard.h > - $(OPENSSL_PATH)/crypto/asn1/asn1_item_list.h > - $(OPENSSL_PATH)/crypto/asn1/asn1_locl.h >$(OPENSSL_PATH)/crypto/async/arch/async_null.c >$(OPENSSL_PATH)/crypto/async/arch/async_posix.c >$(OPENSSL_PATH)/crypto/async/arch/async_win.c >$(OPENSSL_PATH)/crypto/async/async.c >$(OPENSSL_PATH)/crypto/async/async_err.c >$(OPENSSL_PATH)/crypto/async/async_wait.c > - $(OPENSSL_PATH)/crypto/async/arch/async_win.h > - $(OPENSSL_PATH)/crypto/async/async_locl.h > - $(OPENSSL_PATH)/crypto/async/arch/async_posix.h > - $(OPENSSL_PATH)/crypto/async/arch/async_null.h >$(OPENSSL_PATH)/crypto/bio/b_addr.c >$(OPENSSL_PATH)/crypto/bio/b_dump.c >$(OPENSSL_PATH)/crypto/bio/b_sock.c > @@ -138,7 +127,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/bio/bss_mem.c >$(OPENSSL_PATH)/crypto/bio/bss_null.c >$(OPENSSL_PATH)/crypto/bio/bss_sock.c > - $(OPENSSL_PATH)/crypto/bio/bio_lcl.h >$(OPENSSL_PATH)/crypto/bn/bn_add.c >$(OPENSSL_PATH)/crypto/bn/bn_asm.c >$(OPENSSL_PATH)/crypto/bn/bn_blind.c > @@ -170,9 +158,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/bn/bn_srp.c >$(OPENSSL_PATH)/crypto/bn/bn_word.c >$(OPENSSL_PATH)/crypto/bn/bn_x931p.c > - $(OPENSSL_PATH)/crypto/bn/rsaz_exp.h > - $(OPENSSL_PATH)/crypto/bn/bn_prime.h > - $(OPENSSL_PATH)/crypto/bn/bn_lcl.h >$(OPENSSL_PATH)/crypto/buffer/buf_err.c >$(OPENSSL_PATH)/crypto/buffer/buffer.c >$(OPENSSL_PATH)/crypto/cmac/cm_ameth.c > @@ -181,7 +166,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/comp/c_zlib.c >$(OPENSSL_PATH)/crypto/comp/comp_err.c >$(OPENSSL_PATH)/crypto/comp/comp_lib.c > - $(OPENSSL_PATH)/crypto/comp/comp_lcl.h >$(OPENSSL_PATH)/crypto/conf/conf_api.c >$(OPENSSL_PATH)/crypto/conf/conf_def.c >$(OPENSSL_PATH)/crypto/conf/conf_err.c > @@ -190,8 +174,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/conf/conf_mod.c >$(OPENSSL_PATH)/crypto/conf/conf_sap.c >$(OPENSSL_PATH)/crypto/conf/conf_ssl.c > - $(OPENSSL_PATH)/crypto/conf/conf_lcl.h > - $(OPENSSL_PATH)/crypto/conf/conf_def.h >$(OPENSSL_PATH)/crypto/cpt_err.c >$(OPENSSL_PATH)/crypto/cryptlib.c >$(OPENSSL_PATH)/crypto/ctype.c > @@ -215,8 +197,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/des/set_key.c >$(OPENSSL_PATH)/crypto/des/str2key.c >$(OPENSSL_PATH)/crypto/des/xcbc_enc.c > - $(OPENSSL_PATH)/crypto/des/spr.h > - $(OPENSSL_PATH)/crypto/des/des_locl.h >$(OPENSSL_PATH)/crypto/dh/dh_ameth.c >$(OPENSSL_PATH)/crypto/dh/dh_asn1.c >$(OPENSSL_PATH)/crypto/dh/dh_check.c > @@ -231,7 +211,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/dh/dh_prn.c >$(OPENSSL_PATH)/crypto/dh/dh_rfc5114.c >$(OPENSSL_PATH)/crypto/dh/dh_rfc7919.c > - $(OPENSSL_PATH)/crypto/dh/dh_locl.h >$(OPENSSL_PATH)/crypto/dso/dso_dl.c >$(OPENSSL_PATH)/crypto/dso/dso_dlfcn.c >$(OPENSSL_PATH)/crypto/dso/dso_err.c > @@ -239,7 +218,6 @@ [Sources] >$(OPENSSL_PATH)/crypto/dso/dso_openssl.c >$(OPENSSL_PATH)/crypto/dso/dso_vms.c >$(OPENSSL_PATH)/crypto/dso/dso_win32.c > - $(OPENSSL_PATH)/crypto/dso/dso_locl.h >$(OPENSSL_PATH)/
[edk2-devel] [PATCH] CryptoPkg/OpensslLib: Update process_files.pl to generate .h files
There are missing headers added into INF files at 8906f076de35b222a.. They are now manually added but not auto-generated. So we update the perl script to enable this feature. Meanwhile, update the order of the .h files in INF files, which are auto-generated now. https://bugzilla.tianocore.org/show_bug.cgi?id=2085 Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Shenglei Zhang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 103 +- .../Library/OpensslLib/OpensslLibCrypto.inf | 96 CryptoPkg/Library/OpensslLib/process_files.pl | 28 + 3 files changed, 129 insertions(+), 98 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf index b40d82783b4b..b28dd9e4800c 100644 --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf @@ -34,9 +34,7 @@ [Sources] $(OPENSSL_PATH)/crypto/aes/aes_misc.c $(OPENSSL_PATH)/crypto/aes/aes_ofb.c $(OPENSSL_PATH)/crypto/aes/aes_wrap.c - $(OPENSSL_PATH)/crypto/aes/aes_locl.h $(OPENSSL_PATH)/crypto/aria/aria.c - $(OPENSSL_PATH)/crypto/arm_arch.h $(OPENSSL_PATH)/crypto/asn1/a_bitstr.c $(OPENSSL_PATH)/crypto/asn1/a_d2i_fp.c $(OPENSSL_PATH)/crypto/asn1/a_digest.c @@ -101,21 +99,12 @@ [Sources] $(OPENSSL_PATH)/crypto/asn1/x_sig.c $(OPENSSL_PATH)/crypto/asn1/x_spki.c $(OPENSSL_PATH)/crypto/asn1/x_val.c - $(OPENSSL_PATH)/crypto/asn1/standard_methods.h - $(OPENSSL_PATH)/crypto/asn1/charmap.h - $(OPENSSL_PATH)/crypto/asn1/tbl_standard.h - $(OPENSSL_PATH)/crypto/asn1/asn1_item_list.h - $(OPENSSL_PATH)/crypto/asn1/asn1_locl.h $(OPENSSL_PATH)/crypto/async/arch/async_null.c $(OPENSSL_PATH)/crypto/async/arch/async_posix.c $(OPENSSL_PATH)/crypto/async/arch/async_win.c $(OPENSSL_PATH)/crypto/async/async.c $(OPENSSL_PATH)/crypto/async/async_err.c $(OPENSSL_PATH)/crypto/async/async_wait.c - $(OPENSSL_PATH)/crypto/async/arch/async_win.h - $(OPENSSL_PATH)/crypto/async/async_locl.h - $(OPENSSL_PATH)/crypto/async/arch/async_posix.h - $(OPENSSL_PATH)/crypto/async/arch/async_null.h $(OPENSSL_PATH)/crypto/bio/b_addr.c $(OPENSSL_PATH)/crypto/bio/b_dump.c $(OPENSSL_PATH)/crypto/bio/b_sock.c @@ -138,7 +127,6 @@ [Sources] $(OPENSSL_PATH)/crypto/bio/bss_mem.c $(OPENSSL_PATH)/crypto/bio/bss_null.c $(OPENSSL_PATH)/crypto/bio/bss_sock.c - $(OPENSSL_PATH)/crypto/bio/bio_lcl.h $(OPENSSL_PATH)/crypto/bn/bn_add.c $(OPENSSL_PATH)/crypto/bn/bn_asm.c $(OPENSSL_PATH)/crypto/bn/bn_blind.c @@ -170,9 +158,6 @@ [Sources] $(OPENSSL_PATH)/crypto/bn/bn_srp.c $(OPENSSL_PATH)/crypto/bn/bn_word.c $(OPENSSL_PATH)/crypto/bn/bn_x931p.c - $(OPENSSL_PATH)/crypto/bn/rsaz_exp.h - $(OPENSSL_PATH)/crypto/bn/bn_prime.h - $(OPENSSL_PATH)/crypto/bn/bn_lcl.h $(OPENSSL_PATH)/crypto/buffer/buf_err.c $(OPENSSL_PATH)/crypto/buffer/buffer.c $(OPENSSL_PATH)/crypto/cmac/cm_ameth.c @@ -181,7 +166,6 @@ [Sources] $(OPENSSL_PATH)/crypto/comp/c_zlib.c $(OPENSSL_PATH)/crypto/comp/comp_err.c $(OPENSSL_PATH)/crypto/comp/comp_lib.c - $(OPENSSL_PATH)/crypto/comp/comp_lcl.h $(OPENSSL_PATH)/crypto/conf/conf_api.c $(OPENSSL_PATH)/crypto/conf/conf_def.c $(OPENSSL_PATH)/crypto/conf/conf_err.c @@ -190,8 +174,6 @@ [Sources] $(OPENSSL_PATH)/crypto/conf/conf_mod.c $(OPENSSL_PATH)/crypto/conf/conf_sap.c $(OPENSSL_PATH)/crypto/conf/conf_ssl.c - $(OPENSSL_PATH)/crypto/conf/conf_lcl.h - $(OPENSSL_PATH)/crypto/conf/conf_def.h $(OPENSSL_PATH)/crypto/cpt_err.c $(OPENSSL_PATH)/crypto/cryptlib.c $(OPENSSL_PATH)/crypto/ctype.c @@ -215,8 +197,6 @@ [Sources] $(OPENSSL_PATH)/crypto/des/set_key.c $(OPENSSL_PATH)/crypto/des/str2key.c $(OPENSSL_PATH)/crypto/des/xcbc_enc.c - $(OPENSSL_PATH)/crypto/des/spr.h - $(OPENSSL_PATH)/crypto/des/des_locl.h $(OPENSSL_PATH)/crypto/dh/dh_ameth.c $(OPENSSL_PATH)/crypto/dh/dh_asn1.c $(OPENSSL_PATH)/crypto/dh/dh_check.c @@ -231,7 +211,6 @@ [Sources] $(OPENSSL_PATH)/crypto/dh/dh_prn.c $(OPENSSL_PATH)/crypto/dh/dh_rfc5114.c $(OPENSSL_PATH)/crypto/dh/dh_rfc7919.c - $(OPENSSL_PATH)/crypto/dh/dh_locl.h $(OPENSSL_PATH)/crypto/dso/dso_dl.c $(OPENSSL_PATH)/crypto/dso/dso_dlfcn.c $(OPENSSL_PATH)/crypto/dso/dso_err.c @@ -239,7 +218,6 @@ [Sources] $(OPENSSL_PATH)/crypto/dso/dso_openssl.c $(OPENSSL_PATH)/crypto/dso/dso_vms.c $(OPENSSL_PATH)/crypto/dso/dso_win32.c - $(OPENSSL_PATH)/crypto/dso/dso_locl.h $(OPENSSL_PATH)/crypto/ebcdic.c $(OPENSSL_PATH)/crypto/err/err.c $(OPENSSL_PATH)/crypto/err/err_prn.c @@ -304,13 +282,11 @@ [Sources] $(OPENSSL_PATH)/crypto/evp/pmeth_fn.c $(OPENSSL_PATH)/crypto/evp/pmeth_gn.c $(OPENSSL_PATH)/crypto/evp/pmeth_lib.c - $(OPENSSL_PATH)/crypto/evp/evp_locl.h $(OPENSSL_PATH)/crypto/ex_data.c $(OPENSSL_PATH)/crypto/getenv.c $(OPENSSL_PATH)/crypto/hmac/hm_ameth.c $(OPENSSL_PATH)/crypto/hmac/hm_pmeth.c $(OPENSSL_PATH)/crypto/hmac/hmac.c - $(OPENSSL_PATH)/crypto/hmac/
