Re: [edk2-devel] [PATCH v5 4/5] Ovmf/PlatformPei: Use host-provided GPA end if available
Hi, Following the discussion, could these patches already be merged? Best regards, Nicolas Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90086): https://edk2.groups.io/g/devel/message/90086 Mute This Topic: https://groups.io/mt/90695923/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console
Hi Guo, Dumping some of the coreboot table shows that some smaller entries/data (such as build information) are inserted inline while larger entries use the cb_cbmem_ref structure. This may answer why some users of FindCbTag() assign the returned pointer directly to their requested structure, while this library must first dereference the console's address. For reasons unclear to me, cb_cbmem_ref->size == 0x0010, the size of the cb_cbmem_ref structure. Perhaps the structure of cb_cbmem_ref has been changed in the past and the size field informs coreboot payloads? Either way, it doesn't look like a useful field at the moment. I will add comments and submit a v3. Is there anything else that needs some comments? Regards, Benjamin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90087): https://edk2.groups.io/g/devel/message/90087 Mute This Topic: https://groups.io/mt/91273919/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console
Thanks Benjamin for the explaining. I have no other comments. Thanks, Guo From: Benjamin Doron Sent: Friday, May 27, 2022 9:33 AM To: Dong, Guo ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add support for logging to CBMEM console Hi Guo, Dumping some of the coreboot table shows that some smaller entries/data (such as build information) are inserted inline while larger entries use the cb_cbmem_ref structure. This may answer why some users of FindCbTag() assign the returned pointer directly to their requested structure, while this library must first dereference the console's address. For reasons unclear to me, cb_cbmem_ref->size == 0x0010, the size of the cb_cbmem_ref structure. Perhaps the structure of cb_cbmem_ref has been changed in the past and the size field informs coreboot payloads? Either way, it doesn't look like a useful field at the moment. I will add comments and submit a v3. Is there anything else that needs some comments? Regards, Benjamin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90088): https://edk2.groups.io/g/devel/message/90088 Mute This Topic: https://groups.io/mt/91273919/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout
Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure
definitions such that compilers generate same binary layouts.
Cc: Nate DeSimone
Cc: Chasel Chiu
Signed-off-by: Isaac Oram
---
.../Pch/SouthClusterLbg/Include/PchPolicyCommon.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
index 0e10d0b8f0..c95481bf1d 100644
---
a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
+++
b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCommon.h
@@ -1351,7 +1351,9 @@ typedef struct {
**/
UINT32 DmiAspm : 1;
UINT32 PwrOptEnable : 1;///< 0: Disable; 1: Enable DMI
Power Optimizer on PCH side.
+ UINT32 Rsvdbits1 : 30;
BOOLEANDmiStopAndScreamEnable : 1;
+ BOOLEANRsvdbits2 : 7;
UINT32 DmiLinkDownHangBypass : 1;
UINT32 Rsvdbits : 29;
UINT32 Rsvd0[6]; ///< Reserved bytes
@@ -1447,6 +1449,7 @@ typedef struct {
TRACE_HUB_CONFIGTraceHub;
UINT32 AetEnableMode : 2;
UINT32 PchTraceHubHide: 1;
+ UINT32 Rsvdbits : 29;
} PCH_TRACE_HUB_CONFIG;
--
2.36.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90089): https://edk2.groups.io/g/devel/message/90089
Mute This Topic: https://groups.io/mt/91386455/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
