Re: [edk2-devel] [PATCH V2 5/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore
On June 27, 2022 5:14 PM, Gerd Hoffmann wrote: > > + #ifdef SECURE_BOOT_FEATURE_ENABLED > > + PlatformInitEmuVariableNvStore ((VOID *)(UINTN)VariableStore); > > + #endif > > OvmfPkg/Library/NvVarsFileLib/ allows loading variables into emulated > varstore from a on-disk NvVars file. We can't allow that when secure boot is > active. I think we need a simliar check there. Shortcutting the > ConnectNvVarsToFileSystem() function with a > > #ifdef SECURE_BOOT_FEATURE_ENABLED > return EFI_NOT_SUPPORTED; > #endif > > should do the trick I think. > A good suggestion. It will be updated in the next version. Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90831): https://edk2.groups.io/g/devel/message/90831 Mute This Topic: https://groups.io/mt/91995192/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V2 4/8] OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore
On June 27, 2022 5:10 PM, Gerd Hoffmann wrote:
> > +VOID *
> > +EFIAPI
> > +PlatformReserveEmuVariableNvStore (
> > + VOID
> > + )
>
> > + DEBUG ((
> > +DEBUG_INFO,
> > +"Reserved variable store memory: 0x%p; size: %dkb\n",
> > +VariableStore,
> > +VarStoreSize / 1024
> > +));
>
> > +EFI_STATUS
> > +EFIAPI
> > +PlatformInitEmuVariableNvStore (
> > + IN VOID *EmuVariableNvStore
> > + )
> > +{
>
> I think it would be good to add a log message to this function too, to make it
> easier to check variable initialization actually works the way it is supposed
> to work.
>
Thanks for reminder. Log will be added.
Thanks
Min
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90830): https://edk2.groups.io/g/devel/message/90830
Mute This Topic: https://groups.io/mt/91995191/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V2 1/8] OvmfPkg: Move TdxValidateCfv from PeilessStartupLib to PlatformInitLib
On June 27, 2022 4:41 PM, Gerd Hoffmann wrote: > On Mon, Jun 27, 2022 at 08:04:06AM +, Min Xu wrote: > > On June 27, 2022 3:02 PM, Gerd Hoffmann wrote: > > > On Sun, Jun 26, 2022 at 11:05:50AM +0800, Min Xu wrote: > > > > From: Min M Xu > > > > > > > > TdxValidateCfv validates the integrity of Configuration FV (CFV). > > > > It was implemented in PeilessStartupLib which is included in > IntelTdxX64. > > > > > > > --- a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c > > > > +++ b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c > > > > > > > +/** > > > > + Check the integrity of CFV data. > > > > + > > > > + @param[in] TdxCfvBase - A pointer to CFV header @param[in] > > > > + TdxCfvSize - CFV data size > > > > + > > > > + @retval TRUE - The CFV data is valid. > > > > + @retval FALSE - The CFV data is invalid. > > > > + > > > > +**/ > > > > +BOOLEAN > > > > +EFIAPI > > > > +TdxValidateCfv ( > > > > + IN UINT8 *TdxCfvBase, > > > > + IN UINT32 TdxCfvSize > > > > + ) > > > > > > Hmm, is there anything tdx-specific in this function? > > > Looks like generic verification of varstore structure to me. > > > > > There is no tdx-specific in this function. I will rename it to something > > more > generic. > > Also move out of IntelTdx.c please. Yes, it will be in Platform.c, together with PlatformInitEmuVariableNvStore and PlatformReserveEmuVariableNvStore. > > Does it make sense to call it right before calling > PlatformInitEmuVariableNvStore()? I think it can be called in PlatformInitEmuVariableNvStore, as it is a pre-check before copy over the content to EmuVariableNvStore. Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90829): https://edk2.groups.io/g/devel/message/90829 Mute This Topic: https://groups.io/mt/91995188/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Add PCD to control SMRR enable & SmmFeatureControl support
For below question 1&3:
Since we have defined the PCD for the feature control, should we still need
check the enable case? i though we only add the assert case for not support
case, because we must make sure has the capability to enable it. But for
support case, platform can still disable it via the pcd?
For below question 2:
It's the intention because FeatureControl & BIT3 is 0, which means SMRR
Enable(BIT3) of MSR_FEATURE_CONTROL MSR(0x3A) is *not* set before
accessing SMRR base/mask MSRs, then ASSERT (!FeaturePcdGet (PcdSmrrEnable));
Thanks,
Jiaxin
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, June 28, 2022 5:17 PM
> To: Wu, Jiaxin ; devel@edk2.groups.io
> Cc: Dong, Eric
> Subject: RE: [PATCH v1] UefiCpuPkg: Add PCD to control SMRR enable &
> SmmFeatureControl support
>
> > - //
> > - // Check CPUID(CPUID_VERSION_INFO).EDX[12] for MTRR capability
> > - //
> > - if ((RegEdx & BIT12) != 0) {
> > -//
> > -// Check MTRR_CAP MSR bit 11 for SMRR support
> > -//
> > -if ((AsmReadMsr64 (SMM_FEATURES_LIB_IA32_MTRR_CAP) & BIT11) !=
> 0)
> > {
> > - mSmrrSupported = TRUE;
>
> 1. can we keep the logic but just replace the above line as "ASSERT
> (FeaturePcdGet (PcdSmrrEnable));"?
>
> > if ((FeatureControl & BIT3) == 0) {
> > - if ((FeatureControl & BIT0) == 0) {
> > + if (((FeatureControl & BIT0) == 0) && (FeaturePcdGet
> (PcdSmrrEnable)))
> > {
> > AsmWriteMsr64 (SMM_FEATURES_LIB_IA32_FEATURE_CONTROL,
> > FeatureControl | BIT3);
> >} else {
> > -mSmrrSupported = FALSE;
> > +ASSERT (!FeaturePcdGet (PcdSmrrEnable));
>
> 2. If PcdSmrrEnable is TRUE but the FeatureControl MSR is locked (BIT0 is
> set),
> above assertion will be hit. We may need to reconsider the code logic.
>
> > -{
> > - //
> > - // Check to see if the CPU supports the SMM Code Access Check
> feature
> > - // Do not access this MSR unless the CPU supports the
> > SmmRegFeatureControl
> > - //
> > - if ((AsmReadMsr64 (SMM_FEATURES_LIB_IA32_MCA_CAP) &
> > SMM_CODE_ACCESS_CHK_BIT) != 0) {
> > -mSmmFeatureControlSupported = TRUE;
>
> 3. can we keep the logic but just replace the above line as "ASSERT
> (FeaturePcdGet (PcdSmmFeatureControlEnable))"?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90828): https://edk2.groups.io/g/devel/message/90828
Mute This Topic: https://groups.io/mt/92040046/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Alder Lake FSP Released
Hi All, Intel is pleased to announce that Alder Lake FSP is now available at https://github.com/intel/FSP. With Best Regards, Nate -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90827): https://edk2.groups.io/g/devel/message/90827 Mute This Topic: https://groups.io/mt/92057074/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [edk2:PATCH v3] MdePkg/Acpi62: Add type 7 NFIT Platform Capabilities Structure support
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Miki Shindo
> 发送时间: 2022年6月23日 11:40
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Ray Ni
>
> 主题: [edk2-devel] [edk2:PATCH v3] MdePkg/Acpi62: Add type 7 NFIT
> Platform Capabilities Structure support
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3915
>
> This commit adds a definition type 7 Platform Capabilities Structure
> and the struct definition for NFIT Table Structure Types.
> The type has been added since ACPI Specification Version 6.2A.
>
> Signed-off-by: Miki Shindo
> Cc: Michael D Kinney
> Cc: Liming Gao
> Cc: Zhiguang Liu
> Cc: Ray Ni
>
> ---
> MdePkg/Include/IndustryStandard/Acpi62.h | 13 +
> MdePkg/Include/IndustryStandard/Acpi63.h | 13 +
> MdePkg/Include/IndustryStandard/Acpi64.h | 13 +
> 3 files changed, 39 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h
> b/MdePkg/Include/IndustryStandard/Acpi62.h
> index 313db63044..836e986ee5 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -1486,6 +1486,7 @@ typedef struct {
> #define
> EFI_ACPI_6_2_NFIT_NVDIMM_CONTROL_REGION_STRUCTURE_TYPE
> 4
>
> #define
> EFI_ACPI_6_2_NFIT_NVDIMM_BLOCK_DATA_WINDOW_REGION_STRUCTU
> RE_TYPE 5
>
> #define EFI_ACPI_6_2_NFIT_FLUSH_HINT_ADDRESS_STRUCTURE_TYPE
> 6
>
> +#define EFI_ACPI_6_2_NFIT_PLATFORM_CAPABILITIES_STRUCTURE_TYPE
> 7
>
>
>
> //
>
> // Definition for NFIT Structure Header
>
> @@ -1638,6 +1639,18 @@ typedef struct {
>// UINT64
> FlushHintAddress[NumberOfFlushHintAddresses];
>
> } EFI_ACPI_6_2_NFIT_FLUSH_HINT_ADDRESS_STRUCTURE;
>
>
>
> +//
>
> +// Definition for Platform Capabilities Structure
>
> +//
>
> +typedef struct {
>
> + UINT16Type;
>
> + UINT16Length;
>
> + UINT8 HighestValidCapability;
>
> + UINT8 Reserved_5[3];
>
> + UINT32Capabilities;
>
> + UINT8 Reserved_12[4];
>
> +} EFI_ACPI_6_2_NFIT_PLATFORM_CAPABILITIES_STRUCTURE;
>
> +
>
> ///
>
> /// Secure DEVices Table (SDEV)
>
> ///
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h
> b/MdePkg/Include/IndustryStandard/Acpi63.h
> index b1e9d5db5b..15a30d8808 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi63.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi63.h
> @@ -1450,6 +1450,7 @@ typedef struct {
> #define
> EFI_ACPI_6_3_NFIT_NVDIMM_CONTROL_REGION_STRUCTURE_TYPE
> 4
>
> #define
> EFI_ACPI_6_3_NFIT_NVDIMM_BLOCK_DATA_WINDOW_REGION_STRUCTU
> RE_TYPE 5
>
> #define EFI_ACPI_6_3_NFIT_FLUSH_HINT_ADDRESS_STRUCTURE_TYPE
> 6
>
> +#define EFI_ACPI_6_3_NFIT_PLATFORM_CAPABILITIES_STRUCTURE_TYPE
> 7
>
>
>
> //
>
> // Definition for NFIT Structure Header
>
> @@ -1602,6 +1603,18 @@ typedef struct {
>// UINT64
> FlushHintAddress[NumberOfFlushHintAddresses];
>
> } EFI_ACPI_6_3_NFIT_FLUSH_HINT_ADDRESS_STRUCTURE;
>
>
>
> +//
>
> +// Definition for Platform Capabilities Structure
>
> +//
>
> +typedef struct {
>
> + UINT16Type;
>
> + UINT16Length;
>
> + UINT8 HighestValidCapability;
>
> + UINT8 Reserved_5[3];
>
> + UINT32Capabilities;
>
> + UINT8 Reserved_12[4];
>
> +} EFI_ACPI_6_3_NFIT_PLATFORM_CAPABILITIES_STRUCTURE;
>
> +
>
> ///
>
> /// Secure DEVices Table (SDEV)
>
> ///
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 232697f228..c1d8b14c44 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -1493,6 +1493,7 @@ typedef struct {
> #define
> EFI_ACPI_6_4_NFIT_NVDIMM_CONTROL_REGION_STRUCTURE_TYPE
> 4
>
> #define
> EFI_ACPI_6_4_NFIT_NVDIMM_BLOCK_DATA_WINDOW_REGION_STRUCTU
> RE_TYPE 5
>
> #define EFI_ACPI_6_4_NFIT_FLUSH_HINT_ADDRESS_STRUCTURE_TYPE
> 6
>
> +#define EFI_ACPI_6_4_NFIT_PLATFORM_CAPABILITIES_STRUCTURE_TYPE
> 7
>
>
>
> //
>
> // Definition for NFIT Structure Header
>
> @@ -1651,6 +1652,18 @@ typedef struct {
>// UINT64
> FlushHintAddress[NumberOfFlushHintAddresses];
>
> } EFI_ACPI_6_4_NFIT_FLUSH_HINT_ADDRESS_STRUCTURE;
>
>
>
> +//
>
> +// Definition for Platform Capabilities Structure
>
> +//
>
> +typedef struct {
>
> + UINT16Type;
>
> + UINT16Length;
>
> + UINT8 HighestValidCapability;
>
> + UINT8 Reserved_5[3];
>
> + UINT32Capabilities;
>
> + UINT8 Reserved_12[4];
>
> +} EFI_ACPI_6_4_NFIT_PLATFORM_CAPABILITIES_STRUCTURE;
>
> +
>
> ///
>
> /// Secure DEVices Table (SDEV)
>
> ///
>
> --
> 2.27.0.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#90709): https://edk2.groups.io/g/devel/message/90709
> Mute This Topic: https://groups.io/mt/91936713/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
>
Re: [edk2-devel] [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 reference with py3.7
Pushed 6a05ae4630686b5dda91ffd1f8c9a13cae6d079b Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, June 28, 2022 2:54 PM > To: Jayaprakash, N ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Gao, Liming > Subject: RE: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 > reference with py3.7 > > Reviewed-by: Michael D Kinney > > > > -Original Message- > > From: Jayaprakash, N > > Sent: Monday, June 27, 2022 11:48 PM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > > > Subject: RE: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 > > reference with py3.7 > > > > Could you please review and merge this change? > > > > This is a simple documentation fix only. > > > > Regards, > > JP > > > > -Original Message- > > From: Jayaprakash, N > > Sent: 17 June 2022 14:24 > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > > > Subject: RE: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 > > reference with py3.7 > > > > This is a simple documentation fix. Could some one from the group review > > and merge these changes? > > > > Regards, > > JP > > > > -Original Message- > > From: Jayaprakash, N > > Sent: 10 June 2022 09:19 > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > ; Jayaprakash, N > > > > Subject: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 > > reference with py3.7 > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3788 > > > > Removed an outdated reference to py2.7 in the Windows systems wiki page and > > replaced it with the py3.7 to align with the > updated > > build instructions > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Signed-off-by: Jayaprakash N > > --- > > Windows-systems.mediawiki | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Windows-systems.mediawiki b/Windows-systems.mediawiki index > > 0b69b56..cca2b73 100644 > > --- a/Windows-systems.mediawiki > > +++ b/Windows-systems.mediawiki > > @@ -88,7 +88,7 @@ Example: > > Example: > > *Open Command prompt and CD C:\edk2: > > > > - C:\edk2> set PYTHON_HOME=C:\Python27 > > + C:\edk2> set PYTHON_HOME=C:\Python37 > > C:\edk2> edksetup.bat Rebuild > > > > > > -- > > 2.33.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90825): https://edk2.groups.io/g/devel/message/90825 Mute This Topic: https://groups.io/mt/91661795/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 reference with py3.7
Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Monday, June 27, 2022 11:48 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: RE: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 > reference with py3.7 > > Could you please review and merge this change? > > This is a simple documentation fix only. > > Regards, > JP > > -Original Message- > From: Jayaprakash, N > Sent: 17 June 2022 14:24 > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: RE: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 > reference with py3.7 > > This is a simple documentation fix. Could some one from the group review and > merge these changes? > > Regards, > JP > > -Original Message- > From: Jayaprakash, N > Sent: 10 June 2022 09:19 > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Jayaprakash, N > > Subject: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 reference > with py3.7 > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3788 > > Removed an outdated reference to py2.7 in the Windows systems wiki page and > replaced it with the py3.7 to align with the updated > build instructions > > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Jayaprakash N > --- > Windows-systems.mediawiki | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Windows-systems.mediawiki b/Windows-systems.mediawiki index > 0b69b56..cca2b73 100644 > --- a/Windows-systems.mediawiki > +++ b/Windows-systems.mediawiki > @@ -88,7 +88,7 @@ Example: > Example: > *Open Command prompt and CD C:\edk2: > > - C:\edk2> set PYTHON_HOME=C:\Python27 > + C:\edk2> set PYTHON_HOME=C:\Python37 > C:\edk2> edksetup.bat Rebuild > > > -- > 2.33.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90824): https://edk2.groups.io/g/devel/message/90824 Mute This Topic: https://groups.io/mt/91661795/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 00/11] Enhance Secure Boot Variable Libraries
Hi SecurityPkg maintainers & reviewers, I posted this patch series a while back intending to generalize the usage of a few interfaces from secure boot libraries. Could you please help reviewing them and provide feedback? Any input is appreciated. Regards, Kun On Mon, Jun 13, 2022 at 1:39 PM Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3909 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3910 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3911 > > This is a revamp of a previously submitted patch series based on top of > master branch: https://edk2.groups.io/g/devel/message/89507. No changes > added. > > Current SecureBootVariableLib provide great support for deleting secure > boot related variables, creating time-based payloads. > > However, for secure boot enrollment, the SecureBootVariableProvisionLib > interfaces always assume the changes from variable storage, limiting the > usage, requiring existing platforms to change key initialization process > to adapt to the new methods, as well as bringing in extra dependencies > such as FV protocol, time protocols. > > This patch series proposes to update the implementation for Secure Boot > Variable libraries and their consumers to better support the related > variables operations. > > Patch v2 branch: > https://github.com/kuqin12/edk2/tree/secure_boot_enhance_v2 > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Min Xu > Cc: Sean Brogan > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Peter Grehan > Cc: Sebastien Boeuf > Cc: Andrew Fish > Cc: Ray Ni > > Kun Qin (8): > SecurityPkg: UefiSecureBoot: Definitions of cert and payload > structures > SecurityPkg: PlatformPKProtectionLib: Added PK protection interface > SecurityPkg: SecureBootVariableLib: Updated time based payload creator > SecurityPkg: SecureBootVariableProvisionLib: Updated implementation > SecurityPkg: Secure Boot Drivers: Added common header files > SecurityPkg: SecureBootConfigDxe: Updated invocation pattern > OvmfPkg: Pipeline: Resolve SecureBootVariableLib dependency > EmulatorPkg: Pipeline: Resolve SecureBootVariableLib dependency > > kuqin (3): > SecurityPkg: SecureBootVariableLib: Updated signature list creator > SecurityPkg: SecureBootVariableLib: Added newly supported interfaces > SecurityPkg: SecureBootVariableLib: Added unit tests > > SecurityPkg/EnrollFromDefaultKeysApp/EnrollFromDefaultKeysApp.c > |1 + > > SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.c > | 51 + > SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.c > | 486 - > > SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockPlatformPKProtectionLib.c > | 36 + > SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiLib.c > | 201 ++ > > SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiRuntimeServicesTableLib.c > | 13 + > > SecurityPkg/Library/SecureBootVariableLib/UnitTest/SecureBootVariableLibUnitTest.c > | 2037 > > SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.c > | 145 +- > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigImpl.c > | 128 +- > > SecurityPkg/VariableAuthenticated/SecureBootDefaultKeysDxe/SecureBootDefaultKeysDxe.c >|1 + > EmulatorPkg/EmulatorPkg.dsc > |1 + > OvmfPkg/Bhyve/BhyveX64.dsc > |1 + > OvmfPkg/CloudHv/CloudHvX64.dsc > |1 + > OvmfPkg/IntelTdx/IntelTdxX64.dsc > |1 + > OvmfPkg/OvmfPkgIa32.dsc > |1 + > OvmfPkg/OvmfPkgIa32X64.dsc > |1 + > OvmfPkg/OvmfPkgX64.dsc > |1 + > SecurityPkg/Include/Library/PlatformPKProtectionLib.h > | 31 + > SecurityPkg/Include/Library/SecureBootVariableLib.h > | 103 +- > SecurityPkg/Include/UefiSecureBoot.h > | 94 + > > SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf > | 36 + > SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > | 14 +- > > SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockPlatformPKProtectionLib.inf > | 33 + > SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiLib.inf > | 45 + > > SecurityPkg/Library/SecureBootVariableLib/UnitTest/MockUefiRuntimeServicesTableLib.inf > | 25 + > > SecurityPkg/Library/SecureBootVariableLib/UnitTest/SecureBootVariableLibUnitTest.inf > | 36 + > SecurityPkg/SecurityPkg.ci.yaml > | 11 + > SecurityPkg/SecurityPkg.dec > |5 + > SecurityPkg/SecurityPkg.dsc > |2 + > SecurityPkg/Test/SecurityPkgHostTest.dsc > | 38 + >
[edk2-devel] [PATCH v1 1/1] OvmfPkg/QemuVideoDxe: Zero out PixelInformation in QueryMode
Ensure that the PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is zeroed out in
EFI_GRAPHICS_OUTPUT_PROTOCOL.QueryMode() and
EFI_GRAPHICS_OUTPUT_PROTOCOL.SetMode() when PixelFormat is
PixelBlueGreenRedReserved8BitPerColor.
According to UEFI 2.9 Section 12.9, PixelInformation field of the
EFI_GRAPHICS_OUTPUT_MODE_INFORMATION structure is valid only if
PixelFormat is PixelBitMask. This means that firmware is not required
to fill out the PixelInformation field for other PixelFormat types,
which implies that the QemuVideoDxe implementation is technically
correct.
However, not zeroing out those fields will leak the contents of the
memory returned by the memory allocator, so it is better to explicitly
set them to zero.
In addition, the SCT test suite relies on PixelInformation always
having a consistent value, which causes failures.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Jeff Booher-Kaeding
Cc: Samer El-Haj-Mahmoud
Cc: Sunny Wang
Cc: Jeremy Linton
Signed-off-by: Dimitrije Pavlov
---
OvmfPkg/QemuVideoDxe/Gop.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c
index 0c4dea7fb6f2..7a9fe208c99c 100644
--- a/OvmfPkg/QemuVideoDxe/Gop.c
+++ b/OvmfPkg/QemuVideoDxe/Gop.c
@@ -31,7 +31,14 @@ QemuVideoCompleteModeInfo (
Info->PixelInformation.ReservedMask = 0;
} else if (ModeData->ColorDepth == 32) {
DEBUG ((DEBUG_INFO, "PixelBlueGreenRedReserved8BitPerColor\n"));
-Info->PixelFormat = PixelBlueGreenRedReserved8BitPerColor;
+Info->PixelFormat =
PixelBlueGreenRedReserved8BitPerColor;
+Info->PixelInformation.RedMask = 0;
+Info->PixelInformation.GreenMask= 0;
+Info->PixelInformation.BlueMask = 0;
+Info->PixelInformation.ReservedMask = 0;
+ } else {
+DEBUG ((DEBUG_ERROR, "%a: Invalid ColorDepth %u", __FUNCTION__,
ModeData->ColorDepth));
+ASSERT (FALSE);
}
Info->PixelsPerScanLine = Info->HorizontalResolution;
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90822): https://edk2.groups.io/g/devel/message/90822
Mute This Topic: https://groups.io/mt/92050521/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH V2 0/7] Fix ACPI Low Power Idle states for RD platforms
On Tue, 28 Jun 2022 at 20:20, Pranav Madhu wrote: > > Changes since V1: > - Rebased on top of latest master branch. > > The DSDT ACPI table used for Neoverse reference design platforms include > the _LPI control method for the kernel to enter idle states. This patch > series fixes bugs in the existing _LPI control method due to which > certain high level OS failed to boot on the supported Neoverse reference > design platforms. For each platform, the fixes include - clearing level > ID value as the platform supports only platform co-ordinated _LPI and > removing residency counter frequency as the platform does not implement > residency counter. > > In addition to this, the RD-N2 and RD-N2-Cfg1 platforms are direct > connect platforms and so the _LPI control method for cluster is removed. > > Link to github branch with the patches in this series - > https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/lpi_fix_for_rd_platforms > > Reviewed-by: Pierre Gondois > Reviewed-by: Thomas Abraham > > Pranav Madhu (7): > Platform/Sgi: Fix ACPI Low Power Idle states for SGI575 > Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge > Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2 > Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1 > Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC > Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2 > Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1 > Pushed as 8e067b431294..923ef6c8c862 Thanks, -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90821): https://edk2.groups.io/g/devel/message/90821 Mute This Topic: https://groups.io/mt/92050002/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH V2 7/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1
RD-N2-Cfg1 platform supports only the platform co-ordinated LPI. So fix
the LPI Level ID value accordingly.
Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method. As
the cpus are directly connected to the interconnect on this platform,
remove the cluster _LPI control method as well.
Signed-off-by: Pranav Madhu
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl | 54 ++--
1 file changed, 4 insertions(+), 50 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl
b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl
index b6decc77f480..2e9e588806c6 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl
@@ -68,38 +68,16 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Return (Arg3)
}
-Name (CLPI, Package () { /* LPI for Cluster, support 1 LPI state */
- 0, // Version
- 0, // Level Index
- 1, // Count
- Package () {// Power Gating state for Cluster
-2500, // Min residency (uS)
-1150, // Wake latency (uS)
-1,// Flags
-1,// Arch Context Flags
-100, // Residency Counter Frequency
-0,// No Parent State
-0x0020, // Integer Entry method
-ResourceTemplate () { // Null Residency Counter
- Register (SystemMemory, 0, 0, 0, 0)
-},
-ResourceTemplate () { // Null Usage Counter
- Register (SystemMemory, 0, 0, 0, 0)
-},
-"LPI2-Cluster"
- },
-})
-
Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */
0, // Version
- 1, // Level Index
+ 0, // Level Index
2, // Count
Package () {// WFI for CPU
1,// Min residency (uS)
1,// Wake latency (uS)
1,// Flags
0,// Arch Context lost Flags (no loss)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
@@ -122,8 +100,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
350, // Wake latency (uS)
1,// Flags
1,// Arch Context lost Flags (Core context lost)
-100, // Residency Counter Frequency
-1,// Parent node can be in any shallower state
+0,// Residency Counter Frequency
+0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
32, // Bit Width
@@ -145,9 +123,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL00) { // Cluster 0
Name (_HID, "ACPI0010")
Name (_UID, 0)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP00) { // Neoverse N2 core 0
Name (_HID, "ACPI0007")
@@ -172,9 +147,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL01) { // Cluster 1
Name (_HID, "ACPI0010")
Name (_UID, 1)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP01) { // Neoverse N2 core 1
Name (_HID, "ACPI0007")
@@ -199,9 +171,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL02) { // Cluster 2
Name (_HID, "ACPI0010")
Name (_UID, 2)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP02) { // Neoverse N2 core 2
Name (_HID, "ACPI0007")
@@ -226,9 +195,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL03) { // Cluster 3
Name (_HID, "ACPI0010")
Name (_UID, 3)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP03) { // Neoverse N2 core 3
Name (_HID, "ACPI0007")
@@ -253,9 +219,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL04) { // Cluster 4
Name (_HID, "ACPI0010")
Name (_UID, 4)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP04) { // Neoverse N2 core 4
Name (_HID, "ACPI0007")
@@ -280,9 +243,6 @@ DefinitionBlock
[edk2-devel] [edk2-platforms][PATCH V2 6/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2
RD-N2 platform supports only the platform co-ordinated LPI. So fix the
LPI Level ID value accordingly.
Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method. As
the cpus are directly connected to the interconnect on this platform,
remove the cluster _LPI control method as well.
Signed-off-by: Pranav Madhu
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 78 +---
1 file changed, 4 insertions(+), 74 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl
b/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl
index ccd98f829652..0f63ca42d505 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl
@@ -62,38 +62,16 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Return (Arg3)
}
-Name (CLPI, Package () { /* LPI for Cluster, support 1 LPI state */
- 0, // Version
- 0, // Level Index
- 1, // Count
- Package () {// Power Gating state for Cluster
-2500, // Min residency (uS)
-1150, // Wake latency (uS)
-1,// Flags
-1,// Arch Context Flags
-100, // Residency Counter Frequency
-0,// No Parent State
-0x0020, // Integer Entry method
-ResourceTemplate () { // Null Residency Counter
- Register (SystemMemory, 0, 0, 0, 0)
-},
-ResourceTemplate () { // Null Usage Counter
- Register (SystemMemory, 0, 0, 0, 0)
-},
-"LPI2-Cluster"
- },
-})
-
Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */
0, // Version
- 1, // Level Index
+ 0, // Level Index
2, // Count
Package () {// WFI for CPU
1,// Min residency (uS)
1,// Wake latency (uS)
1,// Flags
0,// Arch Context lost Flags (no loss)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
@@ -116,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
350, // Wake latency (uS)
1,// Flags
1,// Arch Context lost Flags (Core context lost)
-100, // Residency Counter Frequency
-1,// Parent node can be in any shallower state
+0,// Residency Counter Frequency
+0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
32, // Bit Width
@@ -139,9 +117,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL00) { // Cluster 0
Name (_HID, "ACPI0010")
Name (_UID, 0)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP00) { // Neoverse N2 core 0
Name (_HID, "ACPI0007")
@@ -166,9 +141,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL01) { // Cluster 1
Name (_HID, "ACPI0010")
Name (_UID, 1)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP01) { // Neoverse N2 core 1
Name (_HID, "ACPI0007")
@@ -193,9 +165,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL02) { // Cluster 2
Name (_HID, "ACPI0010")
Name (_UID, 2)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP02) { // Neoverse N2 core 2
Name (_HID, "ACPI0007")
@@ -220,9 +189,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL03) { // Cluster 3
Name (_HID, "ACPI0010")
Name (_UID, 3)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP03) { // Neoverse N2 core 3
Name (_HID, "ACPI0007")
@@ -247,9 +213,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Device (CL04) { // Cluster 4
Name (_HID, "ACPI0010")
Name (_UID, 4)
- Method (_LPI, 0, NotSerialized) {
-Return (\_SB.CLPI)
- }
Device (CP04) { // Neoverse N2 core 4
Name (_HID, "ACPI0007")
@@ -274,9 +237,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
[edk2-devel] [edk2-platforms][PATCH V2 5/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC
RD-V1-MC platform supports only the platform co-ordinated LPI. So fix
the LPI Level ID value accordingly.
Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method.
Signed-off-by: Pranav Madhu
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl
b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl
index e084d82de7c0..152a3076fedd 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl
@@ -64,14 +64,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */
0, // Version
- 1, // Level Index
+ 0, // Level Index
2, // Count
Package () {// WFI for CPU
1,// Min residency (uS)
1,// Wake latency (uS)
1,// Flags
0,// Arch Context lost Flags (no loss)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
@@ -94,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
350, // Wake latency (uS)
1,// Flags
1,// Arch Context lost Flags (Core context lost)
-100, // Residency Counter Frequency
-1,// Parent node can be in any shallower state
+0,// Residency Counter Frequency
+0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
32, // Bit Width
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90818): https://edk2.groups.io/g/devel/message/90818
Mute This Topic: https://groups.io/mt/92050010/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH V2 4/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1
RD-V1 platform supports only the platform co-ordinated LPI. So fix the
LPI Level ID value accordingly.
Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method.
Signed-off-by: Pranav Madhu
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl
b/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl
index db9c19780e16..3c9c878dd880 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl
@@ -64,14 +64,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */
0, // Version
- 1, // Level Index
+ 0, // Level Index
2, // Count
Package () {// WFI for CPU
1,// Min residency (uS)
1,// Wake latency (uS)
1,// Flags
0,// Arch Context lost Flags (no loss)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
@@ -94,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
350, // Wake latency (uS)
1,// Flags
1,// Arch Context lost Flags (Core context lost)
-100, // Residency Counter Frequency
-1,// Parent node can be in any shallower state
+0,// Residency Counter Frequency
+0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
32, // Bit Width
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90817): https://edk2.groups.io/g/devel/message/90817
Mute This Topic: https://groups.io/mt/92050007/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH V2 3/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2
RD-N1-Edge-X2 platform supports only the platform co-ordinated LPI. So
fix the LPI Level ID value accordingly.
Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method.
Signed-off-by: Pranav Madhu
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
index 9cb2b175418c..28e255c6de6e 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl
@@ -60,7 +60,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
1150, // Wake latency (uS)
1,// Flags
1,// Arch Context Flags
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No Parent State
0x0020, // Integer Entry method
ResourceTemplate () { // Null Residency Counter
@@ -75,14 +75,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */
0, // Version
- 1, // Level Index
+ 0, // Level Index
2, // Count
Package () {// WFI for CPU
1,// Min residency (uS)
1,// Wake latency (uS)
1,// Flags
0,// Arch Context lost Flags (no loss)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
@@ -105,7 +105,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
350, // Wake latency (uS)
1,// Flags
1,// Arch Context lost Flags (Core context lost)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
1,// Parent node can be in any shallower state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90816): https://edk2.groups.io/g/devel/message/90816
Mute This Topic: https://groups.io/mt/92050006/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH V2 2/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge
RD-N1-Edge platform supports only the platform co-ordinated LPI. So fix
the LPI Level ID value accordingly.
Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method.
Signed-off-by: Pranav Madhu
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl
b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl
index bd8efa544a59..7b4bbd36d8c0 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl
@@ -58,7 +58,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
1150, // Wake latency (uS)
1,// Flags
1,// Arch Context Flags
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No Parent State
0x0020, // Integer Entry method
ResourceTemplate () { // Null Residency Counter
@@ -73,14 +73,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */
0, // Version
- 1, // Level Index
+ 0, // Level Index
2, // Count
Package () {// WFI for CPU
1,// Min residency (uS)
1,// Wake latency (uS)
1,// Flags
0,// Arch Context lost Flags (no loss)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
@@ -103,7 +103,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI",
350, // Wake latency (uS)
1,// Flags
1,// Arch Context lost Flags (Core context lost)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
1,// Parent node can be in any shallower state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90815): https://edk2.groups.io/g/devel/message/90815
Mute This Topic: https://groups.io/mt/92050004/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH V2 1/7] Platform/Sgi: Fix ACPI Low Power Idle states for SGI575
SGI-575 platform supports only the platform co-ordinated LPI. So fix the
LPI Level ID value accordingly.
Additionally, as this platform does not support residency counter, clear
the residency counter frequency from _LPI object's control method.
Signed-off-by: Pranav Madhu
Reviewed-by: Pierre Gondois
Reviewed-by: Thomas Abraham
---
Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl
b/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl
index 80075ee1238b..f4e84e806a65 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl
@@ -57,7 +57,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI", EFI_ACPI_ARM_OEM
1150, // Wake latency (uS)
1,// Flags
1,// Arch Context Flags
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No Parent State
0x0020, // Integer Entry method
ResourceTemplate () { // Null Residency Counter
@@ -72,14 +72,14 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI", EFI_ACPI_ARM_OEM
Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */
0, // Version
- 1, // Level Index
+ 0, // Level Index
2, // Count
Package () {// WFI for CPU
1,// Min residency (uS)
1,// Wake latency (uS)
1,// Flags
0,// Arch Context lost Flags (no loss)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
0,// No parent state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
@@ -102,7 +102,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD",
"ARMSGI", EFI_ACPI_ARM_OEM
350, // Wake latency (uS)
1,// Flags
1,// Arch Context lost Flags (Core context lost)
-100, // Residency Counter Frequency
+0,// Residency Counter Frequency
1,// Parent node can be in any shallower state
ResourceTemplate () { // Register Entry method
Register (FFixedHW,
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90814): https://edk2.groups.io/g/devel/message/90814
Mute This Topic: https://groups.io/mt/92050003/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH V2 0/7] Fix ACPI Low Power Idle states for RD platforms
Changes since V1: - Rebased on top of latest master branch. The DSDT ACPI table used for Neoverse reference design platforms include the _LPI control method for the kernel to enter idle states. This patch series fixes bugs in the existing _LPI control method due to which certain high level OS failed to boot on the supported Neoverse reference design platforms. For each platform, the fixes include - clearing level ID value as the platform supports only platform co-ordinated _LPI and removing residency counter frequency as the platform does not implement residency counter. In addition to this, the RD-N2 and RD-N2-Cfg1 platforms are direct connect platforms and so the _LPI control method for cluster is removed. Link to github branch with the patches in this series - https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/lpi_fix_for_rd_platforms Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham Pranav Madhu (7): Platform/Sgi: Fix ACPI Low Power Idle states for SGI575 Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2 Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1 Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2 Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1 Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 8 +- Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 8 +- Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 78 +--- Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl | 54 +- Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 8 +- Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 8 +- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 8 +- 7 files changed, 28 insertions(+), 144 deletions(-) -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90813): https://edk2.groups.io/g/devel/message/90813 Mute This Topic: https://groups.io/mt/92050002/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Silicon/Qemu: Provide _STA ACPI method
On Tue, 28 Jun 2022 at 18:26, Dimitrije Pavlov wrote: > > SBBR requires platforms to provide the _STA ACPI method for each > defined device. This patch implements a stub method that always > indicates devices are present and functional. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Graeme Gregory > Cc: Radoslaw Biernacki > Cc: Jeff Booher-Kaeding > Cc: Samer El-Haj-Mahmoud > Cc: Sunny Wang > Cc: Jeremy Linton > > Signed-off-by: Dimitrije Pavlov For the record, I will mention again that I think it is a stupid idea to *require* that every object has a _STA method that behaves exactly the same as having no _STA at all. Oh well ... Pushed as f653a22385f5..8e067b431294 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90812): https://edk2.groups.io/g/devel/message/90812 Mute This Topic: https://groups.io/mt/92048259/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2-platforms][PATCH v1 1/1] Silicon/Qemu: Provide _STA ACPI method
SBBR requires platforms to provide the _STA ACPI method for each
defined device. This patch implements a stub method that always
indicates devices are present and functional.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Graeme Gregory
Cc: Radoslaw Biernacki
Cc: Jeff Booher-Kaeding
Cc: Samer El-Haj-Mahmoud
Cc: Sunny Wang
Cc: Jeremy Linton
Signed-off-by: Dimitrije Pavlov
---
Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 38 +++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
index 1bf9fbb99e75..3357916571fe 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
@@ -16,6 +16,9 @@
Name (_PRS, ResourceTemplate() {
\
Interrupt (ResourceProducer, Level, ActiveHigh, Exclusive) {
Irq } \
})
\
+Method (_STA) {
\
+ Return (0xF)
\
+}
\
Method (_CRS, 0) { Return (_PRS) }
\
Method (_SRS, 1) { }
\
Method (_DIS) { }
\
@@ -40,6 +43,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x1000)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 33 }
})
+ Method (_STA) {
+Return (0xF)
+ }
}
// AHCI Host Controller
@@ -57,13 +63,18 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
FixedPcdGet32 (PcdPlatformAhciSize))
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 42 }
})
+ Method (_STA) {
+Return (0xF)
+ }
}
// USB EHCI Host Controller
Device (USB0) {
Name (_HID, "LNRO0D20")
Name (_CID, "PNP0D20")
-
+Method (_STA) {
+ Return (0xF)
+}
Method (_CRS, 0x0, Serialized) {
Name (RBUF, ResourceTemplate() {
Memory32Fixed (ReadWrite,
@@ -77,6 +88,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
// Root Hub
Device (RHUB) {
Name (_ADR, 0x) // Address of Root Hub should be 0 as per
ACPI 5.0 spec
+Method (_STA) {
+ Return (0xF)
+}
// Ports connected to Root Hub
Device (HUB1) {
@@ -87,6 +101,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x, // Reserved 0 must be zero
0x // Reserved 1 must be zero
})
+Method (_STA) {
+ Return (0xF)
+}
Device (PRT1) {
Name (_ADR, 0x0001)
@@ -102,6 +119,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+Method (_STA) {
+ Return (0xF)
+}
} // USB0_RHUB_HUB1_PRT1
Device (PRT2) {
Name (_ADR, 0x0002)
@@ -117,6 +137,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+Method (_STA) {
+ Return (0xF)
+}
} // USB0_RHUB_HUB1_PRT2
Device (PRT3) {
@@ -133,6 +156,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+Method (_STA) {
+ Return (0xF)
+}
} // USB0_RHUB_HUB1_PRT3
Device (PRT4) {
@@ -149,6 +175,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
0x31, 0x1C, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
}
})
+Method (_STA) {
+ Return (0xF)
+}
} // USB0_RHUB_HUB1_PRT4
} // USB0_RHUB_HUB1
} // USB0_RHUB
@@ -164,6 +193,10 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
Name (_UID, "PCI0")
Name (_CCA, One)// Initially mark the PCI coherent (for JunoR1)
+ Method (_STA) {
+Return (0xF)
+ }
+
Method (_CBA, 0, NotSerialized) {
return (FixedPcdGet32 (PcdPciExpressBaseAddress))
}
@@ -402,6 +435,9 @@ DefinitionBlock ("DsdtTable.aml", "DSDT",
[edk2-devel] [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL
From: James Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3967
Add macros to decide modules built into UPL.elf.
Macro list:
- GENERIC_MEMORY_TEST_ENABLE: GenericMemoryTestDxe
- NULL_MEMORY_TEST_ENABLE: NullMemoryTestDxe
- ATA_ENABLE: SataControllerDxe, AtaBusDxe, AtaAtapiPassThruDxe
- SD_ENABLE: SdMmcPciDxe, EmmcDxe, SdDxe
- PS2_MOUSE_ENABLE: Ps2MouseDxe
Cc: Guo Dong
Cc: Ray Ni
Cc: Gua Guo
Signed-off-by: James Lu
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 18 ++
UefiPayloadPkg/UefiPayloadPkg.fdf | 15 ++-
2 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index cfcf38578d..9e94a40d72 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -36,6 +36,11 @@
DEFINE PLATFORM_BOOT_TIMEOUT= 3
DEFINE ABOVE_4G_MEMORY = TRUE
DEFINE BOOT_MANAGER_ESCAPE = FALSE
+ DEFINE GENERIC_MEMORY_TEST_ENABLE = FALSE
+ DEFINE NULL_MEMORY_TEST_ENABLE = TRUE
+ DEFINE ATA_ENABLE = TRUE
+ DEFINE SD_ENABLE= TRUE
+ DEFINE PS2_MOUSE_ENABLE = TRUE
DEFINE SD_MMC_TIMEOUT = 100
#
# SBL: UEFI payload for Slim Bootloader
@@ -596,7 +601,12 @@
MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
+!if $(GENERIC_MEMORY_TEST_ENABLE) == TRUE
+
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
+!endif
+!if $(NULL_MEMORY_TEST_ENABLE) == TRUE
MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
+!endif
MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
@@ -631,9 +641,11 @@
MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
FatPkg/EnhancedFatDxe/Fat.inf
+!if $(ATA_ENABLE) == TRUE
MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf
MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
+!endif
MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf
@@ -644,9 +656,11 @@
#
# SD/eMMC Support
#
+!if $(SD_ENABLE) == TRUE
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf
MdeModulePkg/Bus/Sd/SdDxe/SdDxe.inf
+!endif
#
# Usb Support
@@ -671,7 +685,9 @@
!if $(PS2_KEYBOARD_ENABLE) == TRUE
MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
!endif
+!if $(PS2_MOUSE_ENABLE) == TRUE
MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
+!endif
#
# Console Support
@@ -742,12 +758,14 @@
# This should be FALSE for compiling the dynamic command.
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
}
+!if $(PERFORMANCE_MEASUREMENT_ENABLE) == TRUE
ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf {
## This flag is used to control initialization of the shell library
# This should be FALSE for compiling the dynamic command.
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
}
+!endif
ShellPkg/Application/Shell/Shell.inf {
## This flag is used to control initialization of the shell library
diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
b/UefiPayloadPkg/UefiPayloadPkg.fdf
index c7b04978ad..5aa228e828 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -149,7 +149,12 @@ INF
PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
INF UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
-INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
+!if $(GENERIC_MEMORY_TEST_ENABLE) == TRUE
+INF
MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf
+!endif
+!if $(NULL_MEMORY_TEST_ENABLE) == TRUE
+INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
+!endif
INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
@@ -176,7 +181,9 @@ INF OvmfPkg/SioBusDxe/SioBusDxe.inf
!if $(PS2_KEYBOARD_ENABLE) == TRUE
INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
!endif
+!if $(PS2_MOUSE_ENABLE) == TRUE
INF MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf
+!endif
#
# Console Support
@@ -195,9 +202,11 @@ INF UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf
INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
INF
[edk2-devel] [PATCH] ArmVirtPkg: do not enable iSCSI driver by default
The iSCSI driver slows down the boot on a pristine variable store flash image, as it creates a couple of large EFI non-volatile variables to preserve state between boots. Since iSCSI boot for VMs is kind of niche anyway, let's default to disabled. If someone needs it in their build, they can use the -D build command option to re-enable it on the fly. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 1 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - 2 files changed, 2 deletions(-) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 9369a88858fd..45c4a8fc84e0 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -40,7 +40,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE = FALSE DEFINE NETWORK_TLS_ENABLE = FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE - DEFINE NETWORK_ISCSI_ENABLE= TRUE !if $(NETWORK_SNP_ENABLE) == TRUE !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc index 7f7d15d6eee3..66039f07f41b 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -38,7 +38,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE = FALSE DEFINE NETWORK_TLS_ENABLE = FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE - DEFINE NETWORK_ISCSI_ENABLE= TRUE !if $(NETWORK_SNP_ENABLE) == TRUE !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" -- 2.35.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90809): https://edk2.groups.io/g/devel/message/90809 Mute This Topic: https://groups.io/mt/92041308/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Add PCD to control SMRR enable & SmmFeatureControl support
> - //
> - // Check CPUID(CPUID_VERSION_INFO).EDX[12] for MTRR capability
> - //
> - if ((RegEdx & BIT12) != 0) {
> -//
> -// Check MTRR_CAP MSR bit 11 for SMRR support
> -//
> -if ((AsmReadMsr64 (SMM_FEATURES_LIB_IA32_MTRR_CAP) & BIT11) != 0)
> {
> - mSmrrSupported = TRUE;
1. can we keep the logic but just replace the above line as "ASSERT
(FeaturePcdGet (PcdSmrrEnable));"?
> if ((FeatureControl & BIT3) == 0) {
> - if ((FeatureControl & BIT0) == 0) {
> + if (((FeatureControl & BIT0) == 0) && (FeaturePcdGet (PcdSmrrEnable)))
> {
> AsmWriteMsr64 (SMM_FEATURES_LIB_IA32_FEATURE_CONTROL,
> FeatureControl | BIT3);
>} else {
> -mSmrrSupported = FALSE;
> +ASSERT (!FeaturePcdGet (PcdSmrrEnable));
2. If PcdSmrrEnable is TRUE but the FeatureControl MSR is locked (BIT0 is set),
above assertion will be hit. We may need to reconsider the code logic.
> -{
> - //
> - // Check to see if the CPU supports the SMM Code Access Check feature
> - // Do not access this MSR unless the CPU supports the
> SmmRegFeatureControl
> - //
> - if ((AsmReadMsr64 (SMM_FEATURES_LIB_IA32_MCA_CAP) &
> SMM_CODE_ACCESS_CHK_BIT) != 0) {
> -mSmmFeatureControlSupported = TRUE;
3. can we keep the logic but just replace the above line as "ASSERT
(FeaturePcdGet (PcdSmmFeatureControlEnable))"?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90808): https://edk2.groups.io/g/devel/message/90808
Mute This Topic: https://groups.io/mt/92040046/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v1] UefiCpuPkg: Add PCD to control SMRR enable & SmmFeatureControl support
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3962
Two SMM variables (mSmrrSupported & mSmmFeatureControlSupported) are global
variables, they control whether the SMRR and SMM Feature Control MSR will
be restored respectively.
To avoid the TOCTOU, add PCD to control SMRR & SmmFeatureControl enable.
Change-Id: I6835e4b0e12c5e6f52effb60fd9224e3eb97fc0d
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Jiaxin Wu
---
.../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf| 4 ++
.../SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c| 84 --
.../SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf | 4 ++
.../StandaloneMmCpuFeaturesLib.inf | 4 ++
UefiCpuPkg/UefiCpuPkg.dec | 12
UefiCpuPkg/UefiCpuPkg.uni | 12
6 files changed, 48 insertions(+), 72 deletions(-)
diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf
b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf
index 35292dac31..7b5cef9700 100644
--- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf
+++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf
@@ -33,5 +33,9 @@
MemoryAllocationLib
DebugLib
[Pcd]
gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber##
SOMETIMES_CONSUMES
+
+[FeaturePcd]
+ gUefiCpuPkgTokenSpaceGuid.PcdSmrrEnable ## CONSUMES
+ gUefiCpuPkgTokenSpaceGuid.PcdSmmFeatureControlEnable ## CONSUMES
diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c
b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c
index 78de7f8407..b88cdece2a 100644
--- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c
+++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c
@@ -35,20 +35,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
// MSRs required for configuration of SMM Code Access Check
//
#define SMM_FEATURES_LIB_IA32_MCA_CAP 0x17D
#define SMM_CODE_ACCESS_CHK_BIT BIT58
-//
-// Set default value to assume SMRR is not supported
-//
-BOOLEAN mSmrrSupported = FALSE;
-
-//
-// Set default value to assume MSR_SMM_FEATURE_CONTROL is not supported
-//
-BOOLEAN mSmmFeatureControlSupported = FALSE;
-
//
// Set default value to assume IA-32 Architectural MSRs are used
//
UINT32 mSmrrPhysBaseMsr = SMM_FEATURES_LIB_IA32_SMRR_PHYSBASE;
UINT32 mSmrrPhysMaskMsr = SMM_FEATURES_LIB_IA32_SMRR_PHYSMASK;
@@ -81,39 +71,27 @@ CpuFeaturesLibInitialization (
UINTN ModelId;
//
// Retrieve CPU Family and Model
//
- AsmCpuid (CPUID_VERSION_INFO, , NULL, NULL, );
+ AsmCpuid (CPUID_VERSION_INFO, , NULL, NULL, NULL);
FamilyId = (RegEax >> 8) & 0xf;
ModelId = (RegEax >> 4) & 0xf;
if ((FamilyId == 0x06) || (FamilyId == 0x0f)) {
ModelId = ModelId | ((RegEax >> 12) & 0xf0);
}
- //
- // Check CPUID(CPUID_VERSION_INFO).EDX[12] for MTRR capability
- //
- if ((RegEdx & BIT12) != 0) {
-//
-// Check MTRR_CAP MSR bit 11 for SMRR support
-//
-if ((AsmReadMsr64 (SMM_FEATURES_LIB_IA32_MTRR_CAP) & BIT11) != 0) {
- mSmrrSupported = TRUE;
-}
- }
-
//
// Intel(R) 64 and IA-32 Architectures Software Developer's Manual
// Volume 3C, Section 35.3 MSRs in the Intel(R) Atom(TM) Processor Family
//
// If CPU Family/Model is 06_1CH, 06_26H, 06_27H, 06_35H or 06_36H, then
// SMRR Physical Base and SMM Physical Mask MSRs are not available.
//
if (FamilyId == 0x06) {
if ((ModelId == 0x1C) || (ModelId == 0x26) || (ModelId == 0x27) ||
(ModelId == 0x35) || (ModelId == 0x36)) {
- mSmrrSupported = FALSE;
+ ASSERT (!FeaturePcdGet (PcdSmrrEnable));
}
}
//
// Intel(R) 64 and IA-32 Architectures Software Developer's Manual
@@ -194,14 +172,10 @@ SmmCpuFeaturesInitializeProcessor (
IN CPU_HOT_PLUG_DATA *CpuHotPlugData
)
{
SMRAM_SAVE_STATE_MAP *CpuState;
UINT64FeatureControl;
- UINT32RegEax;
- UINT32RegEdx;
- UINTN FamilyId;
- UINTN ModelId;
//
// Configure SMBASE.
//
CpuState = (SMRAM_SAVE_STATE_MAP *)(UINTN)(SMM_DEFAULT_SMBASE +
SMRAM_SAVE_STATE_MAP_OFFSET);
@@ -214,17 +188,17 @@ SmmCpuFeaturesInitializeProcessor (
// If Intel(R) Core(TM) Core(TM) 2 Processor Family MSRs are being used, then
// make sure SMRR Enable(BIT3) of MSR_FEATURE_CONTROL MSR(0x3A) is set before
// accessing SMRR base/mask MSRs. If Lock(BIT0) of MSR_FEATURE_CONTROL
MSR(0x3A)
// is set, then the MSR is locked and can not be modified.
//
- if (mSmrrSupported && (mSmrrPhysBaseMsr ==
SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSBASE)) {
+ if (mSmrrPhysBaseMsr == SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSBASE) {
FeatureControl = AsmReadMsr64 (SMM_FEATURES_LIB_IA32_FEATURE_CONTROL);
if ((FeatureControl & BIT3) == 0) {
- if ((FeatureControl & BIT0) == 0) {
+ if (((FeatureControl & BIT0) == 0) && (FeaturePcdGet (PcdSmrrEnable))) {
Re: [edk2-devel] [edk2-platforms][PATCH V1 0/5] Platform/Sgi: Add initial support for RD-N2-Cfg2 platform
On Mon, 27 Jun 2022 at 08:40, Pranav Madhu wrote: > > RD-N2-Cfg2 platform is the multichip variant of the RD-N2 platform. The > platform is based on 4xMP1 Neoverse N2 CPUs per chip, CMN-700 > interconnect 6x6 mesh, multiple AXI expansion ports for I/O Coherent > PCIe, Ethernet, offload and Arm Cortex-M7 for System Control Processor > (SCP) and Manageability Control Processor (MCP). > > The first patch in this series defines the addressable bit per chip. The > second patch add the product ID unique for this platform. The third > patch adds ACPI tables, the fourth patch add Edk2 build system files. > The last patch in this series adds SMBIOS support. > > This patch series should be applied on top of the patch series: > https://edk2.groups.io/g/devel/message/90765 > > Link to github branch with the patches in this series - > https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/rdn2cfg2-initial-support > > > Pranav Madhu (1): > Platform/Sgi: Extend SMBIOS support for RD-N2-Cfg2 > > Vijayenthiran Subramaniam (4): > Platform/Sgi: Add a new PCD for defining addressable bits per chip > Platform/Sgi: Add ProductId lookup values for RD-N2-Cfg2 Platform > Platform/Sgi: Add ACPI tables for RD-N2-Cfg2 platform > Platform/Sgi: Add support for RD-N2-Cfg2 Platform > Pushed as 750f6807879b..f653a22385f5 Thanks, -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90806): https://edk2.groups.io/g/devel/message/90806 Mute This Topic: https://groups.io/mt/92015419/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH V4 0/9] Upadate the ACPI tables for RD platforms
On Mon, 27 Jun 2022 at 08:05, Pranav Madhu wrote: > > Changes since V3: > - Addressed comments from Pierre Gondois > - Rebased on top of latest master branch > > Changes since V2: > - Rebased on top of latest master branch > - Update PPTT table with unique cache ID across the system for different > levels of cache. > > Changes since V1: > - Rebased on top of latest master branch. > - Rebased on top of patch to remove SLC cache entries from PPTT (link > for the same in edk2.groups.io is provided below) > > Arm infrastructure reference design platforms uses ACPI tables to > provide the hardware information to the operating system. Currently the > ACPI tables are aligned with ACPI v6.2 and v6.3 specification. This > patch series update the tables to ACPI v6.4 specificaion. Features like > MPAM relies on cache ID field of PPTT tables to distinguish between > different physical caches, which is introduced in PPTT table in ACPI > v6.4. Also ServerReady (SBBR compliaance) strictly recomments all the > tables in the system should allign with same version of ACPI. Hence > upgrade all ACPI tables mentioned in ACPI specification to v6.4. > > > The first patch in this series update the generic tables which are > common for all platfoms. The subsequent patches in this series update > platform specific ACPI tables to v6.4 for the respective platform. > > This patch series also update the headers in the .aslc files to match > the coding style as per edk2 coding guidelines. > > Link to github branch with the patches in this series - > https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/acpi64_for_rd_platforms > > Reviewed-by: Pierre Gondois > Reviewed-by: Thomas Abraham > > Pranav Madhu (9): > Platform/Sgi: Update ACPI version to v6.4 > Platform/Sgi: Update ACPI version to v6.4 for SGI575 platform > Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge platform > Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge-X2 platform > Platform/Sgi: Update ACPI version to v6.4 for RD-E1-Edge platform > Platform/Sgi: Update ACPI version to v6.4 for RD-V1 platform > Platform/Sgi: Update ACPI version to v6.4 for RD-V1-MC platform > Platform/Sgi: Update ACPI version to v6.4 for RD-N2 platform > Platform/Sgi: Update ACPI version to v6.4 for RD-N2-Cfg1 platform > Merged as 433b5b1b0f7f..750f6807879b Thanks all, -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90805): https://edk2.groups.io/g/devel/message/90805 Mute This Topic: https://groups.io/mt/92015130/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 reference with py3.7
Could you please review and merge this change? This is a simple documentation fix only. Regards, JP -Original Message- From: Jayaprakash, N Sent: 17 June 2022 14:24 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: RE: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 reference with py3.7 This is a simple documentation fix. Could some one from the group review and merge these changes? Regards, JP -Original Message- From: Jayaprakash, N Sent: 10 June 2022 09:19 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Jayaprakash, N Subject: [edk2 Patch 1/1] Windows-systems.mediawiki: replaced p2.7 reference with py3.7 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3788 Removed an outdated reference to py2.7 in the Windows systems wiki page and replaced it with the py3.7 to align with the updated build instructions Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Jayaprakash N --- Windows-systems.mediawiki | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Windows-systems.mediawiki b/Windows-systems.mediawiki index 0b69b56..cca2b73 100644 --- a/Windows-systems.mediawiki +++ b/Windows-systems.mediawiki @@ -88,7 +88,7 @@ Example: Example: *Open Command prompt and CD C:\edk2: - C:\edk2> set PYTHON_HOME=C:\Python27 + C:\edk2> set PYTHON_HOME=C:\Python37 C:\edk2> edksetup.bat Rebuild -- 2.33.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90804): https://edk2.groups.io/g/devel/message/90804 Mute This Topic: https://groups.io/mt/91661795/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
