Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs
Sounds great! > -Original Message- > From: Kinney, Michael D > Sent: Monday, October 24, 2022 1:44 PM > To: Yao, Jiewen ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin ; > Zurcher, Christopher ; Rebecca Cran > ; Ard Biesheuvel ; Li, Yi1 > > Subject: RE: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and > merge perf opt OpensslLibs > > Hi Jiewen, > > I compared the builds of the CryptoPei, CryptoDxe, CryptoSmm using the > same OpensslLib instance with EC disabled. > > I used an IA32 build of the MIN_PEI profile and an X64 build of the > MIN_DXE_MIN_SMM profile for the comparison. > > Arch Profile DriverOldOld-LZMANewNew-LZMA > === = === === > > IA32 MIN_PEI CryptoPei 252,192 102,109 244,16098,571 > X64 MIN_DXE_MIN_SMM CryptoDxe 812,288 313,340 811,008 > 312,913 > X64 MIN_DXE_MIN_SMM CryptoSmm 549,088 205,613 548,096 > 205,079 > > > These results show that this patch series provide a very small reduction > in both the uncompressed and LZMA compressed sizes of these drivers. > This > is the expected result because no functional changes were introduced. > > The small decrease is likely due to the removal of the UnitTest overhead > that was included in all CryptoPkg.dsc build before this series. This > series only links in the UnitTest related libs and hook of the ASSERT() > macros when building unit tests. > > Best regards, > > Mike > > > -Original Message- > > From: Yao, Jiewen > > Sent: Sunday, October 23, 2022 8:54 PM > > To: devel@edk2.groups.io; Yao, Jiewen ; Kinney, > Michael D > > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin ; > Zurcher, > > Christopher ; Rebecca Cran > ; Ard Biesheuvel ; Li, > > Yi1 > > Subject: RE: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD > and merge perf opt OpensslLibs > > > > Sorry: I mean old configuration without ECC. > > > > > -Original Message- > > > From: devel@edk2.groups.io On Behalf Of Yao, > > > Jiewen > > > Sent: Monday, October 24, 2022 11:53 AM > > > To: Kinney, Michael D ; > > > devel@edk2.groups.io > > > Cc: Wang, Jian J ; Lu, Xiaoyu1 > > > ; Jiang, Guomin ; > > > Zurcher, Christopher ; Rebecca > Cran > > > ; Ard Biesheuvel ; Li, Yi1 > > > > > > Subject: Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD > and > > > merge perf opt OpensslLibs > > > > > > Thanks Mike > > > The update looks good to me. Reviewed-by: Jiewen Yao > > > > > > > > > Do you have any data of size difference before and after? Please share > with > > > us. > > > > > > I am more interested in the old configuration with ECC. > > > > > > Thank you > > > Yao, Jiewen > > > > > > > -Original Message- > > > > From: Kinney, Michael D > > > > Sent: Friday, October 21, 2022 2:35 AM > > > > To: devel@edk2.groups.io > > > > Cc: Yao, Jiewen ; Wang, Jian J > > > > ; Lu, Xiaoyu1 ; Jiang, > > > > Guomin ; Zurcher, Christopher > > > > ; Rebecca Cran > > > > ; Ard Biesheuvel ; Li, Yi1 > > > > > > > > Subject: [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf > opt > > > > OpensslLibs > > > > > > > > The recent addition of the Ecliptic Curve (EC) feature and the > performance > > > > optimization feature increased the complexity for platforms to > integrate > > > > and enable these features. This series simplifies the platform > > > configuration > > > > as much as possible and improves the ability to manage the the size > > > impact > > > > of cryptographic services in each FW phase. A Readme.md is also > added > > > > that > > > > provides an overview of the CryptoPkg design and features along with > > > > platform > > > > integration recommendations. > > > > > > > > This series also addresses private library class declarations missing > from > > > > CryptoPkg.dec and library instances not producing all the APIs defined > > > > by the library classes. A review of the CryptoPkg EDK II meta data files > > > > identified > > > > a number of additional cleanups. The CryptoPkg.dsc file was also > updated > > > to > > > > improve CI coverage for future CryptoPkg changes and identified some > > > > unit test bug fixes. > > > > > > > > Change Summary > > > > > > > > * Document disabled/deprecated cryptographic services > > > > * Add missing UNI files in BaseCryptLib > > > > * Update BaseCryptLib internal functions to be STATIC and remove > EFIAPI > > > > * Add GLOBAL_REMOVE_IF_UNREFERENCED to BaseCryptLib global > > > > variables > > > > * Fix BaseCryptLib unit tests > > > > * Cleanup BaseCryptLib and TlsLib INF files and > > > > * Move SysCall/inet_pton.c from BaseCryptLib to TlsLib that uses it. > > > > * Merge 4 performance optimized INFs into OpensslLib*Accel.inf > > > > * Remove use of PcdOpensslEcEnabled and use OpensslLibFull*.inf > > > instead > > > > * Add OpensslLib and IntrinsicLib to CryptoPkg.dec as private library > > > classes > > > >
[edk2-devel] [PATCH] BaseTools/Tests: Use quotes around PYTHON_COMMAND
Commit ("2355f0c09c52 BaseTools: Fix check for ${PYTHON_COMMAND} in
Tests/GNUmakefile") fixed a latent issue in the BaseTools/Tests
Makefile, but inadvertently broke the BaseTools build for cases where
PYTHON_COMMAND is not set. As it turns out, running 'command' without a
command argument makes the invocation succeed, causing the empty
variable to be evaluated and called later.
Let's put double quotes around PYTHON_COMMAND in the invocation of
'command' and force it to fail when PYTHON_COMMAND is not set.
Signed-off-by: Ard Biesheuvel
---
BaseTools/Tests/GNUmakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Tests/GNUmakefile b/BaseTools/Tests/GNUmakefile
index caa4d26c9ba6..20b387864f74 100644
--- a/BaseTools/Tests/GNUmakefile
+++ b/BaseTools/Tests/GNUmakefile
@@ -8,7 +8,7 @@
all: test
test:
- @if command -v ${PYTHON_COMMAND} >/dev/null 2>&1; then
${PYTHON_COMMAND} RunTests.py; else python RunTests.py; fi
+ @if command -v "${PYTHON_COMMAND}" >/dev/null 2>&1; then
${PYTHON_COMMAND} RunTests.py; else python RunTests.py; fi
clean:
find . -name '*.pyc' -exec rm '{}' ';'
--
2.35.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95492): https://edk2.groups.io/g/devel/message/95492
Mute This Topic: https://groups.io/mt/94528814/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs
Hi Jiewen, I compared the builds of the CryptoPei, CryptoDxe, CryptoSmm using the same OpensslLib instance with EC disabled. I used an IA32 build of the MIN_PEI profile and an X64 build of the MIN_DXE_MIN_SMM profile for the comparison. Arch Profile DriverOldOld-LZMANewNew-LZMA === = === === IA32 MIN_PEI CryptoPei 252,192 102,109 244,16098,571 X64 MIN_DXE_MIN_SMM CryptoDxe 812,288 313,340 811,008 312,913 X64 MIN_DXE_MIN_SMM CryptoSmm 549,088 205,613 548,096 205,079 These results show that this patch series provide a very small reduction in both the uncompressed and LZMA compressed sizes of these drivers. This is the expected result because no functional changes were introduced. The small decrease is likely due to the removal of the UnitTest overhead that was included in all CryptoPkg.dsc build before this series. This series only links in the UnitTest related libs and hook of the ASSERT() macros when building unit tests. Best regards, Mike > -Original Message- > From: Yao, Jiewen > Sent: Sunday, October 23, 2022 8:54 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Kinney, Michael > D > Cc: Wang, Jian J ; Lu, Xiaoyu1 ; > Jiang, Guomin ; Zurcher, > Christopher ; Rebecca Cran > ; Ard Biesheuvel ; Li, > Yi1 > Subject: RE: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge > perf opt OpensslLibs > > Sorry: I mean old configuration without ECC. > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Yao, > > Jiewen > > Sent: Monday, October 24, 2022 11:53 AM > > To: Kinney, Michael D ; > > devel@edk2.groups.io > > Cc: Wang, Jian J ; Lu, Xiaoyu1 > > ; Jiang, Guomin ; > > Zurcher, Christopher ; Rebecca Cran > > ; Ard Biesheuvel ; Li, Yi1 > > > > Subject: Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and > > merge perf opt OpensslLibs > > > > Thanks Mike > > The update looks good to me. Reviewed-by: Jiewen Yao > > > > > > Do you have any data of size difference before and after? Please share with > > us. > > > > I am more interested in the old configuration with ECC. > > > > Thank you > > Yao, Jiewen > > > > > -Original Message- > > > From: Kinney, Michael D > > > Sent: Friday, October 21, 2022 2:35 AM > > > To: devel@edk2.groups.io > > > Cc: Yao, Jiewen ; Wang, Jian J > > > ; Lu, Xiaoyu1 ; Jiang, > > > Guomin ; Zurcher, Christopher > > > ; Rebecca Cran > > > ; Ard Biesheuvel ; Li, Yi1 > > > > > > Subject: [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt > > > OpensslLibs > > > > > > The recent addition of the Ecliptic Curve (EC) feature and the performance > > > optimization feature increased the complexity for platforms to integrate > > > and enable these features. This series simplifies the platform > > configuration > > > as much as possible and improves the ability to manage the the size > > impact > > > of cryptographic services in each FW phase. A Readme.md is also added > > > that > > > provides an overview of the CryptoPkg design and features along with > > > platform > > > integration recommendations. > > > > > > This series also addresses private library class declarations missing from > > > CryptoPkg.dec and library instances not producing all the APIs defined > > > by the library classes. A review of the CryptoPkg EDK II meta data files > > > identified > > > a number of additional cleanups. The CryptoPkg.dsc file was also updated > > to > > > improve CI coverage for future CryptoPkg changes and identified some > > > unit test bug fixes. > > > > > > Change Summary > > > > > > * Document disabled/deprecated cryptographic services > > > * Add missing UNI files in BaseCryptLib > > > * Update BaseCryptLib internal functions to be STATIC and remove EFIAPI > > > * Add GLOBAL_REMOVE_IF_UNREFERENCED to BaseCryptLib global > > > variables > > > * Fix BaseCryptLib unit tests > > > * Cleanup BaseCryptLib and TlsLib INF files and > > > * Move SysCall/inet_pton.c from BaseCryptLib to TlsLib that uses it. > > > * Merge 4 performance optimized INFs into OpensslLib*Accel.inf > > > * Remove use of PcdOpensslEcEnabled and use OpensslLibFull*.inf > > instead > > > * Add OpensslLib and IntrinsicLib to CryptoPkg.dec as private library > > classes > > > * Update all OpensslLib instances to always produce all APIs in OpensslLib > > > class > > > * Move PrintLib dependency from OpensslLib INF files to BaseCryptLib INF > > > files > > > * Update CryptoPkg.dsc files to provide full CI test coverage across all > > > the > > >supported combinations of OpensslLib, BaseCryptLib, and TlsLib > > instances. > > > * Remove PACKAGE profile from CryptoPkg.dsc and add > > > TARGET_UNIT_TESTS > > > profile. Adding TARGET_UNIT_TESTS profile is required to prevent a few > > > unit > > > test artifacts being included in non unit test builds of components. > > > * Add CryptoPkg Readme.md with overview
Re: [edk2-devel] [PATCH v3] remove GCC build warning
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Wu, JessyX
Sent: Tuesday, October 4, 2022 10:04 AM
To: devel@edk2.groups.io
Cc: Wu, JessyX ; Feng, Bob C ; Gao,
Liming ; Chen, Christine
Subject: [PATCH v3] remove GCC build warning
Fix gcc: warning:
-x c after last input file has no effect
These kind of flag can only affect the source code after them.
For the build command in build_rule.template, we have no other source code or
object after these two flag.
It seems we don't need them here.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: JessyX Wu
---
BaseTools/Conf/build_rule.template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Conf/build_rule.template
b/BaseTools/Conf/build_rule.template
index 5895b48fd8..af4819de92 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -463,7 +463,7 @@
"$(ASLCC)" $(DEPS_FLAGS) -c -o
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS) $(ASLCC_FLAGS)
$(DEPS_FLAGS) $(INC) ${src}
-"$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll
$(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj $(CC_FLAGS)
$(ASLCC_FLAGS)
+"$(ASLDLINK)" -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll
$(ASLDLINK_FLAGS) $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.obj
"$(GENFW)" -o ${dst} -c $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.dll
$(GENFW_FLAGS)
--
2.37.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95490): https://edk2.groups.io/g/devel/message/95490
Mute This Topic: https://groups.io/mt/94106021/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] IntelFsp2Pkg: FSP should support input UPD as NULL.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4114
FSP specification supports input UPD as NULL cases which FSP will
use built-in UPD region instead.
FSP should not return INVALID_PARAMETER in such cases.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/SecFspApiChk.c | 11 +--
IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm | 8
IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm | 7 ---
3 files changed, 9 insertions(+), 17 deletions(-)
diff --git a/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
b/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
index a44fbf2a50..bfbdf70083 100644
--- a/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
+++ b/IntelFsp2Pkg/FspSecCore/SecFspApiChk.c
@@ -44,6 +44,8 @@ FspApiCallingCheck (
//
if (((UINTN)FspData != MAX_ADDRESS) && ((UINTN)FspData != MAX_UINT32)) {
Status = EFI_UNSUPPORTED;
+} else if (ApiParam == NULL) {
+ Status = EFI_SUCCESS;
} else if (EFI_ERROR (FspUpdSignatureCheck (ApiIdx, ApiParam))) {
Status = EFI_INVALID_PARAMETER;
}
@@ -67,9 +69,12 @@ FspApiCallingCheck (
} else {
if (FspData->Signature != FSP_GLOBAL_DATA_SIGNATURE) {
Status = EFI_UNSUPPORTED;
- } else if (EFI_ERROR (FspUpdSignatureCheck (FspSiliconInitApiIndex,
ApiParam))) {
-Status = EFI_INVALID_PARAMETER;
} else if (ApiIdx == FspSiliconInitApiIndex) {
+if (ApiParam == NULL) {
+ Status = EFI_SUCCESS;
+} else if (EFI_ERROR (FspUpdSignatureCheck (FspSiliconInitApiIndex,
ApiParam))) {
+ Status = EFI_INVALID_PARAMETER;
+}
//
// Reset MultiPhase NumberOfPhases to zero
//
@@ -89,6 +94,8 @@ FspApiCallingCheck (
} else {
if (FspData->Signature != FSP_GLOBAL_DATA_SIGNATURE) {
Status = EFI_UNSUPPORTED;
+ } else if (ApiParam == NULL) {
+Status = EFI_SUCCESS;
} else if (EFI_ERROR (FspUpdSignatureCheck (FspSmmInitApiIndex,
ApiParam))) {
Status = EFI_INVALID_PARAMETER;
}
diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
index 61030a843b..52e1ff6f1f 100644
--- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
+++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm
@@ -555,14 +555,6 @@ ASM_PFX(TempRamInitApi):
SAVE_EAX
SAVE_EDX
- ;
- ; Check Parameter
- ;
- mov eax, dword [esp + 4]
- cmp eax, 0
- mov eax, 8002h
- jzTempRamInitExit
-
;
; Sec Platform Init
;
diff --git a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm
b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm
index 7dd89c531a..23bb2b0481 100644
--- a/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm
+++ b/IntelFsp2Pkg/FspSecCore/X64/FspApiEntryT.nasm
@@ -441,13 +441,6 @@ ASM_PFX(TempRamInitApi):
orrax, rdx
SAVE_TS rax
- ;
- ; Check Parameter
- ;
- cmp rcx, 0
- mov rcx, 08002h
- jzTempRamInitExit
-
;
; Sec Platform Init
;
--
2.35.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95489): https://edk2.groups.io/g/devel/message/95489
Mute This Topic: https://groups.io/mt/94527493/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs
Sorry: I mean old configuration without ECC. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, > Jiewen > Sent: Monday, October 24, 2022 11:53 AM > To: Kinney, Michael D ; > devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin ; > Zurcher, Christopher ; Rebecca Cran > ; Ard Biesheuvel ; Li, Yi1 > > Subject: Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and > merge perf opt OpensslLibs > > Thanks Mike > The update looks good to me. Reviewed-by: Jiewen Yao > > > Do you have any data of size difference before and after? Please share with > us. > > I am more interested in the old configuration with ECC. > > Thank you > Yao, Jiewen > > > -Original Message- > > From: Kinney, Michael D > > Sent: Friday, October 21, 2022 2:35 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Wang, Jian J > > ; Lu, Xiaoyu1 ; Jiang, > > Guomin ; Zurcher, Christopher > > ; Rebecca Cran > > ; Ard Biesheuvel ; Li, Yi1 > > > > Subject: [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt > > OpensslLibs > > > > The recent addition of the Ecliptic Curve (EC) feature and the performance > > optimization feature increased the complexity for platforms to integrate > > and enable these features. This series simplifies the platform > configuration > > as much as possible and improves the ability to manage the the size > impact > > of cryptographic services in each FW phase. A Readme.md is also added > > that > > provides an overview of the CryptoPkg design and features along with > > platform > > integration recommendations. > > > > This series also addresses private library class declarations missing from > > CryptoPkg.dec and library instances not producing all the APIs defined > > by the library classes. A review of the CryptoPkg EDK II meta data files > > identified > > a number of additional cleanups. The CryptoPkg.dsc file was also updated > to > > improve CI coverage for future CryptoPkg changes and identified some > > unit test bug fixes. > > > > Change Summary > > > > * Document disabled/deprecated cryptographic services > > * Add missing UNI files in BaseCryptLib > > * Update BaseCryptLib internal functions to be STATIC and remove EFIAPI > > * Add GLOBAL_REMOVE_IF_UNREFERENCED to BaseCryptLib global > > variables > > * Fix BaseCryptLib unit tests > > * Cleanup BaseCryptLib and TlsLib INF files and > > * Move SysCall/inet_pton.c from BaseCryptLib to TlsLib that uses it. > > * Merge 4 performance optimized INFs into OpensslLib*Accel.inf > > * Remove use of PcdOpensslEcEnabled and use OpensslLibFull*.inf > instead > > * Add OpensslLib and IntrinsicLib to CryptoPkg.dec as private library > classes > > * Update all OpensslLib instances to always produce all APIs in OpensslLib > > class > > * Move PrintLib dependency from OpensslLib INF files to BaseCryptLib INF > > files > > * Update CryptoPkg.dsc files to provide full CI test coverage across all the > >supported combinations of OpensslLib, BaseCryptLib, and TlsLib > instances. > > * Remove PACKAGE profile from CryptoPkg.dsc and add > > TARGET_UNIT_TESTS > > profile. Adding TARGET_UNIT_TESTS profile is required to prevent a few > > unit > > test artifacts being included in non unit test builds of components. > > * Add CryptoPkg Readme.md with overview and platform integration > > details. > > * Update host-based unit tests to always use OpensslLibFull.inf and add > > unit > > test coverage for OpensslLibFullAccel.inf. > > * Add Readme.md with CryptoPkg overview and platform integration > > documentation > > > > New in V2 > > = > > * Fix service table in Readme.md > > * Fix VS2015x86 RELEASE builds by disabling warning 4718 > > * Rebase to latest and add missing EC functions in EcSm2Null.c > > * Update perl scripts to auto-generate all OpensslLib INF files > > * Update OpensslLib INF files to match auto-generated format > > > > Cc: Jiewen Yao > > Cc: Jian J Wang > > Cc: Xiaoyu Lu > > Cc: Guomin Jiang > > Cc: Christopher Zurcher > > Cc: Rebecca Cran > > Cc: Ard Biesheuvel > > Cc: Yi Li > > Signed-off-by: Michael D Kinney > > > > Michael D Kinney (12): > > CryptoPkg: Document and disable deprecated crypto services > > CryptoPkg/Library/BaseCryptLib: Add missing UNI file and fix format > > CryptoPkg/Library/BaseCryptLib: Update internal functions/variables > > CryptoPkg/Test/UnitTest/Library/BaseCryptLib: Unit test fixes > > CryptoPkg/Library: Cleanup BaseCryptLib and TlsLib > > CryptoPkg/Library/OpensslLib: Combine all performance optimized INFs > > CryptoPkg/Library/OpensslLib: Produce consistent set of APIs > > CryptoPkg/Library/OpensslLib: Remove PrintLib from INF files > > CryptoPkg: Remove PcdOpensslEcEnabled from CryptoPkg.dec > > CryptoPkg: Update DSC to improve CI test coverage > > CryptoPkg: Fixed host-based unit tests > > CryptoPkg: Add Readme.md > > > > Yi Li (4): > > Revert "CryptoPkg: Update process_files.pl to auto add
Re: [edk2-devel] [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt OpensslLibs
Thanks Mike The update looks good to me. Reviewed-by: Jiewen Yao Do you have any data of size difference before and after? Please share with us. I am more interested in the old configuration with ECC. Thank you Yao, Jiewen > -Original Message- > From: Kinney, Michael D > Sent: Friday, October 21, 2022 2:35 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Lu, Xiaoyu1 ; Jiang, > Guomin ; Zurcher, Christopher > ; Rebecca Cran > ; Ard Biesheuvel ; Li, Yi1 > > Subject: [Patch v2 00/16] CryptoPkg: Remove EC PCD and merge perf opt > OpensslLibs > > The recent addition of the Ecliptic Curve (EC) feature and the performance > optimization feature increased the complexity for platforms to integrate > and enable these features. This series simplifies the platform configuration > as much as possible and improves the ability to manage the the size impact > of cryptographic services in each FW phase. A Readme.md is also added > that > provides an overview of the CryptoPkg design and features along with > platform > integration recommendations. > > This series also addresses private library class declarations missing from > CryptoPkg.dec and library instances not producing all the APIs defined > by the library classes. A review of the CryptoPkg EDK II meta data files > identified > a number of additional cleanups. The CryptoPkg.dsc file was also updated to > improve CI coverage for future CryptoPkg changes and identified some > unit test bug fixes. > > Change Summary > > * Document disabled/deprecated cryptographic services > * Add missing UNI files in BaseCryptLib > * Update BaseCryptLib internal functions to be STATIC and remove EFIAPI > * Add GLOBAL_REMOVE_IF_UNREFERENCED to BaseCryptLib global > variables > * Fix BaseCryptLib unit tests > * Cleanup BaseCryptLib and TlsLib INF files and > * Move SysCall/inet_pton.c from BaseCryptLib to TlsLib that uses it. > * Merge 4 performance optimized INFs into OpensslLib*Accel.inf > * Remove use of PcdOpensslEcEnabled and use OpensslLibFull*.inf instead > * Add OpensslLib and IntrinsicLib to CryptoPkg.dec as private library classes > * Update all OpensslLib instances to always produce all APIs in OpensslLib > class > * Move PrintLib dependency from OpensslLib INF files to BaseCryptLib INF > files > * Update CryptoPkg.dsc files to provide full CI test coverage across all the >supported combinations of OpensslLib, BaseCryptLib, and TlsLib instances. > * Remove PACKAGE profile from CryptoPkg.dsc and add > TARGET_UNIT_TESTS > profile. Adding TARGET_UNIT_TESTS profile is required to prevent a few > unit > test artifacts being included in non unit test builds of components. > * Add CryptoPkg Readme.md with overview and platform integration > details. > * Update host-based unit tests to always use OpensslLibFull.inf and add > unit > test coverage for OpensslLibFullAccel.inf. > * Add Readme.md with CryptoPkg overview and platform integration > documentation > > New in V2 > = > * Fix service table in Readme.md > * Fix VS2015x86 RELEASE builds by disabling warning 4718 > * Rebase to latest and add missing EC functions in EcSm2Null.c > * Update perl scripts to auto-generate all OpensslLib INF files > * Update OpensslLib INF files to match auto-generated format > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Christopher Zurcher > Cc: Rebecca Cran > Cc: Ard Biesheuvel > Cc: Yi Li > Signed-off-by: Michael D Kinney > > Michael D Kinney (12): > CryptoPkg: Document and disable deprecated crypto services > CryptoPkg/Library/BaseCryptLib: Add missing UNI file and fix format > CryptoPkg/Library/BaseCryptLib: Update internal functions/variables > CryptoPkg/Test/UnitTest/Library/BaseCryptLib: Unit test fixes > CryptoPkg/Library: Cleanup BaseCryptLib and TlsLib > CryptoPkg/Library/OpensslLib: Combine all performance optimized INFs > CryptoPkg/Library/OpensslLib: Produce consistent set of APIs > CryptoPkg/Library/OpensslLib: Remove PrintLib from INF files > CryptoPkg: Remove PcdOpensslEcEnabled from CryptoPkg.dec > CryptoPkg: Update DSC to improve CI test coverage > CryptoPkg: Fixed host-based unit tests > CryptoPkg: Add Readme.md > > Yi Li (4): > Revert "CryptoPkg: Update process_files.pl to auto add PCD config > option" > CryptoPkg/Library/OpensslLib: Update process_files.pl INF generation > CryptoPkg/Library/OpensslLib: Add generated flag to Accel INF > CryptoPkg/Library/OpensslLib: update auto-generated files > > CryptoPkg/CryptoPkg.ci.yaml | 11 +- > CryptoPkg/CryptoPkg.dec | 42 +- > CryptoPkg/CryptoPkg.dsc | 438 --- > .../Pcd/PcdCryptoServiceFamilyEnable.h| 122 +-- > .../Library/BaseCryptLib/BaseCryptLib.inf | 10 +- > .../Library/BaseCryptLib/BaseCryptLib.uni | 2 - > .../Library/BaseCryptLib/Hmac/CryptHmac.c | 7 + > .../Library/BaseCryptLib/Kdf/
[edk2-devel] Event: Tools, CI, Code base construction meeting series - 10/24/2022 #cal-reminder
*Reminder: Tools, CI, Code base construction meeting series* *When:* 10/24/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610036 ) *Description:* TianoCore community, Microsoft and Intel will be hosting a series of open meetings to discuss build, CI, tools, and other related topics. If you are interested, have ideas/opinions please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft Teams. MS Teams Link in following discussion: * https://github.com/tianocore/edk2/discussions/2614 Anyone is welcome to join. * tianocore/edk2: EDK II (github.com) * tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module (github.com) https://github.com/tianocore/edk2-basetools * tianocore/edk2-pytool-extensions: Extensions to the edk2 build system allowing for a more robust and plugin based build system and tool execution environment (github.com) https://github.com/tianocore/edk2-pytool-extensions * tianocore/edk2-pytool-library: Python library package that supports UEFI development (github.com) https://github.com/tianocore/edk2-pytool-library MS Teams Browser Clients * https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95486): https://edk2.groups.io/g/devel/message/95486 Mute This Topic: https://groups.io/mt/94523843/21656 Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
