Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Add maintainers for Sophgo platform
On Thu, Oct 19, 2023 at 04:11:46PM +0200, Laszlo Ersek wrote: > On 10/19/23 15:48, caiyuqing...@163.com wrote: > > From: caiyuqing379 > > > > This "Platform/Sophgo/Maintainers.md" file format is useless with > > edk2's "BaseTools/Scripts/GetMaintainer.py" utility, so delete this > > file. Add add the maintainers to the "Maintainers.txt" file. > > > > Cc: dahogn > > Cc: meng-cz > > Cc: USER0FISH > > Cc: Sunil V L > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Laszlo Ersek > > Signed-off-by: caiyuqing379 > > --- > > Maintainers.txt| 9 ++ > > Platform/Sophgo/Maintainers.md | 105 > > 2 files changed, 9 insertions(+), 105 deletions(-) > > Acked-by: Laszlo Ersek > Merged as PR #105. Thanks! Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109888): https://edk2.groups.io/g/devel/message/109888 Mute This Topic: https://groups.io/mt/102060744/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM
Hi Abner,
Thanks for your feedback.
Since the IPMI implementation in these two packages are diverging now, and my
patch has some dependency with common code in IpmiFeaturePkg , it will be
better to resend this patch after the diverging is done.
Our target schedule is '23 WW51', could you let me know what's the schedule
for these two packages'(IpmiFeaturePkg and ManageabilityPkg) diverging? Thanks.
Regards,
Lisa
-Original Message-
From: Chang, Abner
Sent: Saturday, October 21, 2023 10:15 PM
To: devel@edk2.groups.io; Huang, Li-Xia
Cc: Isaac Oram ; Desimone, Nathaniel L
Subject: RE: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support
Standalone MM
[AMD Official Use Only - General]
Hi Lisa,
Issac was no longer the maintainer of IpmiFeaturePkg as he was retired. Nate
had sent the maintainers update for review.
As the conversation I had with Issac, we all agreed IpmiFeaturePkg should be
deprecated as the IPMI related drivers are now located under ManageabilityPkg
in edk2-platforms. The IPMI implementation in these two packages are diverging
now, which is not good.
Could you please send this patch against ManageabilityPkg? I can help to review
it, so does Nate as he also proposed himself as the maintainers of
ManageabilityPkg.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Huang,
> Li-Xia via groups.io
> Sent: Friday, October 20, 2023 2:46 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram ; Nate DeSimone
>
> Subject: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi:
> Support Standalone MM
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild'
> for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver
>
> Cc: Isaac Oram
> Cc: Nate DeSimone
> Signed-off-by: Lixia Huang
> ---
>
> Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa
> loneMm/StandaloneMmGenericIpmi.c | 148
>
> Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa
> loneMm/StandaloneMmGenericIpmi.inf | 52 +++
>
> Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
> | 2 +
> 3 files changed, 202 insertions(+)
>
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan
> daloneMm/StandaloneMmGenericIpmi.c
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan
> daloneMm/StandaloneMmGenericIpmi.c
> new file mode 100644
> index ..52d8d2abdd0d
> --- /dev/null
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan
> daloneMm/StandaloneMmGenericIpmi.c
> @@ -0,0 +1,148 @@
> +/** @file
>
> + Generic StandaloneMm IPMI stack driver
>
> +
>
> + @copyright
>
> + Copyright 2023 Intel Corporation.
>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
>
> +**/
>
> +
>
> +//
>
> +// Statements that include other files
>
> +//
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include
>
> +#include "IpmiHooks.h"
>
> +#include "IpmiBmcCommon.h"
>
> +#include "IpmiBmc.h"
>
> +#include
>
> +
>
> +IPMI_BMC_INSTANCE_DATA *mIpmiInstance;
>
> +EFI_HANDLE mHandle;
>
> +
>
> +EFI_STATUS
>
> +SmmInitializeIpmiKcsPhysicalLayer (
>
> + VOID
>
> + )
>
> +/*++
>
> +
>
> +Routine Description:
>
> + Setup and initialize the BMC for the SMM phase. In order to verify
> + the BMC
> is functioning
>
> + as expected, the BMC Selftest is performed. The results are then
> + checked
> and any errors are
>
> + reported to the error manager. Errors are collected throughout
> + this routine
> and reported
>
> + just prior to installing the driver. If there are more errors than
> MAX_SOFT_COUNT, then they
>
> + will be ignored.
>
> +
>
> +Arguments:
>
> + ImageHandle - Handle of this driver image
>
> + SystemTable - Table containing standard EFI services
>
> +
>
> +Returns:
>
> + EFI_SUCCESS - Successful driver initialization
>
> +
>
> +--*/
>
> +{
>
> + EFI_STATUS Status;
>
> +
>
> + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n"));
>
> +
>
> + Status = gMmst->MmAllocatePool (
>
> +EfiRuntimeServicesData,
>
> +sizeof (IPMI_BMC_INSTANCE_DATA),
>
> +(VOID **));
>
> +
>
> + if (EFI_ERROR (Status)) {
>
> +DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n",
> Status));
>
> +return Status;
>
> + } else {
>
> +
>
> +//
>
> +// Initialize the KCS transaction timeout. Assume delay unit is 1000 us.
>
> +//
>
> +mIpmiInstance->KcsTimeoutPeriod = (BMC_KCS_TIMEOUT * 1000*1000) /
> KCS_DELAY_UNIT;
>
> +
>
> +//
>
> +// Initialize IPMI IO Base, we still use SMS IO base to get
> + device ID and
>
Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error
This looks good to me. I also build-tested this patch. Reviewed-by: Nhi Pham Tested-by: Nhi Pham On 10/3/2023 10:04 PM, Jake Garver via groups.io wrote: Ignore old style declaration warnings in oniguruma/src/st.c. This was already ignored for MSFT, but newer versions of clang complain as well. Signed-off-by: Jake Garver --- .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf index 84489c2942..0092531a67 100644 --- a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf +++ b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf @@ -102,6 +102,7 @@ # Oniguruma: old style declaration in st.c MSFT:*_*_*_CC_FLAGS = /wd4131 + GCC:*_*_*_CC_FLAGS = -Wno-deprecated-non-prototype # Oniguruma: 'type cast' : truncation from 'OnigUChar *' to 'unsigned int' MSFT:*_*_*_CC_FLAGS = /wd4305 /wd4306 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109886): https://edk2.groups.io/g/devel/message/109886 Mute This Topic: https://groups.io/mt/101735690/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list
Thanks for the effort, everyone!! =D -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109885): https://edk2.groups.io/g/devel/message/109885 Mute This Topic: https://groups.io/mt/101660590/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, October 23, 2023 #cal-reminder
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, October 23, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-41af-91ab-2d7cd011db47%22%2c%22Oid%22%3a%2223af6561-6e1c-450d-b917-d9d674eb3cb6%22%7d View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=2068434 ) *Description:* TianoCore community, Microsoft and Intel will be hosting a series of open meetings to discuss build, CI, tools, and other related topics. If you are interested, have ideas/opinions please join us. These meetings will be Monday 4:30pm Pacific Time on Microsoft Teams. MS Teams Link in following discussion: * https://github.com/tianocore/edk2/discussions/2614 Anyone is welcome to join. * tianocore/edk2: EDK II (github.com) * tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module (github.com) https://github.com/tianocore/edk2-basetools * tianocore/edk2-pytool-extensions: Extensions to the edk2 build system allowing for a more robust and plugin based build system and tool execution environment (github.com) https://github.com/tianocore/edk2-pytool-extensions * tianocore/edk2-pytool-library: Python library package that supports UEFI development (github.com) https://github.com/tianocore/edk2-pytool-library MS Teams Browser Clients * https://docs.microsoft.com/en-us/microsoftteams/get-clients?tabs=Windows#browser-client -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109884): https://edk2.groups.io/g/devel/message/109884 Mute This Topic: https://groups.io/mt/102126105/21656 Mute #cal-reminder:https://edk2.groups.io/g/devel/mutehashtag/cal-reminder Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] edk2-libc Python Build issue
You can build edk2-libc Python 3.6.8 using GCC tool chain by following the BKMs documented in this file https://github.com/tianocore/edk2-libc/blob/master/AppPkg/Applications/Python/Python-3.6.8/GCCCompilationBKMs.rst -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109883): https://edk2.groups.io/g/devel/message/109883 Mute This Topic: https://groups.io/mt/90297607/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Enhance StdLib for supporting Aarch64 and ARM
Thanks Pedro. These are pretty old PRs and some of them have valuable contributions to edk2-libc. Not every PR owner is interested in submitting the email patch for the PRs. Mike and Rebecca are aware of this. We had a discussion couple of Months ago on processing these PRs. I have volunteered to send email patches on behalf of these old PRs raised on edk2-libc over last few years. Regarding the patch currently under review, I have extracted the patch from PR https://github.com/tianocore/edk2-libc/pull/3) and submitted it for review without any changes of mine added to it to retain the sanctity of the original changes. All the changes are owned by Tyler Erickson and he has added his consent in the PR https://github.com/tianocore/edk2-libc/pull/3 I agree this could have been submitted as multiple patches but since I am not the original author I don't wanted to make changes to this patch. Since the original author of the changes has already given consent through Signed-off-by clause in the PR, It doesn't require my signature. Also while merging the change the commit log message would be edited to reflect the author correctly. Adding Tyler Erickson to this review discussions so that he can take appropriate action on the comments. @Tyler Erickson Would you want to take a look at these comments and make changes accordingly. Regards, JP -Original Message- From: Pedro Falcato Sent: Saturday, October 21, 2023 1:57 AM To: devel@edk2.groups.io; Jayaprakash, N Cc: Rebecca Cran ; Kinney, Michael D ; Tyler Erickson ; Ard Biesheuvel ; Leif Lindholm Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: Enhance StdLib for supporting Aarch64 and ARM On Fri, Oct 20, 2023 at 3:04 PM Jayaprakash, N wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4570 > > This commit is for processing the below PR on edk2-libc repo > https://github.com/tianocore/edk2-libc/pull/3 > These are the changes introduced to StdLib to build an application for > the UEFI shell. > Added format macros for int types to Aarch64, ARM, and Ia32. > Also modified the X64 macros so that everything would build when they > are used. > Added some macros that can be used for compatibility that define when > socklen_t has been defined. > Added getopt_long parser from OpenBSD to provide long and short option > parsing capability with getopt. This patch is unreviewable. You'd think (from the subject) that it's an ARM centric change, but it ends up being a whole squashed up sequence of unrelated changes. Please separate this into one commit per change. > > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Tyler Erickson AIUI, if this is Tyler's commit, you need a From: Tyler Erickson (since this is his commit?). Also probably your own Signed-off-by, I'm not sure. Lastly, you can't just take NetBSD's headers like this for one simple reason: UNIX systems have used LP64 for ages, Windows systems use LLP64. What does this mean? UNIX (and thus, code compiled using gcc or clang linux/netbsd/whatever) has sizeof(long) = 8 for 64-bit systems, whereas in MSVC sizeof(long) = 4. So macros like: > #define PRIdPTR "ld"/* intptr_t */ > #define PRIuPTR "lu"/* uintptr_t */ etc, are not correct on MSVC. Tip: since it's pretty safe, you can probably have two headers: 32-bit architectures (ILP32, should not change between MSVC and GCC/clang) and 64-bit architectures (LP64 on GCC/clang, LLP64 on MSVC). The same goes for the other type-related headers (I have *no* idea if those are correct). -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109882): https://edk2.groups.io/g/devel/message/109882 Mute This Topic: https://groups.io/mt/102081650/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
