Re: [edk2-devel] Error during build the Add_Shell_String

2024-07-19 Thread Adam Liu
Looks like nmake.exe not found. Try to fix this problem first.

I recommend to use "Developer Command Prompt for VS 2019" to build when 
Toolchain is set to VS2019.

You could type below command to check if your command prompt could run it 
without errors.

> 
> nmake.exe /?
> 

Regards,
Adam


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119981): https://edk2.groups.io/g/devel/message/119981
Mute This Topic: https://groups.io/mt/107157383/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-28 Thread Adam Liu
Hello all,

The patch was reviewed and I submitted a pull request 
https://github.com/tianocore/edk2/pull/5482 for this patch. Is there any other 
requirement to let this patch merge into master?

Regards,
Adam


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117229): https://edk2.groups.io/g/devel/message/117229
Mute This Topic: https://groups.io/mt/105038588/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] Attempting to update to latest Repository Won't Build.

2024-03-28 Thread Adam Liu
In Acme\Acme.dsc, find [LibraryClasses] and add below line should fix the 
problem.

RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterLibNull.inf

Regards,
Adam


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117225): https://edk2.groups.io/g/devel/message/117225
Mute This Topic: https://groups.io/mt/105203223/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




Re: [edk2-devel] VS2019 and AARCH64 with current EDKII mainline code.

2024-03-19 Thread Adam Liu
I got the same issue and already submit a patch.
https://edk2.groups.io/g/devel/topic/patch_v2_1_1/105038588?p=,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,105038588,previd%3D1710905523338626613,nextid%3D1710847665703537227&previd=1710905523338626613&nextid=1710847665703537227
Hope it got accepted and push to master soon.

Regards,
Adam


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116913): https://edk2.groups.io/g/devel/message/116913
Mute This Topic: https://groups.io/mt/105033123/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-19 Thread Adam Liu
Declare InternalAssertJumpBuffer as EXTERN

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Cc: Sami Mujawar 
Cc: Michael D Kinney 
Cc: Liming Gao 
Cc: Zhiguang Liu 
Signed-off-by: Shun Cheng Liu 
Reviewed-by: levi.yun 
---
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S   | 1 +
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 2 files changed, 2 insertions(+)

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S 
b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
index 3e58119b25d2..505d3765c522 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
@@ -9,6 +9,7 @@
 
 GCC_ASM_EXPORT(SetJump)
 GCC_ASM_EXPORT(InternalLongJump)
+GCC_ASM_IMPORT(InternalAssertJumpBuffer)
 
 #define GPR_LAYOUT \
 REG_PAIR (x19, x20,  0);   \
diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm 
b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
index 6ec8f35f2c9f..fa161e25f517 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
@@ -7,6 +7,7 @@
 
   EXPORT SetJump
   EXPORT InternalLongJump
+  EXTERN InternalAssertJumpBuffer
   AREA BaseLib_LowLevel, CODE, READONLY
 
 #define GPR_LAYOUT  \
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116911): https://edk2.groups.io/g/devel/message/116911
Mute This Topic: https://groups.io/mt/105038588/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH v2 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-19 Thread Adam Liu
Declare InternalAssertJumpBuffer to fix build error. 

Shun Cheng Liu (1):
  MdePkg/BaseLib: Fix AARCH64 compilation error

 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S   | 1 +
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 2 files changed, 2 insertions(+)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116910): https://edk2.groups.io/g/devel/message/116910
Mute This Topic: https://groups.io/mt/105038587/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH v1 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-17 Thread Adam Liu
MdePkg/BaseLib complains missing InternalAsserJumpBuffer error when built with 
-a AARCH64 option. Declare InternalAssertJumpBuffer to fix this issue. 

Command:
build -a AARCH64 -p MdePkg\MdePkg.dsc -m MdePkg\Library\BaseLib\BaseLib.inf

Output:
c:\projects\github\edk2\Build\Mde\DEBUG_VS2019\AARCH64\MdePkg\Library\BaseLib\BaseLib\OUTPUT\AArch64\SetJumpLongJump.(51)
 : error A2023: undefined symbol: InternalAssertJumpBuffer
bl  InternalAssertJumpBuffer
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual 
Studio\2019\Professional\VC\Tools\MSVC\14.29.30133\bin\Hostx86\arm64\armasm64.exe"'
 : return code '0x1'
Stop.

Shun Cheng Liu (1):
  MdePkg/BaseLib: Fix AARCH64 compilation error

 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 1 file changed, 1 insertion(+)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116833): https://edk2.groups.io/g/devel/message/116833
Mute This Topic: https://groups.io/mt/104997021/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-




[edk2-devel] [PATCH v1 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error

2024-03-17 Thread Adam Liu
Declare InternalAssertJumpBuffer as EXTERN

Cc: Leif Lindholm 
Cc: Ard Biesheuvel 
Cc: Sami Mujawar 
Cc: Michael D Kinney 
Cc: Liming Gao 
Cc: Zhiguang Liu 
Signed-off-by: Shun Cheng Liu 
---
 MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm 
b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
index 6ec8f35f2c9f..fa161e25f517 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
@@ -7,6 +7,7 @@
 
   EXPORT SetJump
   EXPORT InternalLongJump
+  EXTERN InternalAssertJumpBuffer
   AREA BaseLib_LowLevel, CODE, READONLY
 
 #define GPR_LAYOUT  \
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116834): https://edk2.groups.io/g/devel/message/116834
Mute This Topic: https://groups.io/mt/104997022/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-