Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmInfo: Drop -r parameter
Reviewed-by: Ankit Sinha > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, January 10, 2024 5:20 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Sinha, Ankit > > Subject: [PATCH v1 1/1] PrmPkg/PrmInfo: Drop -r parameter > > From: Michael Kubacki > > The "-r" parameter was not added to the application so remove it from the > help string. > > The standards section is also updated to point to the current specification > location on uefi.org. > > Cc: Nate DeSimone > Cc: Ankit Sinha > Signed-off-by: Michael Kubacki > --- > PrmPkg/Application/PrmInfo/PrmInfoStrings.uni | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/PrmPkg/Application/PrmInfo/PrmInfoStrings.uni > b/PrmPkg/Application/PrmInfo/PrmInfoStrings.uni > index 9385fd848344..756cf97c7c37 100644 > --- a/PrmPkg/Application/PrmInfo/PrmInfoStrings.uni > +++ b/PrmPkg/Application/PrmInfo/PrmInfoStrings.uni > @@ -61,7 +61,7 @@ > "Display and test Platform Runtime Mechanism (PRM) modules.\r\n" > ".SH SYNOPSIS\r\n" > "\r\n" > -"PRMINFO [[-?] | [-b] [-l] [-r] [-t (guid | all)]]\r\n" > +"PRMINFO [[-?] | [-b] [-l] [-t (guid | all)]]\r\n" > ".SH OPTIONS\r\n" > " \r\n" > " -? - Show help.\r\n" > @@ -107,18 +107,14 @@ > ".SH STANDARDS\r\n" > " \r\n" > "STANDARDS:\r\n" > -" Platform Runtime Mechanism (PRM) is currently in a draft state and > the\r\n" > -" specification is not yet publicly available. A reference to the > publicly\r\n" > -" available document will replace this text when it is available.\r\n" > +" The Platform Runtime Mechanism (PRM) specification is available at:\r\n" > +" > https://uefi.org/sites/default/files/resources/Platform%20Runtime%20Mech > anism%20-%20with%20legal%20notice.pdf\r\n" > ".SH EXAMPLES\r\n" > " \r\n" > "EXAMPLES:\r\n" > " * To display a list of the installed PRM modules and PRM handlers:\r\n" > "fs0:\> prminfo -l\r\n" > " \r\n" > -" * To validate the installed PRMT ACPI table:\r\n" > -"fs0:\> prminfo -r\r\n" > -" \r\n" > " * To call a PRM handler by GUID:\r\n" > "fs0:\> prminfo -t e1466081-7562-430f-896b-b0e523dc335a\r\n" > " \r\n" > -- > 2.43.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114099): https://edk2.groups.io/g/devel/message/114099 Mute This Topic: https://groups.io/mt/103654540/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS
Reviewed-by: Ankit Sinha
Thank you,
Ankit
> -Original Message-
> From: Ke, VincentX
> Sent: Wednesday, May 24, 2023 1:39 AM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric ; Sinha, Ankit
> Subject: [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS
>
> From: VincentX Ke
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
>
> Calculating CRC based on each ACPI table.
> Update HWSignature field in FACS based on CRC while ACPI table changed.
>
> Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c
> Signed-off-by: VincentX Ke
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Cc: Isaac Oram
> Cc: Liming Gao
> Cc: Eric Dong
> Cc: Ankit Sinha
> Signed-off-by: VincentX Ke
> ---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 282
> +++-
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
> 2 files changed, 215 insertions(+), 68 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index 2f2c96f907..ca1c73f6fe 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -1191,98 +1191,244 @@ PlatformUpdateTables (
> }
>
>
>
> /**
>
> - This function calculates RCR based on PCI Device ID and Vendor ID from the
> devices
>
> - available on the platform.
>
> - It also includes other instances of BIOS change to calculate CRC and
> provides as
>
> - HWSignature filed in FADT table.
>
> + Function prototype for GetAcpiTableCount/CalculateAcpiTableCrc.
>
> +
>
> + @param[in] TableThe pointer to ACPI table.
>
> + @param[in] TableIndex The ACPI table index.
>
> + @param[in] Context The pointer to UINTN for GetAcpiTableCount.
>
> + The pointer to UINT32 array for
> CalculateAcpiTableCrc.
>
> **/
>
> +typedef
>
> VOID
>
> -IsHardwareChange (
>
> - VOID
>
> +(EFIAPI *ACPI_TABLE_CALLBACK)(
>
> + IN EFI_ACPI_COMMON_HEADER *Table,
>
> + IN UINTN TableIndex,
>
> + IN VOID*Context
>
> + );
>
> +
>
> +/**
>
> + Enumerate all ACPI tables in RSDT/XSDT.
>
> +
>
> + @param[in] SdtACPI XSDT/RSDT.
>
> + @param[in] TablePointerSize Size of table pointer:
>
> +4(RSDT) or 8(XSDT).
>
> + @param[in] CallbackFunction The pointer to
> GetAcpiTableCount/CalculateAcpiTableCrc.
>
> + @param[in] ContextThe pointer to UINTN for GetAcpiTableCount.
>
> +The pointer to UINT32 array for
> CalculateAcpiTableCrc.
>
> +**/
>
> +VOID
>
> +EnumerateAllAcpiTables (
>
> + IN EFI_ACPI_DESCRIPTION_HEADER *Sdt,
>
> + IN UINTNTablePointerSize,
>
> + IN ACPI_TABLE_CALLBACK CallbackFunction,
>
> + IN VOID *Context
>
>)
>
> {
>
> - EFI_STATUS Status;
>
> - UINTNIndex;
>
> - UINTNHandleCount;
>
> - EFI_HANDLE *HandleBuffer;
>
> - EFI_PCI_IO_PROTOCOL *PciIo;
>
> - UINT32 CRC;
>
> - UINT32 *HWChange;
>
> - UINTNHWChangeSize;
>
> - UINT32 PciId;
>
> - UINTNHandle;
>
> - EFI_ACPI_6_5_FIRMWARE_ACPI_CONTROL_STRUCTURE *FacsPtr;
>
> - EFI_ACPI_6_5_FIXED_ACPI_DESCRIPTION_TABLE*pFADT;
>
> -
>
> - HandleCount = 0;
>
> - HandleBuffer = NULL;
>
> -
>
> - Status = gBS->LocateHandleBuffer (
>
> - ByProtocol,
>
> - ,
>
> - NULL,
>
> - ,
>
> -
>
> - );
>
> - if (EFI_ERROR (Status)) {
>
> -return; // PciIO protocol not installed yet!
>
> + UINTN Index;
>
> + UINTN TableIndex;
>
> + UINTN EntryCount;
>
> + UINT64
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Update ACPI 6.5 definition
Thank you Aryeh.
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, May 10, 2023 8:58 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric ; Yao, Jiewen ;
> Sinha, Ankit
> Subject: [PATCH v3] MinPlatformPkg: Update ACPI 6.5 definition
>
> From: Aryeh Chen
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=4442
>
> Update ACPI 6.5 definition on MinPlatformPkg
>
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Cc: Isaac Oram
> Cc: Liming Gao
> Cc: Eric Dong
> Cc: Jiewen Yao
> Cc: Ankit Sinha
>
> Signed-off-by: Aryeh Chen
> ---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> | 154 ++--
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Facs/Facs.c
> |
> 8 +-
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c
> |
> 46 +++---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Hpet/Hpet.c
> | 4 +-
>
> Platform/Intel/MinPlatformPkg/Acpi/Library/DxeAslUpdateLib/DxeAslUpdat
> eLib.c | 2 +-
> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> | 2
> +-
>
> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA
> cpi.c | 154 ++--
>
> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA
> cpiMadt.c | 150 +--
>
> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckD
> maProtection.c | 4 +-
>
> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc
> gTrustedBoot.c | 2 +-
>
> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi
> ntCheckLib.c | 2 +-
> 11 files changed, 264 insertions(+), 264 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index e967031a3b..2f2c96f907 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -27,9 +27,9 @@ typedef struct {
> // Define Union of IO APIC & Local APIC structure;
>
> //
>
> typedef union {
>
> - EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC_STRUCTURE AcpiLocalApic;
>
> - EFI_ACPI_6_3_IO_APIC_STRUCTUREAcpiIoApic;
>
> - EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC_STRUCTURE AcpiLocalx2Apic;
>
> + EFI_ACPI_6_5_PROCESSOR_LOCAL_APIC_STRUCTURE AcpiLocalApic;
>
> + EFI_ACPI_6_5_IO_APIC_STRUCTUREAcpiIoApic;
>
> + EFI_ACPI_6_5_PROCESSOR_LOCAL_X2APIC_STRUCTURE AcpiLocalx2Apic;
>
>struct {
>
> UINT8 Type;
>
> UINT8 Length;
>
> @@ -38,8 +38,8 @@ typedef union {
>
>
> #pragma pack()
>
>
>
> -extern EFI_ACPI_6_3_FIRMWARE_ACPI_CONTROL_STRUCTURE Facs;
>
> -extern EFI_ACPI_6_3_FIXED_ACPI_DESCRIPTION_TABLEFadt;
>
> +extern EFI_ACPI_6_5_FIRMWARE_ACPI_CONTROL_STRUCTURE Facs;
>
> +extern EFI_ACPI_6_5_FIXED_ACPI_DESCRIPTION_TABLEFadt;
>
> extern EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_TABLE_HEADER Hpet;
>
> extern EFI_ACPI_WSMT_TABLE Wsmt;
>
>
>
> @@ -92,16 +92,16 @@ AppendCpuMapTableEntry (
>)
>
> {
>
>EFI_STATUSStatus;
>
> - EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC_STRUCTURE *LocalApicPtr;
>
> - EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC_STRUCTURE *LocalX2ApicPtr;
>
> + EFI_ACPI_6_5_PROCESSOR_LOCAL_APIC_STRUCTURE *LocalApicPtr;
>
> + EFI_ACPI_6_5_PROCESSOR_LOCAL_X2APIC_STRUCTURE *LocalX2ApicPtr;
>
>UINT8 Type;
>
>
>
>Status = EFI_SUCCESS;
>
>Type = ((ACPI_APIC_STRUCTURE_PTR *)ApicPtr)->AcpiApicCommon.Type;
>
> - LocalApicPtr = (EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC_STRUCTURE
> *)(&((ACPI_APIC_STRUCTURE_PTR *)ApicPtr)->AcpiLocalApic);
>
> - LocalX2ApicPtr = (EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC_STRUCTURE
> *)(&((ACPI_APIC_STRUCTURE_PTR *)ApicPtr)->AcpiLocalx2Apic);
>
> + LocalApicPtr = (EFI_ACPI_6_5_PROCESSOR_LOCAL_APIC_STRUCTURE
> *)(&((ACPI_APIC_STRUCTURE_PTR *)ApicPtr)->AcpiLocalApic);
>
> + LocalX2ApicPtr = (EFI_ACPI_6_5_PROCESSOR_LOCAL_X2APIC_STRUCTURE
> *)(&((ACPI_APIC_STRUCTURE_PTR *)ApicPtr)->AcpiLocalx2Apic);
>
>
>
> - if(Type == EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC) {
>
> + if(Type == EFI_ACPI_6_5_PROCESSOR_LOCAL_APIC) {
>
> if(!mX2ApicEnabled) {
>
>LocalApicPtr->Flags=
> (UINT8)CpuApic
Re: [edk2-devel] [PATCH v7] MinPlatformPkg: Update HWSignature filed in FACS
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Ke, VincentX
> Sent: Thursday, May 11, 2023 3:00 AM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric ; Sinha, Ankit
> Subject: [PATCH v7] MinPlatformPkg: Update HWSignature filed in FACS
>
> From: VincentX Ke
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
>
> Calculating CRC based on each ACPI table.
> Update HWSignature filed in FACS based on CRC while ACPI table changed.
>
> Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c
> Signed-off-by: VincentX Ke
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Cc: Isaac Oram
> Cc: Liming Gao
> Cc: Eric Dong
> Cc: Ankit Sinha
> Signed-off-by: VincentX Ke
> ---
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 287
> +++-
> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 1 +
> 2 files changed, 223 insertions(+), 65 deletions(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> index e967031a3b..3dca6f99f7 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c
> @@ -1191,98 +1191,255 @@ PlatformUpdateTables (
> }
>
>
>
> /**
>
> - This function calculates RCR based on PCI Device ID and Vendor ID from the
> devices
>
> - available on the platform.
>
> - It also includes other instances of BIOS change to calculate CRC and
> provides as
>
> - HWSignature filed in FADT table.
>
> + This function calculates CRC based on each offset in the ACPI table.
>
> +
>
> + @param[in] Table The ACPI table required to calculate CRC.
>
> +
>
> + @retval CRC A pointer to allocate UINT32 that
>
> +contains the CRC32 data.
>
> +**/
>
> +UINT32
>
> +AcpiTableCrcCalculator (
>
> + IN EFI_ACPI_COMMON_HEADER *Table
>
> + )
>
> +{
>
> + EFI_STATUS Status;
>
> + UINT32 CRC;
>
> +
>
> + Status = EFI_SUCCESS;
>
> + CRC= 0;
>
> +
>
> + //
>
> + // Calculate CRC value.
>
> + //
>
> + if (Table->Signature ==
> EFI_ACPI_6_5_FIRMWARE_ACPI_CONTROL_STRUCTURE_SIGNATURE) {
>
> +//
>
> +// Zero HardwareSignature field before Calculating FACS CRC
>
> +//
>
> +((EFI_ACPI_6_5_FIRMWARE_ACPI_CONTROL_STRUCTURE *)Table)-
> >HardwareSignature = 0;
>
> + }
>
> +
>
> + Status = gBS->CalculateCrc32 ((UINT8 *)Table, (UINTN)Table->Length,
> );
>
> + return CRC;
>
> +}
>
> +
>
> +/**
>
> + This function count ACPI tables in RSDT/XSDT and return the result.
>
> +
>
> + @param[in] SdtACPI XSDT/RSDT.
>
> + @param[in] TablePointerSize Size of table pointer:
>
> +4(RSDT) or 8(XSDT).
>
> +
>
> + @retval TableCountThe total number of ACPI tables in
>
> +RSDT or XSDT.
>
> +**/
>
> +UINTN
>
> +CountTableInSDT (
>
> + IN EFI_ACPI_DESCRIPTION_HEADER *Sdt,
>
> + IN UINTNTablePointerSize
>
> + )
>
> +{
>
> + UINTN Index;
>
> + UINTN TableCount;
>
> + UINTN EntryCount;
>
> + UINT64 EntryPtr;
>
> + UINTN BasePtr;
>
> + EFI_ACPI_COMMON_HEADER *Table;
>
> +
>
> + EntryCount = (Sdt->Length - sizeof (EFI_ACPI_DESCRIPTION_HEADER)) /
> TablePointerSize;
>
> + BasePtr= (UINTN)(Sdt + 1);
>
> +
>
> + for (Index = 0, TableCount = 0; Index < EntryCount; Index++) {
>
> +EntryPtr = 0;
>
> +Table= NULL;
>
> +CopyMem (, (VOID *)(BasePtr + Index * TablePointerSize),
> TablePointerSize);
>
> +Table = (EFI_ACPI_COMMON_HEADER *)((UINTN)(EntryPtr));
>
> +if (Table) {
>
> + TableCount++;
>
> +}
>
> +
>
> +if (Table->Signature ==
> EFI_ACPI_6_5_FIXED_ACPI_DESCRIPTION_TABLE_SIGNATURE) {
>
> + CopyMem ((VOID *), (VOID *)Table, sizeof
> (EFI_ACPI_6_5_FIXED_ACPI_DESCRIPTION_TABLE));
>
> + if (Fadt.FirmwareCtrl || Fadt.XFirmwareCtrl) {
>
> +TableCount++;
>
> + }
>
> +
>
> + if (Fadt.Dsdt || Fadt.XDsdt) {
>
> +TableCount++;
>
> + }
>
&
Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00
Hi Aryeh,
Is it possible to use a FixedPCD for "PCI0"/"PC00" string itself? That way we
don't have to keep adding conditional statements for future changes. It will
scale better.
Declare in MinPlatformPkg.dec and provide the value in
OpenBoardPkg.dsc.
Thank you,
Ankit
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Chen,
> Aryeh
> Sent: Monday, January 30, 2023 9:45 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric
> Subject: [edk2-devel] [PATCH v1] MinPlatformPkg: Add PCD
> PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00
>
> From: Aryeh Chen
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4329
>
> To add PCD PcdMinPciBridgePC00 to support \_SB.PCI0 and \_SB.PC00 on
> MinDsdt.asl because PciBridge has modified from \_SB.PCI0 to
> \_SB.PC00 since Client ADL platform.
>
> Signed-off-by: Aryeh Chen
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Cc: Isaac Oram
> Cc: Liming Gao
> Cc: Eric Dong
> ---
> Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 4
> Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf | 1 +
> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 3 +++
> 3 files changed, 8 insertions(+)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> index 4efb8709ac..b7361b6d44 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> @@ -23,7 +23,11 @@ DefinitionBlock (
>
> //---
> // Begin PCI
> tree object scope
> //-
> --+#if FixedPcdGetBool (PcdMinPciBridgePC00) == 1+Device(PC00) { // PCI
> Bridge "Host Bridge"+#else Device(PCI0) { // PCI Bridge "Host
> Bridge"+#endif Name(_HID, EISAID("PNP0A08")) // Indicates PCI
> Express/PCI-X Mode2 host hierarchy Name(_CID, EISAID("PNP0A03")) //
> To support legacy OS that doesn't understand the new HID Name(_SEG,
> 0)diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> index 3437bc489c..b3b45039cc 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.inf
> @@ -40,6 +40,7 @@
> [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemBase
> gMinPlatformPkgTokenSpaceGuid.PcdPciReservedMemLimit+
> gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00 [Depex]
> gEfiAcpiTableProtocolGuid ANDdiff --git
> a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> index e6f714b181..68a76db4de 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
> @@ -139,6 +139,9 @@
>
> gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkRegisterBitWidth|0x00|U
> INT8|0x00010056
> gMinPlatformPkgTokenSpaceGuid.PcdAcpiS4BiosReq|0x|UINT8|0x0001
> 0055 + # The PCD controls MinDsdt PciBridge+
> gMinPlatformPkgTokenSpaceGuid.PcdMinPciBridgePC00|FALSE|BOOLEAN|0x
> 00010057+ # # FADT Duty Offset - The zero-based index of where the
> processor's duty cycle # setting is within the processor's P_CNT register.--
> 2.26.2.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#99338): https://edk2.groups.io/g/devel/message/99338
> Mute This Topic: https://groups.io/mt/96647478/1772825
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ankit.si...@intel.com]
> -=-=-=-=-=-=
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99362): https://edk2.groups.io/g/devel/message/99362
Mute This Topic: https://groups.io/mt/96647478/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 01/14] PrmPkg: Fix new typos reported
Hi Michael, There is a typo that got missed in one of the modified comments. In file "b/PrmPkg/Include/Library/PrmModuleDiscoveryLib.h": - Each PRM Module discovered is placed into a linked list so the list can br processsed in the future. + Each PRM Module discovered is placed into a linked list so the list can br processed in the future. 'br' should change to 'be' Thank you, Ankit > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Wednesday, December 14, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Desimone, Nathaniel > L ; Sinha, Ankit > Subject: [edk2-devel] [PATCH v3 01/14] PrmPkg: Fix new typos reported > > From: Michael Kubacki > > The SpellCheck plugin began reporting new typos that were previously > missed. This change fixes those typos. > > Cc: Michael Kubacki > Cc: Nate DeSimone > Cc: Ankit Sinha > Signed-off-by: Michael Kubacki > --- > PrmPkg/Application/PrmInfo/PrmInfo.c > | 2 +- > PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib.c > | 2 +- > PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c > | 2 +- > > UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestU > efiBootServicesTableLibImage.c| 2 +- > > UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestU > efiBootServicesTableLibProtocol.c | 2 +- > PrmPkg/Include/Library/PrmModuleDiscoveryLib.h > | 2 +- > PrmPkg/PrmLoaderDxe/PrmAcpiTable.h > | 4 ++-- > PrmPkg/PrmPkg.ci.yaml > | 9 > + > > UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTestU > efiBootServicesTableLib.h | 4 ++-- > 9 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/PrmPkg/Application/PrmInfo/PrmInfo.c > b/PrmPkg/Application/PrmInfo/PrmInfo.c > index 0cde2fad3b4b..178d4810f498 100644 > --- a/PrmPkg/Application/PrmInfo/PrmInfo.c > +++ b/PrmPkg/Application/PrmInfo/PrmInfo.c > @@ -148,7 +148,7 @@ PrintMmioRuntimeRangeInfo ( >Gathers the PRM handler (and by extension module) information > discovered on this system. > >This function must be called to build up the discovered context for other > functions in the application. The > - function will optionally print results as determed by the value of the > PrintInformation parameter. > + function will optionally print results as determined by the value of the > PrintInformation parameter. > >@param[in] PrintInformation Indicates whether to print > information > as discovered in the function. > > diff --git > a/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. > c > b/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. > c > index e6bea47bc583..34373effd4cd 100644 > --- > a/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. > c > +++ > b/PrmPkg/Library/DxePrmModuleDiscoveryLib/DxePrmModuleDiscoveryLib. > c > @@ -149,7 +149,7 @@ IsAddressInMmram ( > /** >Discovers all PRM Modules loaded during boot. > > - Each PRM Module discovered is placed into a linked list so the list can br > processsed in the future. > + Each PRM Module discovered is placed into a linked list so the list can br > processed in the future. > >@param[out] ModuleCount An optional pointer parameter > that, if > provided, is set to the number >of PRM modules discovered. > diff --git a/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c > b/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c > index 5a223d783d80..7b0042f133ef 100644 > --- a/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c > +++ b/PrmPkg/PrmLoaderDxe/PrmLoaderDxe.c > @@ -295,7 +295,7 @@ PublishPrmAcpiTable ( >time of this function invocation. > >The main responsibilities of the PRM Loader are executed from this > function which include 3 phases: > -1.) Disover PRM Modules - Find all PRM modules loaded during DXE > dispatch and insert a PRM Module > +1.) Discover PRM Modules - Find all PRM modules loaded during DXE > + dispatch and insert a PRM Module > Context entry into a linked list to be handed off to phase 2. > 2.) Process PRM Modules - Build a GUID to PRM handler mapping for each > module that is described in the > PRM ACPI table so the OS can resolve a PRM Handler GUID to the > corresponding PRM Handler physical address. > diff --git > a/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest > UefiBootServicesTableLibImage.c > b/UnitTestFrameworkPkg/Library/UnitTestUefiBootServicesTableLib/UnitTest > UefiBootServicesTableLibImage.c > index 144c
Re: [edk2-devel] [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID to PNP0C02.
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Xu, Wei6
> Sent: Monday, November 7, 2022 3:58 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael ; Desimone,
> Nathaniel L ; Sinha, Ankit
>
> Subject: [PATCH v1 1/1] PrmPkg/PrmSsdtInstallDxe: Update PRMT Device CID
> to PNP0C02.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4141
>
> PRMT device is an unknown device in Device Manager if there is no Windows
> Driver installed for it. It will cause WHQL Signed Driver test failure.
> To complete WHQL certification, update PRMT Device CID to PNP0C02.
> In this way, PRMT Device will be a Motherboard Resources when no real
> driver is loaded (default), but will be shown as the actual device name when
> a legitimate Windows Driver is loaded.
>
> Cc: Michael Kubacki
> Cc: Nate DeSimone
> Cc: Ankit Sinha
> Signed-off-by: Wei6 Xu
> ---
> PrmPkg/PrmSsdtInstallDxe/Prm.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> b/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> index e34336b4eee6..c4c406e93e2f 100644
> --- a/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> +++ b/PrmPkg/PrmSsdtInstallDxe/Prm.asl
> @@ -22,7 +22,7 @@ DefinitionBlock (
> Device (PRMT)
> {
> Name (_HID, "80860223")
> -Name (_CID, "80860223")
> +Name (_CID, EisaId ("PNP0C02"))
> Name (_DDN, "PRM Test Device")
>
> //PRM operation region format
> --
> 2.29.2.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96048): https://edk2.groups.io/g/devel/message/96048
Mute This Topic: https://groups.io/mt/94864133/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Hi Aryeh,
Thank you for testing.
Reviewed-by: Ankit Sinha
> -Original Message-
> From: Chen, Aryeh
> Sent: Wednesday, September 21, 2022 12:34 AM
> To: Sinha, Ankit ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric
> Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
>
> Hi Ankit,
>
> Add a change to remove Name(_ADR, 0x) from edk2-
> platforms\Platform\Intel\MinPlatformPkg\Acpi\MinDsdt\MinDsdt.asl
> It can boot to OS success on Win10 21H2 and Ubuntu 22.4.0 on TGLU
> openboard bios.
>
> === Acpidump ===
> Signature "DSDT"
> Length0x00FD (253)
> Revision 0x01 (1)
> Checksum 0x33 (51)
> OEM ID"INTEL "
> OEM Table ID "MIN "
> OEM Revision 0x (0)
> Creator ID"INTL"
> Creator Revision 0x20210930 (539035952)
> DefinitionBlock ("DSDT.AML", "DSDT", 0x01, "INTEL ", "MIN ", 0x)
> {
> Scope(_SB)
> {
> Device(PCI0)
> {
> Name(_HID, EISAID("PNP0A08"))
> Name(_CID, EISAID("PNP0A03"))
> Name(_SEG, Zero)
> Method(^BN00, 0, NotSerialized)
> {
> Return(Zero)
> }
>
> === Original mindsdt.asl ===
> Scope(\_SB) {
>
> //---
> // Begin PCI tree object scope
>
> //---
> Device(PCI0) { // PCI Bridge "Host Bridge"
> Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy
> Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't
> understand the new HID
> Name(_SEG, 0)
> Name(_ADR, 0x)
> Method(^BN00, 0){ return(0x) } // Returns default Bus number for
> Peer PCI busses. Name can be overriden with control method placed directly
> under Device scope
> Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the Root
> PCI Bus
>
> Thanks,
> Aryeh
>
> -Original Message-
> From: Sinha, Ankit
> Sent: Tuesday, September 13, 2022 4:54 AM
> To: Chen, Aryeh ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric
> Subject: RE: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
>
> Hi Aryeh,
>
> Can you please post the test results for this change. It would be good to note
> that there is no change in behavior in the OS.
>
> Thank you,
> Ankit
>
> > -Original Message-
> > From: Chen, Aryeh
> > Sent: Sunday, September 11, 2022 10:18 PM
> > To: devel@edk2.groups.io
> > Cc: Chen, Aryeh ; Chiu, Chasel
> > ; Desimone, Nathaniel L
> > ; Oram, Isaac W
> > ; Sinha, Ankit ; Gao,
> > Liming ; Dong, Eric
> > Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
> >
> > From: Aryeh Chen
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> >
> > According to ASL Coding Guidelines - Device Identifiers "A Device
> > should contain either an _ADR or a _HID object, never both."
> > , so remove _ADR due to _HID exist.
> >
> > Signed-off-by: Aryeh Chen
> > Cc: Chasel Chiu
> > Cc: Nate DeSimone
> > Cc: Isaac Oram
> > Cc: Ankit Sinha
> > Cc: Liming Gao
> > Cc: Eric Dong
> > ---
> > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > index 0d94472450..4efb8709ac 100644
> > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > @@ -27,7 +27,6 @@ DefinitionBlock (
> >Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> > host hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy OS
> > that doesn't understand the new HID Name(_SEG, 0)- Name(_ADR,
> > 0x) Method(^BN00, 0){ return(0x) } // Returns default Bus
> > number for Peer PCI busses. Name can be overriden with control method
> > placed directly under Device scope Method(_BBN, 0){ return(BN00()) }
> //
> > Bus number, optional for the Root PCI Bus Name(_UID, 0x) //
> Unique
> > Bus ID, optional--
> > 2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94486): https://edk2.groups.io/g/devel/message/94486
Mute This Topic: https://groups.io/mt/93627173/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Hi Aryeh,
Can you please post the test results for this change. It would be good to note
that there is no change in behavior in the OS.
Thank you,
Ankit
> -Original Message-
> From: Chen, Aryeh
> Sent: Sunday, September 11, 2022 10:18 PM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Sinha, Ankit ; Gao,
> Liming ; Dong, Eric
> Subject: [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
>
> From: Aryeh Chen
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
>
> According to ASL Coding Guidelines - Device Identifiers "A Device should
> contain either an _ADR or a _HID object, never both."
> , so remove _ADR due to _HID exist.
>
> Signed-off-by: Aryeh Chen
> Cc: Chasel Chiu
> Cc: Nate DeSimone
> Cc: Isaac Oram
> Cc: Ankit Sinha
> Cc: Liming Gao
> Cc: Eric Dong
> ---
> Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> index 0d94472450..4efb8709ac 100644
> --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> @@ -27,7 +27,6 @@ DefinitionBlock (
>Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy Name(_CID, EISAID("PNP0A03")) // To support legacy OS
> that doesn't understand the new HID Name(_SEG, 0)- Name(_ADR,
> 0x) Method(^BN00, 0){ return(0x) } // Returns default Bus
> number for Peer PCI busses. Name can be overriden with control method
> placed directly under Device scope Method(_BBN, 0){ return(BN00()) } //
> Bus number, optional for the Root PCI Bus Name(_UID, 0x) // Unique
> Bus ID, optional--
> 2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93663): https://edk2.groups.io/g/devel/message/93663
Mute This Topic: https://groups.io/mt/93627173/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from MinDsdt.asl
Hi Igor,
Section 6.1 of the ACPI specification describes this (Last line of the
paragraph below states what Aryeh was saying):
For any device that is on a non-enumerable type of bus (for example, an ISA
bus), OSPM enumerates the devices' identifier(s) and the ACPI system firmware
must supply an _HID object (plus one or more optional objects such as _CID,
_CLS, _HRV, _SUB) for each device to enable OSPM to do that. For devices on an
enumerable type of bus, such as a PCI bus, the ACPI system must identify which
device on the enumerable bus is identified by a particular address; the ACPI
system firmware must supply an _ADR object for each device to enable this. A
device object must contain either an _HID object or an _ADR object, but must
not contain both.
Thank you,
Ankit
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Igor
> Mammedov
> Sent: Monday, September 12, 2022 1:33 AM
> To: Chen, Aryeh
> Cc: devel@edk2.groups.io; Chiu, Chasel ; Desimone,
> Nathaniel L ; Oram, Isaac W
> ; Sinha, Ankit ; Gao,
> Liming ; Dong, Eric
> Subject: Re: [edk2-devel] [PATCH v3] MinPlatformPkg: Remove _ADR from
> MinDsdt.asl
>
> On Mon, 12 Sep 2022 13:17:45 +0800
> aryeh.c...@intel.com wrote:
>
> > From: Aryeh Chen
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4057
> >
> > According to ASL Coding Guidelines - Device Identifiers "A Device
> > should contain either an _ADR or a _HID object, never both."
> > , so remove _ADR due to _HID exist.
>
> I'm curious where exactly in ACPI spec it's said...
>
> > Signed-off-by: Aryeh Chen
> > Cc: Chasel Chiu
> > Cc: Nate DeSimone
> > Cc: Isaac Oram
> > Cc: Ankit Sinha
> > Cc: Liming Gao
> > Cc: Eric Dong
> > ---
> > Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > index 0d94472450..4efb8709ac 100644
> > --- a/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > +++ b/Platform/Intel/MinPlatformPkg/Acpi/MinDsdt/MinDsdt.asl
> > @@ -27,7 +27,6 @@ DefinitionBlock (
> >Name(_HID, EISAID("PNP0A08")) // Indicates PCI Express/PCI-X Mode2
> host hierarchy
> >Name(_CID, EISAID("PNP0A03")) // To support legacy OS that doesn't
> understand the new HID
> >Name(_SEG, 0)
> > - Name(_ADR, 0x)
> Spec also says
> v6.3
> 6.1.1 _ADR (Address)
> An _ADR object must be used when specifying the address of any device on
> a bus that has a standard enumeration algorithm
>
> >Method(^BN00, 0){ return(0x) } // Returns default Bus number for
> Peer PCI busses. Name can be overriden with control method placed directly
> under Device scope
> >Method(_BBN, 0){ return(BN00()) } // Bus number, optional for the
> Root PCI Bus
> >Name(_UID, 0x) // Unique Bus ID, optional
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93662): https://edk2.groups.io/g/devel/message/93662
Mute This Topic: https://groups.io/mt/93627173/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
