Re: [edk2-devel] [PATCH v3 00/78] Fix a bunch of typos (part 1)
Le 11/02/2020 à 06:54, Laszlo Ersek a écrit : Thank you Antoine and Phil for this large work! Laszlo No problem for the work. Sorry for the EFI_D_INFO: it was changed with the typo in October 2019, while my commit predates. For the little story, I made most corrections in February 2018, and I spent a huge time with merge conflicts from the cleanup of June 2018 by lgao4. I'm really happy that Philippe saved the work. By the way, I recall I made two PR after the split of edk2-platforms, so if anyone is interested, they are: - https://github.com/tianocore/edk2-platforms/pull/3 for BeagleBoardPkg - https://github.com/tianocore/edk2-platforms/pull/4 for IntelSiliconPkg Antoine -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54301): https://edk2.groups.io/g/devel/message/54301 Mute This Topic: https://groups.io/mt/71039512/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 00/78] Fix a bunch of typos (part 1)
Le 03/01/2020 à 17:06, Philippe Mathieu-Daude a écrit : Around February of this year, Antoine posted various patches fixing a huge quantity of typos, over 8000+ lines (such [1]). It was year 2019, and the changes were mostly a rebase from year 2018. ^_^ Thank you for the huge salvage. Antoine -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52819): https://edk2.groups.io/g/devel/message/52819 Mute This Topic: https://groups.io/mt/69395700/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
for all my patches until now: Signed-off-by: Antoine Coeur (see the discussion on [PATCH 61/79] OvmfPkg/Xen: Fix various typos) Regards, Antoine Cœur Le 04/12/2019 à 00:14, Philippe Mathieu-Daude a écrit : Around February of this year, Antoine posted various patches fixing a huge quantity of typos, over 8000+ lines (such [1]). The community merged the smaller patches, and told him his patches were too big, and he should split them. Around June, Antoine opened a GitHub pull request [2], due to the size of his patchset. We told him the project doesn't accept GitHub PR. Since I find his cleanup work very valuable for the project, I spent few hours trying to salvage a chunk of it, splitting per maintainer areas, each patch not to big to avoid reviewers burning out. I expect each maintainer to take his patches. I wanted to split Antoine work in 3 parts, but I'm about at 80 patches, for only 1854 lines changed, so enough for a first round. Oh, and it is easier to review the patches using '--word-diff=color' git option :) Regards, Phil. P.D.: I think the project is really failing at getting new contributors involved, and keeping them. But that is another topic. [1] https://edk2.groups.io/g/devel/message/43043 [2] https://edk2.groups.io/g/devel/message/42941 Antoine Coeur (72): CryptoPkg/OpensslLib: Fix few typos EmbeddedPkg/FdtLib: Fix a typo EmbeddedPkg/VirtualKeyboard: Fix few typos EmulatorPkg/Sec: Fix various typos EmulatorPkg/Unix: Fix various typos EmulatorPkg/Win: Fix various typos FatPkg/EnhancedFatDxe: Fix various typos FatPkg/FatPei: Fix few typos IntelFsp2WrapperPkg: Fix various typos MdeModulePkg/Application: Improve French translation MdeModulePkg/Application: Fix various typos MdeModulePkg/Bus/Ata: Fix various typos MdeModulePkg/Bus/I2c: Fix few typos MdeModulePkg/Bus/Isa: Fix various typos MdeModulePkg/Bus/Scsi: Fix various typos MdeModulePkg/Bus/Sd: Fix various typos MdeModulePkg/Core/Pei: Fix various typos MdeModulePkg/Core/PiSmmCore: Fix various typos MdeModulePkg/UsbMass: Fix various typos MdeModulePkg/UsbMouse: Fix few typos MdeModulePkg/UsbBus: Fix various typos MdeModulePkg/Usb: Fix various typos MdePkg/IndustryStandard: Fix various typos MdePkg/Library/Dxe: Fix various typos MdePkg/Library/Pci: Fix various typos MdePkg/Library/Smm: Fix various typos MdePkg/Ppi: Fix various typos MdePkg/Register: Fix various typos NetworkPkg/ArpDxe: Fix various typos NetworkPkg/Dhcp4Dxe: Fix various typos NetworkPkg/Dhcp6Dxe: Fix various typos NetworkPkg/DnsDxe: Fix various typos NetworkPkg/DpcDxe: Fix few typos NetworkPkg/HttpBootDxe: Fix various typos NetworkPkg/HttpDxe: Fix various typos NetworkPkg/Ip4Dxe: Fix various typos NetworkPkg/Ip6Dxe: Fix various typos NetworkPkg/IScsiDxe: Fix various typos NetworkPkg/Library: Fix various typos NetworkPkg/MnpDxe: Fix various typos NetworkPkg/Mtftp4Dxe: Fix various typos NetworkPkg/Mtftp6Dxe: Fix various typos NetworkPkg/SnpDxe: Fix few typos NetworkPkg/TcpDxe/Sock: Fix few typos NetworkPkg/TcpDxe/Tcp: Fix various typos NetworkPkg/Tls: Fix few typos NetworkPkg/Udp4Dxe: Fix various typos NetworkPkg/Udp6Dxe: Fix various typos NetworkPkg/UefiPxeBcDxe: Fix various typos NetworkPkg/VlanConfigDxe: Fix few typos OvmfPkg/Acpi: Fix few typos OvmfPkg/Csm: Fix various typos OvmfPkg/Qemu: Fix various typos OvmfPkg/Virtio: Fix few typos OvmfPkg/Xen: Fix various typos PcAtChipsetPkg: Fix few typos SecurityPkg: Fix few typos SecurityPkg/Hash2DxeCrypto: Fix few typos SecurityPkg/Library/Tpm: Fix various typos SecurityPkg/Tcg: Fix various typos SecurityPkg/VariableAuthenticated: Fix few typos ShellPkg/Application: Fix various typos ShellPkg/DynamicCommand: Fix various typos SignedCapsulePkg: Fix various typos SignedCapsulePkg/Universal: Fix various typos SourceLevelDebugPkg/DebugAgent: Fix various typos SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos SourceLevelDebugPkg: Fix few typos StandaloneMmPkg: Fix few typos UefiCpuPkg/CpuDxe: Fix few typos UefiCpuPkg/PiSmm: Fix various typos UefiCpuPkg/Smm: Fix various typos Philippe Mathieu-Daude (7): EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER MdeModulePkg/UsbBusDxe: Fix a typo NetworkPkg: Fix a typo NetworkPkg/DnsDxe: Fix a typo NetworkPkg/HttpBootDxe: Fix a typo in variable name OvmfPkg/Xen: Fix a typo StandaloneMmPkg: Fix a typo SignedCapsulePkg/SignedCapsulePkg.dec | 4 +- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 10
Re: [edk2-devel] [PATCH v2 005/105] .mailmap: Add an entry for Antoine Cœur
Reviewed-by: Antoine Cœur Le 06/12/2019 à 19:24, Philippe Mathieu-Daude a écrit : We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Antoine Cœur to have his name and email address displayed properly in the git history. Cc: Antoine Cœur Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can not Cc all the named developers in the cover. Therefore I'm adapting the explaination from the cover in each patch] This patch won't get merged if Antoine Cœur doesn't give his approval, by replying to this patch with: Reviewed-by: Antoine Cœur If you think this patch is inappropriate, you don't need to justify, reply with: NAcked-by: Antoine Cœur or simply: NACK If your Firstname Lastname order is incorrect, tell me and I will fix it. You can also ignore this mail, but I might resend it and keep bothering you. Regards, Phil. --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index 476f7cd9b24c..0c201cd5cd86 100644 --- a/.mailmap +++ b/.mailmap @@ -16,3 +16,5 @@ Amy Chan Andrew Fish Andrew Fish Andrew Fish +Antoine Cœur +Antoine Cœur -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51941): https://edk2.groups.io/g/devel/message/51941 Mute This Topic: https://groups.io/mt/67467663/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 61/79] OvmfPkg/Xen: Fix various typos
Le 04/12/2019 à 00:56, Anthony PERARD a écrit : There's seems to be missing SoB from Antoine. Could that be added? Hi, no need to worry about my attribution: it's really just spellchecking. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#51714): https://edk2.groups.io/g/devel/message/51714 Mute This Topic: https://groups.io/mt/65782892/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1)
Woah, thank you for the work, Philippe. Tell me if there is anything I can do to help. Antoine Le 04/12/2019 à 00:14, Philippe Mathieu-Daude a écrit : Around February of this year, Antoine posted various patches fixing a huge quantity of typos, over 8000+ lines (such [1]). The community merged the smaller patches, and told him his patches were too big, and he should split them. Around June, Antoine opened a GitHub pull request [2], due to the size of his patchset. We told him the project doesn't accept GitHub PR. Since I find his cleanup work very valuable for the project, I spent few hours trying to salvage a chunk of it, splitting per maintainer areas, each patch not to big to avoid reviewers burning out. I expect each maintainer to take his patches. I wanted to split Antoine work in 3 parts, but I'm about at 80 patches, for only 1854 lines changed, so enough for a first round. Oh, and it is easier to review the patches using '--word-diff=color' git option :) Regards, Phil. P.D.: I think the project is really failing at getting new contributors involved, and keeping them. But that is another topic. [1] https://edk2.groups.io/g/devel/message/43043 [2] https://edk2.groups.io/g/devel/message/42941 Antoine Coeur (72): CryptoPkg/OpensslLib: Fix few typos EmbeddedPkg/FdtLib: Fix a typo EmbeddedPkg/VirtualKeyboard: Fix few typos EmulatorPkg/Sec: Fix various typos EmulatorPkg/Unix: Fix various typos EmulatorPkg/Win: Fix various typos FatPkg/EnhancedFatDxe: Fix various typos FatPkg/FatPei: Fix few typos IntelFsp2WrapperPkg: Fix various typos MdeModulePkg/Application: Improve French translation MdeModulePkg/Application: Fix various typos MdeModulePkg/Bus/Ata: Fix various typos MdeModulePkg/Bus/I2c: Fix few typos MdeModulePkg/Bus/Isa: Fix various typos MdeModulePkg/Bus/Scsi: Fix various typos MdeModulePkg/Bus/Sd: Fix various typos MdeModulePkg/Core/Pei: Fix various typos MdeModulePkg/Core/PiSmmCore: Fix various typos MdeModulePkg/UsbMass: Fix various typos MdeModulePkg/UsbMouse: Fix few typos MdeModulePkg/UsbBus: Fix various typos MdeModulePkg/Usb: Fix various typos MdePkg/IndustryStandard: Fix various typos MdePkg/Library/Dxe: Fix various typos MdePkg/Library/Pci: Fix various typos MdePkg/Library/Smm: Fix various typos MdePkg/Ppi: Fix various typos MdePkg/Register: Fix various typos NetworkPkg/ArpDxe: Fix various typos NetworkPkg/Dhcp4Dxe: Fix various typos NetworkPkg/Dhcp6Dxe: Fix various typos NetworkPkg/DnsDxe: Fix various typos NetworkPkg/DpcDxe: Fix few typos NetworkPkg/HttpBootDxe: Fix various typos NetworkPkg/HttpDxe: Fix various typos NetworkPkg/Ip4Dxe: Fix various typos NetworkPkg/Ip6Dxe: Fix various typos NetworkPkg/IScsiDxe: Fix various typos NetworkPkg/Library: Fix various typos NetworkPkg/MnpDxe: Fix various typos NetworkPkg/Mtftp4Dxe: Fix various typos NetworkPkg/Mtftp6Dxe: Fix various typos NetworkPkg/SnpDxe: Fix few typos NetworkPkg/TcpDxe/Sock: Fix few typos NetworkPkg/TcpDxe/Tcp: Fix various typos NetworkPkg/Tls: Fix few typos NetworkPkg/Udp4Dxe: Fix various typos NetworkPkg/Udp6Dxe: Fix various typos NetworkPkg/UefiPxeBcDxe: Fix various typos NetworkPkg/VlanConfigDxe: Fix few typos OvmfPkg/Acpi: Fix few typos OvmfPkg/Csm: Fix various typos OvmfPkg/Qemu: Fix various typos OvmfPkg/Virtio: Fix few typos OvmfPkg/Xen: Fix various typos PcAtChipsetPkg: Fix few typos SecurityPkg: Fix few typos SecurityPkg/Hash2DxeCrypto: Fix few typos SecurityPkg/Library/Tpm: Fix various typos SecurityPkg/Tcg: Fix various typos SecurityPkg/VariableAuthenticated: Fix few typos ShellPkg/Application: Fix various typos ShellPkg/DynamicCommand: Fix various typos SignedCapsulePkg: Fix various typos SignedCapsulePkg/Universal: Fix various typos SourceLevelDebugPkg/DebugAgent: Fix various typos SourceLevelDebugPkg/DebugCommunicationLib: Fix various typos SourceLevelDebugPkg: Fix few typos StandaloneMmPkg: Fix few typos UefiCpuPkg/CpuDxe: Fix few typos UefiCpuPkg/PiSmm: Fix various typos UefiCpuPkg/Smm: Fix various typos Philippe Mathieu-Daude (7): EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER MdeModulePkg/UsbBusDxe: Fix a typo NetworkPkg: Fix a typo NetworkPkg/DnsDxe: Fix a typo NetworkPkg/HttpBootDxe: Fix a typo in variable name OvmfPkg/Xen: Fix a typo StandaloneMmPkg: Fix a typo SignedCapsulePkg/SignedCapsulePkg.dec | 4 +- MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf | 2 +- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf | 10 ++-- MdePkg/Library/DxePcdLib/DxePcdLib.inf
[edk2-devel] Fw: [PATCH] MdeModulePkg: Fix various typos
CC the maintainers. This is only a small subset of all the spelling/typo issues from MdeModulePkg. But I don't want to overload you with too much to review, so I'll only post one MdeModulePkg batch at a time. Coeur Gesendet: Samstag, 13. Juli 2019 um 12:57 Uhr Von: "Antoine Cœur" An: devel@edk2.groups.io Cc: "Antoine Cœur" Betreff: [PATCH] MdeModulePkg: Fix various typos Fix various typos in MdeModulePkg. Signed-off-by: Coeur --- .../Application/CapsuleApp/CapsuleApp.c | 2 +- .../Application/CapsuleApp/CapsuleDump.c | 6 ++--- .../PlatformVarCleanupLib/PlatVarCleanupLib.c | 10 +++ MdeModulePkg/MdeModulePkg.dec | 26 +-- MdeModulePkg/MdeModulePkg.uni | 8 +++--- .../Universal/DevicePathDxe/DevicePathDxe.uni | 4 +-- .../Disk/RamDiskDxe/RamDiskProtocol.c | 2 +- .../EbcDxe/EbcDebugger/EdbCmdSymbol.c | 10 +++ .../PlatDriOverrideDxe.uni | 10 +++ 9 files changed, 39 insertions(+), 39 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c index 3439ce5feb..4034714773 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c @@ -494,7 +494,7 @@ BuildGatherList ( } // - // Record descirptor header + // Record descriptor header // if (Index == 0) { BlockDescriptorsHeader = BlockDescriptors1; diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c index 58a93568d0..d623d7c809 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c @@ -38,7 +38,7 @@ DumpUxCapsule ( { EFI_DISPLAY_CAPSULE *DisplayCapsule; DisplayCapsule = (EFI_DISPLAY_CAPSULE *)CapsuleHeader; - Print(L"[UxCapusule]\n"); + Print(L"[UxCapsule]\n"); Print(L"CapsuleHeader:\n"); Print(L" CapsuleGuid - %g\n", >CapsuleHeader.CapsuleGuid); Print(L" HeaderSize - 0x%x\n", DisplayCapsule->CapsuleHeader.HeaderSize); @@ -199,7 +199,7 @@ DumpCapsule ( DumpFmpCapsule(CapsuleHeader); } if (IsNestedFmpCapsule(CapsuleHeader)) { - Print(L"[NestedCapusule]\n"); + Print(L"[NestedCapsule]\n"); Print(L"CapsuleHeader:\n"); Print(L" CapsuleGuid - %g\n", >CapsuleGuid); Print(L" HeaderSize - 0x%x\n", CapsuleHeader->HeaderSize); @@ -793,7 +793,7 @@ DumpCapsuleFromDisk ( goto Done; } - Print(L"The infomation of the capsules:\n"); + Print(L"The information of the capsules:\n"); for (Index = 0; Index < FileCount; Index++) { FileHandle = NULL; diff --git a/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c b/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c index 968c044a31..d9daf7f86a 100644 --- a/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c +++ b/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c @@ -260,12 +260,12 @@ CreateUserVariableNode ( ASSERT (UserVariableNameNode->PromptString != NULL); UnicodeSPrint (UserVariableNameNode->PromptString, StringSize, L" %s", UserVariableNameNode->Name); // - // (33 chars of "Attribtues = 0x and DataSize = 0x" + 1 terminator + (sizeof (UINT32) + sizeof (UINTN)) * 2) * sizeof (CHAR16). + // (33 chars of "Attributes = 0x and DataSize = 0x" + 1 terminator + (sizeof (UINT32) + sizeof (UINTN)) * 2) * sizeof (CHAR16). // StringSize = (33 + 1 + (sizeof (UINT32) + sizeof (UINTN)) * 2) * sizeof (CHAR16); UserVariableNameNode->HelpString = AllocatePool (StringSize); ASSERT (UserVariableNameNode->HelpString != NULL); - UnicodeSPrint (UserVariableNameNode->HelpString, StringSize, L"Attribtues = 0x%08x and DataSize = 0x%x", UserVariableNameNode->Attributes, UserVariableNameNode->DataSize); + UnicodeSPrint (UserVariableNameNode->HelpString, StringSize, L"Attributes = 0x%08x and DataSize = 0x%x", UserVariableNameNode->Attributes, UserVariableNameNode->DataSize); UserVariableNameNode->Deleted = FALSE; InsertTailList (>NameLink, >Link); Index++; @@ -332,7 +332,7 @@ DestroyUserVariableNode ( it's caller's responsibility to free the memory after using it. @retval EFI_SUCCESS Create time based payload successfully. - @retval EFI_OUT_OF_RESOURCES There are not enough memory resourses to create time based payload. + @retval EFI_OUT_OF_RESOURCES There are not enough memory resources to create time based payload. @retval EFI_INVALID_PARAMETER The parameter is invalid. @retval Others Unexpected error happens. @@ -416,7 +416,7 @@ CreateTimeBasedPayload ( it's caller's responsibility to free the memory after using it. @retval EFI_SUCCESS Create counter based payload successfully. - @retval EFI_OUT_OF_RESOURCES There are not enough memory resourses to create time based payload. + @retval EFI_OUT_OF_RESOURCES There are not enough memory resources to create time based pay
[edk2-devel] [PATCH] MdeModulePkg: Fix various typos
Fix various typos in MdeModulePkg. Signed-off-by: Coeur --- .../Application/CapsuleApp/CapsuleApp.c | 2 +- .../Application/CapsuleApp/CapsuleDump.c | 6 ++--- .../PlatformVarCleanupLib/PlatVarCleanupLib.c | 10 +++ MdeModulePkg/MdeModulePkg.dec | 26 +-- MdeModulePkg/MdeModulePkg.uni | 8 +++--- .../Universal/DevicePathDxe/DevicePathDxe.uni | 4 +-- .../Disk/RamDiskDxe/RamDiskProtocol.c | 2 +- .../EbcDxe/EbcDebugger/EdbCmdSymbol.c | 10 +++ .../PlatDriOverrideDxe.uni| 10 +++ 9 files changed, 39 insertions(+), 39 deletions(-) diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c index 3439ce5feb..4034714773 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.c @@ -494,7 +494,7 @@ BuildGatherList ( } // -// Record descirptor header +// Record descriptor header // if (Index == 0) { BlockDescriptorsHeader = BlockDescriptors1; diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c index 58a93568d0..d623d7c809 100644 --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c @@ -38,7 +38,7 @@ DumpUxCapsule ( { EFI_DISPLAY_CAPSULE *DisplayCapsule; DisplayCapsule = (EFI_DISPLAY_CAPSULE *)CapsuleHeader; - Print(L"[UxCapusule]\n"); + Print(L"[UxCapsule]\n"); Print(L"CapsuleHeader:\n"); Print(L" CapsuleGuid - %g\n", >CapsuleHeader.CapsuleGuid); Print(L" HeaderSize - 0x%x\n", DisplayCapsule->CapsuleHeader.HeaderSize); @@ -199,7 +199,7 @@ DumpCapsule ( DumpFmpCapsule(CapsuleHeader); } if (IsNestedFmpCapsule(CapsuleHeader)) { -Print(L"[NestedCapusule]\n"); +Print(L"[NestedCapsule]\n"); Print(L"CapsuleHeader:\n"); Print(L" CapsuleGuid - %g\n", >CapsuleGuid); Print(L" HeaderSize - 0x%x\n", CapsuleHeader->HeaderSize); @@ -793,7 +793,7 @@ DumpCapsuleFromDisk ( goto Done; } - Print(L"The infomation of the capsules:\n"); + Print(L"The information of the capsules:\n"); for (Index = 0; Index < FileCount; Index++) { FileHandle = NULL; diff --git a/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c b/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c index 968c044a31..d9daf7f86a 100644 --- a/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c +++ b/MdeModulePkg/Library/PlatformVarCleanupLib/PlatVarCleanupLib.c @@ -260,12 +260,12 @@ CreateUserVariableNode ( ASSERT (UserVariableNameNode->PromptString != NULL); UnicodeSPrint (UserVariableNameNode->PromptString, StringSize, L" %s", UserVariableNameNode->Name); // - // (33 chars of "Attribtues = 0x and DataSize = 0x" + 1 terminator + (sizeof (UINT32) + sizeof (UINTN)) * 2) * sizeof (CHAR16). + // (33 chars of "Attributes = 0x and DataSize = 0x" + 1 terminator + (sizeof (UINT32) + sizeof (UINTN)) * 2) * sizeof (CHAR16). // StringSize = (33 + 1 + (sizeof (UINT32) + sizeof (UINTN)) * 2) * sizeof (CHAR16); UserVariableNameNode->HelpString = AllocatePool (StringSize); ASSERT (UserVariableNameNode->HelpString != NULL); - UnicodeSPrint (UserVariableNameNode->HelpString, StringSize, L"Attribtues = 0x%08x and DataSize = 0x%x", UserVariableNameNode->Attributes, UserVariableNameNode->DataSize); + UnicodeSPrint (UserVariableNameNode->HelpString, StringSize, L"Attributes = 0x%08x and DataSize = 0x%x", UserVariableNameNode->Attributes, UserVariableNameNode->DataSize); UserVariableNameNode->Deleted = FALSE; InsertTailList (>NameLink, >Link); Index++; @@ -332,7 +332,7 @@ DestroyUserVariableNode ( it's caller's responsibility to free the memory after using it. @retval EFI_SUCCESS Create time based payload successfully. - @retval EFI_OUT_OF_RESOURCES There are not enough memory resourses to create time based payload. + @retval EFI_OUT_OF_RESOURCES There are not enough memory resources to create time based payload. @retval EFI_INVALID_PARAMETER The parameter is invalid. @retval OthersUnexpected error happens. @@ -416,7 +416,7 @@ CreateTimeBasedPayload ( it's caller's responsibility to free the memory after using it. @retval EFI_SUCCESS Create counter based payload successfully. - @retval EFI_OUT_OF_RESOURCES There are not enough memory resourses to create time based payload. + @retval EFI_OUT_OF_RESOURCES There are not enough memory resources to create time based payload. @retval EFI_INVALID_PARAMETER The parameter is invalid.
[edk2-devel] [PATCH] Revert "FmpDevicePkg: Fix various typos"
This reverts commit f527942e6bdd9f198db90f2de99a0482e9be5b1b. Commit message was incorrect. Signed-off-by: Coeur --- .../FspSecCore/Ia32/FspApiEntryM.nasm | 4 +-- .../FspSecCore/Ia32/InitializeFpu.nasm| 4 +-- .../FspSecCore/Ia32/SaveRestoreSseNasm.inc| 4 +-- IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm | 4 +-- IntelFsp2Pkg/FspSecCore/SecFsp.c | 4 +-- IntelFsp2Pkg/FspSecCore/SecMain.c | 2 +- .../FspSecCore/Vtf0/Ia16/ResetVec.asm16 | 4 +-- IntelFsp2Pkg/Include/FspEas/FspApi.h | 8 ++--- .../Include/Library/FspSecPlatformLib.h | 4 +-- IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c | 12 +++ .../BaseFspDebugLibSerialPort/DebugLib.c | 34 +-- .../BaseFspSwitchStackLib/Ia32/Stack.nasm | 4 +-- .../SecFspSecPlatformLibNull/Ia32/Flat32.nasm | 4 +-- .../PlatformSecLibNull.c | 4 +-- IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +- IntelFsp2Pkg/Tools/PatchFv.py | 2 +- .../Tools/UserManuals/GenCfgOptUserManual.md | 2 +- .../Tools/UserManuals/PatchFvUserManual.md| 2 +- 18 files changed, 52 insertions(+), 52 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm index e7261b41cd..f14c18c7b9 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm @@ -194,9 +194,9 @@ StackSetupDone: ; ; Pass BFV into the PEI Core - ; It uses relative address to calculate the actual boot FV base + ; It uses relative address to calucate the actual boot FV base ; For FSP implementation with single FV, PcdFspBootFirmwareVolumeBase and - ; PcdFspAreaBaseAddress are the same. For FSP with multiple FVs, + ; PcdFspAreaBaseAddress are the same. For FSP with mulitple FVs, ; they are different. The code below can handle both cases. ; callASM_PFX(AsmGetFspBaseAddress) diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm index ebc91c41e4..e1886ea11b 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm @@ -1,6 +1,6 @@ ;-- ; -; Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved. +; Copyright (c) 2015, Intel Corporation. All rights reserved. ; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; Abstract: @@ -46,7 +46,7 @@ ASM_PFX(InitializeFloatingPointUnits): fldcw[ASM_PFX(mFpuControlWord)] ; -; Use CpuId instruction (CPUID.01H:EDX.SSE[bit 25] = 1) to test +; Use CpuId instructuion (CPUID.01H:EDX.SSE[bit 25] = 1) to test ; whether the processor supports SSE instruction. ; mov eax, 1 diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc b/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc index 4c321cbece..b257deb76c 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc +++ b/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc @@ -1,6 +1,6 @@ ;-- ; -; Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved. +; Copyright (c) 2015, Intel Corporation. All rights reserved. ; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; Abstract: @@ -150,7 +150,7 @@ NextAddress: fldcw [FpuControlWord] ; -; Use CpuId instruction (CPUID.01H:EDX.SSE[bit 25] = 1) to test +; Use CpuId instructuion (CPUID.01H:EDX.SSE[bit 25] = 1) to test ; whether the processor supports SSE instruction. ; mov eax, 1 diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm index 5a7e27c240..d72212ed45 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm @@ -1,6 +1,6 @@ ;-- ; -; Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved. +; Copyright (c) 2015, Intel Corporation. All rights reserved. ; SPDX-License-Identifier: BSD-2-Clause-Patent ; ; Abstract: @@ -58,7 +58,7 @@ ASM_PFX(SecSwitchStack): mov esp, eax ; From now, esp is pointed to permanent memory ; -; Fixup the ebp point to permanent memory +; Fixup the ebp point to permenent memory ; mov eax, ebp sub eax, ebx diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.c b/IntelFsp2Pkg/FspSecCore/SecFsp.c index 446d1730e9..6497c88ebe 100644 --- a/IntelFsp2Pkg/FspSecCore/SecFsp.c +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved. + Copyright (c) 2014 - 2018, Intel Corporation. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@
[edk2-devel] [PATCH] Revert "FmpDevicePkg: Fix various typos" + Reapply as "IntelFsp2Pkg: Fix various typos"
Two patches attached: 1. revert f527942e6bdd9f198db90f2de99a0482e9be5b1b, because the commit message was incorrect. 2. reapply it with a correct commit message. If you apply both patches, the balance of changes should be zero (except for the commit messages). Sorry for the confusion. Coeur -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43588): https://edk2.groups.io/g/devel/message/43588 Mute This Topic: https://groups.io/mt/32428310/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=- patch1.diff Description: Binary data patch2.diff Description: Binary data
Re: [edk2-devel] [PATCH] FmpDevicePkg: Fix various typos
On Mon, Jul 8, 2019 at 09:21 AM, Liming Gao wrote: > > Please add Signed-off-by: your name. I'll do that in the future. Consider it's the following for past emails/patches: Signed-off-by: Cœur -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43410): https://edk2.groups.io/g/devel/message/43410 Mute This Topic: https://groups.io/mt/32317809/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] FmpDevicePkg: Fix various typos
Fix one typo in FmpDevicePkg. --- FmpDevicePkg/FmpDxe/DetectTestKey.c | 2 +- FmpDevicePkg/Include/Library/FmpDeviceLib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c b/FmpDevicePkg/FmpDxe/DetectTestKey.c index 52e780dac8..e697a08489 100644 --- a/FmpDevicePkg/FmpDxe/DetectTestKey.c +++ b/FmpDevicePkg/FmpDxe/DetectTestKey.c @@ -139,7 +139,7 @@ DetectTestKey ( } // - // If test key detected or an error occured checking for the test key, then + // If test key detected or an error occurred checking for the test key, then // set PcdTestKeyUsed to TRUE. // if (TestKeyUsed) { diff --git a/FmpDevicePkg/Include/Library/FmpDeviceLib.h b/FmpDevicePkg/Include/Library/FmpDeviceLib.h index 708ebca8c5..c435b23030 100644 --- a/FmpDevicePkg/Include/Library/FmpDeviceLib.h +++ b/FmpDevicePkg/Include/Library/FmpDeviceLib.h @@ -73,7 +73,7 @@ RegisterFmpInstaller ( @retval EFI_INVALID_PARAMETER Size is NULL. @retval EFI_UNSUPPORTEDThe firmware device does not support reporting the size of the currently stored firmware image. - @retval EFI_DEVICE_ERROR An error occured attempting to determine the + @retval EFI_DEVICE_ERROR An error occurred attempting to determine the size of the firmware image currently stored in in the firmware device. -- 2.20.1 (Apple Git-117) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43364): https://edk2.groups.io/g/devel/message/43364 Mute This Topic: https://groups.io/mt/32317809/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] IntelFsp2Pkg: Fix various typos
Fix various typos in IntelFsp2Pkg. --- .../FspSecCore/Ia32/FspApiEntryM.nasm | 4 +-- .../FspSecCore/Ia32/InitializeFpu.nasm| 2 +- .../FspSecCore/Ia32/SaveRestoreSseNasm.inc| 2 +- IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm | 2 +- IntelFsp2Pkg/FspSecCore/SecFsp.c | 2 +- IntelFsp2Pkg/FspSecCore/SecMain.c | 2 +- .../FspSecCore/Vtf0/Ia16/ResetVec.asm16 | 2 +- IntelFsp2Pkg/Include/FspEas/FspApi.h | 6 ++-- .../Include/Library/FspSecPlatformLib.h | 2 +- IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c | 10 +++--- .../BaseFspDebugLibSerialPort/DebugLib.c | 34 +-- .../BaseFspSwitchStackLib/Ia32/Stack.nasm | 2 +- .../SecFspSecPlatformLibNull/Ia32/Flat32.nasm | 2 +- .../PlatformSecLibNull.c | 2 +- IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +- IntelFsp2Pkg/Tools/PatchFv.py | 2 +- .../Tools/UserManuals/GenCfgOptUserManual.md | 2 +- .../Tools/UserManuals/PatchFvUserManual.md| 2 +- 18 files changed, 41 insertions(+), 41 deletions(-) diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm index f14c18c7b9..e7261b41cd 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm @@ -194,9 +194,9 @@ StackSetupDone: ; ; Pass BFV into the PEI Core - ; It uses relative address to calucate the actual boot FV base + ; It uses relative address to calculate the actual boot FV base ; For FSP implementation with single FV, PcdFspBootFirmwareVolumeBase and - ; PcdFspAreaBaseAddress are the same. For FSP with mulitple FVs, + ; PcdFspAreaBaseAddress are the same. For FSP with multiple FVs, ; they are different. The code below can handle both cases. ; callASM_PFX(AsmGetFspBaseAddress) diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm index e1886ea11b..c45520c6c1 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/InitializeFpu.nasm @@ -46,7 +46,7 @@ ASM_PFX(InitializeFloatingPointUnits): fldcw[ASM_PFX(mFpuControlWord)] ; -; Use CpuId instructuion (CPUID.01H:EDX.SSE[bit 25] = 1) to test +; Use CpuId instruction (CPUID.01H:EDX.SSE[bit 25] = 1) to test ; whether the processor supports SSE instruction. ; mov eax, 1 diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc b/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc index b257deb76c..09cb813497 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc +++ b/IntelFsp2Pkg/FspSecCore/Ia32/SaveRestoreSseNasm.inc @@ -150,7 +150,7 @@ NextAddress: fldcw [FpuControlWord] ; -; Use CpuId instructuion (CPUID.01H:EDX.SSE[bit 25] = 1) to test +; Use CpuId instruction (CPUID.01H:EDX.SSE[bit 25] = 1) to test ; whether the processor supports SSE instruction. ; mov eax, 1 diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm b/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm index d72212ed45..f183d0d10b 100644 --- a/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm +++ b/IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm @@ -58,7 +58,7 @@ ASM_PFX(SecSwitchStack): mov esp, eax ; From now, esp is pointed to permanent memory ; -; Fixup the ebp point to permenent memory +; Fixup the ebp point to permanent memory ; mov eax, ebp sub eax, ebx diff --git a/IntelFsp2Pkg/FspSecCore/SecFsp.c b/IntelFsp2Pkg/FspSecCore/SecFsp.c index 6497c88ebe..a939b7e836 100644 --- a/IntelFsp2Pkg/FspSecCore/SecFsp.c +++ b/IntelFsp2Pkg/FspSecCore/SecFsp.c @@ -169,7 +169,7 @@ FspGlobalDataInit ( SerialPortInitialize (); // - // Ensure the golbal data pointer is valid + // Ensure the global data pointer is valid // ASSERT (GetFspGlobalDataPointer () == PeiFspData); diff --git a/IntelFsp2Pkg/FspSecCore/SecMain.c b/IntelFsp2Pkg/FspSecCore/SecMain.c index cd3ab46ce2..a63d1336e4 100644 --- a/IntelFsp2Pkg/FspSecCore/SecMain.c +++ b/IntelFsp2Pkg/FspSecCore/SecMain.c @@ -110,7 +110,7 @@ SecStartup ( // |---|> // | | // | | - // | Heap |PeiTemporayRamSize + // | Heap |PeiTemporaryRamSize // | | // | | // |---|> TempRamBase diff --git a/IntelFsp2Pkg/FspSecCore/Vtf0/Ia16/ResetVec.asm16 b/IntelFsp2Pkg/FspSecCore/Vtf0/Ia16/ResetVec.asm16 index f25de0206a..e16d692a76 100644 --- a/IntelFsp2Pkg/FspSecCore/Vtf0/Ia16/ResetVec.asm16 +++ b/IntelFsp2Pkg/FspSecCore/Vtf0/Ia16/ResetVec.asm16 @@ -61,7 +61,7 @@ ApStartup: ; ; Jmp Rel16 instruction ; Use machine code directly in case of the assembler optimization -; SEC entry point relatvie address will be fixed up by
[edk2-devel] [PATCH] SignedCapsulePkg: Fix various typos
Fix various typos in SignedCapsulePkg. --- .../Include/Guid/EdkiiSystemFmpCapsule.h | 4 +-- .../Include/Library/IniParsingLib.h | 14 +- .../Library/IniParsingLib/IniParsingLib.c | 26 +-- SignedCapsulePkg/SignedCapsulePkg.dec | 4 +-- .../ParseConfigProfile.c | 2 +- .../RecoveryModuleLoadPei.c | 14 +- .../SystemFirmwareUpdate/ParseConfigProfile.c | 2 +- .../SystemFirmwareCommonDxe.c | 4 +-- .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 2 +- .../SystemFirmwareReportDxe.c | 8 +++--- .../SystemFirmwareUpdateDxe.c | 4 +-- 11 files changed, 42 insertions(+), 42 deletions(-) diff --git a/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h b/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h index 1129d715ae..8295f92a73 100644 --- a/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h +++ b/SignedCapsulePkg/Include/Guid/EdkiiSystemFmpCapsule.h @@ -60,7 +60,7 @@ ImageOffset = # Fv offset of this SystemFirmware image (HEX) FileGuid= ---- # PcdEdkiiSystemFirmwareFileGuid - NOTE: The [Name?] entry may have differnt FileGuid. + NOTE: The [Name?] entry may have different FileGuid. Only the one, whose FileGuid matches PcdEdkiiSystemFirmwareFileGuid, takes effect. The other entry is ignored. @@ -80,7 +80,7 @@ ImageOffset = # Image offset of this SystemFirmware image (HEX) FileGuid= ---- # PcdEdkiiSystemFirmwareFileGuid - NOTE: The [Name?] entry may have differnt FileGuid. + NOTE: The [Name?] entry may have different FileGuid. Only the one, whose FileGuid matches PcdEdkiiSystemFirmwareFileGuid, takes effect. The other entry is ignored. diff --git a/SignedCapsulePkg/Include/Library/IniParsingLib.h b/SignedCapsulePkg/Include/Library/IniParsingLib.h index 26d100ffde..edfdde7e8d 100644 --- a/SignedCapsulePkg/Include/Library/IniParsingLib.h +++ b/SignedCapsulePkg/Include/Library/IniParsingLib.h @@ -14,7 +14,7 @@ 3.1) an ASCII String. The valid format is [A-Za-z0-9_]+ 3.2) a GUID. The valid format is ----, where x is [A-Fa-f0-9] 3.3) a decimal value. The valid format is [0-9]+ - 3.4) a heximal value. The valid format is 0x[A-Fa-f0-9]+ + 3.4) a hexadecimal value. The valid format is 0x[A-Fa-f0-9]+ 4) '#' or ';' can be used as comment at anywhere. 5) TAB(0x20) or SPACE(0x9) can be used as separator. 6) LF(\n, 0xA) or CR(\r, 0xD) can be used as line break. @@ -106,14 +106,14 @@ GetDecimalUintnFromDataFile ( ); /** - Get section entry heximal UINTN value. + Get section entry hexadecimal UINTN value. @param[in] Context INI Config file context. @param[in] SectionName Section name. @param[in] EntryName Section entry name. - @param[out] DataPoint to the got heximal UINTN value. + @param[out] DataPoint to the got hexadecimal UINTN value. - @retval EFI_SUCCESSSection entry heximal UINTN value is got. + @retval EFI_SUCCESSSection entry hexadecimal UINTN value is got. @retval EFI_NOT_FOUND Section is not found. **/ EFI_STATUS @@ -126,14 +126,14 @@ GetHexUintnFromDataFile ( ); /** - Get section entry heximal UINT64 value. + Get section entry hexadecimal UINT64 value. @param[in] Context INI Config file context. @param[in] SectionName Section name. @param[in] EntryName Section entry name. - @param[out] DataPoint to the got heximal UINT64 value. + @param[out] DataPoint to the got hexadecimal UINT64 value. - @retval EFI_SUCCESSSection entry heximal UINT64 value is got. + @retval EFI_SUCCESSSection entry hexadecimal UINT64 value is got. @retval EFI_NOT_FOUND Section is not found. **/ EFI_STATUS diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c index 757d65a206..bea45e0d3b 100644 --- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c +++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c @@ -14,7 +14,7 @@ 3.1) an ASCII String. The valid format is [A-Za-z0-9_]+ 3.2) a GUID. The valid format is ----, where x is [A-Fa-f0-9] 3.3) a decimal value. The valid format is [0-9]+ - 3.4) a heximal value. The valid format is 0x[A-Fa-f0-9]+ + 3.4) a hexadecimal value. The valid format is 0x[A-Fa-f0-9]+ 4) '#' or ';' can be used as comment at anywhere. 5) TAB(0x20) or SPACE(0x9) can be used as separator. 6) LF(\n, 0xA) or CR(\r, 0xD) can be used as line break. @@ -165,13 +165,13 @@ IsValidDecimalString ( } /** - Return if the heximal string is valid. + Return if the hexadecimal string is valid. - @param[in] Hex The
[edk2-devel] [PATCH] PcAtChipsetPkg: Fix various typos
Fix various typos in PcAtChipsetPkg. --- PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c| 4 ++-- PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf | 2 +- PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni | 2 +- PcAtChipsetPkg/Include/Library/IoApicLib.h | 2 +- PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c | 2 +- PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c | 2 +- PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c | 14 +++--- PcAtChipsetPkg/PcAtChipsetPkg.dec | 2 +- PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.h | 2 +- 9 files changed, 16 insertions(+), 16 deletions(-) diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c b/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c index ded3b53619..1a1ed29e9c 100644 --- a/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c +++ b/PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c @@ -1,5 +1,5 @@ /** @file - Timer Architectural Protocol module using High Precesion Event Timer (HPET) + Timer Architectural Protocol module using High Precision Event Timer (HPET) Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -246,7 +246,7 @@ HpetRead ( /** Write a 64-bit HPET register. - @param Offset Specifies the ofsfert of the HPET register to write. + @param Offset Specifies the offset of the HPET register to write. @param Value Specifies the value to write to the HPET register specified by Offset. @return The 64-bit value written to HPET register specified by Offset. diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf b/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf index ba2e075118..125eea0aab 100644 --- a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf +++ b/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf @@ -1,5 +1,5 @@ ## @file -# Timer Architectural Protocol module using High Precesion Event Timer (HPET). +# Timer Architectural Protocol module using High Precision Event Timer (HPET). # # Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved. # SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni b/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni index e2320653b6..7d1797b1df 100644 --- a/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni +++ b/PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni @@ -1,5 +1,5 @@ // /** @file -// Timer Architectural Protocol module using High Precesion Event Timer (HPET). +// Timer Architectural Protocol module using High Precision Event Timer (HPET). // // Timer Architectural Protocol module using High Precision Event Timer (HPET). // diff --git a/PcAtChipsetPkg/Include/Library/IoApicLib.h b/PcAtChipsetPkg/Include/Library/IoApicLib.h index 200ef731fb..4ee092c0f2 100644 --- a/PcAtChipsetPkg/Include/Library/IoApicLib.h +++ b/PcAtChipsetPkg/Include/Library/IoApicLib.h @@ -63,7 +63,7 @@ IoApicEnableInterrupt ( Configures an I/O APIC interrupt. Configure an I/O APIC Redirection Table Entry to deliver an interrupt in physical - mode to the Local APIC of the currntly executing CPU. The default state of the + mode to the Local APIC of the currently executing CPU. The default state of the entry is for the interrupt to be disabled (masked). IoApicEnableInterrupts() must be used to enable(unmask) the I/O APIC Interrupt. diff --git a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c index 7dc11014a5..0a49093dbf 100644 --- a/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c +++ b/PcAtChipsetPkg/Library/AcpiTimerLib/AcpiTimerLib.c @@ -59,7 +59,7 @@ AcpiTimerLibConstructor ( // // If the register offset to the BAR for the ACPI I/O Port Base Address is 0x, then - // no PCI register programming is required to enable access to the the ACPI registers + // no PCI register programming is required to enable access to the ACPI registers // specified by PcdAcpiIoPortBaseAddress // if (PcdGet16 (PcdAcpiIoPciBarRegisterOffset) == 0x) { diff --git a/PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c b/PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c index 7a3c9aca8d..9e4a58049e 100644 --- a/PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c +++ b/PcAtChipsetPkg/Library/BaseIoApicLib/IoApicLib.c @@ -94,7 +94,7 @@ IoApicEnableInterrupt ( Configures an I/O APIC interrupt. Configure an I/O APIC Redirection Table Entry to deliver an interrupt in physical - mode to the Local APIC of the currntly executing CPU. The default state of the + mode to the Local APIC of the currently executing CPU. The default state of the entry is for the interrupt to be disabled (masked). IoApicEnableInterrupts() must be used to enable(unmask) the I/O APIC Interrupt. diff --git a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c b/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c index 93affe151e..aa5657a7fd 100644 --- a/PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c +++
Re: [edk2-devel] [PATCH] BaseTools: Fix encoding typos
I didn't kept that specific patch. Anyway, if Pccts is dead, let's forget about that one. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43352): https://edk2.groups.io/g/devel/message/43352 Mute This Topic: https://groups.io/mt/32250884/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] EmbeddedPkg: Fix various typos
On Thu, Jul 4, 2019 at 09:01 PM, Leif Lindholm wrote: > > Urgh, don't make me elaborate on the implications of public domain > versus copyright... If you're interested, have a look at > https://wiki.spdx.org/view/Legal_Team/Decisions/Dealing_with_Public_Domain_within_SPDX_Files > This link says: > Some commonly used “Public Domain dedications” have already been included in > the SPDX License List (e.g., ANTLR, Sax, CC-0). And CC-0 was what I was proposing; I'm aware of the difference with American Public Domain, as, for the record, I'm an elected Wikipedia Administrator, so I've also had my share of licensing questions. Anyway, BSD+Patent is really fine by me. On Thu, Jul 4, 2019 at 09:01 PM, Leif Lindholm wrote: > > Out of interest - how did you find all these typos? I hope it was > something at least semi-automated? I think it was roughly two weeks of review with a spellchecker while being sick in bed. When I started, I never thought it would be so much time consuming. The only folders that I ignored were the AppPkg Python ones. Thank you for the link to GMX Konfiguration, I'll try it for next patch. Antoine -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43275): https://edk2.groups.io/g/devel/message/43275 Mute This Topic: https://groups.io/mt/32238806/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] BaseTools: Fix various typos
Sorry about that, I won't copy-paste anymore. Can you see it with an attachment? Antoine -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43266): https://edk2.groups.io/g/devel/message/43266 Mute This Topic: https://groups.io/mt/32298356/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=- BaseTools_patch.diff Description: Binary data
Re: [edk2-devel] [PATCH] EmbeddedPkg: Fix various typos
On Wed, Jul 3, 2019 at 11:30 PM, Leif Lindholm wrote: > > Normally, we expect patches to be submitted via git send-email, as > opposed to through the groups.io web interface (it introduces > spectacular levels of corruption to the original patch). Hello Leif, and thank you for the message and the review. I wasn't able to configure ` git send-email ` with my provider (GMX), and all the doc and support is in German... so basically I only use emails through web interfaces. I didn't know there was corruption through the web interface: I thought the patch format was ASCII-friendly. If attachments are fine, then that will also be the easiest for me in the future, as I won't need to copy-paste the content anymore. > > so could you confirm whether you are happy to contribute these > patches under BSD+Patent? Sure. I'm fine with any license with all my contributions; so BSD+Patent it is for past and future patches on edk2. Do I need to resubmit anything? Or is this declaration enough for past emails on the mailing list? Actually, I can even share the whole 4000+ typos corrections ( https://github.com/Coeur/edk2/commit/c2eed45a596b42768fe7916fb5491bfc1b9efe0c ) as CC0 ( https://creativecommons.org/publicdomain/zero/1.0/deed ): you can cherry pick from it anytime. I don't think there is any intellectual property possible for spelling corrections anyway. Regards, Antoine Cœur -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43225): https://edk2.groups.io/g/devel/message/43225 Mute This Topic: https://groups.io/mt/32238806/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v2 7/7] EmulatorPkg: Fix various typos
Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/BootModePei/BootModePei.c | 2 +- .../FirmwareVolumePei/FirmwareVolumePei.c | 2 +- EmulatorPkg/Unix/Host/Host.c | 20 +-- EmulatorPkg/Unix/Host/LinuxPacketFilter.c | 2 +- EmulatorPkg/Unix/Host/Pthreads.c | 2 +- EmulatorPkg/Unix/Host/X64/Gasket.S | 4 ++-- EmulatorPkg/Unix/Host/X64/SwitchStack.S | 2 +- 7 files changed, 17 insertions(+), 17 deletions(-) diff --git a/EmulatorPkg/BootModePei/BootModePei.c b/EmulatorPkg/BootModePei/BootModePei.c index a008a2331d..0f8d8f090e 100644 --- a/EmulatorPkg/BootModePei/BootModePei.c +++ b/EmulatorPkg/BootModePei/BootModePei.c @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent // -// The protocols, PPI and GUID defintions for this module +// The protocols, PPI and GUID definitions for this module // #include #include diff --git a/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c b/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c index 4178111096..c8ff6edff3 100644 --- a/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c +++ b/EmulatorPkg/FirmwareVolumePei/FirmwareVolumePei.c @@ -77,7 +77,7 @@ Returns: if (Index == 0) { // // Assume the first FD was produced by the NT32.DSC - // All these strange offests are needed to keep in + // All these strange offsets are needed to keep in // sync with the FlashMap and NT32.dsc file // BuildResourceDescriptorHob ( diff --git a/EmulatorPkg/Unix/Host/Host.c b/EmulatorPkg/Unix/Host/Host.c index febfb1f44c..b6dd41 100644 --- a/EmulatorPkg/Unix/Host/Host.c +++ b/EmulatorPkg/Unix/Host/Host.c @@ -38,7 +38,7 @@ UINTN gFdInfoCount = 0; EMU_FD_INFO *gFdInfo; // -// Array that supports seperate memory rantes. +// Array that supports separate memory ranges. // The memory ranges are set in system.cmd via the EFI_MEMORY_SIZE variable. // The number of array elements is allocated base on parsing // EFI_MEMORY_SIZE and the memory is never freed. @@ -379,7 +379,7 @@ Arguments: Returns: EFI_SUCCESS - The file was opened and mapped. EFI_NOT_FOUND - FileName was not found in the current directory - EFI_DEVICE_ERROR - An error occured attempting to map the opened file + EFI_DEVICE_ERROR - An error occurred attempting to map the opened file **/ EFI_STATUS @@ -523,7 +523,7 @@ Arguments: PeiCorePe32File - SEC PE32 Returns: - Success means control is transfered and thus we should never return + Success means control is transferred and thus we should never return **/ VOID @@ -611,7 +611,7 @@ Routine Description: It allows discontinuous memory regions to be supported by the emulator. It uses gSystemMemory[] and gSystemMemoryCount that were created by parsing the host environment variable EFI_MEMORY_SIZE. - The size comes from the varaible and the address comes from the call to + The size comes from the variable and the address comes from the call to UnixOpenFile. Arguments: @@ -661,7 +661,7 @@ Routine Description: This is all of GCD for system memory passed to DXE Core. FV mapping and other device mapped into system memory are not - inlcuded in the check. + included in the check. Arguments: Index - Which memory region to use @@ -898,7 +898,7 @@ Routine Description: The ModHandle is needed to unload the image. Arguments: - ImageContext - Input data returned from PE Laoder Library. Used to find the + ImageContext - Input data returned from PE Loader Library. Used to find the .PDB file name of the PE Image. ModHandle - Returned from LoadLibraryEx() and stored for call to FreeLibrary(). @@ -922,7 +922,7 @@ AddHandle ( for (Index = 0; Index < mImageContextModHandleArraySize; Index++, Array++) { if (Array->ImageContext == NULL) { // - // Make a copy of the stirng and store the ModHandle + // Make a copy of the string and store the ModHandle // Array->ImageContext = ImageContext; Array->ModHandle = ModHandle; @@ -933,7 +933,7 @@ AddHandle ( // // No free space in mImageContextModHandleArray so grow it by // IMAGE_CONTEXT_TO_MOD_HANDLE entires. realloc will - // copy the old values to the new locaiton. But it does + // copy the old values to the new location. But it does // not zero the new memory area. // PreviousSize = mImageContextModHandleArraySize * sizeof (IMAGE_CONTEXT_TO_MOD_HANDLE); @@ -961,11 +961,11 @@ Routine Description: Return the ModHandle and delete the entry in the array. Arguments: - ImageContext - Input data returned from PE Laoder Library. Used to find the + ImageContext - Input data returned from PE Loader Library. Used to find the .PDB file name of the PE Image. Returns: - ModHandle - ModHandle assoicated with ImageContext is returned + ModHandle - ModHandle associated with ImageContext is returned NULL - No ModHandle associated with ImageContext **/ diff --git a/EmulatorPkg/Unix/Host/LinuxPacketFilter.c
[edk2-devel] [PATCH v2 6/7] EmulatorPkg: Fix various typos
Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Unix/GdbRun.sh | 4 ++-- EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 2 +- EmulatorPkg/Unix/Host/BlockIo.c | 12 ++-- EmulatorPkg/Unix/Host/EmuThunk.c | 2 +- EmulatorPkg/Unix/lldbefi.py | 14 +++--- 5 files changed, 17 insertions(+), 17 deletions(-) diff --git a/EmulatorPkg/Unix/GdbRun.sh b/EmulatorPkg/Unix/GdbRun.sh index 8c761ff2c9..b050ad5e2c 100644 --- a/EmulatorPkg/Unix/GdbRun.sh +++ b/EmulatorPkg/Unix/GdbRun.sh @@ -62,8 +62,8 @@ define RemoveFirmwareSymbolFile end if gInXcode == 1 - # in Xcode the program is already runing. Issuing a run command - # will cause a fatal debugger error. The break point sciprt that + # in Xcode the program is already running. Issuing a run command + # will cause a fatal debugger error. The break point script that # is used to source this script sets gInCode to 1. else # diff --git a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c index e318a90740..dcc315ac72 100644 --- a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c +++ b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c @@ -5,7 +5,7 @@ Tested on Mac OS X. Copyright (c) 2004 - 2009, Intel Corporation. All rights reserved. -Portitions copyright (c) 2011, Apple Inc. All rights reserved. +Portions copyright (c) 2011, Apple Inc. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/EmulatorPkg/Unix/Host/BlockIo.c b/EmulatorPkg/Unix/Host/BlockIo.c index 07e39347e4..18368060d5 100644 --- a/EmulatorPkg/Unix/Host/BlockIo.c +++ b/EmulatorPkg/Unix/Host/BlockIo.c @@ -398,7 +398,7 @@ EmuBlockIoReadBlocks ( Done: if (Token != NULL) { if (Token->Event != NULL) { - // Caller is responcible for signaling EFI Event + // Caller is responsible for signaling EFI Event Token->TransactionStatus = Status; return EFI_SUCCESS; } @@ -429,7 +429,7 @@ Done: the Event is NULL. @retval EFI_WRITE_PROTECTED The device can not be written to. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_DEVICE_ERROR The device reported an error while performing the write. @retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device. @retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid, @@ -477,7 +477,7 @@ EmuBlockIoWriteBlocks ( Done: if (Token != NULL) { if (Token->Event != NULL) { - // Caller is responcible for signaling EFI Event + // Caller is responsible for signaling EFI Event Token->TransactionStatus = Status; return EFI_SUCCESS; } @@ -500,7 +500,7 @@ Done: @retval EFI_SUCCESS The flush request was queued if Event is not NULL. All outstanding data was written correctly to the device if the Event is NULL. - @retval EFI_DEVICE_ERROR The device reported an error while writting back + @retval EFI_DEVICE_ERROR The device reported an error while writing back the data. @retval EFI_WRITE_PROTECTED The device cannot be written to. @retval EFI_NO_MEDIA There is no media in the device. @@ -529,7 +529,7 @@ EmuBlockIoFlushBlocks ( if (Token != NULL) { if (Token->Event != NULL) { - // Caller is responcible for signaling EFI Event + // Caller is responsible for signaling EFI Event Token->TransactionStatus = EFI_SUCCESS; return EFI_SUCCESS; } @@ -544,7 +544,7 @@ EmuBlockIoFlushBlocks ( @param[in] This Indicates a pointer to the calling context. @param[in] ExtendedVerification Indicates that the driver may perform a more - exhausive verfication operation of the device + exhaustive verification operation of the device during reset. @retval EFI_SUCCESS The device was reset. diff --git a/EmulatorPkg/Unix/Host/EmuThunk.c b/EmulatorPkg/Unix/Host/EmuThunk.c index f1330c8234..b831c67946 100644 --- a/EmulatorPkg/Unix/Host/EmuThunk.c +++ b/EmulatorPkg/Unix/Host/EmuThunk.c @@ -6,7 +6,7 @@ The mUnixThunkTable exists so that a change to EFI_EMU_THUNK_PROTOCOL will cause an error in initializing the array if all the member functions are not added. It looks like adding a element to end and not initializing - it may cause the table to be initaliized with the members at the end being + it may cause the table to be initialized with the members at the end being set to zero. This is bad as jumping to zero will crash. Copyright (c) 2004 - 2009, Intel Corporation. All rights reserved. diff --git a/EmulatorPkg/Unix/lldbefi.py b/EmulatorPkg/Unix/lldbefi.py index 218326b8cb..f3e35865c2 100755 --- a/EmulatorPkg/Unix/lldbefi.py +++ b/EmulatorPkg/Unix/lldbefi.py @@ -1,7 +1,7 @@ #!/usr/bin/python # -# Copyright 2014
[edk2-devel] [PATCH v2 5/7] EmulatorPkg: Fix various typos
Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Sec/Ia32/SwitchRam.S | 18 +- EmulatorPkg/Sec/Ia32/SwitchRam.asm | 20 ++-- EmulatorPkg/Sec/Sec.c | 5 ++--- EmulatorPkg/Sec/Sec.h | 4 ++-- EmulatorPkg/Sec/X64/SwitchRam.S | 2 +- EmulatorPkg/Sec/X64/SwitchRam.asm | 2 +- 6 files changed, 25 insertions(+), 26 deletions(-) diff --git a/EmulatorPkg/Sec/Ia32/SwitchRam.S b/EmulatorPkg/Sec/Ia32/SwitchRam.S index f24529cc8e..d8298223a9 100644 --- a/EmulatorPkg/Sec/Ia32/SwitchRam.S +++ b/EmulatorPkg/Sec/Ia32/SwitchRam.S @@ -9,7 +9,7 @@ # # Abstract: # -# Switch the stack from temporary memory to permenent memory. +# Switch the stack from temporary memory to permanent memory. # #-- @@ -36,7 +36,7 @@ ASM_PFX(SecSwitchStack): # # !!CAUTION!! this function address's is pushed into stack after -# migration of whole temporary memory, so need save it to permenent +# migration of whole temporary memory, so need save it to permanent # memory at first! # @@ -44,14 +44,14 @@ ASM_PFX(SecSwitchStack): movl 24(%esp), %ecx # Save the second parameter # -# Save this function's return address into permenent memory at first. -# Then, Fixup the esp point to permenent memory +# Save this function's return address into permanent memory at first. +# Then, Fixup the esp point to permanent memory # movl %esp, %eax subl %ebx, %eax addl %ecx, %eax - movl (%esp), %edx # copy pushed register's value to permenent memory + movl (%esp), %edx # copy pushed register's value to permanent memory movl %edx, (%eax) movl 4(%esp), %edx movl %edx, 4(%eax) @@ -61,16 +61,16 @@ ASM_PFX(SecSwitchStack): movl %edx, 12(%eax) movl 16(%esp), %edx movl %edx, 16(%eax) - movl %eax, %esp # From now, esp is pointed to permenent memory + movl %eax, %esp # From now, esp is pointed to permanent memory # -# Fixup the ebp point to permenent memory +# Fixup the ebp point to permanent memory # #ifndef __APPLE__ movl %ebp, %eax subl %ebx, %eax addl %ecx, %eax - movl %eax, %ebp # From now, ebp is pointed to permenent memory + movl %eax, %ebp # From now, ebp is pointed to permanent memory # # Fixup callee's ebp point for PeiDispatch @@ -78,7 +78,7 @@ ASM_PFX(SecSwitchStack): movl (%ebp), %eax subl %ebx, %eax addl %ecx, %eax - movl %eax, (%ebp) # From now, Temporary's PPI caller's stack is in permenent memory + movl %eax, (%ebp) # From now, Temporary's PPI caller's stack is in permanent memory #endif pop %edx diff --git a/EmulatorPkg/Sec/Ia32/SwitchRam.asm b/EmulatorPkg/Sec/Ia32/SwitchRam.asm index 9c7908f7a0..99ef002980 100644 --- a/EmulatorPkg/Sec/Ia32/SwitchRam.asm +++ b/EmulatorPkg/Sec/Ia32/SwitchRam.asm @@ -9,7 +9,7 @@ ; ; Abstract: ; -; Switch the stack from temporary memory to permenent memory. +; Switch the stack from temporary memory to permanent memory. ; ;-- @@ -36,7 +36,7 @@ SecSwitchStack PROC ; ; !!CAUTION!! this function address's is pushed into stack after - ; migration of whole temporary memory, so need save it to permenent + ; migration of whole temporary memory, so need save it to permanent ; memory at first! ; @@ -44,13 +44,13 @@ SecSwitchStack PROC mov ecx, [esp + 24] ; Save the second parameter ; - ; Save this function's return address into permenent memory at first. - ; Then, Fixup the esp point to permenent memory + ; Save this function's return address into permanent memory at first. + ; Then, Fixup the esp point to permanent memory ; mov eax, esp sub eax, ebx add eax, ecx - mov edx, dword ptr [esp] ; copy pushed register's value to permenent memory + mov edx, dword ptr [esp] ; copy pushed register's value to permanent memory mov dword ptr [eax], edx mov edx, dword ptr [esp + 4] mov dword ptr [eax + 4], edx @@ -58,17 +58,17 @@ SecSwitchStack PROC mov dword ptr [eax + 8], edx mov edx, dword ptr [esp + 12] mov dword ptr [eax + 12], edx - mov edx, dword ptr [esp + 16] ; Update this function's return address into permenent memory + mov edx, dword ptr [esp + 16] ; Update this function's return address into permanent memory mov dword ptr [eax + 16], edx - mov esp, eax ; From now, esp is pointed to permenent memory + mov esp, eax ; From now, esp is pointed to permanent memory ; - ; Fixup the ebp point to permenent memory + ; Fixup the ebp point to permanent memory ; mov eax, ebp sub eax, ebx add eax, ecx - mov ebp, eax ; From now, ebp is pointed to permenent
[edk2-devel] [PATCH v2 2/7] EmulatorPkg: Fix various typos
Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c | 2 +- EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c | 10 +- EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c | 2 +- .../FvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf | 4 ++-- EmulatorPkg/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 4 ++-- EmulatorPkg/PlatformSmbiosDxe/SmbiosTable.c | 2 +- EmulatorPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 10 +- EmulatorPkg/TimerDxe/Timer.c | 2 +- 8 files changed, 18 insertions(+), 18 deletions(-) diff --git a/EmulatorPkg/EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c b/EmulatorPkg/EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c index 6cea25b140..a0fddff1f7 100644 --- a/EmulatorPkg/EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c +++ b/EmulatorPkg/EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c @@ -700,7 +700,7 @@ EmuSimpleFileSystemDriverBindingSupported ( @retval EFI_SUCCESS The device was started. @retval EFI_DEVICE_ERROR The device could not be started due to a device error.Currently not implemented. @retval EFI_OUT_OF_RESOURCES The request could not be completed due to a lack of resources. - @retval Others The driver failded to start the device. + @retval Others The driver failed to start the device. **/ EFI_STATUS diff --git a/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c b/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c index db028c9e92..e47f20fe0e 100644 --- a/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c +++ b/EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c @@ -137,7 +137,7 @@ Arguments: returned Global - Pointer to ESAL_FWB_GLOBAL that contains all instance data - FwhInstance - The EFI_FW_VOL_INSTANCE fimrware instance structure + FwhInstance - The EFI_FW_VOL_INSTANCE firmware instance structure Virtual - Whether CPU is in virtual or physical mode Returns: @@ -956,7 +956,7 @@ Routine Description: Writes data beginning at Lba:Offset from FV. The write terminates either when *NumBytes of data have been written, or when a block boundary is reached. *NumBytes is updated to reflect the actual number of bytes - written. The write opertion does not include erase. This routine will + written. The write operation does not include erase. This routine will attempt to write only the specified bytes. If the writes do not stick, it will return an error. @@ -1004,7 +1004,7 @@ Routine Description: Reads data beginning at Lba:Offset from FV. The Read terminates either when *NumBytes of data have been read, or when a block boundary is reached. *NumBytes is updated to reflect the actual number of bytes - written. The write opertion does not include erase. This routine will + written. The write operation does not include erase. This routine will attempt to write only the specified bytes. If the writes do not stick, it will return an error. @@ -1185,7 +1185,7 @@ Returns: // // Only need to allocate once. There is only one copy of physical memory for // the private data of each FV instance. But in virtual mode or in physical - // mode, the address of the the physical memory may be different. + // mode, the address of the physical memory may be different. // Status = gBS->AllocatePool ( EfiRuntimeServicesData, @@ -1313,7 +1313,7 @@ Returns: ASSERT_EFI_ERROR (Status); } else if (IsDevicePathEnd (TempFwbDevicePath)) { // - // Device allready exists, so reinstall the FVB protocol + // Device already exists, so reinstall the FVB protocol // Status = gBS->HandleProtocol ( FwbHandle, diff --git a/EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c b/EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c index af8f9a9831..386d6e63d8 100644 --- a/EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c +++ b/EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c @@ -81,7 +81,7 @@ EFI_FVB_MEDIA_INFO mPlatformFvbMediaInfo[] = { } }, // - // Systen NvStorage FVB + // System NvStorage FVB // { FixedPcdGet32 (PcdFlashNvStorageVariableSize) + \ diff --git a/EmulatorPkg/FvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf b/EmulatorPkg/FvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf index 7ef0288275..c117c7ee2b 100644 --- a/EmulatorPkg/FvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf +++ b/EmulatorPkg/FvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf @@ -1,7 +1,7 @@ ## @file -# Component description file for Emu Fimware Volume Block DXE driver module. +# Component description file for Emu Firmware Volume Block DXE driver module. # -# This DXE runtime driver implements and produces the Fimware Volue Block Protocol on +# This DXE runtime driver implements and produces the Firmware Volue Block Protocol on # Emu emulator. # Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved. # Portions copyright (c) 2011, Apple Inc. All rights reserved.
[edk2-devel] [PATCH v2 3/7] EmulatorPkg: Fix various typos
Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Include/Library/EmuThunkLib.h | 2 +- EmulatorPkg/Include/Library/SmbiosLib.h | 12 ++-- EmulatorPkg/Include/Protocol/EmuBlockIo.h | 6 +++--- EmulatorPkg/Include/Protocol/EmuGraphicsWindow.h | 2 +- EmulatorPkg/Include/Protocol/EmuSnp.h | 4 ++-- EmulatorPkg/Include/Protocol/EmuThunk.h | 4 ++-- EmulatorPkg/Win/Host/WinGopScreen.c | 2 +- EmulatorPkg/Win/Host/WinHost.c | 2 +- 8 files changed, 17 insertions(+), 17 deletions(-) diff --git a/EmulatorPkg/Include/Library/EmuThunkLib.h b/EmulatorPkg/Include/Library/EmuThunkLib.h index ddb3d59b00..43cb39f47f 100644 --- a/EmulatorPkg/Include/Library/EmuThunkLib.h +++ b/EmulatorPkg/Include/Library/EmuThunkLib.h @@ -15,7 +15,7 @@ extern EMU_THUNK_PROTOCOL *gEmuThunk; /** - Serach the EMU IO Thunk database for a matching EMU IO Thunk + Search the EMU IO Thunk database for a matching EMU IO Thunk Protocol instance. @param Protocol Protocol to search for. diff --git a/EmulatorPkg/Include/Library/SmbiosLib.h b/EmulatorPkg/Include/Library/SmbiosLib.h index 1022b48c5e..4e96b7c31e 100644 --- a/EmulatorPkg/Include/Library/SmbiosLib.h +++ b/EmulatorPkg/Include/Library/SmbiosLib.h @@ -4,7 +4,7 @@ Copyright (c) 2012, Apple Inc. All rights reserved. -Portitions Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved. +Portions Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -24,8 +24,8 @@ extern EFI_SMBIOS_PROTOCOL *gSmbios; /// /// Template for SMBIOS table initialization. -/// The SMBIOS_TABLE_STRING types in the formated area must match the -/// StringArray sequene. +/// The SMBIOS_TABLE_STRING types in the formatted area must match the +/// StringArray sequence. /// typedef struct { // @@ -143,7 +143,7 @@ SmbiosLibUpdateUnicodeString ( Allow caller to read a specific SMBIOS string @param[in] Header SMBIOS record that contains the string. - @param[in[ StringNumber Instance of SMBIOS string 1 - N. + @param[in] StringNumber Instance of SMBIOS string 1 - N. @retval NULL Instance of Type SMBIOS string was not found. @retval Other Pointer to matching SMBIOS string. @@ -157,10 +157,10 @@ SmbiosLibReadString ( /** - Allow the caller to discover a specific SMBIOS entry, and patch it if necissary. + Allow the caller to discover a specific SMBIOS entry, and patch it if necessary. @param[in] Type Type of the next SMBIOS record to return. - @param[in[ Instance Instance of SMBIOS record 0 - N-1. + @param[in] Instance Instance of SMBIOS record 0 - N-1. @param[out] SmbiosHandle Returns SMBIOS handle for the matching record. @retval NULL Instance of Type SMBIOS record was not found. diff --git a/EmulatorPkg/Include/Protocol/EmuBlockIo.h b/EmulatorPkg/Include/Protocol/EmuBlockIo.h index a17cefa83d..36df7e052a 100644 --- a/EmulatorPkg/Include/Protocol/EmuBlockIo.h +++ b/EmulatorPkg/Include/Protocol/EmuBlockIo.h @@ -28,7 +28,7 @@ typedef struct _EMU_BLOCK_IO_PROTOCOL EMU_BLOCK_IO_PROTOCOL; @param[in] This Indicates a pointer to the calling context. @param[in] ExtendedVerification Indicates that the driver may perform a more - exhausive verfication operation of the device + exhaustive verification operation of the device during reset. @retval EFI_SUCCESS The device was reset. @@ -109,7 +109,7 @@ EFI_STATUS the Event is NULL. @retval EFI_WRITE_PROTECTED The device can not be written to. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_DEVICE_ERROR The device reported an error while performing the write. @retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device. @retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid, @@ -142,7 +142,7 @@ EFI_STATUS @retval EFI_SUCCESS The flush request was queued if Event is not NULL. All outstanding data was written correctly to the device if the Event is NULL. - @retval EFI_DEVICE_ERROR The device reported an error while writting back + @retval EFI_DEVICE_ERROR The device reported an error while writing back the data. @retval EFI_WRITE_PROTECTED The device cannot be written to. @retval EFI_NO_MEDIA There is no media in the device. diff --git a/EmulatorPkg/Include/Protocol/EmuGraphicsWindow.h b/EmulatorPkg/Include/Protocol/EmuGraphicsWindow.h index 07d4070b35..f8f9788ded 100644 --- a/EmulatorPkg/Include/Protocol/EmuGraphicsWindow.h +++
[edk2-devel] [PATCH v2 4/7] EmulatorPkg: Fix various typos
Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Library/DxeEmuLib/DxeEmuLib.c | 2 +- .../DxeEmuPeCoffExtraActionLib.c | 2 +- .../DxeEmuPeCoffExtraActionLib.inf | 2 +- .../Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c | 8 .../DxeEmuStdErrSerialPortLib/DxeEmuStdErrSerialPortLib.c | 2 +- .../GuardUefiMemoryAllocationLib/MemoryAllocationLib.c | 6 +++--- .../PeiEmuPeCoffExtraActionLib.c | 2 +- .../PeiEmuPeCoffExtraActionLib.inf | 2 +- .../PeiEmuPeCoffGetEntryPointLib.c | 4 ++-- .../Library/PeiEmuSerialPortLib/PeiEmuSerialPortLib.c | 2 +- .../PeiServicesTablePointerLib/PeiServicesTablePointer.c | 4 ++-- .../PeiServicesTablePointer.c | 4 ++-- .../PeiServicesTablePointerLibMagicPage.inf | 2 +- EmulatorPkg/Library/PlatformBmLib/PlatformBmLib.inf | 2 +- EmulatorPkg/Library/SmbiosLib/SmbiosLib.c | 8 15 files changed, 26 insertions(+), 26 deletions(-) diff --git a/EmulatorPkg/Library/DxeEmuLib/DxeEmuLib.c b/EmulatorPkg/Library/DxeEmuLib/DxeEmuLib.c index 3247114d09..6e718109e9 100644 --- a/EmulatorPkg/Library/DxeEmuLib/DxeEmuLib.c +++ b/EmulatorPkg/Library/DxeEmuLib/DxeEmuLib.c @@ -45,7 +45,7 @@ DxeEmuLibConstructor ( /** - Serach the EMU IO Thunk database for a matching EMU IO Thunk + Search the EMU IO Thunk database for a matching EMU IO Thunk Protocol instance. @param Protocol Protocol to search for. diff --git a/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.c b/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.c index 44a42a3784..1ab24aa7c0 100644 --- a/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.c +++ b/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.c @@ -1,6 +1,6 @@ /** @file Provides services to perform additional actions to relocate and unload - PE/Coff image for Emu environment specific purpose such as souce level debug. + PE/Coff image for Emu environment specific purpose such as source level debug. This version only works for DXE phase Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved. diff --git a/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf b/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf index fdc890a000..180f153e9b 100644 --- a/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf +++ b/EmulatorPkg/Library/DxeEmuPeCoffExtraActionLib/DxeEmuPeCoffExtraActionLib.inf @@ -1,5 +1,5 @@ ## @file -# PeCoff extra action libary for DXE phase that run Emu emulator. +# PeCoff extra action library for DXE phase that run Emu emulator. # # Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved. # Portions copyright (c) 2011, Apple Inc. All rights reserved. diff --git a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c index 1f9ab86377..e1a8be5a14 100644 --- a/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c +++ b/EmulatorPkg/Library/DxeEmuSerialPortLib/DxeEmuSerialPortLib.c @@ -1,6 +1,6 @@ /** @file Serial Port Lib that thunks back to Emulator services to write to StdErr. - All read functions are stubed out. + All read functions are stubbed out. Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved. Portions copyright (c) 2011, Apple Inc. All rights reserved. @@ -153,13 +153,13 @@ SerialPortGetControl ( } /** - Sets the baud rate, receive FIFO depth, transmit/receice time out, parity, + Sets the baud rate, receive FIFO depth, transmit/receive time out, parity, data bits, and stop bits on a serial device. @param BaudRate The requested baud rate. A BaudRate value of 0 will use the device's default interface speed. On output, the value actually set. - @param ReveiveFifoDepth The requested depth of the FIFO on the receive side of the + @param ReceiveFifoDepth The requested depth of the FIFO on the receive side of the serial interface. A ReceiveFifoDepth value of 0 will use the device's default FIFO depth. On output, the value actually set. @@ -172,7 +172,7 @@ SerialPortGetControl ( DefaultParity will use the device's default parity value. On output, the value actually set. @param DataBits The number of data bits to use on the serial device. A DataBits - vaule of 0 will use the device's default data bit setting. + value of 0 will use the device's default data bit setting. On output, the value actually set. @param StopBits The number of stop bits to use on this serial device. A StopBits value of DefaultStopBits will use the device's default number of diff --git
[edk2-devel] [PATCH v2 1/7] EmulatorPkg: Fix various typos
Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/CpuRuntimeDxe/MpService.c | 11 +-- EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c | 14 +++--- EmulatorPkg/EmuGopDxe/GopDriver.c | 4 ++-- EmulatorPkg/EmuGopDxe/GopInput.c | 12 ++-- EmulatorPkg/EmuGopDxe/GopScreen.c | 6 +++--- EmulatorPkg/EmuThunkDxe/EmuThunk.c | 2 +- 6 files changed, 24 insertions(+), 25 deletions(-) diff --git a/EmulatorPkg/CpuRuntimeDxe/MpService.c b/EmulatorPkg/CpuRuntimeDxe/MpService.c index 42f94ada27..ff379a1ce3 100644 --- a/EmulatorPkg/CpuRuntimeDxe/MpService.c +++ b/EmulatorPkg/CpuRuntimeDxe/MpService.c @@ -29,10 +29,9 @@ Diagnostics applications may also use this protocol for multi-processor. Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved. -Portitions Copyright (c) 2011, Apple Inc. All rights reserved. +Portions Copyright (c) 2011, Apple Inc. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent - **/ #include "CpuDriver.h" @@ -292,7 +291,7 @@ CpuMpServicesGetProcessorInfo ( and releases the BSP to continue with other tasks. -# The caller can use the CheckEvent() and WaitForEvent() services to check the state of the WaitEvent created in step 1. - -# When the APs complete their task or TimeoutInMicroSecondss expires, the MP + -# When the APs complete their task or TimeoutInMicroSeconds expires, the MP Service signals WaitEvent by calling the EFI SignalEvent() function. If FailedCpuList is not NULL, its content is available when WaitEvent is signaled. If all APs returned from Procedure prior to the timeout, then @@ -332,7 +331,7 @@ CpuMpServicesGetProcessorInfo ( EFI_EVENT is defined in CreateEvent() in the Unified Extensible Firmware Interface Specification. - @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for + @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for APs to return from Procedure, either for blocking or non-blocking mode. Zero means infinity. If the timeout expires before @@ -601,7 +600,7 @@ Done: This function is used to dispatch one enabled AP to the function specified by Procedure passing in the argument specified by ProcedureArgument. If WaitEvent is NULL, execution is in blocking mode. The BSP waits until the AP finishes or - TimeoutInMicroSecondss expires. Otherwise, execution is in non-blocking mode. + TimeoutInMicroSeconds expires. Otherwise, execution is in non-blocking mode. BSP proceeds to the next task without waiting for the AP. If a non-blocking mode is requested after the UEFI Event EFI_EVENT_GROUP_READY_TO_BOOT is signaled, then EFI_UNSUPPORTED must be returned. @@ -636,7 +635,7 @@ Done: EFI_EVENT is defined in CreateEvent() in the Unified Extensible Firmware Interface Specification. - @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for + @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for APs to return from Procedure, either for blocking or non-blocking mode. Zero means infinity. If the timeout expires before diff --git a/EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c b/EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c index 96424a82ae..1a88223f91 100644 --- a/EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c +++ b/EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c @@ -13,7 +13,7 @@ bbe @param[in] This Indicates a pointer to the calling context. @param[in] ExtendedVerification Indicates that the driver may perform a more - exhausive verfication operation of the device + exhaustive verification operation of the device during reset. @retval EFI_SUCCESS The device was reset. @@ -123,7 +123,7 @@ EmuBlockIo2ReadBlocksEx ( the Event is NULL. @retval EFI_WRITE_PROTECTED The device can not be written to. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_DEVICE_ERROR The device reported an error while performing the write. @retval EFI_BAD_BUFFER_SIZE The Buffer was not a multiple of the block size of the device. @retval EFI_INVALID_PARAMETER The write request contains LBAs that are not valid, @@ -172,7 +172,7 @@ EmuBlockIo2WriteBlocksEx ( @retval EFI_SUCCESS The flush request was queued if Event is not NULL. All outstanding data was written correctly to the device if the Event is NULL. - @retval EFI_DEVICE_ERROR The device reported an error while writting back + @retval EFI_DEVICE_ERROR The device reported an error while writing back the data. @retval EFI_WRITE_PROTECTED The device cannot be written to. @retval EFI_NO_MEDIA There is no media in the device. @@ -250,7 +250,7 @@ EmuBlockIoReset ( @retval EFI_SUCCESS The data was read
[edk2-devel] [PATCH v2 0/7] EmulatorPkg: Fix various typos
Each commit can be reviewed/merged independently. Each commit is roughly 20 lines modified. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43174): https://edk2.groups.io/g/devel/message/43174 Mute This Topic: https://groups.io/mt/32288181/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] BaseTools: Fix encoding typos
For the record, in UTF-8, you're supposed to read: - Jean-François PIÉRONNE - Jean-François Piéronne - David Kågedal -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43046): https://edk2.groups.io/g/devel/message/43046 Mute This Topic: https://groups.io/mt/32250884/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] BaseTools: Fix encoding typos
Fix encoding typos in BaseTools by using UTF-8. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt b/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt index 4d84d1c19c..c3fcadfd59 100644 --- a/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt +++ b/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt @@ -40,7 +40,7 @@ List of Implemented Fixes and Changes for Maintenance Releases of PCCTS #309. (Changed in MR32) Renamed baseName because of VMS name conflict Renamed baseName to pcctsBaseName to avoid library name conflict with - VMS library routine. Reported by Jean-FranÁois PI…RONNE. + VMS library routine. Reported by Jean-Fran√ßois PI√âRONNE. #308. (Changed in MR32) Used "template" as name of formal in C routine @@ -975,7 +975,7 @@ List of Implemented Fixes and Changes for Maintenance Releases of PCCTS #249. (MR21) Changes for DEC/VMS systems - Jean-FranÁois PiÈronne (jfp altavista.net) has updated some + Jean-Fran√ßois Pi√©ronne (jfp altavista.net) has updated some VMS related command files and fixed some minor problems related to building pccts under the DEC/VMS operating system. For DEC/VMS users the most important differences are: @@ -1750,7 +1750,7 @@ List of Implemented Fixes and Changes for Maintenance Releases of PCCTS Under certain circumstances a predicate test could generate a #line directive which was not at column 1. - Reported with fix by David KÂgedal (davidk lysator.liu.se) + Reported with fix by David K√•gedal (davidk lysator.liu.se) (http://www.lysator.liu.se/~davidk/). #194. (Changed in MR14) (C Mode only) Demand lookahead with #tokclass -- 2.20.1 (Apple Git-117) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43045): https://edk2.groups.io/g/devel/message/43045 Mute This Topic: https://groups.io/mt/32250884/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH] FatPkg: Fix various typos
Fix various typos in FatPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- FatPkg/EnhancedFatDxe/Delete.c | 2 +- FatPkg/EnhancedFatDxe/DirectoryManage.c | 10 +- FatPkg/EnhancedFatDxe/Fat.c | 2 +- FatPkg/EnhancedFatDxe/Fat.h | 24 FatPkg/EnhancedFatDxe/FileName.c | 4 ++-- FatPkg/EnhancedFatDxe/FileSpace.c | 8 FatPkg/EnhancedFatDxe/Flush.c | 2 +- FatPkg/EnhancedFatDxe/Info.c | 2 +- FatPkg/EnhancedFatDxe/Init.c | 2 +- FatPkg/EnhancedFatDxe/Misc.c | 6 +++--- FatPkg/EnhancedFatDxe/Open.c | 2 +- FatPkg/FatPei/FatLiteApi.c | 6 +++--- FatPkg/FatPei/FatLitePeim.h | 4 ++-- 13 files changed, 37 insertions(+), 37 deletions(-) diff --git a/FatPkg/EnhancedFatDxe/Delete.c b/FatPkg/EnhancedFatDxe/Delete.c index b2a62b35de..8a437e3ee2 100644 --- a/FatPkg/EnhancedFatDxe/Delete.c +++ b/FatPkg/EnhancedFatDxe/Delete.c @@ -56,7 +56,7 @@ FatDelete ( goto Done; } // - // If the file has a permanant error, skip the delete + // If the file has a permanent error, skip the delete // Status = OFile->Error; if (!EFI_ERROR (Status)) { diff --git a/FatPkg/EnhancedFatDxe/DirectoryManage.c b/FatPkg/EnhancedFatDxe/DirectoryManage.c index 21656883bd..90c01b3baa 100644 --- a/FatPkg/EnhancedFatDxe/DirectoryManage.c +++ b/FatPkg/EnhancedFatDxe/DirectoryManage.c @@ -13,11 +13,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent Get a directory entry from disk for the Ofile. @param Parent - The parent of the OFile which need to update. - @param IoMode - Indicate whether to read directory entry or write directroy entry. + @param IoMode - Indicate whether to read directory entry or write directory entry. @param EntryPos - The position of the directory entry to be accessed. @param Entry - The directory entry read or written. - @retval EFI_SUCCESS - Access the directory entry sucessfully. + @retval EFI_SUCCESS - Access the directory entry successfully. @return other - An error occurred when reading the directory entry. **/ @@ -896,7 +896,7 @@ FatNewEntryPos ( @param Volume - FAT file system volume. @param Name - The file name of the volume. - @retval EFI_SUCCESS - Update the volume with the directory entry sucessfully. + @retval EFI_SUCCESS - Update the volume with the directory entry successfully. @return others - An error occurred when getting volume label. **/ @@ -927,7 +927,7 @@ FatGetVolumeEntry ( @param Volume - FAT file system volume. @param Name - The new file name of the volume. - @retval EFI_SUCCESS - Update the Volume sucessfully. + @retval EFI_SUCCESS - Update the Volume successfully. @retval EFI_UNSUPPORTED - The input label is not a valid volume label. @return other - An error occurred when setting volume label. @@ -1246,7 +1246,7 @@ FatCloseDirEnt ( not be created either). @retval EFI_INVALID_PARAMETER - The parameter is not valid. @retval EFI_SUCCESS - Open the file successfully. - @return other - An error occured when locating the OFile. + @return other - An error occurred when locating the OFile. **/ EFI_STATUS diff --git a/FatPkg/EnhancedFatDxe/Fat.c b/FatPkg/EnhancedFatDxe/Fat.c index 3bec1c94ec..77cda19539 100644 --- a/FatPkg/EnhancedFatDxe/Fat.c +++ b/FatPkg/EnhancedFatDxe/Fat.c @@ -417,7 +417,7 @@ FatDriverBindingStart ( Status = FatAllocateVolume (ControllerHandle, DiskIo, DiskIo2, BlockIo); // - // When the media changes on a device it will Reinstall the BlockIo interaface. + // When the media changes on a device it will Reinstall the BlockIo interface. // This will cause a call to our Stop(), and a subsequent reentrant call to our // Start() successfully. We should leave the device open when this happen. // diff --git a/FatPkg/EnhancedFatDxe/Fat.h b/FatPkg/EnhancedFatDxe/Fat.h index 98ead5a0fb..47358d4452 100644 --- a/FatPkg/EnhancedFatDxe/Fat.h +++ b/FatPkg/EnhancedFatDxe/Fat.h @@ -236,7 +236,7 @@ struct _FAT_OFILE { UINTN Signature; FAT_VOLUME *Volume; // - // A permanant error code to return to all accesses to + // A permanent error code to return to all accesses to // this opened file // EFI_STATUS Error; @@ -246,7 +246,7 @@ struct _FAT_OFILE { LIST_ENTRY Opens; // - // The dynamic infomation + // The dynamic information // UINTN FileSize; UINTN FileCluster; @@ -865,7 +865,7 @@ FatCleanupVolume ( @param OFile - The open file. - @retval EFI_SUCCESS - Shrinked sucessfully. + @retval EFI_SUCCESS - Shrinked successfully. @retval EFI_VOLUME_CORRUPTED - There are errors in the file's
[edk2-devel] [PATCH] EmbeddedPkg: Fix various typos
Fix various typos in EmbeddedPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- .../AndroidFastboot/AndroidBootImg.c | 2 +- .../AndroidFastboot/AndroidFastbootApp.c | 2 +- .../Drivers/ConsolePrefDxe/ConsolePrefDxe.c | 2 +- .../Drivers/DtPlatformDxe/DtPlatformDxe.c | 2 +- .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c | 4 ++-- EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c | 2 +- EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h | 2 +- .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 2 +- EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c | 2 +- EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h | 2 +- .../SataSiI3132Dxe/SiI3132AtaPassThru.c | 2 +- EmbeddedPkg/EmbeddedPkg.dsc | 2 +- EmbeddedPkg/GdbStub/Arm/Processor.c | 2 +- EmbeddedPkg/GdbStub/GdbStub.c | 20 EmbeddedPkg/GdbStub/GdbStubInternal.h | 24 +-- EmbeddedPkg/GdbStub/Ia32/Processor.c | 4 ++-- EmbeddedPkg/GdbStub/SerialIo.c | 24 +-- EmbeddedPkg/GdbStub/X64/Processor.c | 4 ++-- .../Include/Library/DebugAgentTimerLib.h | 2 +- EmbeddedPkg/Include/Library/EfiFileLib.h | 6 ++--- EmbeddedPkg/Include/Library/GdbSerialLib.h | 8 +++ EmbeddedPkg/Include/Library/PrePiLib.h | 4 ++-- .../Protocol/AndroidFastbootPlatform.h | 4 ++-- .../Include/Protocol/HardwareInterrupt.h | 2 +- EmbeddedPkg/Include/Protocol/PeCoffLoader.h | 4 ++-- .../DebugAgentTimerLib.c | 2 +- .../GdbSerialDebugPortLib.c | 8 +++ .../Library/GdbSerialLib/GdbSerialLib.c | 8 +++ EmbeddedPkg/Library/PrePiHobLib/Hob.c | 2 +- EmbeddedPkg/Library/PrePiLib/FwVol.c | 4 ++-- .../MemoryAllocationLib.c | 2 +- .../RealTimeClockLib.c | 4 ++-- .../SimpleTextInOutSerial/SimpleTextInOut.c | 2 +- EmbeddedPkg/Universal/MmcDxe/Mmc.h | 2 +- 34 files changed, 84 insertions(+), 84 deletions(-) diff --git a/EmbeddedPkg/Application/AndroidFastboot/AndroidBootImg.c b/EmbeddedPkg/Application/AndroidFastboot/AndroidBootImg.c index 896ad29afc..54b7bee162 100644 --- a/EmbeddedPkg/Application/AndroidFastboot/AndroidBootImg.c +++ b/EmbeddedPkg/Application/AndroidFastboot/AndroidBootImg.c @@ -9,7 +9,7 @@ #include "AndroidFastbootApp.h" // Find the kernel and ramdisk in an Android boot.img. -// return EFI_INVALID_PARAMTER if the boot.img is invalid (i.e. doesn't have the +// return EFI_INVALID_PARAMETER if the boot.img is invalid (i.e. doesn't have the // right magic value), // return EFI_NOT_FOUND if there was no kernel in the boot.img. // Note that the Ramdisk is optional - *Ramdisk won't be touched if it isn't diff --git a/EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c b/EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c index c8e89173e6..3e3f4b7eb2 100644 --- a/EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c +++ b/EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c @@ -300,7 +300,7 @@ AcceptCmd ( } else if (IS_LOWERCASE_ASCII (Command[0])) { // Commands starting with lowercase ASCII characters are reserved for the // Fastboot protocol. If we don't recognise it, it's probably the future - // and there are new commmands in the protocol. + // and there are new commands in the protocol. // (By the way, the "oem" command mentioned above makes this reservation // redundant, but we handle it here to be spec-compliant) SEND_LITERAL ("FAILCommand not recognised. Check Fastboot version."); diff --git a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c b/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c index 8d0ffbe88d..c250844eda 100644 --- a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c +++ b/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c @@ -224,7 +224,7 @@ OnReadyToBoot ( @retval EFI_ALREADY_STARTED The driver already exists in system. @retval EFI_OUT_OF_RESOURCES Fail to execute entry point due to lack of resources. - @retval EFI_SUCCES All the related protocols are installed on + @retval EFI_SUCCESS All the related protocols are installed on the driver. **/ diff --git a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c index 5ec95f7491..907d46a495 100644 --- a/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c +++ b/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c @@ -92,7 +92,7 @@ InstallHiiPages ( @retval EFI_ALREADY_STARTED The driver already exists in system. @retval EFI_OUT_OF_RESOURCES Fail to execute entry point due to lack of resources. - @retval EFI_SUCCES All the related protocols are installed on + @retval EFI_SUCCESS All the related protocols are installed on the driver. **/ diff --git a/EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c
[edk2-devel] [PATCH] ArmPlatformPkg: Fix various typos
>From 0fdb05b34e5bfdcbd92d21cdf446eec06cf9035f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antoine=20C=C5=93ur?= Date: Wed, 6 Feb 2019 23:40:38 +0800 Subject: [PATCH] ArmPlatformPkg: Fix various typos Fix various typos in ArmPlatformPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 ++-- ArmPlatformPkg/Include/Library/ArmPlatformLib.h | 2 +- ArmPlatformPkg/Include/Library/PL011UartLib.h | 2 +- ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c | 2 +- ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c | 2 +- ArmPlatformPkg/PlatformPei/PlatformPeim.c | 2 +- ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 2 +- ArmPlatformPkg/PrePi/PrePi.c | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c index 468dd00ae8..d9e196cbf1 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c @@ -1109,7 +1109,7 @@ NorFlashWriteSingleBlock ( @retval EFI_SUCCESS The data was read correctly from the device. @retval EFI_DEVICE_ERROR The device reported an error while performing the read. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_INVALID_PARAMETER The read request contains device addresses that are not valid for the device. @@ -1154,7 +1154,7 @@ NorFlashDiskIoReadDisk ( @retval EFI_WRITE_PROTECTED The device can not be written to. @retval EFI_DEVICE_ERROR The device reported an error while performing the write. @retval EFI_NO_MEDIA There is no media in the device. - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. @retval EFI_INVALID_PARAMETER The write request contains device addresses that are not valid for the device. diff --git a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h index b6cd647d05..225183af2c 100644 --- a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h +++ b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h @@ -14,7 +14,7 @@ // #include // -// The protocols, PPI and GUID defintions for this module +// The protocols, PPI and GUID definitions for this module // #include #include diff --git a/ArmPlatformPkg/Include/Library/PL011UartLib.h b/ArmPlatformPkg/Include/Library/PL011UartLib.h index 7108587350..3bd2e294b0 100644 --- a/ArmPlatformPkg/Include/Library/PL011UartLib.h +++ b/ArmPlatformPkg/Include/Library/PL011UartLib.h @@ -112,7 +112,7 @@ PL011UartSetControl ( . EFI_SERIAL_OUTPUT_BUFFER_EMPTY : equal to one if the transmit buffer is empty, 0 otherwise. . EFI_SERIAL_HARDWARE_LOOPBACK_ENABLE : equal to one if - the hardware loopback is enabled (the ouput feeds the + the hardware loopback is enabled (the output feeds the receive buffer), 0 otherwise. . EFI_SERIAL_SOFTWARE_LOOPBACK_ENABLE : equal to one if a loopback is accomplished by software, 0 otherwise. diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c index 20a53be02e..801990d955 100644 --- a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c @@ -321,7 +321,7 @@ PL011UartSetControl ( . EFI_SERIAL_OUTPUT_BUFFER_EMPTY : equal to one if the transmit buffer is empty, 0 otherwise. . EFI_SERIAL_HARDWARE_LOOPBACK_ENABLE : equal to one if - the hardware loopback is enabled (the ouput feeds the + the hardware loopback is enabled (the output feeds the receive buffer), 0 otherwise. . EFI_SERIAL_SOFTWARE_LOOPBACK_ENABLE : equal to one if a loopback is accomplished by software, 0 otherwise. diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c index 485dad0ac8..027fa11a89 100644 --- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c +++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c @@ -9,7 +9,7 @@ #include // -// The protocols, PPI and GUID defintions for this module +// The protocols, PPI and GUID definitions for this module // #include #include diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeim.c b/ArmPlatformPkg/PlatformPei/PlatformPeim.c index 27687e9c7e..ca5a31116a 100644 --- a/ArmPlatformPkg/PlatformPei/PlatformPeim.c +++ b/ArmPlatformPkg/PlatformPei/PlatformPeim.c @@ -9,7 +9,7 @@ #include // -// The protocols, PPI and GUID defintions for this module +// The protocols, PPI and GUID definitions for this module // #include #include diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c
[edk2-devel] [PATCH] ArmPkg: Fix various typos
Fix various typos in ArmPkg. Same as https://github.com/tianocore/edk2/pull/143/files -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42964): https://edk2.groups.io/g/devel/message/42964 Mute This Topic: https://groups.io/mt/32238697/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=- patch.diff Description: Binary data