Re: [edk2-devel] [PATCH] Improved Smbios Type0 fields under smbiosview

[Kanagavel S via groups.io]

Please help to review the patch.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106276): https://edk2.groups.io/g/devel/message/106276
Mute This Topic: https://groups.io/mt/96192446/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] ShellPkg: Fixed system hang issue when executing ping6 command cross network segment in EFI Shell.

[Kanagavel S via groups.io]

Please help to review this patch.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106274): https://edk2.groups.io/g/devel/message/106274
Mute This Topic: https://groups.io/mt/97949969/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] ShellPkg: Fixed system hang issue when executing ping6 command cross network segment in EFI Shell.

[Kanagavel S via groups.io]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4376

While shell is polling to send/receive ICMP packets, Private ->status is not 
updated for below scenario,
Considering 10 packets are transferred and it's RTT time is between 1764-1812 
ms .In this 10 packets 2 or 3 packets
are lost in between ping communication and reported timeout issue and last one 
is successful packet.
In this case failed packet is reported before the last successful packet hence 
,private ->status is not
updated with either success or EFI_TIMEOUT.
Counted Fail count of Ping communication ,when private->Txinfo list is empty 
and sum of failcount and receive
count equals to the total packets private->status has been updated to timeout.

Signed-off-by: Kanagavel S 
---
 ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c 
b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c
index e0b58d4b85..50d1bb6e1d 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ping6.c
@@ -2,6 +2,7 @@
   The implementation for Ping6 application.



   Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.

+  Copyright (c) 1985 - 2023, American Megatrends International LLC.



   SPDX-License-Identifier: BSD-2-Clause-Patent



@@ -92,7 +93,7 @@ SHELL_PARAM_ITEM  Ping6ParamList[] = {
 CONST CHAR16   *mIp6DstString;

 CONST CHAR16   *mIp6SrcString;

 EFI_CPU_ARCH_PROTOCOL  *Cpu = NULL;

-

+UINT32  gFailCount = 0;

 /**

   RTT timer tick routine.



@@ -457,6 +458,9 @@ Ping6OnEchoReplyReceived6 (
 ON_EXIT:



   if (Private->RxCount < Private->SendNum) {

+  if (IsListEmpty (&Private->TxList) && ((Private->RxCount + gFailCount) 
== Private->SendNum)){

+  Private->Status = EFI_TIMEOUT;

+  }

 //

 // Continue to receive icmp6 echo reply packets.

 //

@@ -715,7 +719,7 @@ Ping6OnTimerRoutine6 (
   // Remove the timeout icmp6 echo request from list.

   //

   ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_PING6_TIMEOUT), 
gShellNetwork2HiiHandle, TxInfo->SequenceNum);

-

+  gFailCount++;

   RemoveEntryList (&TxInfo->Link);

   Ping6DestroyTxInfo (TxInfo);



@@ -1048,6 +1052,7 @@ ShellPing6 (
   SHELL_STATUS ShellStatus;



   ShellStatus = SHELL_SUCCESS;

+  gFailCount = 0;

   Private = AllocateZeroPool (sizeof (PING6_PRIVATE_DATA));



   if (Private == NULL) {

--
2.35.1.windows.2
-The information contained in this message may be confidential and proprietary 
to American Megatrends (AMI). This communication is intended to be read only by 
the individual or entity to whom it is addressed or by their designee. If the 
reader of this message is not the intended recipient, you are on notice that 
any distribution of this message, in any form, is strictly prohibited. Please 
promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and 
then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102178): https://edk2.groups.io/g/devel/message/102178
Mute This Topic: https://groups.io/mt/97949969/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH] Improved Smbios Type0 fields under smbiosview

[Kanagavel S via groups.io]

[PATCH] ShellPkg:Improved Smbios Type0 fields under SmbiosView

Corrected few wrongly updated Smbios Type0 strings as per Smbios Spec under 
SmbiosView.

Signed-off by: Kanagavel S 

CC: Srinivasan M 
CC: Sundaresan S 
CC: Prarthana S  
CC: Ramesh R 
---
 .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 ++--
 .../SmbiosView/SmbiosViewStrings.uni  | 8 
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index e936ee8ea9..db868f36d1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -2,7 +2,7 @@
   Module for clarifying the content of the smbios structure element 
information.



   Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.

-  Copyright (c) 1985 - 2022, American Megatrends International LLC.

+  Copyright (c) 1985 - 2023, American Megatrends International LLC.

   (C) Copyright 2014 Hewlett-Packard Development Company, L.P.

   (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP

   SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -1459,7 +1459,7 @@ DisplayBiosCharacteristics (
   // Just print the Reserved

   //

   ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN 
(STR_SMBIOSVIEW_PRINTINFO_BITS_32_47), gShellDebug1HiiHandle);

-  ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN 
(STR_SMBIOSVIEW_PRINTINFO_BITS_48_64), gShellDebug1HiiHandle);

+  ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN 
(STR_SMBIOSVIEW_PRINTINFO_BITS_48_63), gShellDebug1HiiHandle);

 }



 /**

diff --git 
a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
index 1ab0e3dd60..3aa021f2c0 100644
--- 
a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
+++ 
b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
@@ -1,7 +1,7 @@
 // /**

 //

 // Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.

-// Copyright (c) 1985 - 2022, American Megatrends International LLC.

+// Copyright (c) 1985 - 2023, American Megatrends International LLC.

 // (C) Copyright 2014-2015 Hewlett-Packard Development Company, L.P.

 // (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP

 // SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -136,7 +136,7 @@
 #string STR_SMBIOSVIEW_PRINTINFO_BOOT_FROM_PC_CARD  #language 
en-US "Boot From PC Card(PCMCIA)is supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_EDD_ENHANCED_DRIVER#language 
en-US "EDD (Enhanced Disk Driver) Specification is supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_JAPANESE_FLOPPY_NEC#language 
en-US "Int 13h - Japanese Floppy for NEC 9800 1.2mb (3.5\",1k Bytes/Sector, 360 
RPM) is supported\r\n"

-#string STR_SMBIOSVIEW_PRINTINFO_JAPANESE_FLOPPY_TOSHIBA#language 
en-US "Int 13h - Japanese Floppy for Toshiba 1.2mn (3.5\", 360 RPM) is 
supported\r\n"

+#string STR_SMBIOSVIEW_PRINTINFO_JAPANESE_FLOPPY_TOSHIBA#language 
en-US "Int 13h - Japanese Floppy for Toshiba 1.2mb (3.5\", 360 RPM) is 
supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_FLOPPY_SERVICES_SUPPORTED  #language 
en-US "Int 13h - 5.25\"/360KB Floppy Services are supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_ONE_POINT_TWO_MB   #language 
en-US "Int 13h - 5.25\"/1.2MB Floppy services are supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_720_KB #language 
en-US "Int 13h - 3.5\"/720KB Floppy services are supported\r\n"

@@ -145,10 +145,10 @@
 #string STR_SMBIOSVIEW_PRINTINFO_KEYBOARD_SERV_SUPPORT  #language 
en-US "Int 9h, 8042 Keyboard services are supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_SERIAL_SERVICES_SUPPORT#language 
en-US "Int 14h, Serial Services are supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_PRINTER_SERVICES_SUPPORT   #language 
en-US "Int 17h, Printer services are supported\r\n"

-#string STR_SMBIOSVIEW_PRINTINFO_MONO_VIDEO_SUPPORT #language 
en-US "Int 10h, CGA/Mono Video services are supported2\r\n"

+#string STR_SMBIOSVIEW_PRINTINFO_MONO_VIDEO_SUPPORT #language 
en-US "Int 10h, CGA/Mono Video services are supported\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_NEC_PC_98  #language 
en-US "NEC PC-98\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_BITS_32_47 #language 
en-US " Bits 32:47 are reserved for BIOS Vendor\r\n"

-#string STR_SMBIOSVIEW_PRINTINFO_BITS_48_64 #language 
en-US " Bits 48:64 are reserved for System Vendor\r\n"

+#string STR_SMBIOSVIEW_PRINTINFO_BITS_48_63 #language 
en-US " Bits 48:63 are reserved for System Vendor\r\n"

 #string STR_SMBIOSVIEW_PRINTINFO_BIOS_CHAR_EXTENSION#lan