Re: [edk2-devel] Refactoring the UEFI shell

[Sheng Lean Tan]

Hi all,
Any feedback regarding this? :P
Any thoughts?
Much appreciated!

Best Regards,
Sheng

On Tue, 19 Mar 2024 at 18:44, Benjamin Doron 
wrote:

> Hi all,
> We're planning to refactor the shell into a library so that shell apps
> possibly used in the field for testing can be easily adapted for automation.
>
> Our plan is:
>
>- Refactor ShellInfoObject into base internals and interactive elements
>- Migrate functions that imply interactivity into a new library class,
>and write some stubs in a LibNull
>- Refactor last shell app files (file interface, shell env var) into
>another (or same) library
>- Implement non-interactive functions, as required
>- Write an example implementation in MdeModulePkg/Application/
>
>
> We're looking for thoughts and ideas on our approach, as well as opinions
> on the concept.
>
> Best regards,
> Benjamin
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117165): https://edk2.groups.io/g/devel/message/117165
Mute This Topic: https://groups.io/mt/105028827/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: CbParseLib: Fix integer overflow

[Sheng Lean Tan]

Hi Gua or Sean,
Would you mind to help review this?
Thanks!

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR



On Mon, 8 Jan 2024 at 08:00, Patrick Rudolph 
wrote:

> The IMD entry uses the 32bit start field as relative offset
> to root. On Ia32X64 this works fine as UINTN is also 32 bit and
> negative relative offsets are properly calculated due to an
> integer overflow.
>
> On X64 this doesn't work as UINTN is 64 bit and the offset
> is no longer subtracted, but it's added to the root. Fix that
> by sign extending the start field to 64 bit.
>
> Test: Booting UefiPayloadPkg still works on Ia32X64 and now also
>   works on X64.
>
> Signed-off-by: Patrick Rudolph 
> ---
>  UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> index 8a353f77f6..9e149532a7 100644
> --- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> +++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> @@ -282,7 +282,7 @@ FindCbMemTable (
>for (Idx = 0; Idx < Root->num_entries; Idx++) {
>  if (Entries[Idx].id == TableId) {
>if (IsImdEntry) {
> -*MemTable = (VOID *)((UINTN)Entries[Idx].start + (UINTN)Root);
> +*MemTable = (VOID *)((INTN)(INT32)Entries[Idx].start +
> (UINTN)Root);
>} else {
>  *MemTable = (VOID *)(UINTN)Entries[Idx].start;
>}
> --
> 2.43.0
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113713): https://edk2.groups.io/g/devel/message/113713
Mute This Topic: https://groups.io/mt/103593206/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 2/2] UefiPayloadPkg: Add FIT support

[Sheng Lean Tan]

The spec version should be v.8 instead of v.75


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108705): https://edk2.groups.io/g/devel/message/108705
Mute This Topic: https://groups.io/mt/101375948/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/1] UefiPayloadPkg: Match BAR if framebuffer is at an offset

[Sheng Lean Tan]

Reminder: Can anyone help to review this? Thanks!


On Fri, 25 Aug 2023 at 10:33, Sheng Lean Tan via groups.io  wrote:

> Hi Michael,
> You will need to CC the maintainers/reviewers for UEFIpayloadpkg.
> I have added them in ;)
> Best Regards,
> *Lean Sheng Tan*
>
>
>
> 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email: sheng@9elements.com
> Phone: *+49 234 68 94 188 <+492346894188>*
> Mobile: *+49 176 76 113842 <+4917676113842>*
>
> Registered office: Bochum
> Commercial register: Amtsgericht Bochum, HRB 17519
> Management: Sebastian German, Eray Bazaar
>
> Data protection information according to Art. 13 GDPR
> <https://9elements.com/privacy>
>
>
> On Fri, 7 Jul 2023 at 20:04, Michael Büchler 
> wrote:
>
>> Hi,
>>
>> this is my first message to this list and the first time I am using git
>> send-email. Please let me know if I messed something up. For example, I
>> have to use `git am --keep-cr` to apply the patch myself.
>>
>> Regards,
>> Michael
>>
>> Michael Büchler (1):
>>   UefiPayloadPkg: Match BAR if framebuffer is at an offset
>>
>>  UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutput.c | 9 ++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> --
>> 2.39.3
>>
>>
>>
>>
>>
>>
>> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108280): https://edk2.groups.io/g/devel/message/108280
Mute This Topic: https://groups.io/mt/100011246/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/1] UefiPayloadPkg: Match BAR if framebuffer is at an offset

[Sheng Lean Tan]

Hi Michael,
You will need to CC the maintainers/reviewers for UEFIpayloadpkg.
I have added them in ;)
Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR



On Fri, 7 Jul 2023 at 20:04, Michael Büchler 
wrote:

> Hi,
>
> this is my first message to this list and the first time I am using git
> send-email. Please let me know if I messed something up. For example, I
> have to use `git am --keep-cr` to apply the patch myself.
>
> Regards,
> Michael
>
> Michael Büchler (1):
>   UefiPayloadPkg: Match BAR if framebuffer is at an offset
>
>  UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutput.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> --
> 2.39.3
>
>
>
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108032): https://edk2.groups.io/g/devel/message/108032
Mute This Topic: https://groups.io/mt/100011246/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Now: UEFI Memory Map, GCD, Page Table discussion - ARM/X86 - Wednesday, May 17, 2023 #cal-notice

[Sheng Lean Tan]

This was a good sharing! May I know where can I get the presentation slides?
Thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105085): https://edk2.groups.io/g/devel/message/105085
Mute This Topic: https://groups.io/mt/98948349/21656
Mute #cal-notice:https://edk2.groups.io/g/devel/mutehashtag/cal-notice
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

[Sheng Lean Tan]

Hi Gua,
Thanks for the review. Do you have a proposal or small example on how you
want to separate into another FV?

Thanks,
Sheng



On Wed, 26 Apr 2023 at 14:55, Guo, Gua  wrote:

> Do we separate these Security Driver into separate FV ?
>
>
>
> I really don’t want to see gather everything into uefi_fv.
>
> Separate it into a lot of fv, we can easy to plug in and plug out.
>
>
>
> Thanks,
>
> Gua
>
>
>
> *From:* devel@edk2.groups.io  * On Behalf Of *Sean
> Rhodes
> *Sent:* Wednesday, April 26, 2023 8:33 PM
> *To:* Benjamin Doron 
> *Cc:* devel@edk2.groups.io; Dong, Guo ; Ni, Ray <
> ray...@intel.com>; Lu, James ; Guo, Gua <
> gua@intel.com>
> *Subject:* Re: [edk2-devel][PATCH v1 2/2] UefiPayloadPkg: Enable RNG
> support
>
>
>
> Reviewed-by: Sean Rhodes 
>
>
>
> On Tue, 25 Apr 2023 at 18:09, Benjamin Doron 
> wrote:
>
> From: Benjamin Doron 
>
> Uses CPU RDRAND support and installs the EfiRngProtocol.
> The protocol may be used by iPXE or the Linux kernel to gather entropy.
>
> Cc: Guo Dong 
> Cc: Ray Ni 
> Cc: Sean Rhodes 
> Cc: James Lu 
> Cc: Gua Guo 
> Signed-off-by: Benjamin Doron 
> ---
>  UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++
>  UefiPayloadPkg/UefiPayloadPkg.fdf | 3 +++
>  2 files changed, 6 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
> b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index 1e803ba01567..486af2396731 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -634,6 +634,9 @@
>MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
>  !endif
>UefiCpuPkg/CpuDxe/CpuDxe.inf
> +!if $(CPU_RNG_ENABLE) == TRUE
> +  SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf
> +!endif
>MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>  !if $(BOOTSPLASH_IMAGE)
>MdeModulePkg/Logo/LogoDxe.inf
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf
> b/UefiPayloadPkg/UefiPayloadPkg.fdf
> index f8c2aa8c4a02..53add65a6a40 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.fdf
> +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
> @@ -157,6 +157,9 @@ INF CryptoPkg/Driver/CryptoDxe.inf
>  INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
>  !endif
>  INF UefiCpuPkg/CpuDxe/CpuDxe.inf
> +!if $(CPU_RNG_ENABLE) == TRUE
> +INF SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf
> +!endif
>
>  INF RuleOverride = UI MdeModulePkg/Application/UiApp/UiApp.inf
>  INF MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
> --
> 2.39.2
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103649): https://edk2.groups.io/g/devel/message/103649
Mute This Topic: https://groups.io/mt/98497422/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 2/2] UefiPayloadPkg: Enable RNG support

[Sheng Lean Tan]

Hi Gua,
Thanks for the review. Do you have a proposal or small example on how you want 
to see to separate into another FV?

Thanks,
Sheng


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103648): https://edk2.groups.io/g/devel/message/103648
Mute This Topic: https://groups.io/mt/98497422/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

[Sheng Lean Tan]

Thanks Mike for the proposal layout!
It sounds good to me :)

*Hi Pedro,*
I went through the email chain again, basically these are 2 of your main
concerns (correct me if I'm wrong):
1. a good idea to at least ditch that specific copy (current FDT in
Embedded Pkg) for a git submodule.
2. Rework to remove/reduce libc Implementation as there is a problem with
both libc fragments and compiler intrinsic fragments all over edk2. Should
unify standards between crypto, libfdt, etc, could we try here

I guess Mike has provided a plan to answer your first question, and the 2nd
question would require a broader discussion with a few key owners.

So it seems like we could get the current patchset from Benny Lin in for
now? Any minor clean up needed for the current patch?



On Sat, 8 Apr 2023 at 01:04, Kinney, Michael D 
wrote:

> The main advantage of the new lib is that it depends on a submodule for
> the FDT
> content so we can easily move to new releases for bug fixes or features.
>
> The FDT content in the EmbeddedPkg is a snap-shot of the code from a long
> time
> ago.  We have been discouraging that approach and trying to move to
> released
> content from a well support submodule if one is available.
>
> Once this new better supported version is accepted, we can then
> incrementally
> remove the duplicate content with the existing consumers moving from use of
> EmbeddedPkg version to the MdePkg version and finally the removal of the
> duplicate content in the EmbeddedPkg.
>
> Mike
>
> > -Original Message-
> > From: Warkentin, Andrei 
> > Sent: Friday, April 7, 2023 3:36 PM
> > To: Pedro Falcato ; devel@edk2.groups.io; Tan,
> Lean Sheng 
> > Cc: Lin, Benny ; Kinney, Michael D <
> michael.d.kin...@intel.com>; Gao, Liming ;
> > Liu, Zhiguang ; Sean Brogan <
> sean.bro...@microsoft.com>; Michael Kubacki 
> > Subject: RE: [edk2-devel] [PATCH 0/2] Support FDT library.
> >
> > I think in general it would be nice to understand the long term picture
> of a change, esp. since there is already FDT support in
> > EDK2 in various forms (with libraries and drivers depending on the
> existing FdtLib). So it would really of confusing to see
> > another FDT library in MdePkg, without a clear reasoning for the work
> (this isn't reflected in the BZ) and a clear action plan
> > to end up with just one FDT library in MdePkg in some identified time
> frame.
> >
> > I do think FDT lib *does* belong in MdePkg, but it seems the shortest
> path to get there is to simply move the existing
> > EmbeddedPkg one (and update all users). Subsequent cleanup can be
> incremental. And regardless, every existing FdtLib user ought
> > to be updated to use the new one, so there need to be more patches
> (we're not just throwing the code over the wall, right?)
> >
> > A
> >
> > > -Original Message-
> > > From: Pedro Falcato 
> > > Sent: Friday, April 7, 2023 8:24 AM
> > > To: devel@edk2.groups.io; Tan, Lean Sheng 
> > > Cc: Warkentin, Andrei ; Lin, Benny
> > > ; Kinney, Michael D ;
> > > Gao, Liming ; Liu, Zhiguang
> > > ; Sean Brogan ;
> > > Michael Kubacki 
> > > Subject: Re: [edk2-devel] [PATCH 0/2] Support FDT library.
> > >
> > > On Thu, Apr 6, 2023 at 5:34 PM Sheng Lean Tan
> > >  wrote:
> > > >
> > > > Thanks for the nice feedback Pedro, Gerd and Andrei! Yeah it seems
> like a
> > > valid concern here as Mik mentioned on edk2-libc, and it seems to fits
> edk2
> > > long term interest on this.
> > > > Can we file this as an issue in Bugzilla for tracking or something?
> Since this
> > > will take some time to work on this as it involves a bigger discussion,
> > > personally I think we could get this FDT patch in first meanwhile, and
> also
> > > remove the FDT from Embedded Pkg as next step, per discussion with
> Leif?
> > > > What do you think?
> > >
> > > I'm all for not merging this without a proper solution in that regard
> (I even
> > > presented a quick RFC solution which wasn't tested by anyone involved
> in
> > > this patch, yet).
> > >
> > > But if there really is an urgent need for this lib, I'm O-K with
> merging this
> > > given that all my concerns are addressed (minus libc duplication).
> > >
> > > --
> > > Pedro
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102830): https://edk2.groups.io/g/devel/message/102830
Mute This Topic: https://groups.io/mt/97955736/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] Support FDT library.

[Sheng Lean Tan]

Thanks for the nice feedback Pedro, Gerd and Andrei! Yeah it seems like a
valid concern here as Mik mentioned on edk2-libc, and it seems to fits edk2
long term interest on this.
Can we file this as an issue in Bugzilla for tracking or something? Since
this will take some time to work on this as it involves a bigger
discussion, personally I think we could get this FDT patch in first
meanwhile, and also remove the FDT from Embedded Pkg as next step, per
discussion with Leif?
What do you think?




On Sat, 1 Apr 2023 at 03:30, Andrei Warkentin 
wrote:

> How does this relate to the existing EmbeddedPkg/Library/FdtLib code? Is
> there a specific plan to move away from this in existing components?
>
> I did look in the BZ (https://bugzilla.tianocore.org/show_bug.cgi?id=4392)
> but this doesn't seem to acknowledge that there is existing Fdt support in
> EmbeddedPkg.
>
> A
>
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of Benny
> > Lin
> > Sent: Thursday, March 30, 2023 11:52 AM
> > To: devel@edk2.groups.io
> > Cc: Lin, Benny ; Kinney, Michael D
> > ; Gao, Liming ;
> > Liu, Zhiguang ; Sean Brogan
> > ; Michael Kubacki
> > 
> > Subject: [edk2-devel] [PATCH 0/2] Support FDT library.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4392
> > Add FDT support in EDK2 by submodule 3rd party libfdt
> > (https://github.com/devicetree-org/pylibfdt/tree/main/libfdt)
> >
> > Cc: Michael D Kinney 
> > Cc: Liming Gao 
> > Cc: Zhiguang Liu 
> > Cc: Sean Brogan 
> > Cc: Michael Kubacki 
> > Signed-off-by: Benny Lin 
> >
> > Benny Lin (2):
> >   MdePkg: Support FDT library.
> >   .pytool: Support FDT library.
> >
> >  .gitmodules   |   3 +
> >  .pytool/CISettings.py |   2 +
> >  MdePkg/Include/Library/FdtLib.h   | 300 ++
> >  MdePkg/Library/BaseFdtLib/BaseFdtLib.inf  |  62 +
> > MdePkg/Library/BaseFdtLib/BaseFdtLib.uni  |  14 +
> >  MdePkg/Library/BaseFdtLib/FdtLib.c| 284 
> >  MdePkg/Library/BaseFdtLib/LibFdtSupport.h | 102 
> > MdePkg/Library/BaseFdtLib/LibFdtWrapper.c | 138 ++
> >  MdePkg/Library/BaseFdtLib/libfdt  |   1 +
> >  MdePkg/Library/BaseFdtLib/limits.h|  10 +
> >  MdePkg/Library/BaseFdtLib/stdbool.h   |  10 +
> >  MdePkg/Library/BaseFdtLib/stddef.h|  10 +
> >  MdePkg/Library/BaseFdtLib/stdint.h|  10 +
> >  MdePkg/Library/BaseFdtLib/stdlib.h|  10 +
> >  MdePkg/Library/BaseFdtLib/string.h|  10 +
> >  MdePkg/MdePkg.ci.yaml |  17 +-
> >  MdePkg/MdePkg.dec |   4 +
> >  MdePkg/MdePkg.dsc |   2 +
> >  ReadMe.rst|   1 +
> >  19 files changed, 988 insertions(+), 2 deletions(-)  create mode 100644
> > MdePkg/Include/Library/FdtLib.h  create mode 100644
> > MdePkg/Library/BaseFdtLib/BaseFdtLib.inf
> >  create mode 100644 MdePkg/Library/BaseFdtLib/BaseFdtLib.uni
> >  create mode 100644 MdePkg/Library/BaseFdtLib/FdtLib.c
> >  create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtSupport.h
> >  create mode 100644 MdePkg/Library/BaseFdtLib/LibFdtWrapper.c
> >  create mode 16 MdePkg/Library/BaseFdtLib/libfdt  create mode 100644
> > MdePkg/Library/BaseFdtLib/limits.h
> >  create mode 100644 MdePkg/Library/BaseFdtLib/stdbool.h
> >  create mode 100644 MdePkg/Library/BaseFdtLib/stddef.h
> >  create mode 100644 MdePkg/Library/BaseFdtLib/stdint.h
> >  create mode 100644 MdePkg/Library/BaseFdtLib/stdlib.h
> >  create mode 100644 MdePkg/Library/BaseFdtLib/string.h
> >
> > --
> > 2.39.1.windows.1
> >
> >
> >
> >
> >
>
>
>
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102625): https://edk2.groups.io/g/devel/message/102625
Mute This Topic: https://groups.io/mt/97955736/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

[Sheng Lean Tan]

Hi,
Can anyone help to look into this?
Thanks.


On Tue, 4 Apr 2023 at 14:46, Lean Sheng Tan  wrote:

>
> Hi Rebecca/ Marvin,
> Patrick has filed it as a separate patch email here
> https://edk2.groups.io/g/devel/message/102168
> However the email still group them together.
> It is because he could not reproduce any issue anymore that was seen on
> 2nd patch (could be that Rebecca already fixed it).
> Could you help to review and get this merged?
>
> Thanks,
> Sheng
>
>
> On Thu, 30 Mar 2023 at 10:05, Marvin Häuser  wrote:
>
>> Hi Lean,
>>
>> I don’t think individual patches from a series are merged generally. Your
>> 2/3 has open concerns from both Liming and myself.
>>
>> Best regards,
>> Marvin
>>
>> On 30. Mar 2023, at 09:31, Lean Sheng Tan 
>> wrote:
>>
>> 
>> HI Liming,
>> If no further concern, would you mind to help get this patch merged?
>> Thanks!
>>
>> Best Regards,
>> *Lean Sheng Tan*
>>
>>
>> On Tue, 28 Mar 2023 at 07:42, gaoliming via groups.io > byosoft.com...@groups.io> wrote:
>>
>>> Reviewed-by: Liming Gao 
>>>
>>> > -邮件原件-
>>> > 发件人: devel@edk2.groups.io  代表 Patrick
>>> > Rudolph
>>> > 发送时间: 2023年3月17日 22:06
>>> > 抄送: devel@edk2.groups.io; guo.d...@intel.com; gua@intel.com;
>>> > james...@intel.com; ray...@intel.com; mhaeu...@posteo.de;
>>> > a...@kernel.org
>>> > 主题: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking
>>> using
>>> > CLANGDWARF_IA32
>>> >
>>> > The clang toolchain might default to fPIE/fPIC, which prevents
>>> > lld from linking the objects into a binary.
>>> >
>>> > Specify -fno-pie -fno-pic as done on GCC to fix linking.
>>> >
>>> > Test:
>>> > Building the Universal Payload using the command
>>> > 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually
>>> > works.
>>> >
>>> > Signed-off-by: Patrick Rudolph 
>>> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4356
>>> > ---
>>> >  BaseTools/Conf/tools_def.template | 14 +++---
>>> >  1 file changed, 7 insertions(+), 7 deletions(-)
>>> >
>>> > diff --git a/BaseTools/Conf/tools_def.template
>>> > b/BaseTools/Conf/tools_def.template
>>> > index 471eb67c0c..9b59bd75c3 100755
>>> > --- a/BaseTools/Conf/tools_def.template
>>> > +++ b/BaseTools/Conf/tools_def.template
>>> > @@ -2888,7 +2888,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
>>> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
>>> >  *_CLANGDWARF_IA32_RC_PATH  =
>>> > DEF(CLANGDWARF_IA32_PREFIX)llvm-rc
>>> >
>>> >
>>> >
>>> >  *_CLANGDWARF_IA32_ASLCC_FLAGS  = DEF(GCC_ASLCC_FLAGS)
>>> > -m32 -fno-lto DEF(CLANG38_IA32_TARGET)
>>> >
>>> > -*_CLANGDWARF_IA32_ASLDLINK_FLAGS   =
>>> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
>>> >
>>> > +*_CLANGDWARF_IA32_ASLDLINK_FLAGS   =
>>> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
>>> > -no-pie
>>> >
>>> >  *_CLANGDWARF_IA32_ASM_FLAGS= DEF(GCC5_ASM_FLAGS)
>>> > -m32 -march=i386 DEF(CLANG38_IA32_TARGET)
>>> >
>>> >  *_CLANGDWARF_IA32_RC_FLAGS =
>>> > DEF(GCC_IA32_RC_FLAGS)
>>> >
>>> >  *_CLANGDWARF_IA32_OBJCOPY_FLAGS=
>>> >
>>> > @@ -2897,17 +2897,17 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
>>> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
>>> >  *_CLANGDWARF_IA32_ASLPP_FLAGS  = DEF(GCC_ASLPP_FLAGS)
>>> > DEF(CLANG38_IA32_TARGET)
>>> >
>>> >  *_CLANGDWARF_IA32_VFRPP_FLAGS  = DEF(GCC_VFRPP_FLAGS)
>>> > DEF(CLANG38_IA32_TARGET)
>>> >
>>> >
>>> >
>>> > -DEBUG_CLANGDWARF_IA32_CC_FLAGS =
>>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
>>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>>> >
>>> > +DEBUG_CLANGDWARF_IA32_CC_FLAGS =
>>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
>>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>>> >
>>> >  DEBUG_CLANGDWARF_IA32_DLINK_FLAGS  =
>>> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
>>> > -Wl,--oformat,elf32-i386
>>> >
>>> > -DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
>>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
>>> >
>>> > +DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
>>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
>>> >
>>> >
>>> >
>>> > -RELEASE_CLANGDWARF_IA32_CC_FLAGS   =
>>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
>>> > DEF(CLANG38_IA32_TARGET) -malign-double
>>> >
>>> > +RELEASE_CLANGDWARF_IA32_CC_FLAGS   =
>>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
>>> > DEF(CLANG38_IA32_TARGET) -malign-double
>>> >
>>> >  RELEASE_CLANGDWARF_IA32_DLINK_FLAGS=
>>> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
>>> > -Wl,--oformat,elf32-i386
>>> >
>>> > -RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS   =
>>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
>>> >
>>> > +RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS   =
>>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
>>> >
>>> >
>>> >
>>> > -NOOPT_CLANGDWARF_IA32_CC_FLAGS =
>>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

[Sheng Lean Tan]

Hi Rebecca/ Marvin,
Patrick has filed it as a separate patch email here
https://edk2.groups.io/g/devel/message/102168
However the email still group them together.
It is because he could not reproduce any issue anymore that was seen on 2nd
patch (could be that Rebecca already fixed it).
Could you help to review and get this merged?

Thanks,
Sheng


On Thu, 30 Mar 2023 at 10:05, Marvin Häuser  wrote:

> Hi Lean,
>
> I don’t think individual patches from a series are merged generally. Your
> 2/3 has open concerns from both Liming and myself.
>
> Best regards,
> Marvin
>
> On 30. Mar 2023, at 09:31, Lean Sheng Tan  wrote:
>
> 
> HI Liming,
> If no further concern, would you mind to help get this patch merged?
> Thanks!
>
> Best Regards,
> *Lean Sheng Tan*
>
>
> On Tue, 28 Mar 2023 at 07:42, gaoliming via groups.io  byosoft.com...@groups.io> wrote:
>
>> Reviewed-by: Liming Gao 
>>
>> > -邮件原件-
>> > 发件人: devel@edk2.groups.io  代表 Patrick
>> > Rudolph
>> > 发送时间: 2023年3月17日 22:06
>> > 抄送: devel@edk2.groups.io; guo.d...@intel.com; gua@intel.com;
>> > james...@intel.com; ray...@intel.com; mhaeu...@posteo.de;
>> > a...@kernel.org
>> > 主题: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using
>> > CLANGDWARF_IA32
>> >
>> > The clang toolchain might default to fPIE/fPIC, which prevents
>> > lld from linking the objects into a binary.
>> >
>> > Specify -fno-pie -fno-pic as done on GCC to fix linking.
>> >
>> > Test:
>> > Building the Universal Payload using the command
>> > 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually
>> > works.
>> >
>> > Signed-off-by: Patrick Rudolph 
>> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4356
>> > ---
>> >  BaseTools/Conf/tools_def.template | 14 +++---
>> >  1 file changed, 7 insertions(+), 7 deletions(-)
>> >
>> > diff --git a/BaseTools/Conf/tools_def.template
>> > b/BaseTools/Conf/tools_def.template
>> > index 471eb67c0c..9b59bd75c3 100755
>> > --- a/BaseTools/Conf/tools_def.template
>> > +++ b/BaseTools/Conf/tools_def.template
>> > @@ -2888,7 +2888,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
>> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
>> >  *_CLANGDWARF_IA32_RC_PATH  =
>> > DEF(CLANGDWARF_IA32_PREFIX)llvm-rc
>> >
>> >
>> >
>> >  *_CLANGDWARF_IA32_ASLCC_FLAGS  = DEF(GCC_ASLCC_FLAGS)
>> > -m32 -fno-lto DEF(CLANG38_IA32_TARGET)
>> >
>> > -*_CLANGDWARF_IA32_ASLDLINK_FLAGS   =
>> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
>> >
>> > +*_CLANGDWARF_IA32_ASLDLINK_FLAGS   =
>> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
>> > -no-pie
>> >
>> >  *_CLANGDWARF_IA32_ASM_FLAGS= DEF(GCC5_ASM_FLAGS)
>> > -m32 -march=i386 DEF(CLANG38_IA32_TARGET)
>> >
>> >  *_CLANGDWARF_IA32_RC_FLAGS =
>> > DEF(GCC_IA32_RC_FLAGS)
>> >
>> >  *_CLANGDWARF_IA32_OBJCOPY_FLAGS=
>> >
>> > @@ -2897,17 +2897,17 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
>> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
>> >  *_CLANGDWARF_IA32_ASLPP_FLAGS  = DEF(GCC_ASLPP_FLAGS)
>> > DEF(CLANG38_IA32_TARGET)
>> >
>> >  *_CLANGDWARF_IA32_VFRPP_FLAGS  = DEF(GCC_VFRPP_FLAGS)
>> > DEF(CLANG38_IA32_TARGET)
>> >
>> >
>> >
>> > -DEBUG_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> > +DEBUG_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> >  DEBUG_CLANGDWARF_IA32_DLINK_FLAGS  =
>> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
>> > -Wl,--oformat,elf32-i386
>> >
>> > -DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
>> >
>> > +DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
>> >
>> >
>> >
>> > -RELEASE_CLANGDWARF_IA32_CC_FLAGS   =
>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -malign-double
>> >
>> > +RELEASE_CLANGDWARF_IA32_CC_FLAGS   =
>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
>> > DEF(CLANG38_IA32_TARGET) -malign-double
>> >
>> >  RELEASE_CLANGDWARF_IA32_DLINK_FLAGS=
>> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
>> > -Wl,--oformat,elf32-i386
>> >
>> > -RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS   =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
>> >
>> > +RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS   =
>> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
>> >
>> >
>> >
>> > -NOOPT_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> > +NOOPT_CLANGDWARF_IA32_CC_FLAGS =
>> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -O0 -march=i586
>> > DEF(CLANG38_IA32_TARGET) -g -malign-double
>> >
>> >  NOOPT_CLANGDWARF_IA32_DLI

Re: [edk2-devel] [PATCH 1/1] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

[Sheng Lean Tan]

Can anyone help to review this?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102481): https://edk2.groups.io/g/devel/message/102481
Mute This Topic: https://groups.io/mt/97947217/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

[Sheng Lean Tan]

HI Liming,
If no further concern, would you mind to help get this patch merged?
Thanks!

Best Regards,
*Lean Sheng Tan*


On Tue, 28 Mar 2023 at 07:42, gaoliming via groups.io  wrote:

> Reviewed-by: Liming Gao 
>
> > -邮件原件-
> > 发件人: devel@edk2.groups.io  代表 Patrick
> > Rudolph
> > 发送时间: 2023年3月17日 22:06
> > 抄送: devel@edk2.groups.io; guo.d...@intel.com; gua@intel.com;
> > james...@intel.com; ray...@intel.com; mhaeu...@posteo.de;
> > a...@kernel.org
> > 主题: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using
> > CLANGDWARF_IA32
> >
> > The clang toolchain might default to fPIE/fPIC, which prevents
> > lld from linking the objects into a binary.
> >
> > Specify -fno-pie -fno-pic as done on GCC to fix linking.
> >
> > Test:
> > Building the Universal Payload using the command
> > 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually
> > works.
> >
> > Signed-off-by: Patrick Rudolph 
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4356
> > ---
> >  BaseTools/Conf/tools_def.template | 14 +++---
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template
> > b/BaseTools/Conf/tools_def.template
> > index 471eb67c0c..9b59bd75c3 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -2888,7 +2888,7 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
> >  *_CLANGDWARF_IA32_RC_PATH  =
> > DEF(CLANGDWARF_IA32_PREFIX)llvm-rc
> >
> >
> >
> >  *_CLANGDWARF_IA32_ASLCC_FLAGS  = DEF(GCC_ASLCC_FLAGS)
> > -m32 -fno-lto DEF(CLANG38_IA32_TARGET)
> >
> > -*_CLANGDWARF_IA32_ASLDLINK_FLAGS   =
> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
> >
> > +*_CLANGDWARF_IA32_ASLDLINK_FLAGS   =
> > DEF(CLANGDWARF_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -fuse-ld=lld
> > -no-pie
> >
> >  *_CLANGDWARF_IA32_ASM_FLAGS= DEF(GCC5_ASM_FLAGS)
> > -m32 -march=i386 DEF(CLANG38_IA32_TARGET)
> >
> >  *_CLANGDWARF_IA32_RC_FLAGS =
> > DEF(GCC_IA32_RC_FLAGS)
> >
> >  *_CLANGDWARF_IA32_OBJCOPY_FLAGS=
> >
> > @@ -2897,17 +2897,17 @@ DEFINE CLANGDWARF_X64_DLINK2_FLAGS
> > = -Wl,--defsym=PECOFF_HEADER_SIZE=0x22
> >  *_CLANGDWARF_IA32_ASLPP_FLAGS  = DEF(GCC_ASLPP_FLAGS)
> > DEF(CLANG38_IA32_TARGET)
> >
> >  *_CLANGDWARF_IA32_VFRPP_FLAGS  = DEF(GCC_VFRPP_FLAGS)
> > DEF(CLANG38_IA32_TARGET)
> >
> >
> >
> > -DEBUG_CLANGDWARF_IA32_CC_FLAGS =
> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
> > DEF(CLANG38_IA32_TARGET) -g -malign-double
> >
> > +DEBUG_CLANGDWARF_IA32_CC_FLAGS =
> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
> > DEF(CLANG38_IA32_TARGET) -g -malign-double
> >
> >  DEBUG_CLANGDWARF_IA32_DLINK_FLAGS  =
> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
> > -Wl,--oformat,elf32-i386
> >
> > -DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
> >
> > +DEBUG_CLANGDWARF_IA32_DLINK2_FLAGS =
> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
> >
> >
> >
> > -RELEASE_CLANGDWARF_IA32_CC_FLAGS   =
> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -Oz -flto -march=i586
> > DEF(CLANG38_IA32_TARGET) -malign-double
> >
> > +RELEASE_CLANGDWARF_IA32_CC_FLAGS   =
> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -Oz -flto -march=i586
> > DEF(CLANG38_IA32_TARGET) -malign-double
> >
> >  RELEASE_CLANGDWARF_IA32_DLINK_FLAGS=
> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -flto -Wl,-O3 -Wl,-melf_i386
> > -Wl,--oformat,elf32-i386
> >
> > -RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS   =
> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld
> >
> > +RELEASE_CLANGDWARF_IA32_DLINK2_FLAGS   =
> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O3 -fuse-ld=lld -no-pie
> >
> >
> >
> > -NOOPT_CLANGDWARF_IA32_CC_FLAGS =
> > DEF(CLANG38_ALL_CC_FLAGS) -m32 -O0 -march=i586
> > DEF(CLANG38_IA32_TARGET) -g -malign-double
> >
> > +NOOPT_CLANGDWARF_IA32_CC_FLAGS =
> > DEF(CLANG38_ALL_CC_FLAGS) -fno-pic -fno-pie -m32 -O0 -march=i586
> > DEF(CLANG38_IA32_TARGET) -g -malign-double
> >
> >  NOOPT_CLANGDWARF_IA32_DLINK_FLAGS  =
> > DEF(CLANGDWARF_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_i386
> > -Wl,--oformat,elf32-i386
> >
> > -NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =
> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=lld
> >
> > +NOOPT_CLANGDWARF_IA32_DLINK2_FLAGS =
> > DEF(CLANGDWARF_IA32_DLINK2_FLAGS) -O0 -fuse-ld=lld -no-pie
> >
> >
> >
> >  ##
> >
> >  # CLANGDWARF X64 definitions
> >
> > --
> > 2.39.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#101340):
> > https://edk2.groups.io/g/devel/message/101340
> > Mute This Topic: https://groups.io/mt/97673648/4905953
> > Group Owner: devel+ow...@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [gaolim...@byosoft.co

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

[Sheng Lean Tan]

Added @rebe...@bsdio.com  as well.


On Sun, 26 Mar 2023 at 21:39, Sheng Lean Tan via groups.io  wrote:

> Can someone also help to review this please?
> Thanks.
>
>
> On Fri, 17 Mar 2023 at 15:06, Patrick Rudolph <
> patrick.rudo...@9elements.com> wrote:
>
>> Drop the "-z max-page-size=0x40" option as it causes the ELF
>> header to overflow into the .text section, causing undefined
>> behaviour.
>>
>> With high optimization level it corrupts essential code and
>> the binary would crash. It might work with low optimization
>> level though. As the default is to use Oz and LTO, it always
>> crashes.
>>
>> Test:
>> The ELF generated by
>> 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' boots.
>>
>> Signed-off-by: Patrick Rudolph 
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4357
>> ---
>>  BaseTools/Conf/tools_def.template | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/BaseTools/Conf/tools_def.template
>> b/BaseTools/Conf/tools_def.template
>> index 9b59bd75c3..0c584ab390 100755
>> --- a/BaseTools/Conf/tools_def.template
>> +++ b/BaseTools/Conf/tools_def.template
>> @@ -2866,7 +2866,7 @@ DEFINE CLANGDWARF_X64_PREFIX= ENV(CLANG_BIN)
>>
>>  # LLVM/CLANG doesn't support -n link option. So, it can't share the same
>> IA32_X64_DLINK_COMMON flag.
>>  # LLVM/CLANG doesn't support common page size. So, it can't share the
>> same GccBase.lds script.
>> -DEFINE CLANGDWARF_IA32_X64_DLINK_COMMON   = -nostdlib
>> -Wl,-q,--gc-sections -z max-page-size=0x40
>> +DEFINE CLANGDWARF_IA32_X64_DLINK_COMMON   = -nostdlib
>> -Wl,-q,--gc-sections
>>  DEFINE CLANGDWARF_DLINK2_FLAGS_COMMON =
>> -Wl,--script=$(EDK_TOOLS_PATH)/Scripts/ClangBase.lds
>>  DEFINE CLANGDWARF_IA32_X64_ASLDLINK_FLAGS =
>> DEF(CLANGDWARF_IA32_X64_DLINK_COMMON) -Wl,--defsym=PECOFF_HEADER_SIZE=0
>> DEF(CLANGDWARF_DLINK2_FLAGS_COMMON) -Wl,--entry,ReferenceAcpiTable -u
>> ReferenceAcpiTable
>>  DEFINE CLANGDWARF_IA32_X64_DLINK_FLAGS=
>> DEF(CLANGDWARF_IA32_X64_DLINK_COMMON) -Wl,--entry,$(IMAGE_ENTRY_POINT) -u
>> $(IMAGE_ENTRY_POINT)
>> -Wl,-Map,$(DEST_DIR_DEBUG)/$(BASE_NAME).map,--whole-archive
>> --
>> 2.39.1
>>
>>
>>
>> 
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#101341):
>> https://edk2.groups.io/g/devel/message/101341
>> Mute This Topic: https://groups.io/mt/97673649/6757431
>> Group Owner: devel+ow...@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [
>> sheng@9elements.com]
>> 
>>
>>
>> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101906): https://edk2.groups.io/g/devel/message/101906
Mute This Topic: https://groups.io/mt/97673649/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

[Sheng Lean Tan]

Can someone also help to review this please?
Thanks.


On Fri, 17 Mar 2023 at 15:06, Patrick Rudolph 
wrote:

> Drop the "-z max-page-size=0x40" option as it causes the ELF
> header to overflow into the .text section, causing undefined
> behaviour.
>
> With high optimization level it corrupts essential code and
> the binary would crash. It might work with low optimization
> level though. As the default is to use Oz and LTO, it always
> crashes.
>
> Test:
> The ELF generated by
> 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' boots.
>
> Signed-off-by: Patrick Rudolph 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4357
> ---
>  BaseTools/Conf/tools_def.template | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 9b59bd75c3..0c584ab390 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -2866,7 +2866,7 @@ DEFINE CLANGDWARF_X64_PREFIX= ENV(CLANG_BIN)
>
>  # LLVM/CLANG doesn't support -n link option. So, it can't share the same
> IA32_X64_DLINK_COMMON flag.
>  # LLVM/CLANG doesn't support common page size. So, it can't share the
> same GccBase.lds script.
> -DEFINE CLANGDWARF_IA32_X64_DLINK_COMMON   = -nostdlib
> -Wl,-q,--gc-sections -z max-page-size=0x40
> +DEFINE CLANGDWARF_IA32_X64_DLINK_COMMON   = -nostdlib -Wl,-q,--gc-sections
>  DEFINE CLANGDWARF_DLINK2_FLAGS_COMMON =
> -Wl,--script=$(EDK_TOOLS_PATH)/Scripts/ClangBase.lds
>  DEFINE CLANGDWARF_IA32_X64_ASLDLINK_FLAGS =
> DEF(CLANGDWARF_IA32_X64_DLINK_COMMON) -Wl,--defsym=PECOFF_HEADER_SIZE=0
> DEF(CLANGDWARF_DLINK2_FLAGS_COMMON) -Wl,--entry,ReferenceAcpiTable -u
> ReferenceAcpiTable
>  DEFINE CLANGDWARF_IA32_X64_DLINK_FLAGS=
> DEF(CLANGDWARF_IA32_X64_DLINK_COMMON) -Wl,--entry,$(IMAGE_ENTRY_POINT) -u
> $(IMAGE_ENTRY_POINT)
> -Wl,-Map,$(DEST_DIR_DEBUG)/$(BASE_NAME).map,--whole-archive
> --
> 2.39.1
>
>
>
> 
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#101341): https://edk2.groups.io/g/devel/message/101341
> Mute This Topic: https://groups.io/mt/97673649/6757431
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [sheng@9elements.com
> ]
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101905): https://edk2.groups.io/g/devel/message/101905
Mute This Topic: https://groups.io/mt/97673649/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

[Sheng Lean Tan]

Would anyone mind to spare some time to review this patch?
Thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101904): https://edk2.groups.io/g/devel/message/101904
Mute This Topic: https://groups.io/mt/97673648/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32

[Sheng Lean Tan]

Added the right reviewers @Gao, Liming   @Feng,
Bob C  @yuwei.c...@intel.com 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101695): https://edk2.groups.io/g/devel/message/101695
Mute This Topic: https://groups.io/mt/97673648/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

[Sheng Lean Tan]

> Another reminder, thanks.
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101484): https://edk2.groups.io/g/devel/message/101484
Mute This Topic: https://groups.io/mt/97727098/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[Sheng Lean Tan]

Another reminder, thanks.

>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101483): https://edk2.groups.io/g/devel/message/101483
Mute This Topic: https://groups.io/mt/97727097/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

[Sheng Lean Tan]

Can anyone help to review this? Thanks :)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101451): https://edk2.groups.io/g/devel/message/101451
Mute This Topic: https://groups.io/mt/97727097/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

[Sheng Lean Tan]

Can anyone help to review this? Thanks :)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101450): https://edk2.groups.io/g/devel/message/101450
Mute This Topic: https://groups.io/mt/97727098/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

Hi Ray,Any feedback per Mic feedback?On 15. Mar 2023, at 16:35, Michael D Kinney  wrote:









HI Ray,
 
I think it is a reasonable request to have the EDK II logo driver support multiple standards for the logo location. 
Especially if they are documented in public specifications.
 
The additional conditions of supporting a logo larger than the display resolution also looks like a good corner case to cover
 no matter what logo location standard is used.
 
Perhaps a single PCD that is
a enum of logo locations. 
Default 0x00 can be EDK II default that is centered in the display. 
0x01 can be BGRT.  Leaves from for more if there are additional public standard logo locations.
 
Mike
 
 



From: Ni, Ray 

Sent: Wednesday, March 15, 2023 2:24 AM
To: devel@edk2.groups.io; Rhodes, Sean 
Cc: Kinney, Michael D ; Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 
What’s the meaning of “have both options”?
If you want to support two cases, put the logic in your platform specific Logo driver.
This Logo driver is just for reference.
 



From: 
devel@edk2.groups.io 
On Behalf Of Sean Rhodes
Sent: Friday, March 10, 2023 9:43 PM
To: Ni, Ray 
Cc: devel@edk2.groups.io; Kinney, Michael D ; Gao, Zhichao ; Wang,
 Jian J ; Gao, Liming 
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 



Hi Ray


 


> You can return a carefully-calculated X/Y value to make the logo at MS preferred position.

As we discussed before, we need to have both options.


 


Thanks


 


Sean

 


On Wed, 8 Mar 2023 at 09:01, Ni, Ray  wrote:





Maybe I didn’t explain my idea clearly.
That is:
    You can get the screen resolution in the code that produces Logo protocol.
    You can return a carefully-calculated X/Y value to make the logo at MS preferred position.
 



From: devel@edk2.groups.io 
On Behalf Of Ni, Ray
Sent: Wednesday, October 26, 2022 10:32 AM
To: Kinney, Michael D ;
devel@edk2.groups.io; Rhodes, Sean 
Cc: Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 
Are you suggesting that the exiting logic be updated for this use case without adding a new enum?


yes. 
 




From: Kinney, Michael D 

Sent: Wednesday, October 26, 2022 12:21 AM
To: devel@edk2.groups.io; Ni, Ray ; Rhodes, Sean ;
 Kinney, Michael D 
Cc: Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 
Ray,
 
Are you suggesting that the exiting logic be updated for this use case without adding a new enum?
 
Sean, can you provide a revised patch that does this?
 
Thanks,
 
Mike
 



From: devel@edk2.groups.io 
On Behalf Of Ni, Ray
Sent: Tuesday, October 25, 2022 12:58 AM
To: devel@edk2.groups.io; Rhodes, Sean 
Cc: Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 
I need a reason of adding EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended.
In my opinion, without adding this new enum value, it’s still possible to support MS recommendation.
 




From: devel@edk2.groups.io 
On Behalf Of Sean Rhodes
Sent: Tuesday, October 25, 2022 3:27 PM
To: Ni, Ray 
Cc: devel@edk2.groups.io; Gao, Zhichao ; Wang, Jian J ;
 Gao, Liming 
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 


Hi Ray


 


Where would you suggest this code goes? edk2 should support both Microsoft recommended and "normal". The original patch handled
 this well.


 


Thanks


 


Sean


 


On Mon, 10 Oct 2022 at 10:25, Ni, Ray  wrote:





The logic I shared below is from the LogoDxe driver which produces EDKII_PLATFORM_LOGO_PROTOCOL.
This driver should know the image size and it can account for the image size.
 
Thanks,
Ray
 




From: Sean Rhodes 

Sent: Monday, October 10, 2022 4:51 PM
To: Ni, Ray 
Cc: devel@edk2.groups.io; Gao, Zhichao ; Wang, Jian J ;
 Gao, Liming 

Re: [edk2-devel] [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX

[Sheng Lean Tan]

Added Zhichao.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101239): https://edk2.groups.io/g/devel/message/101239
Mute This Topic: https://groups.io/mt/97421038/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

[Sheng Lean Tan]

adding the right reviewers.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101238): https://edk2.groups.io/g/devel/message/101238
Mute This Topic: https://groups.io/mt/97421037/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32_X64

[Sheng Lean Tan]

I think the right reviewer was not added.
Added them.

On Wed, 15 Mar 2023 at 17:46, Sheng Lean Tan via groups.io  wrote:

> Hi all,
> Can someone please help to review this?
> Thanks.
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101237): https://edk2.groups.io/g/devel/message/101237
Mute This Topic: https://groups.io/mt/97421035/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32_X64

[Sheng Lean Tan]

Hi all,
Can someone please help to review this?
Thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101236): https://edk2.groups.io/g/devel/message/101236
Mute This Topic: https://groups.io/mt/97421035/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

[Sheng Lean Tan]

Hi Liming/ Ray,
Could you help to merge?
Thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101235): https://edk2.groups.io/g/devel/message/101235
Mute This Topic: https://groups.io/mt/97487045/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

Hi Ray,Again - any update on this. Thanks.On 13. Mar 2023, at 12:49, Lean Sheng Tan  wrote:Hi Ray,What is your thought on this?Best Regards,Lean Sheng Tan9elements GmbH, Kortumstraße 19-21, 44787 Bochum, GermanyEmail: sheng@9elements.comPhone: +49 234 68 94 188Mobile: +49 176 76 113842Registered office: BochumCommercial register: Amtsgericht Bochum, HRB 17519Management: Sebastian German, Eray BazaarData protection information according to Art. 13 GDPROn Fri, 10 Mar 2023 at 14:43, Sean Rhodes  wrote:Hi Ray> You can return a carefully-calculated X/Y value to make the logo at MS preferred position.As we discussed before, we need to have both options.ThanksSeanOn Wed, 8 Mar 2023 at 09:01, Ni, Ray  wrote:







Maybe I didn’t explain my idea clearly.
That is:
    You can get the screen resolution in the code that produces Logo protocol.
    You can return a carefully-calculated X/Y value to make the logo at MS preferred position.
 


From: devel@edk2.groups.io  
On Behalf Of Ni, Ray
Sent: Wednesday, October 26, 2022 10:32 AM
To: Kinney, Michael D ; devel@edk2.groups.io; Rhodes, Sean 
Cc: Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 
Are you suggesting that the exiting logic be updated for this use case without adding a new enum?

yes.

 



From: Kinney, Michael D 

Sent: Wednesday, October 26, 2022 12:21 AM
To: devel@edk2.groups.io; Ni, Ray ; Rhodes, Sean ; Kinney, Michael D 
Cc: Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 
Ray,
 
Are you suggesting that the exiting logic be updated for this use case without adding a new enum?
 
Sean, can you provide a revised patch that does this?
 
Thanks,
 
Mike
 


From: devel@edk2.groups.io 
On Behalf Of Ni, Ray
Sent: Tuesday, October 25, 2022 12:58 AM
To: devel@edk2.groups.io; Rhodes, Sean 
Cc: Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 
I need a reason of adding EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended.
In my opinion, without adding this new enum value, it’s still possible to support MS recommendation.
 



From: devel@edk2.groups.io 
On Behalf Of Sean Rhodes
Sent: Tuesday, October 25, 2022 3:27 PM
To: Ni, Ray 
Cc: devel@edk2.groups.io; Gao, Zhichao ; Wang, Jian J ; Gao, Liming 
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 


Hi Ray


 


Where would you suggest this code goes? edk2 should support both Microsoft recommended and "normal". The original patch handled this well.


 


Thanks


 


Sean


 


On Mon, 10 Oct 2022 at 10:25, Ni, Ray  wrote:





The logic I shared below is from the LogoDxe driver which produces EDKII_PLATFORM_LOGO_PROTOCOL.
This driver should know the image size and it can account for the image size.
 
Thanks,
Ray
 



From: Sean Rhodes 

Sent: Monday, October 10, 2022 4:51 PM
To: Ni, Ray 
Cc: devel@edk2.groups.io; Gao, Zhichao ; Wang, Jian J ;
 Gao, Liming 
Subject: Re: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo


 


Hi Ray


 


Thank you, it does, and I think it will work for most splash images. However, the way it's written in my patch accounts for the
 Image size. This will handle splash images that are equal to, or larger than the resolution of the display. 


 


Thanks


 


Sean


 


On Sat, 8 Oct 2022 at 03:02, Ni, Ray  wrote:


Sean,
I remember that I evaluated the BGRT requirement when designing the PlatformLogo protocol.

So, I went back to got the code I wrote long time ago as below.
I didn't try to understand them now. Does it make sense to you?

    Status = gBS->HandleProtocol (gST->ConsoleOutHandle, &gEfiGraphicsOutputProtocolGuid, (VOID **) &GraphicsOutput);
    if (!EFI_ERROR (Status)) {
      //
      // Center of LOGO is in the vertical position 38.2% when PcdBootLogoOnlyEnable is TRUE
      // Y = (VerticalResolution - LogoHeight) / 2
      // Y' = VerticalResolution * 0.382 - LogoHeight * 0.5
      // OffsetY + Y = Y'
      // OffsetY = Y' - Y = -0.118 * VerticalResolution
      //
   

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

Hi Ray,
What is your thought on this?

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR



On Fri, 10 Mar 2023 at 14:43, Sean Rhodes  wrote:

> Hi Ray
>
> > You can return a carefully-calculated X/Y value to make
> the logo at MS preferred position.
>
> As we discussed before, we need to have both options.
>
> Thanks
>
> Sean
>
> On Wed, 8 Mar 2023 at 09:01, Ni, Ray  wrote:
>
>> Maybe I didn’t explain my idea clearly.
>>
>> That is:
>>
>> You can get the screen resolution in the code that
>> produces Logo protocol.
>>
>> You can return a carefully-calculated X/Y value to make
>> the logo at MS preferred position.
>>
>>
>>
>> *From:* devel@edk2.groups.io  * On Behalf Of *Ni,
>> Ray
>> *Sent:* Wednesday, October 26, 2022 10:32 AM
>> *To:* Kinney, Michael D ;
>> devel@edk2.groups.io; Rhodes, Sean 
>> *Cc:* Gao, Zhichao ; Wang, Jian J <
>> jian.j.w...@intel.com>; Gao, Liming 
>> *Subject:* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to
>> control the position of the Logo
>>
>>
>>
>> Are you suggesting that the exiting logic be updated for this use case
>> without adding a new enum?
>>
>>- yes.
>>
>>
>>
>> *From:* Kinney, Michael D 
>> *Sent:* Wednesday, October 26, 2022 12:21 AM
>> *To:* devel@edk2.groups.io; Ni, Ray ; Rhodes, Sean <
>> sean@starlabs.systems>; Kinney, Michael D 
>> *Cc:* Gao, Zhichao ; Wang, Jian J <
>> jian.j.w...@intel.com>; Gao, Liming 
>> *Subject:* RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to
>> control the position of the Logo
>>
>>
>>
>> Ray,
>>
>>
>>
>> Are you suggesting that the exiting logic be updated for this use case
>> without adding a new enum?
>>
>>
>>
>> Sean, can you provide a revised patch that does this?
>>
>>
>>
>> Thanks,
>>
>>
>>
>> Mike
>>
>>
>>
>> *From:* devel@edk2.groups.io  *On Behalf Of *Ni,
>> Ray
>> *Sent:* Tuesday, October 25, 2022 12:58 AM
>> *To:* devel@edk2.groups.io; Rhodes, Sean 
>> *Cc:* Gao, Zhichao ; Wang, Jian J <
>> jian.j.w...@intel.com>; Gao, Liming 
>> *Subject:* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to
>> control the position of the Logo
>>
>>
>>
>> I need a reason of adding
>> EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended.
>>
>> In my opinion, without adding this new enum value, it’s still possible to
>> support MS recommendation.
>>
>>
>>
>> *From:* devel@edk2.groups.io  *On Behalf Of *Sean
>> Rhodes
>> *Sent:* Tuesday, October 25, 2022 3:27 PM
>> *To:* Ni, Ray 
>> *Cc:* devel@edk2.groups.io; Gao, Zhichao ; Wang,
>> Jian J ; Gao, Liming 
>> *Subject:* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to
>> control the position of the Logo
>>
>>
>>
>> Hi Ray
>>
>>
>>
>> Where would you suggest this code goes? edk2 should support both
>> Microsoft recommended and "normal". The original patch handled this well.
>>
>>
>>
>> Thanks
>>
>>
>>
>> Sean
>>
>>
>>
>> On Mon, 10 Oct 2022 at 10:25, Ni, Ray  wrote:
>>
>> The logic I shared below is from the LogoDxe driver which produces
>> EDKII_PLATFORM_LOGO_PROTOCOL.
>>
>> This driver should know the image size and it can account for the image
>> size.
>>
>>
>>
>> Thanks,
>>
>> Ray
>>
>>
>>
>> *From:* Sean Rhodes 
>> *Sent:* Monday, October 10, 2022 4:51 PM
>> *To:* Ni, Ray 
>> *Cc:* devel@edk2.groups.io; Gao, Zhichao ; Wang,
>> Jian J ; Gao, Liming 
>> *Subject:* Re: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the
>> position of the Logo
>>
>>
>>
>> Hi Ray
>>
>>
>>
>> Thank you, it does, and I think it will work for most splash images.
>> However, the way it's written in my patch accounts for the Image size. This
>> will handle splash images that are equal to, or larger than the resolution
>> of the display.
>>
>>
>>
>> Thanks
>>
>>
>>
>> Sean
>>
>>
>>
>> On Sat, 8 Oct 2022 at 03:02, Ni, Ray  wrote:
>>
>> Sean,
>> I remember that I evaluated the BGRT requirement when designing the
>> PlatformLogo protocol.
>>
>> So, I went back to got the code I wrote long time ago as below.
>> I didn't try to understand them now. Does it make sense to you?
>>
>> Status = gBS->HandleProtocol (gST->ConsoleOutHandle,
>> &gEfiGraphicsOutputProtocolGuid, (VOID **) &GraphicsOutput);
>> if (!EFI_ERROR (Status)) {
>>   //
>>   // Center of LOGO is in the vertical position 38.2% when
>> PcdBootLogoOnlyEnable is TRUE
>>   // Y = (VerticalResolution - LogoHeight) / 2
>>   // Y' = VerticalResolution * 0.382 - LogoHeight * 0.5
>>   // OffsetY + Y = Y'
>>   // OffsetY = Y' - Y = -0.118 * VerticalResolution
>>   //
>>   *Attribute = EdkiiPlatformLogoDisplayAttributeCenter;
>>   *OffsetX   = 0;
>>   *Offset

Re: [edk2-devel] 回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

[Sheng Lean Tan]

Thanks Liming and Ray for looking into this. It was really frustrating that no 
one bothers to reply after keep pinging for months.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100996): https://edk2.groups.io/g/devel/message/100996
Mute This Topic: https://groups.io/mt/97487045/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

On 8. Mar 2023, at 09:55, Sheng Lean Tan  wrote:

Same here.
Seriously, what is the hold up here?
did Sean not following the process? Did he miss anything?
it just doesn’t make sense to keep ignoring this patch for half year for no 
reason. Is there a way to voice up a about this?

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100844): https://edk2.groups.io/g/devel/message/100844
Mute This Topic: https://groups.io/mt/95802829/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

It also doesn’t give good impression on edk2 if the reviewers continue to 
ignore review requests after such a long time.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100842): https://edk2.groups.io/g/devel/message/100842
Mute This Topic: https://groups.io/mt/95802829/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

Same here.
Seriously, what is the hold up here?
did Sean not following the process? Did he miss anything?
it just doesn’t make sense to keep ignoring this patch for half year for no 
reason. Is there a way to voice up a about this?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100840): https://edk2.groups.io/g/devel/message/100840
Mute This Topic: https://groups.io/mt/95802829/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

[Sheng Lean Tan]

Seriously, what is the hold up here?
did Sean not following the process? Did he miss anything?
it just doesn’t make sense to keep ignoring this patch for half year for no 
reason. Is there a way to voice up a about this?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100839): https://edk2.groups.io/g/devel/message/100839
Mute This Topic: https://groups.io/mt/95706437/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

Another kind reminder, thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100800): https://edk2.groups.io/g/devel/message/100800
Mute This Topic: https://groups.io/mt/95802829/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

[Sheng Lean Tan]

Another kind reminder, thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100799): https://edk2.groups.io/g/devel/message/100799
Mute This Topic: https://groups.io/mt/95706437/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

[Sheng Lean Tan]

@Jian J Wang 
Any update on this? Anything needs to be done from our side?
Thanks.

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR
<https://9elements.com/privacy>


On Fri, 17 Feb 2023 at 13:57, Sheng Lean Tan via groups.io  wrote:

> Hi,
> A kind reminder - has this been merged?
>
> Best Regards,
> *Lean Sheng Tan*
>
>
>
> 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email: sheng@9elements.com
> Phone: *+49 234 68 94 188 <+492346894188>*
> Mobile: *+49 176 76 113842 <+4917676113842>*
>
> Registered office: Bochum
> Commercial register: Amtsgericht Bochum, HRB 17519
> Management: Sebastian German, Eray Bazaar
>
> Data protection information according to Art. 13 GDPR
> <https://9elements.com/privacy>
>
>
> On Mon, 13 Feb 2023 at 12:57, Ni, Ray  wrote:
>
>> @Wang, Jian J 
>>
>> thanks,
>> ray
>> --
>> *From:* devel@edk2.groups.io  on behalf of Sheng
>> Lean Tan 
>> *Sent:* Monday, February 13, 2023 6:01:21 PM
>> *To:* Rhodes, Sean ; devel@edk2.groups.io <
>> devel@edk2.groups.io>
>> *Subject:* Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip
>> removable media if it is not present
>>
>> Hi Ray,
>> This patch has been hanging along since last year. Has it been merged?
>>
>> Thanks,
>> Sheng
>>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100725): https://edk2.groups.io/g/devel/message/100725
Mute This Topic: https://groups.io/mt/95706437/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

This patch has been pending for ages, can someone help to review?
Thank you.
Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR
<https://9elements.com/privacy>


On Fri, 17 Feb 2023 at 13:59, Sheng Lean Tan via groups.io  wrote:

> Hi all,
> Could you help to review this? thanks.
>
> Best Regards,
> *Lean Sheng Tan*
>
>
>
> 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email: sheng@9elements.com
> Phone: *+49 234 68 94 188 <+492346894188>*
> Mobile: *+49 176 76 113842 <+4917676113842>*
>
> Registered office: Bochum
> Commercial register: Amtsgericht Bochum, HRB 17519
> Management: Sebastian German, Eray Bazaar
>
> Data protection information according to Art. 13 GDPR
> <https://9elements.com/privacy>
>
>
> On Wed, 21 Dec 2022 at 09:20, Sean Rhodes  wrote:
>
>> When set to true, the Logo is positioned according to the BGRT
>> specification, 38.2% from the top of the screen. When set to false,
>> no behaviour is changed and the logo is positioned centrally.
>>
>> Cc: Zhichao Gao 
>> Cc: Ray Ni 
>> Cc: Jian J Wang 
>> Cc: Liming Gao 
>> Signed-off-by: Sean Rhodes 
>> ---
>>  MdeModulePkg/MdeModulePkg.dec |  6 ++
>>  MdeModulePkg/Logo/LogoDxe.inf |  4 
>>  MdeModulePkg/Logo/Logo.c  | 28 +++-
>>  MdeModulePkg/MdeModulePkg.uni |  6 ++
>>  4 files changed, 43 insertions(+), 1 deletion(-)
>>
>> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
>> index be5e829ca9..c8bb51df3b 100644
>> --- a/MdeModulePkg/MdeModulePkg.dec
>> +++ b/MdeModulePkg/MdeModulePkg.dec
>> @@ -2102,6 +2102,12 @@ [PcdsFixedAtBuild, PcdsPatchableInModule,
>> PcdsDynamic, PcdsDynamicEx]
>># @Prompt The shared bit mask when Intel Tdx is enabled.
>>
>>  gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x1025
>>
>> +  ## This PCD sets the position of the Boot Logo.
>> +  #   TRUE  - The Logo is positioned following the recommendations from
>> Microsoft.
>> +  #   FALSE - The logo is positioned in the center of the screen.
>> +  # @ Prompt This position of the boot logo
>> +
>> gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|FALSE|BOOLEAN|0x1026
>> +
>>  [PcdsPatchableInModule]
>>## Specify memory size with page number for PEI code when
>>#  Loading Module at Fixed Address feature is enabled.
>> diff --git a/MdeModulePkg/Logo/LogoDxe.inf b/MdeModulePkg/Logo/LogoDxe.inf
>> index 41215d25d8..ce29950089 100644
>> --- a/MdeModulePkg/Logo/LogoDxe.inf
>> +++ b/MdeModulePkg/Logo/LogoDxe.inf
>> @@ -41,6 +41,7 @@ [LibraryClasses]
>>UefiBootServicesTableLib
>>UefiDriverEntryPoint
>>DebugLib
>> +  PcdLib
>>
>>  [Protocols]
>>gEfiHiiDatabaseProtocolGuid## CONSUMES
>> @@ -48,6 +49,9 @@ [Protocols]
>>gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES
>>gEdkiiPlatformLogoProtocolGuid ## PRODUCES
>>
>> +[Pcd]
>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended ##
>> CONSUMES
>> +
>>  [Depex]
>>gEfiHiiDatabaseProtocolGuid AND
>>gEfiHiiImageExProtocolGuid
>> diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c
>> index 8ab874d2da..96e34b2011 100644
>> --- a/MdeModulePkg/Logo/Logo.c
>> +++ b/MdeModulePkg/Logo/Logo.c
>> @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>>  #include 
>>  #include 
>>  #include 
>> +#include 
>>
>>  typedef struct {
>>EFI_IMAGE_ID ImageId;
>> @@ -51,12 +52,14 @@ GetImage (
>>IN EDKII_PLATFORM_LOGO_PROTOCOL*This,
>>IN OUT UINT32  *Instance,
>>OUT EFI_IMAGE_INPUT*Image,
>> +  EFI_GRAPHICS_OUTPUT_PROTOCOL   *GraphicsOutput,
>>OUT EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE  *Attribute,
>>OUT INTN   *OffsetX,
>>OUT INTN   *OffsetY
>>)
>>  {
>> -  UINT32  Current;
>> +  UINT32  Current;
>> +  EFI_STATUS  Status;
>>
>>if ((Instance == NULL) || (Image == NULL) ||
>>(A

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

[Sheng Lean Tan]

Hi all,
Could you help to review this? thanks.

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR



On Wed, 21 Dec 2022 at 09:20, Sean Rhodes  wrote:

> When set to true, the Logo is positioned according to the BGRT
> specification, 38.2% from the top of the screen. When set to false,
> no behaviour is changed and the logo is positioned centrally.
>
> Cc: Zhichao Gao 
> Cc: Ray Ni 
> Cc: Jian J Wang 
> Cc: Liming Gao 
> Signed-off-by: Sean Rhodes 
> ---
>  MdeModulePkg/MdeModulePkg.dec |  6 ++
>  MdeModulePkg/Logo/LogoDxe.inf |  4 
>  MdeModulePkg/Logo/Logo.c  | 28 +++-
>  MdeModulePkg/MdeModulePkg.uni |  6 ++
>  4 files changed, 43 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index be5e829ca9..c8bb51df3b 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2102,6 +2102,12 @@ [PcdsFixedAtBuild, PcdsPatchableInModule,
> PcdsDynamic, PcdsDynamicEx]
># @Prompt The shared bit mask when Intel Tdx is enabled.
>gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask|0x0|UINT64|0x1025
>
> +  ## This PCD sets the position of the Boot Logo.
> +  #   TRUE  - The Logo is positioned following the recommendations from
> Microsoft.
> +  #   FALSE - The logo is positioned in the center of the screen.
> +  # @ Prompt This position of the boot logo
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended|FALSE|BOOLEAN|0x1026
> +
>  [PcdsPatchableInModule]
>## Specify memory size with page number for PEI code when
>#  Loading Module at Fixed Address feature is enabled.
> diff --git a/MdeModulePkg/Logo/LogoDxe.inf b/MdeModulePkg/Logo/LogoDxe.inf
> index 41215d25d8..ce29950089 100644
> --- a/MdeModulePkg/Logo/LogoDxe.inf
> +++ b/MdeModulePkg/Logo/LogoDxe.inf
> @@ -41,6 +41,7 @@ [LibraryClasses]
>UefiBootServicesTableLib
>UefiDriverEntryPoint
>DebugLib
> +  PcdLib
>
>  [Protocols]
>gEfiHiiDatabaseProtocolGuid## CONSUMES
> @@ -48,6 +49,9 @@ [Protocols]
>gEfiHiiPackageListProtocolGuid ## PRODUCES CONSUMES
>gEdkiiPlatformLogoProtocolGuid ## PRODUCES
>
> +[Pcd]
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFollowMicrosoftRecommended ## CONSUMES
> +
>  [Depex]
>gEfiHiiDatabaseProtocolGuid AND
>gEfiHiiImageExProtocolGuid
> diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c
> index 8ab874d2da..96e34b2011 100644
> --- a/MdeModulePkg/Logo/Logo.c
> +++ b/MdeModulePkg/Logo/Logo.c
> @@ -13,6 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  #include 
>  #include 
>  #include 
> +#include 
>
>  typedef struct {
>EFI_IMAGE_ID ImageId;
> @@ -51,12 +52,14 @@ GetImage (
>IN EDKII_PLATFORM_LOGO_PROTOCOL*This,
>IN OUT UINT32  *Instance,
>OUT EFI_IMAGE_INPUT*Image,
> +  EFI_GRAPHICS_OUTPUT_PROTOCOL   *GraphicsOutput,
>OUT EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE  *Attribute,
>OUT INTN   *OffsetX,
>OUT INTN   *OffsetY
>)
>  {
> -  UINT32  Current;
> +  UINT32  Current;
> +  EFI_STATUS  Status;
>
>if ((Instance == NULL) || (Image == NULL) ||
>(Attribute == NULL) || (OffsetX == NULL) || (OffsetY == NULL))
> @@ -69,6 +72,29 @@ GetImage (
>  return EFI_NOT_FOUND;
>}
>
> +  if (PcdGetBool (PcdFollowMicrosoftRecommended)) {
> +//
> +// Get current video resolution and text mode
> +//
> +Status = gBS->HandleProtocol (
> +gST->ConsoleOutHandle,
> +&gEfiGraphicsOutputProtocolGuid,
> +(VOID **)&GraphicsOutput
> +);
> +if (!EFI_ERROR (Status)) {
> +  //
> +  // Center of LOGO is in the vertical position 38.2% when
> PcdBootLogoOnlyEnable is TRUE
> +  // Y = (VerticalResolution - LogoHeight) / 2
> +  // Y' = VerticalResolution * 0.382 - LogoHeight * 0.5
> +  // OffsetY + Y = Y'
> +  // OffsetY = Y' - Y = -0.118 * VerticalResolution
> +  //
> +  *Attribute = EdkiiPlatformLogoDisplayAttributeCenter;
> +  *OffsetX   = 0;
> +  *OffsetY   = -118 *
> (INTN)GraphicsOutput->Mode->Info->VerticalResolution / 1000;
> +}
> +  }
> +
>(*Instance)++;
>*Attribute = mLogos[Current].Attribute;
>*OffsetX   = mLogos[Current].OffsetX;
> diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
> index 33ce9f6198..09c1ac1cc1 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

[Sheng Lean Tan]

Hi,
A kind reminder - has this been merged?

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR
<https://9elements.com/privacy>


On Mon, 13 Feb 2023 at 12:57, Ni, Ray  wrote:

> @Wang, Jian J 
>
> thanks,
> ray
> --
> *From:* devel@edk2.groups.io  on behalf of Sheng
> Lean Tan 
> *Sent:* Monday, February 13, 2023 6:01:21 PM
> *To:* Rhodes, Sean ; devel@edk2.groups.io <
> devel@edk2.groups.io>
> *Subject:* Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip
> removable media if it is not present
>
> Hi Ray,
> This patch has been hanging along since last year. Has it been merged?
>
> Thanks,
> Sheng
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100313): https://edk2.groups.io/g/devel/message/100313
Mute This Topic: https://groups.io/mt/95706437/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

[Sheng Lean Tan]

Hi Ray,
This patch has been hanging along since last year. Has it been merged?

Thanks,
Sheng


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100074): https://edk2.groups.io/g/devel/message/100074
Mute This Topic: https://groups.io/mt/95706437/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal

[Sheng Lean Tan]

Hi Ray please help to merge this if no concerns, thanks.

On Tue 11. Oct 2022 at 01:50, Sheng Lean Tan via groups.io  wrote:

> Thanks Ray for the review.
> FYI Sean has also push the github PR here:
>
> https://github.com/tianocore/edk2/pull/3389
> 
>
> --
Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR
<https://9elements.com/privacy>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95547): https://edk2.groups.io/g/devel/message/95547
Mute This Topic: https://groups.io/mt/89066601/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal

[Sheng Lean Tan]

Thanks Ray for the review.
FYI Sean has also push the github PR here:

https://github.com/tianocore/edk2/pull/3389


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94981): https://edk2.groups.io/g/devel/message/94981
Mute This Topic: https://groups.io/mt/89066601/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal

[Sheng Lean Tan]

Quick reminder for review, thanks.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94876): https://edk2.groups.io/g/devel/message/94876
Mute This Topic: https://groups.io/mt/89066601/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations

[Sheng Lean Tan]

Reminder for review, thanks.

From: devel@edk2.groups.io  on behalf of Sheng Lean Tan 
via groups.io 
Date: Monday, 3. October 2022 at 11:22
To: devel@edk2.groups.io , sean@starlabs.systems 

Cc: Sean Rhodes , Zhichao Gao , 
Ray Ni , Jian J Wang , Liming Gao 
, Dong, Guo , Guo, Gua 

Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to 
follow Microsoft Recommendations
Hi Liming,
Mind to help to take a look at these 2 patches? Sean has updated the initial 
patches per your recommendation:
https://edk2.groups.io/g/devel/message/94318?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922542

https://edk2.groups.io/g/devel/message/94320?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922544

Previous feedback:
https://edk2.groups.io/g/devel/message/92385?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C92974182

https://edk2.groups.io/g/devel/message/92146?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C92830014

Thanks,
Sheng

From: devel@edk2.groups.io  on behalf of Sean Rhodes 

Date: Monday, 26. September 2022 at 10:10
To: devel@edk2.groups.io 
Cc: Sean Rhodes , Zhichao Gao , 
Ray Ni , Jian J Wang , Liming Gao 

Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to 
follow Microsoft Recommendations
Add an option to position the logo 38.2% from the top of the screen,
which follows the recommendations from Microsoft. These can be found
here:
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components

Cc: Zhichao Gao 
Cc: Ray Ni 
Cc: Jian J Wang 
Cc: Liming Gao 
Signed-off-by: Sean Rhodes 
---
 MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h 
b/MdeModulePkg/Include/Protocol/PlatformLogo.h
index 08e1dc35a4..b24d7d5b79 100644
--- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
+++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
@@ -29,7 +29,8 @@ typedef enum {
   EdkiiPlatformLogoDisplayAttributeCenterBottom,

   EdkiiPlatformLogoDisplayAttributeLeftBottom,

   EdkiiPlatformLogoDisplayAttributeCenterLeft,

-  EdkiiPlatformLogoDisplayAttributeCenter

+  EdkiiPlatformLogoDisplayAttributeCenter,

+  EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended

 } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;



 /**

diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c 
b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 478ec2d40e..9065e5281b 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -169,7 +169,6 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;

 DestY = 0;

 break;

-

   case EdkiiPlatformLogoDisplayAttributeCenterLeft:

 DestX = 0;

 DestY = (SizeOfY - Image.Height) / 2;

@@ -182,7 +181,6 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;

 DestY = (SizeOfY - Image.Height) / 2;

 break;

-

   case EdkiiPlatformLogoDisplayAttributeLeftBottom:

 DestX = 0;

 DestY = SizeOfY - Image.Height;

@@ -195,7 +193,10 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;

 DestY = SizeOfY - Image.Height;

 break;

-

+  case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended:

+DestX = (SizeOfX - Image.Width) / 2;

+DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;

+break;

   default:

 ASSERT (FALSE);

 continue;

--
2.34.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94318): https://edk2.groups.io/g/devel/message/94318
Mute This Topic: https://groups.io/mt/93922542/6757431
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [sheng@9elements.com]
-=-=-=-=-=-=





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94804): https://edk2.groups.io/g/devel/message/94804
Mute This Topic: https://groups.io/mt/93922542/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Remove deprecate Crypto Service

[Sheng Lean Tan]

Thanks Gua :)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94748): https://edk2.groups.io/g/devel/message/94748
Mute This Topic: https://groups.io/mt/94131672/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Remove deprecate Crypto Service

[Sheng Lean Tan]

Maybe can add a comment inline mentioned that it is depreciated for future 
reference?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94746): https://edk2.groups.io/g/devel/message/94746
Mute This Topic: https://groups.io/mt/94131547/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment

[Sheng Lean Tan]

Hi Wu Hao/ Zeng Star,
Any update on this? :)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94663): https://edk2.groups.io/g/devel/message/94663
Mute This Topic: https://groups.io/mt/91134149/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations

[Sheng Lean Tan]

Hi Liming,
Mind to help to take a look at these 2 patches? Sean has updated the initial 
patches per your recommendation:
https://edk2.groups.io/g/devel/message/94318?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922542

https://edk2.groups.io/g/devel/message/94320?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922544

Previous feedback:
https://edk2.groups.io/g/devel/message/92385?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C92974182

https://edk2.groups.io/g/devel/message/92146?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C92830014

Thanks,
Sheng

From: devel@edk2.groups.io  on behalf of Sean Rhodes 

Date: Monday, 26. September 2022 at 10:10
To: devel@edk2.groups.io 
Cc: Sean Rhodes , Zhichao Gao , 
Ray Ni , Jian J Wang , Liming Gao 

Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to 
follow Microsoft Recommendations
Add an option to position the logo 38.2% from the top of the screen,
which follows the recommendations from Microsoft. These can be found
here:
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components

Cc: Zhichao Gao 
Cc: Ray Ni 
Cc: Jian J Wang 
Cc: Liming Gao 
Signed-off-by: Sean Rhodes 
---
 MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h 
b/MdeModulePkg/Include/Protocol/PlatformLogo.h
index 08e1dc35a4..b24d7d5b79 100644
--- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
+++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
@@ -29,7 +29,8 @@ typedef enum {
   EdkiiPlatformLogoDisplayAttributeCenterBottom,

   EdkiiPlatformLogoDisplayAttributeLeftBottom,

   EdkiiPlatformLogoDisplayAttributeCenterLeft,

-  EdkiiPlatformLogoDisplayAttributeCenter

+  EdkiiPlatformLogoDisplayAttributeCenter,

+  EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended

 } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;



 /**

diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c 
b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
index 478ec2d40e..9065e5281b 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -169,7 +169,6 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;

 DestY = 0;

 break;

-

   case EdkiiPlatformLogoDisplayAttributeCenterLeft:

 DestX = 0;

 DestY = (SizeOfY - Image.Height) / 2;

@@ -182,7 +181,6 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;

 DestY = (SizeOfY - Image.Height) / 2;

 break;

-

   case EdkiiPlatformLogoDisplayAttributeLeftBottom:

 DestX = 0;

 DestY = SizeOfY - Image.Height;

@@ -195,7 +193,10 @@ BootLogoEnableLogo (
 DestX = SizeOfX - Image.Width;

 DestY = SizeOfY - Image.Height;

 break;

-

+  case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended:

+DestX = (SizeOfX - Image.Width) / 2;

+DestY = (SizeOfY * 382) / 1000 - Image.Height / 2;

+break;

   default:

 ASSERT (FALSE);

 continue;

--
2.34.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94318): https://edk2.groups.io/g/devel/message/94318
Mute This Topic: https://groups.io/mt/93922542/6757431
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [sheng@9elements.com]
-=-=-=-=-=-=



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94659): https://edk2.groups.io/g/devel/message/94659
Mute This Topic: https://groups.io/mt/93922542/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v4] UefiPayloadPkg: Add support for logging to CBMEM console

[Sheng Lean Tan]

Reviewed-by: Lean Sheng Tan


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91144): https://edk2.groups.io/g/devel/message/91144
Mute This Topic: https://groups.io/mt/91945631/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Add macro to support selective driver in UPL

[Sheng Lean Tan]

Reviewed-by: Lean Sheng Tan< sheng@9elements.com >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91112): https://edk2.groups.io/g/devel/message/91112
Mute This Topic: https://groups.io/mt/92181074/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Set console rows and columns to 100

[Sheng Lean Tan]

Reviewed-by: Lean Sheng Tan< sheng@9elements.com >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91064): https://edk2.groups.io/g/devel/message/91064
Mute This Topic: https://groups.io/mt/92120219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Hook up PCIE_BASE build option

[Sheng Lean Tan]

Reviewed-by: Lean Sheng Tan< sheng@9elements.com >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91063): https://edk2.groups.io/g/devel/message/91063
Mute This Topic: https://groups.io/mt/92160855/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/3] UefiPayloadPkg: Allow full screen setup mode

[Sheng Lean Tan]

Reviewed-by: Lean Sheng Tan< sheng@9elements.com >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91062): https://edk2.groups.io/g/devel/message/91062
Mute This Topic: https://groups.io/mt/92172172/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3] UefiPayloadPkg: Add support for logging to CBMEM console

[Sheng Lean Tan]

Reviewed-by: Lean Sheng Tan 



On Mon, 6 Jun 2022 at 02:56, Benjamin Doron 
wrote:

> Writes TianoCore debug logs into the CBMEM console ringbuffer, from
> where the user can retrieve them with the `cbmem` userspace utility.
>
> The intention is to aid in debugging non-fatal issues even in release
> builds, or simply make TianoCore's logs available to those interested.
> Consequently, MDEPKG_NDEBUG must be masked. As an in-memory debug
> logging library, ASSERTs must be non-fatal to be seen, so they neither
> dead-loop nor create a breakpoint. It is assumed that ASSERT() neither
> enforces fatal conditions nor security integrity, as release builds do
> not call DebugAssert() from the ASSERT macro.
>
> More detailed debug logs are produced with the DEBUG_CODE macro, but
> this guards other debug-related code throughout the codebase. To avoid
> changing behaviour on release builds, this is only set for debug builds.
>
> Tested on QEMU, dumping the appropriate memory region in the UEFI shell
> shows the TianoCore log. An improved revision of the debug library used
> in several coreboot-related EDK2 forks, including MrChromebox's.
> Previous revisions also tested on an Acer Aspire VN7-572G laptop.
>
> Cc: Guo Dong 
> Cc: Ray Ni 
> Cc: Maurice Ma 
> Cc: Benjamin You 
> Cc: Sean Rhodes 
> Signed-off-by: Benjamin Doron 
> ---
>  UefiPayloadPkg/Include/Coreboot.h  |  13 +
>  UefiPayloadPkg/Library/CbSerialPortLib/CbSerialPortLib.c   | 264
> 
>  UefiPayloadPkg/Library/CbSerialPortLib/CbSerialPortLib.inf |  30 +++
>  UefiPayloadPkg/UefiPayloadPkg.dsc  |  25 +-
>  4 files changed, 327 insertions(+), 5 deletions(-)
>
> diff --git a/UefiPayloadPkg/Include/Coreboot.h
> b/UefiPayloadPkg/Include/Coreboot.h
> index a3e1109fe84e..5892fae7682b 100644
> --- a/UefiPayloadPkg/Include/Coreboot.h
> +++ b/UefiPayloadPkg/Include/Coreboot.h
> @@ -199,6 +199,13 @@ struct cb_forward {
>UINT64forward;
>  };
>
> +struct cb_cbmem_ref {
> +  UINT32tag;
> +  // Field contains size of this struct = 0x0010
> +  UINT32size;
> +  UINT64cbmem_addr;
> +};
> +
>  #define CB_TAG_FRAMEBUFFER  0x0012
>  struct cb_framebuffer {
>UINT32tag;
> @@ -229,6 +236,12 @@ struct cb_vdat {
>
>  #define CB_TAG_TIMESTAMPS 0x0016
>  #define CB_TAG_CBMEM_CONSOLE  0x0017
> +struct cbmem_console {
> +  UINT32 size;
> +  UINT32 cursor;
> +  UINT8  body[0];
> +} __attribute__((packed));
> +
>  #define CB_TAG_MRC_CACHE  0x0018
>  struct cb_cbmem_tab {
>UINT32tag;
> diff --git a/UefiPayloadPkg/Library/CbSerialPortLib/CbSerialPortLib.c
> b/UefiPayloadPkg/Library/CbSerialPortLib/CbSerialPortLib.c
> new file mode 100644
> index ..863fbcfef2f0
> --- /dev/null
> +++ b/UefiPayloadPkg/Library/CbSerialPortLib/CbSerialPortLib.c
> @@ -0,0 +1,264 @@
> +/** @file
> +  CBMEM console SerialPortLib instance
> +
> +  Copyright (c) 2022, Baruch Binyamin Doron
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include 
> +#include 
> +
> +#include 
> +#include 
> +#include 
> +
> +// Upper nibble contains flags
> +#define CBMC_CURSOR_MASK ((1 << 28) - 1)
> +#define CBMC_OVERFLOW (1 << 31)
> +
> +STATIC struct cbmem_console  *mCbConsole = NULL;
> +
> +/**
> +  Find coreboot record with given Tag.
> +  NOTE: This coreboot-specific function definition is absent
> + from the common BlParseLib header.
> +
> +  @param  TagThe tag id to be found
> +
> +  @retval NULL  The Tag is not found.
> +  @retval OthersThe pointer to the record found.
> +
> +**/
> +VOID *
> +FindCbTag (
> +  IN  UINT32 Tag
> +  );
> +
> +/**
> +  Initialize the serial device hardware.
> +
> +  If no initialization is required, then return RETURN_SUCCESS.
> +  If the serial device was successfully initialized, then return
> RETURN_SUCCESS.
> +  If the serial device could not be initialized, then return
> RETURN_DEVICE_ERROR.
> +
> +  @retval RETURN_SUCCESSThe serial device was initialized.
> +  @retval RETURN_DEVICE_ERROR   The serial device could not be
> initialized.
> +
> +**/
> +RETURN_STATUS
> +EFIAPI
> +SerialPortInitialize (
> +  VOID
> +  )
> +{
> +  // The coreboot table contains large structures as references
> +  struct cb_cbmem_ref *cbref = FindCbTag(CB_TAG_CBMEM_CONSOLE);
> +  if (!cbref) {
> +return RETURN_DEVICE_ERROR;
> +  }
> +
> +  mCbConsole = (VOID *)(UINTN)cbref->cbmem_addr;  // Support PEI and DXE
> +  if (mCbConsole == NULL) {
> +return RETURN_DEVICE_ERROR;
> +  }
> +
> +  return RETURN_SUCCESS;
> +}
> +
> +/**
> +  Write data from buffer to serial device.
> +
> +  Writes NumberOfBytes data bytes from Buffer to the serial device.
> +  The number of bytes actually written to the serial device is returned.
> +  If the return value is less than NumberOfBytes, then the write
> operation failed.
> +  If Buffer is NULL, then ASSERT().
> +  If NumberOfBytes is zero, then return 0.
> +
> +  @param 

Re: [edk2-devel] [PATCH 1/2] SecurityPkg: Add RNG support

[Sheng Lean Tan]

Hi Jiewen/ Jian J,
This patch has been hanging around for months, could you help?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89817): https://edk2.groups.io/g/devel/message/89817
Mute This Topic: https://groups.io/mt/89353220/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hook up RNG support

[Sheng Lean Tan]

Hi Ray/Dong Guo,
Could you help to get this merge?

Thanks,
Sheng


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89816): https://edk2.groups.io/g/devel/message/89816
Mute This Topic: https://groups.io/mt/89353219/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [edk2-devel] [PATCH 43/43] MdeModulePkg/BmBoot: skip secondary eMMC entries

[Sheng Lean Tan]

Hi Liming,
Mind to help on this? This patch has been hanging on for a long time :(
Thank you.

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR



On Mon, 21 Mar 2022 at 10:41, Sean Rhodes  wrote:

> Hi Liming
>
> This is how the entries appear for multiple MMC drives. Can you advise how
> you'd like me to adjust the patch?
>
> Thanks
>
> Sean
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89815): https://edk2.groups.io/g/devel/message/89815
Mute This Topic: https://groups.io/mt/88963038/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add support for logging to CBMEM console

[Sheng Lean Tan]

Hi Ray,
Could you help to review this?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89814): https://edk2.groups.io/g/devel/message/89814
Mute This Topic: https://groups.io/mt/88756033/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Ps2KbdCtrller: Make wait for SUCCESS after BAT non-fatal

[Sheng Lean Tan]

Hi Ray,
Could you help to review this?

Thanks,
Sheng


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89813): https://edk2.groups.io/g/devel/message/89813
Mute This Topic: https://groups.io/mt/89066601/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] OvmfPkg: Fix PciHostBridgeLibScan

[Sheng Lean Tan]

Hi Ard,
As per discribed in the commit message, this issue is seen on actual hardware 
and the fix is merged:

https://github.com/tianocore/edk2/commit/bfefdc2c49ca9487b7aa0df196b2aca6c0c170a2

Since this function is the exact duplicate of the one in UefiPayloadPkg, he 
figured to port the fix here as well to prevent future issue.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89812): https://edk2.groups.io/g/devel/message/89812
Mute This Topic: https://groups.io/mt/90138165/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: Add Pcd to prioritize internal devices

[Sheng Lean Tan]

Hi Jian J/Liming,
Any update on this?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89811): https://edk2.groups.io/g/devel/message/89811
Mute This Topic: https://groups.io/mt/89924426/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment

[Sheng Lean Tan]

Hi Star & Liming,
Any update on this?
Much appreciated.

Best Regards,
*Lean Sheng Tan*



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: sheng@9elements.com
Phone: *+49 234 68 94 188 <+492346894188>*
Mobile: *+49 176 76 113842 <+4917676113842>*

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar

Data protection information according to Art. 13 GDPR



On Mon, 16 May 2022 at 11:03, Wu, Hao A  wrote:

> Sorry Star and Liming,
>
>
>
> For the below patch (removing the alignment check for WorkSpace &
> SpareArea):
>
> https://edk2.groups.io/g/devel/message/89742
>
>
>
> Do you think it will impact the FTW service on flash device? Thanks in
> advance.
>
>
>
> Best Regards,
>
> Hao Wu
>
>
>
> *From:* devel@edk2.groups.io  * On Behalf Of *Sean
> Rhodes
> *Sent:* Monday, May 16, 2022 3:54 PM
> *To:* Wu, Hao A 
> *Cc:* devel@edk2.groups.io
> *Subject:* Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe:
> Don't check for address alignment
>
>
>
> The bug discovered was with coreboot, and the PCD values are derived from
> the block size of its SMMStore (NvStorage) region. The discussion on the
> patch can be found here: https://review.coreboot.org/c/coreboot/+/62990
>
>
>
> Hacking the PCDs could work,, but why would we want to keep an incorrect
> check?
>
>
>
> Thanks!
>
>
>
>
>
> On Mon, 16 May 2022 at 08:36, Wu, Hao A  wrote:
>
> Sorry for not being clear on what I mean.
>
> Is it possible to change the platform PCD values and keep these block size
> alignment requirements.
>
>
>
> Best Regards,
>
> Hao Wu
>
>
>
> *From:* devel@edk2.groups.io  *On Behalf Of *Sean
> Rhodes
> *Sent:* Monday, May 16, 2022 3:00 PM
> *To:* Wu; Wu, Hao A ; devel@edk2.groups.io
> *Subject:* Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe:
> Don't check for address alignment
>
>
>
> Hi Hao
>
> Yes, it does conflict - I will update the patch to fix these comments :)
>
> Thank you
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89810): https://edk2.groups.io/g/devel/message/89810
Mute This Topic: https://groups.io/mt/91134149/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Change some configuration of the payload

[Sheng Lean Tan]

Reviewed-by: Lean Sheng Tan 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88324): https://edk2.groups.io/g/devel/message/88324
Mute This Topic: https://groups.io/mt/89991252/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

[Sheng Lean Tan]

Merged:

https://github.com/tianocore/edk2/pull/2596


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88303): https://edk2.groups.io/g/devel/message/88303
Mute This Topic: https://groups.io/mt/88853648/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 43/43] UefiPayloadPkg: Make Boot Manager Key configurable

[Sheng Lean Tan]

Merged:

https://github.com/tianocore/edk2/pull/2596


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88302): https://edk2.groups.io/g/devel/message/88302
Mute This Topic: https://groups.io/mt/88817968/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Fix case of protocol

[Sheng Lean Tan]

Merged.

https://github.com/tianocore/edk2/pull/2591


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88299): https://edk2.groups.io/g/devel/message/88299
Mute This Topic: https://groups.io/mt/88757873/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Fix case of protocol

[Sheng Lean Tan]

Merged:

https://github.com/tianocore/edk2/pull/2591


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88301): https://edk2.groups.io/g/devel/message/88301
Mute This Topic: https://groups.io/mt/88757873/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 32/32] UefiPayloadPkg: Add build option for Above 4G Memory

[Sheng Lean Tan]

Merged.

https://github.com/tianocore/edk2/pull/2590


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88298): https://edk2.groups.io/g/devel/message/88298
Mute This Topic: https://groups.io/mt/88757870/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 43/43] UefiPayloadPkg: Provide option to use Boot Splash

[Sheng Lean Tan]

Done in another mail:

https://edk2.groups.io/g/devel/topic/89281295#86816


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88300): https://edk2.groups.io/g/devel/message/88300
Mute This Topic: https://groups.io/mt/88817761/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Timeout configurable

[Sheng Lean Tan]

Merged.

https://github.com/tianocore/edk2/commit/55637a2894babca97945eeca1da0d431f74f8627


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88297): https://edk2.groups.io/g/devel/message/88297
Mute This Topic: https://groups.io/mt/88757864/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Timeout configurable

[Sheng Lean Tan]

[to keep record]

This is merged:

https://github.com/tianocore/edk2/commit/55637a2894babca97945eeca1da0d431f74f8627


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#88296): https://edk2.groups.io/g/devel/message/88296
Mute This Topic: https://groups.io/mt/89868842/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-