Re: [edk2-devel][edk2-platforms][PATCH V1 0/9] Add Whitley AcpiPlatform driver
Pushed as: 3c40bddded..7cd51aa3c1 -Original Message- From: Desimone, Nathaniel L Sent: Thursday, March 10, 2022 5:13 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 0/9] Add Whitley AcpiPlatform driver For the series... Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Thursday, March 10, 2022 2:41 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 0/9] Add Whitley AcpiPlatform driver This series converts the AcpiPlatform driver for Whitley ICX to open source. The driver requires libraries providing: 16-bit CRC service A library to update the tables based on boot time data. A board hook library to control publishing individual tables and to modify tables. A library to build MADT and SRAT tables during boot. A Universal Board Abstraction library to translate UBA data. The driver consumes the AcpiTables data file and the AML opcode patching table From StaticSkuDataDxe driver. This code does not support the CooperCity hardware at present. The code depends on additional DynamicSiLibraryProtocol2 and updated WhitleyFspBinPkg content. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram Isaac Oram (9): WhitleyOpenBoardPkg: Add definitions needed for AcpiPlatform driver WhitleySiliconPkg: Add definitions used in ACPI subsystem WhitleyOpenBoardPkg/BaseCrcLib: Add library for CRC16 WhitleyOpenBoardPkg: Add UbaPlatLib Library WhitleyOpenBoardPkg/PlatformSpecificAcpiTableLib: Add library WhitleyOpenBoardPkg/BuildAcpiTablesLib: Add lib for building MADT and SRAT WhitleyOpenBoardPkg/AcpiTablesLib: Add library for AcpiPlatform driver WhitleyOpenBoardPkg/AcpiPlatform: Add driver for publishing ACPI tables WhitleyOpenBoardPkg/Build: Remove confusing build options Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c | 754 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.h | 117 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.inf | 107 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformHooks.c | 384 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformHooks.h | 51 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformUtils.c | 133 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformUtils.h | 66 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformVTDHooks.c | 1762 Platform/Intel/WhitleyOpenBoardPkg/Features/Pci/Dxe/PciHostBridge/PciHostBridge.inf |1 + Platform/Intel/WhitleyOpenBoardPkg/Features/Pci/Dxe/PciPlatform/PciPlatform.inf |1 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Madt.h | 118 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Slit.h | 75 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Srat.h | 53 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/amlresrc.h | 542 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Dsc/BuildOptions.dsc | 18 +- Platform/Intel/WhitleyOpenBoardPkg/Include/Library/AcpiPlatformLib.h | 107 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/BuildAcpiTablesLib.h | 111 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h | 42 + Platform/Intel/WhitleyOpenBoardPkg/Include/Library/PlatformSpecificAcpiTableLib.h | 129 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/PlatformStatusCodes.h | 364 Platform/Intel/WhitleyOpenBoardPkg/Include/Library/UbaFpkConfigLib.h | 55 + Platform/Intel/WhitleyOpenBoardPkg/Include/Library/UbaSmbiosUpdateLib.h | 275 +++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLib.c | 534 ++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLib.inf | 127 ++ Platform/Intel/WhitleyOpenBoardPkg/Library
Re: [edk2-devel][edk2-platforms][PATCH V1 0/9] Add Whitley AcpiPlatform driver
For the series... Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Thursday, March 10, 2022 2:41 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 0/9] Add Whitley AcpiPlatform driver This series converts the AcpiPlatform driver for Whitley ICX to open source. The driver requires libraries providing: 16-bit CRC service A library to update the tables based on boot time data. A board hook library to control publishing individual tables and to modify tables. A library to build MADT and SRAT tables during boot. A Universal Board Abstraction library to translate UBA data. The driver consumes the AcpiTables data file and the AML opcode patching table From StaticSkuDataDxe driver. This code does not support the CooperCity hardware at present. The code depends on additional DynamicSiLibraryProtocol2 and updated WhitleyFspBinPkg content. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram Isaac Oram (9): WhitleyOpenBoardPkg: Add definitions needed for AcpiPlatform driver WhitleySiliconPkg: Add definitions used in ACPI subsystem WhitleyOpenBoardPkg/BaseCrcLib: Add library for CRC16 WhitleyOpenBoardPkg: Add UbaPlatLib Library WhitleyOpenBoardPkg/PlatformSpecificAcpiTableLib: Add library WhitleyOpenBoardPkg/BuildAcpiTablesLib: Add lib for building MADT and SRAT WhitleyOpenBoardPkg/AcpiTablesLib: Add library for AcpiPlatform driver WhitleyOpenBoardPkg/AcpiPlatform: Add driver for publishing ACPI tables WhitleyOpenBoardPkg/Build: Remove confusing build options Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c | 754 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.h | 117 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.inf | 107 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformHooks.c | 384 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformHooks.h | 51 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformUtils.c | 133 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformUtils.h | 66 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformVTDHooks.c | 1762 Platform/Intel/WhitleyOpenBoardPkg/Features/Pci/Dxe/PciHostBridge/PciHostBridge.inf |1 + Platform/Intel/WhitleyOpenBoardPkg/Features/Pci/Dxe/PciPlatform/PciPlatform.inf |1 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Madt.h | 118 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Slit.h | 75 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Srat.h | 53 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/amlresrc.h | 542 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Dsc/BuildOptions.dsc | 18 +- Platform/Intel/WhitleyOpenBoardPkg/Include/Library/AcpiPlatformLib.h | 107 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/BuildAcpiTablesLib.h | 111 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h | 42 + Platform/Intel/WhitleyOpenBoardPkg/Include/Library/PlatformSpecificAcpiTableLib.h | 129 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/PlatformStatusCodes.h | 364 Platform/Intel/WhitleyOpenBoardPkg/Include/Library/UbaFpkConfigLib.h | 55 + Platform/Intel/WhitleyOpenBoardPkg/Include/Library/UbaSmbiosUpdateLib.h | 275 +++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLib.c | 534 ++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLib.inf | 127 ++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLibApic.c | 735 Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLibBdat.c | 1574 + Platform/Intel/WhitleyOpenBoardPkg/Library
[edk2-devel][edk2-platforms][PATCH V1 0/9] Add Whitley AcpiPlatform driver
This series converts the AcpiPlatform driver for Whitley ICX to open source. The driver requires libraries providing: 16-bit CRC service A library to update the tables based on boot time data. A board hook library to control publishing individual tables and to modify tables. A library to build MADT and SRAT tables during boot. A Universal Board Abstraction library to translate UBA data. The driver consumes the AcpiTables data file and the AML opcode patching table From StaticSkuDataDxe driver. This code does not support the CooperCity hardware at present. The code depends on additional DynamicSiLibraryProtocol2 and updated WhitleyFspBinPkg content. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram Isaac Oram (9): WhitleyOpenBoardPkg: Add definitions needed for AcpiPlatform driver WhitleySiliconPkg: Add definitions used in ACPI subsystem WhitleyOpenBoardPkg/BaseCrcLib: Add library for CRC16 WhitleyOpenBoardPkg: Add UbaPlatLib Library WhitleyOpenBoardPkg/PlatformSpecificAcpiTableLib: Add library WhitleyOpenBoardPkg/BuildAcpiTablesLib: Add lib for building MADT and SRAT WhitleyOpenBoardPkg/AcpiTablesLib: Add library for AcpiPlatform driver WhitleyOpenBoardPkg/AcpiPlatform: Add driver for publishing ACPI tables WhitleyOpenBoardPkg/Build: Remove confusing build options Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c | 754 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.h | 117 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.inf | 107 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformHooks.c | 384 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformHooks.h | 51 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformUtils.c | 133 ++ Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformUtils.h | 66 + Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatformVTDHooks.c | 1762 Platform/Intel/WhitleyOpenBoardPkg/Features/Pci/Dxe/PciHostBridge/PciHostBridge.inf |1 + Platform/Intel/WhitleyOpenBoardPkg/Features/Pci/Dxe/PciPlatform/PciPlatform.inf |1 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Madt.h | 118 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Slit.h | 75 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/Srat.h | 53 + Platform/Intel/WhitleyOpenBoardPkg/Include/Acpi/amlresrc.h | 542 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Dsc/BuildOptions.dsc | 18 +- Platform/Intel/WhitleyOpenBoardPkg/Include/Library/AcpiPlatformLib.h | 107 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/BuildAcpiTablesLib.h | 111 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/CrcLib.h | 42 + Platform/Intel/WhitleyOpenBoardPkg/Include/Library/PlatformSpecificAcpiTableLib.h | 129 ++ Platform/Intel/WhitleyOpenBoardPkg/Include/Library/PlatformStatusCodes.h | 364 Platform/Intel/WhitleyOpenBoardPkg/Include/Library/UbaFpkConfigLib.h | 55 + Platform/Intel/WhitleyOpenBoardPkg/Include/Library/UbaSmbiosUpdateLib.h | 275 +++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLib.c | 534 ++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLib.inf | 127 ++ Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLibApic.c | 735 Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLibBdat.c | 1574 + Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLibDsdt.c | 673 Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLibFadt.c | 75 + Platform/Intel/WhitleyOpenBoardPkg/Library/AcpiPlatformTableLib/AcpiPlatformLibHmat.c
